Re: [PATCH 2/2] drm/amdgpu: allocate entities on demand

2020-01-22 Thread Luben Tuikov
On 2020-01-22 4:25 a.m., Nirmoy wrote: > Hi Luben, > > Thanks for reviewing.  Was expecting lot from vim auto-indent :/ Yes, no problem. It's a learning experience for me as well. If you use Emacs, pressing TAB anywhere on a line, will indent it according to the mode. (It runs the

Re: [PATCH 2/2] drm/amdgpu: allocate entities on demand

2020-01-22 Thread Nirmoy
On 1/22/20 12:39 PM, Christian König wrote: Am 22.01.20 um 10:33 schrieb Nirmoy Das: Currently we pre-allocate entities and fences for all the HW IPs on context creation and some of which are might never be used. This patch tries to resolve entity/fences wastage by creating entities for a HW

Re: [PATCH 2/2] drm/amdgpu: allocate entities on demand

2020-01-22 Thread Christian König
Am 22.01.20 um 10:33 schrieb Nirmoy Das: Currently we pre-allocate entities and fences for all the HW IPs on context creation and some of which are might never be used. This patch tries to resolve entity/fences wastage by creating entities for a HW IP only when it is required. v2: consolidated

[PATCH 2/2] drm/amdgpu: allocate entities on demand

2020-01-22 Thread Nirmoy Das
Currently we pre-allocate entities and fences for all the HW IPs on context creation and some of which are might never be used. This patch tries to resolve entity/fences wastage by creating entities for a HW IP only when it is required. v2: consolidated priority checking at

Re: [PATCH 2/2] drm/amdgpu: allocate entities on demand

2020-01-22 Thread Nirmoy
Hi Luben, Thanks for reviewing.  Was expecting lot from vim auto-indent :/ On 1/22/20 1:07 AM, Luben Tuikov wrote: On 2020-01-21 11:50 a.m., Nirmoy Das wrote: - switch (i) { + priority = (ctx->override_priority == DRM_SCHED_PRIORITY_UNSET) ? +

Re: [PATCH 2/2] drm/amdgpu: allocate entities on demand

2020-01-21 Thread Luben Tuikov
On 2020-01-21 11:50 a.m., Nirmoy Das wrote: > Currently we pre-allocate entities and fences for all the HW IPs on > context creation and some of which are might never be used. > > This patch tries to resolve entity/fences wastage by creating entities > for a HW IP only when it is required. > >

[PATCH 2/2] drm/amdgpu: allocate entities on demand

2020-01-21 Thread Nirmoy Das
Currently we pre-allocate entities and fences for all the HW IPs on context creation and some of which are might never be used. This patch tries to resolve entity/fences wastage by creating entities for a HW IP only when it is required. Signed-off-by: Nirmoy Das ---