I will change it to CHIP_MULLINS.
Yes , I also spotted the kq->ops cleanup, will send it out shortly.
Regards,
Yong
On 2019-11-13 2:31 p.m., Felix Kuehling wrote:
See one comment inline. With that fixed, the series is
Reviewed-by: Felix Kuehling
I could think of more follow-up cleanup
See one comment inline. With that fixed, the series is
Reviewed-by: Felix Kuehling
I could think of more follow-up cleanup while you're at it:
1. Can you see any reason why the kq->ops need to be function pointers.
Looks to me like they are the same for all kernel queues, so those
Thanks Alex, I appreciate the explanation!
Kent
From: Deucher, Alexander
Sent: Wednesday, November 13, 2019 1:31 PM
To: Russell, Kent ; Zhao, Yong ;
amd-gfx@lists.freedesktop.org
Subject: Re: [PATCH 2/2] drm/amdkfd: Eliminate ops_asic_specific in kernel queue
CI just refers to the dGPUs
, Yong ; amd-gfx@lists.freedesktop.org
Cc: Zhao, Yong
Subject: RE: [PATCH 2/2] drm/amdkfd: Eliminate ops_asic_specific in kernel queue
Should we use "CI" instead of "CIK" in the comments? I thought CIK was a short
form for CI kickers, while CI encompasses all CI ASICs. Eve
: amd-gfx On Behalf Of Yong Zhao
Sent: Tuesday, November 12, 2019 5:19 PM
To: amd-gfx@lists.freedesktop.org
Cc: Zhao, Yong
Subject: [PATCH 2/2] drm/amdkfd: Eliminate ops_asic_specific in kernel queue
The ops_asic_specific function pointers are actually quite generic after using
a simple if condition.
The ops_asic_specific function pointers are actually quite generic after
using a simple if condition. Eliminate it by code refactoring.
Change-Id: Icb891289cca31acdbe2d2eea76a426f1738b9c08
Signed-off-by: Yong Zhao
---
drivers/gpu/drm/amd/amdkfd/kfd_kernel_queue.c | 63 ---
