Re: [PATCH 2/2] drm/scheduler: Remove obsolete spinlock.

2018-05-16 Thread Andrey Grodzovsky
On 05/16/2018 09:16 AM, Lucas Stach wrote: Am Mittwoch, den 16.05.2018, 15:10 +0200 schrieb Christian König: Am 16.05.2018 um 15:00 schrieb Lucas Stach: Am Mittwoch, den 16.05.2018, 14:32 +0200 schrieb Christian König: Am 16.05.2018 um 14:28 schrieb Lucas Stach: Am Mittwoch, den

Re: [PATCH 2/2] drm/scheduler: Remove obsolete spinlock.

2018-05-16 Thread Lucas Stach
Am Mittwoch, den 16.05.2018, 15:10 +0200 schrieb Christian König: > Am 16.05.2018 um 15:00 schrieb Lucas Stach: > > Am Mittwoch, den 16.05.2018, 14:32 +0200 schrieb Christian König: > > > Am 16.05.2018 um 14:28 schrieb Lucas Stach: > > > > Am Mittwoch, den 16.05.2018, 14:08 +0200 schrieb Christian

Re: [PATCH 2/2] drm/scheduler: Remove obsolete spinlock.

2018-05-16 Thread Christian König
Am 16.05.2018 um 15:00 schrieb Lucas Stach: Am Mittwoch, den 16.05.2018, 14:32 +0200 schrieb Christian König: Am 16.05.2018 um 14:28 schrieb Lucas Stach: Am Mittwoch, den 16.05.2018, 14:08 +0200 schrieb Christian König: Yes, exactly. For normal user space command submission we should have

Re: [PATCH 2/2] drm/scheduler: Remove obsolete spinlock.

2018-05-16 Thread Lucas Stach
Am Mittwoch, den 16.05.2018, 14:32 +0200 schrieb Christian König: > Am 16.05.2018 um 14:28 schrieb Lucas Stach: > > Am Mittwoch, den 16.05.2018, 14:08 +0200 schrieb Christian König: > > > Yes, exactly. > > > > > > For normal user space command submission we should have tons of > > > locks > > >

Re: [PATCH 2/2] drm/scheduler: Remove obsolete spinlock.

2018-05-16 Thread Christian König
/2] drm/scheduler: Remove obsolete spinlock. On 2018年05月16日 03:31, Andrey Grodzovsky wrote: Signed-off-by: Andrey Grodzovsky <andrey.grodzovsky@amd.c om> ---    drivers/gpu/drm/scheduler/gpu_scheduler.c | 4    include/drm/gpu_scheduler.h   | 1 -    2 files chan

Re: [PATCH 2/2] drm/scheduler: Remove obsolete spinlock.

2018-05-16 Thread Lucas Stach
Grodzovsky, Andrey: > > > > > > Yeah, that what I am not sure about... It's lockless in a > > > > > > sense of  > > > > > > single producer single consumer but not for multiple > > > > > > concurrent  > > > > &

Re: [PATCH 2/2] drm/scheduler: Remove obsolete spinlock.

2018-05-16 Thread Christian König
From: Zhou, David(ChunMing) Sent: 15 May 2018 23:04:44 To: Grodzovsky, Andrey; amd-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org Cc: Koenig, Christian Subject: Re: [PATCH 2/2] drm/scheduler: Remove obsolete spinlock. On 2018年05月16日 03:31, Andrey Grodzovsky wrote: Signed

Re: [PATCH 2/2] drm/scheduler: Remove obsolete spinlock.

2018-05-16 Thread Andrey Grodzovsky
, Andrey; amd-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org Cc: Koenig, Christian Subject: Re: [PATCH 2/2] drm/scheduler: Remove obsolete spinlock. On 2018年05月16日 03:31, Andrey Grodzovsky wrote: Signed-off-by: Andrey Grodzovsky <andrey.grodzov...@amd.com> ---    drivers/g

Re: [PATCH 2/2] drm/scheduler: Remove obsolete spinlock.

2018-05-16 Thread Christian König
To: Grodzovsky, Andrey; amd-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org Cc: Koenig, Christian Subject: Re: [PATCH 2/2] drm/scheduler: Remove obsolete spinlock. On 2018年05月16日 03:31, Andrey Grodzovsky wrote: Signed-off-by: Andrey Grodzovsky <andrey.grodzov...@amd.

Re: [PATCH 2/2] drm/scheduler: Remove obsolete spinlock.

2018-05-16 Thread Andrey Grodzovsky
@lists.freedesktop.org; dri-de...@lists.freedesktop.org Cc: Koenig, Christian Subject: Re: [PATCH 2/2] drm/scheduler: Remove obsolete spinlock. On 2018年05月16日 03:31, Andrey Grodzovsky wrote: Signed-off-by: Andrey Grodzovsky <andrey.grodzov...@amd.com> ---    drivers/gpu/drm/scheduler/gpu_scheduler

Re: [PATCH 2/2] drm/scheduler: Remove obsolete spinlock.

2018-05-16 Thread Christian König
From: Zhou, David(ChunMing) Sent: 15 May 2018 23:04:44 To: Grodzovsky, Andrey; amd-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org Cc: Koenig, Christian Subject: Re: [PATCH 2/2] drm/scheduler: Remove obsolete spinlock. On 2018年05月16日 03:31

Re: [PATCH 2/2] drm/scheduler: Remove obsolete spinlock.

2018-05-15 Thread Grodzovsky, Andrey
: Zhou, David(ChunMing) Sent: 15 May 2018 23:04:44 To: Grodzovsky, Andrey; amd-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org Cc: Koenig, Christian Subject: Re: [PATCH 2/2] drm/scheduler: Remove obsolete spinlock. On 2018年05月16日 03:31, Andrey Grodzovsky wrote: > Signed-off-by: And

Re: [PATCH 2/2] drm/scheduler: Remove obsolete spinlock.

2018-05-15 Thread zhoucm1
On 2018年05月16日 03:31, Andrey Grodzovsky wrote: Signed-off-by: Andrey Grodzovsky --- drivers/gpu/drm/scheduler/gpu_scheduler.c | 4 include/drm/gpu_scheduler.h | 1 - 2 files changed, 5 deletions(-) diff --git

Re: [PATCH 2/2] drm/scheduler: Remove obsolete spinlock.

2018-05-15 Thread Andrey Grodzovsky
Yea, I might need to give another thought to whether this  spinlock can actually be removed. Andrey On 05/15/2018 03:38 PM, Alex Deucher wrote: On Tue, May 15, 2018 at 3:31 PM, Andrey Grodzovsky wrote: Signed-off-by: Andrey Grodzovsky

Re: [PATCH 2/2] drm/scheduler: Remove obsolete spinlock.

2018-05-15 Thread Alex Deucher
On Tue, May 15, 2018 at 3:31 PM, Andrey Grodzovsky wrote: > Signed-off-by: Andrey Grodzovsky Please provide a better patch description. Alex > --- > drivers/gpu/drm/scheduler/gpu_scheduler.c | 4 > include/drm/gpu_scheduler.h

[PATCH 2/2] drm/scheduler: Remove obsolete spinlock.

2018-05-15 Thread Andrey Grodzovsky
Signed-off-by: Andrey Grodzovsky --- drivers/gpu/drm/scheduler/gpu_scheduler.c | 4 include/drm/gpu_scheduler.h | 1 - 2 files changed, 5 deletions(-) diff --git a/drivers/gpu/drm/scheduler/gpu_scheduler.c