Re: [PATCH 2/4] drm/amd/powerplay: valid Vega10 DPMTABLE_OD_UPDATE_VDDC settings V2

[Alex Deucher]

On Wed, May 8, 2019 at 2:41 AM Evan Quan  wrote:
>
> With user specified voltage(DPMTABLE_OD_UPDATE_VDDC), the AVFS
> will be disabled. However, the buggy code makes this actually not
> working as expected.
>
> - V2: clear all OD flags excpet DPMTABLE_OD_UPDATE_VDDC
>
> Change-Id: Ifa83a6255bb3f6fa4bdb4de616521cb7bab6830a
> Signed-off-by: Evan Quan 

Acked-by: Alex Deucher 

> ---
>  drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c | 9 -
>  1 file changed, 4 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c 
> b/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c
> index 138f9f9ea765..05f6bf7d703e 100644
> --- a/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c
> +++ b/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c
> @@ -2466,11 +2466,6 @@ static void vega10_check_dpm_table_updated(struct 
> pp_hwmgr *hwmgr)
> return;
> }
> }
> -
> -   if (data->need_update_dpm_table & DPMTABLE_OD_UPDATE_VDDC) {
> -   data->need_update_dpm_table &= ~DPMTABLE_OD_UPDATE_VDDC;
> -   data->need_update_dpm_table |= DPMTABLE_OD_UPDATE_SCLK | 
> DPMTABLE_OD_UPDATE_MCLK;
> -   }
>  }
>
>  /**
> @@ -3683,6 +3678,10 @@ static int vega10_set_power_state_tasks(struct 
> pp_hwmgr *hwmgr,
>
> vega10_update_avfs(hwmgr);
>
> +   /*
> +* Clear all OD flags except DPMTABLE_OD_UPDATE_VDDC.
> +* That will help to keep AVFS disabled.
> +*/
> data->need_update_dpm_table &= DPMTABLE_OD_UPDATE_VDDC;
>
> return 0;
> --
> 2.21.0
>
> ___
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

RE: [PATCH 2/4] drm/amd/powerplay: valid Vega10 DPMTABLE_OD_UPDATE_VDDC settings

[Quan, Evan]

Just sent out a V2 version and drop this one.

> -Original Message-
> From: Evan Quan 
> Sent: 2019年5月7日 14:09
> To: amd-gfx@lists.freedesktop.org
> Cc: ya...@yiannakis.de; Deucher, Alexander
> ; Quan, Evan 
> Subject: [PATCH 2/4] drm/amd/powerplay: valid Vega10
> DPMTABLE_OD_UPDATE_VDDC settings
> 
> With user specified voltage(DPMTABLE_OD_UPDATE_VDDC), the AVFS will
> be disabled. However, the buggy code makes this actually not working as
> expected.
> 
> Change-Id: Ifa83a6255bb3f6fa4bdb4de616521cb7bab6830a
> Signed-off-by: Evan Quan 
> ---
>  drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c | 7 +--
>  1 file changed, 1 insertion(+), 6 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c
> b/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c
> index 138f9f9ea765..103f7e3f0783 100644
> --- a/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c
> +++ b/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c
> @@ -2466,11 +2466,6 @@ static void
> vega10_check_dpm_table_updated(struct pp_hwmgr *hwmgr)
>   return;
>   }
>   }
> -
> - if (data->need_update_dpm_table &
> DPMTABLE_OD_UPDATE_VDDC) {
> - data->need_update_dpm_table &=
> ~DPMTABLE_OD_UPDATE_VDDC;
> - data->need_update_dpm_table |=
> DPMTABLE_OD_UPDATE_SCLK | DPMTABLE_OD_UPDATE_MCLK;
> - }
>  }
> 
>  /**
> @@ -3683,7 +3678,7 @@ static int vega10_set_power_state_tasks(struct
> pp_hwmgr *hwmgr,
> 
>   vega10_update_avfs(hwmgr);
> 
> - data->need_update_dpm_table &= DPMTABLE_OD_UPDATE_VDDC;
> + data->need_update_dpm_table = 0;
> 
>   return 0;
>  }
> --
> 2.21.0

___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

[PATCH 2/4] drm/amd/powerplay: valid Vega10 DPMTABLE_OD_UPDATE_VDDC settings V2

[Evan Quan]

With user specified voltage(DPMTABLE_OD_UPDATE_VDDC), the AVFS
will be disabled. However, the buggy code makes this actually not
working as expected.

- V2: clear all OD flags excpet DPMTABLE_OD_UPDATE_VDDC

Change-Id: Ifa83a6255bb3f6fa4bdb4de616521cb7bab6830a
Signed-off-by: Evan Quan 
---
 drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c | 9 -
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c 
b/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c
index 138f9f9ea765..05f6bf7d703e 100644
--- a/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c
+++ b/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c
@@ -2466,11 +2466,6 @@ static void vega10_check_dpm_table_updated(struct 
pp_hwmgr *hwmgr)
return;
}
}
-
-   if (data->need_update_dpm_table & DPMTABLE_OD_UPDATE_VDDC) {
-   data->need_update_dpm_table &= ~DPMTABLE_OD_UPDATE_VDDC;
-   data->need_update_dpm_table |= DPMTABLE_OD_UPDATE_SCLK | 
DPMTABLE_OD_UPDATE_MCLK;
-   }
 }
 
 /**
@@ -3683,6 +3678,10 @@ static int vega10_set_power_state_tasks(struct pp_hwmgr 
*hwmgr,
 
vega10_update_avfs(hwmgr);
 
+   /*
+* Clear all OD flags except DPMTABLE_OD_UPDATE_VDDC.
+* That will help to keep AVFS disabled.
+*/
data->need_update_dpm_table &= DPMTABLE_OD_UPDATE_VDDC;
 
return 0;
-- 
2.21.0

___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

[PATCH 2/4] drm/amd/powerplay: valid Vega10 DPMTABLE_OD_UPDATE_VDDC settings

[Evan Quan]

With user specified voltage(DPMTABLE_OD_UPDATE_VDDC), the AVFS
will be disabled. However, the buggy code makes this actually not
working as expected.

Change-Id: Ifa83a6255bb3f6fa4bdb4de616521cb7bab6830a
Signed-off-by: Evan Quan 
---
 drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c | 7 +--
 1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c 
b/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c
index 138f9f9ea765..103f7e3f0783 100644
--- a/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c
+++ b/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c
@@ -2466,11 +2466,6 @@ static void vega10_check_dpm_table_updated(struct 
pp_hwmgr *hwmgr)
return;
}
}
-
-   if (data->need_update_dpm_table & DPMTABLE_OD_UPDATE_VDDC) {
-   data->need_update_dpm_table &= ~DPMTABLE_OD_UPDATE_VDDC;
-   data->need_update_dpm_table |= DPMTABLE_OD_UPDATE_SCLK | 
DPMTABLE_OD_UPDATE_MCLK;
-   }
 }
 
 /**
@@ -3683,7 +3678,7 @@ static int vega10_set_power_state_tasks(struct pp_hwmgr 
*hwmgr,
 
vega10_update_avfs(hwmgr);
 
-   data->need_update_dpm_table &= DPMTABLE_OD_UPDATE_VDDC;
+   data->need_update_dpm_table = 0;
 
return 0;
 }
-- 
2.21.0

___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx