Re: [PATCH 3/3] drm/amdgpu: cleanup adjust_mc_addr handling

2017-05-14 Thread zhoucm1
On 2017年05月13日 02:57, Felix Kuehling wrote: Hi Christian, One comment inline [FK]. If this is not a problem, then feel free to add my R-B for the whole series. Kent, when we adopt this change, we need to convert the PDE back to an address, because KFD needs to fill just the page directory

Re: [PATCH 3/3] drm/amdgpu: cleanup adjust_mc_addr handling

2017-05-14 Thread zhoucm1
the series is Reviewed-by: Chunming Zhou On 2017年05月12日 21:48, Christian König wrote: From: Christian König Rename adjust_mc_addr to get_vm_pde, check the address bits in one place and move setting the valid bit in there as well. Signed-off-by:

Re: [PATCH 3/3] drm/amdgpu: cleanup adjust_mc_addr handling

2017-05-12 Thread Felix Kuehling
Hi Christian, One comment inline [FK]. If this is not a problem, then feel free to add my R-B for the whole series. Kent, when we adopt this change, we need to convert the PDE back to an address, because KFD needs to fill just the page directory base address into the map_process HIQ packet. I

[PATCH 3/3] drm/amdgpu: cleanup adjust_mc_addr handling

2017-05-12 Thread Christian König
From: Christian König Rename adjust_mc_addr to get_vm_pde, check the address bits in one place and move setting the valid bit in there as well. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu.h| 5 +++--