Re: [PATCH 4/4] drm/amdkfd: Implement image tiling mode support

2017-08-15 Thread Michel Dänzer
On 16/08/17 09:35 AM, Felix Kuehling wrote: > On 2017-08-15 06:20 AM, Oded Gabbay wrote: >> I prefer to do it incrementally, to avoid very large patch-sets which >> usually end up in longer cycles of review-fix, which causes you more >> pain because internal development continues during this time

Re: [PATCH 4/4] drm/amdkfd: Implement image tiling mode support

2017-08-15 Thread Oded Gabbay
On Tue, Aug 15, 2017 at 1:55 AM, Felix Kuehling wrote: > OK, I was hoping to keep the ABI unchanged during upstreaming, but I > realize that may not be realistic. And I feel I'm getting valuable > feedback, so I don't want to limit myself with ABI requirements that are >

Re: [PATCH 4/4] drm/amdkfd: Implement image tiling mode support

2017-08-14 Thread Felix Kuehling
OK, I was hoping to keep the ABI unchanged during upstreaming, but I realize that may not be realistic. And I feel I'm getting valuable feedback, so I don't want to limit myself with ABI requirements that are not necessary. I still don't have commit access to git repos on freedesktop.org. But I'm

Re: [PATCH 4/4] drm/amdkfd: Implement image tiling mode support

2017-08-14 Thread Felix Kuehling
On 2017-08-13 05:08 AM, Oded Gabbay wrote: > As in the previous patch, there is a hole here in the IOCTLs > numbering. I suggest that when you upstream new IOCTLs, you will put > them in consecutive numbers per the upstream driver, and then take > that change downstream because you can easily

Re: [PATCH 4/4] drm/amdkfd: Implement image tiling mode support

2017-08-13 Thread Oded Gabbay
On Sat, Aug 12, 2017 at 7:47 AM, Felix Kuehling wrote: > From: Yong Zhao > > Signed-off-by: Yong Zhao > Signed-off-by: Felix Kuehling > --- > drivers/gpu/drm/amd/amdkfd/kfd_chardev.c | 43 >