Re: [PATCH 4/8] drm/amd/pp: Clean up the code for RV in powerplay

2018-03-08 Thread Alex Deucher
From: Alex Deucher [mailto:alexdeuc...@gmail.com] > Sent: Thursday, March 08, 2018 1:23 AM > To: Zhu, Rex > Cc: amd-gfx list > Subject: Re: [PATCH 4/8] drm/amd/pp: Clean up the code for RV in powerplay > > On Wed, Mar 7, 2018 at 5:46 AM, Rex Zhu wrote: >> In send_message_to_s

RE: [PATCH 4/8] drm/amd/pp: Clean up the code for RV in powerplay

2018-03-07 Thread Zhu, Rex
he dispatch functions. Best Regards Rex -Original Message- From: Alex Deucher [mailto:alexdeuc...@gmail.com] Sent: Thursday, March 08, 2018 1:23 AM To: Zhu, Rex Cc: amd-gfx list Subject: Re: [PATCH 4/8] drm/amd/pp: Clean up the code for RV in powerplay On Wed, Mar 7, 2018 at 5:46 AM

Re: [PATCH 4/8] drm/amd/pp: Clean up the code for RV in powerplay

2018-03-07 Thread Alex Deucher
On Wed, Mar 7, 2018 at 5:46 AM, Rex Zhu wrote: > In send_message_to_smu helper functions, > Print out the error code for debug if smu failed to response. > > and the helper functions always return true, so no need to > check their return value. > > Signed-off-by: Rex Zhu Is this consistent with

[PATCH 4/8] drm/amd/pp: Clean up the code for RV in powerplay

2018-03-07 Thread Rex Zhu
In send_message_to_smu helper functions, Print out the error code for debug if smu failed to response. and the helper functions always return true, so no need to check their return value. Signed-off-by: Rex Zhu Change-Id: I27da8bf22d3cea0df968df7b0809dc727461762f --- drivers/gpu/drm/amd/powerp