Re: [PATCH libdrm] amdgpu: add amdgpu_bo_handle_type_kms_noimport

2018-07-25 Thread Christian König
Patch is Reviewed-by: Christian König Regards, Christian. Am 24.07.2018 um 20:11 schrieb Marek Olšák: Christian, Would you please give me an Rb if the patch is OK with you? I have spoken with Michel and he would be OK with me pushing it as long as it gets an Rb from either you or Alex.

Re: [PATCH libdrm] amdgpu: add amdgpu_bo_handle_type_kms_noimport

2018-07-24 Thread Marek Olšák
Christian, Would you please give me an Rb if the patch is OK with you? I have spoken with Michel and he would be OK with me pushing it as long as it gets an Rb from either you or Alex. Thanks, Marek On Wed, Jul 11, 2018 at 8:47 PM, Marek Olšák wrote: > From: Marek Olšák > > --- >

Re: [PATCH libdrm] amdgpu: add amdgpu_bo_handle_type_kms_noimport

2018-07-19 Thread Marek Olšák
On Wed, Jul 18, 2018 at 11:55 AM, Michel Dänzer wrote: > On 2018-07-17 08:14 PM, Marek Olšák wrote: >> Michel, I think you are wasting your time. This change can be misused >> as easily as any other API. It's not more dangerous that any other >> amdgpu libdrm function. > > That's trivially false.

Re: [PATCH libdrm] amdgpu: add amdgpu_bo_handle_type_kms_noimport

2018-07-18 Thread Michel Dänzer
On 2018-07-17 08:14 PM, Marek Olšák wrote: > Michel, I think you are wasting your time. This change can be misused > as easily as any other API. It's not more dangerous that any other > amdgpu libdrm function. That's trivially false. > You won't achieve anything by optimizing the hash table (=

Re: [PATCH libdrm] amdgpu: add amdgpu_bo_handle_type_kms_noimport

2018-07-17 Thread Marek Olšák
Michel, I think you are wasting your time. This change can be misused as easily as any other API. It's not more dangerous that any other amdgpu libdrm function. You won't achieve anything by optimizing the hash table (= losing time), and you also won't achieve anything by NAKing this (= losing

Re: [PATCH libdrm] amdgpu: add amdgpu_bo_handle_type_kms_noimport

2018-07-17 Thread Michel Dänzer
On 2018-07-16 08:51 PM, Marek Olšák wrote: > On Mon, Jul 16, 2018 at 12:05 PM, Michel Dänzer wrote: >> On 2018-07-13 08:47 PM, Marek Olšák wrote: >>> On Fri, Jul 13, 2018 at 4:28 AM, Michel Dänzer wrote: >> I'd rather add the handle to the hash table in amdgpu_bo_alloc,

Re: [PATCH libdrm] amdgpu: add amdgpu_bo_handle_type_kms_noimport

2018-07-17 Thread Christian König
Am 17.07.2018 um 10:30 schrieb Michel Dänzer: On 2018-07-17 10:19 AM, Christian König wrote: Am 17.07.2018 um 10:03 schrieb Michel Dänzer: On 2018-07-17 09:59 AM, Christian König wrote: Am 17.07.2018 um 09:46 schrieb Michel Dänzer: On 2018-07-17 09:33 AM, Christian König wrote: Am

Re: [PATCH libdrm] amdgpu: add amdgpu_bo_handle_type_kms_noimport

2018-07-17 Thread Michel Dänzer
On 2018-07-17 10:19 AM, Christian König wrote: > Am 17.07.2018 um 10:03 schrieb Michel Dänzer: >> On 2018-07-17 09:59 AM, Christian König wrote: >>> Am 17.07.2018 um 09:46 schrieb Michel Dänzer: On 2018-07-17 09:33 AM, Christian König wrote: > Am 17.07.2018 um 09:26 schrieb Michel Dänzer:

Re: [PATCH libdrm] amdgpu: add amdgpu_bo_handle_type_kms_noimport

2018-07-17 Thread Christian König
Am 17.07.2018 um 10:03 schrieb Michel Dänzer: On 2018-07-17 09:59 AM, Christian König wrote: Am 17.07.2018 um 09:46 schrieb Michel Dänzer: On 2018-07-17 09:33 AM, Christian König wrote: Am 17.07.2018 um 09:26 schrieb Michel Dänzer: [SNIP] All that should be needed is one struct list_head per

Re: [PATCH libdrm] amdgpu: add amdgpu_bo_handle_type_kms_noimport

2018-07-17 Thread Michel Dänzer
On 2018-07-17 09:59 AM, Christian König wrote: > Am 17.07.2018 um 09:46 schrieb Michel Dänzer: >> On 2018-07-17 09:33 AM, Christian König wrote: >>> Am 17.07.2018 um 09:26 schrieb Michel Dänzer: On 2018-07-17 08:50 AM, Christian König wrote: > Am 16.07.2018 um 18:05 schrieb Michel Dänzer:

Re: [PATCH libdrm] amdgpu: add amdgpu_bo_handle_type_kms_noimport

2018-07-17 Thread Christian König
Am 17.07.2018 um 09:46 schrieb Michel Dänzer: On 2018-07-17 09:33 AM, Christian König wrote: Am 17.07.2018 um 09:26 schrieb Michel Dänzer: On 2018-07-17 08:50 AM, Christian König wrote: Am 16.07.2018 um 18:05 schrieb Michel Dänzer: On 2018-07-13 08:47 PM, Marek Olšák wrote: [SNIP] Other

Re: [PATCH libdrm] amdgpu: add amdgpu_bo_handle_type_kms_noimport

2018-07-17 Thread Michel Dänzer
On 2018-07-17 09:33 AM, Christian König wrote: > Am 17.07.2018 um 09:26 schrieb Michel Dänzer: >> On 2018-07-17 08:50 AM, Christian König wrote: >>> Am 16.07.2018 um 18:05 schrieb Michel Dänzer: On 2018-07-13 08:47 PM, Marek Olšák wrote: [SNIP] Other opinions? >>> I understand the

Re: [PATCH libdrm] amdgpu: add amdgpu_bo_handle_type_kms_noimport

2018-07-17 Thread Christian König
Am 17.07.2018 um 09:26 schrieb Michel Dänzer: On 2018-07-17 08:50 AM, Christian König wrote: Am 16.07.2018 um 18:05 schrieb Michel Dänzer: On 2018-07-13 08:47 PM, Marek Olšák wrote: [SNIP] Other opinions? I understand the reason why Marek wants to do this, but I agree that this is a little

Re: [PATCH libdrm] amdgpu: add amdgpu_bo_handle_type_kms_noimport

2018-07-17 Thread Michel Dänzer
On 2018-07-17 08:50 AM, Christian König wrote: > Am 16.07.2018 um 18:05 schrieb Michel Dänzer: >> On 2018-07-13 08:47 PM, Marek Olšák wrote: >>> On Fri, Jul 13, 2018 at 4:28 AM, Michel Dänzer >>> wrote: On 2018-07-12 07:03 PM, Marek Olšák wrote: > On Thu, Jul 12, 2018, 3:31 AM Michel

Re: [PATCH libdrm] amdgpu: add amdgpu_bo_handle_type_kms_noimport

2018-07-17 Thread Christian König
Am 16.07.2018 um 18:05 schrieb Michel Dänzer: On 2018-07-13 08:47 PM, Marek Olšák wrote: On Fri, Jul 13, 2018 at 4:28 AM, Michel Dänzer wrote: On 2018-07-12 07:03 PM, Marek Olšák wrote: On Thu, Jul 12, 2018, 3:31 AM Michel Dänzer wrote: What is the rationale for this? I.e. why do you want

Re: [PATCH libdrm] amdgpu: add amdgpu_bo_handle_type_kms_noimport

2018-07-16 Thread Marek Olšák
On Mon, Jul 16, 2018 at 12:05 PM, Michel Dänzer wrote: > On 2018-07-13 08:47 PM, Marek Olšák wrote: >> On Fri, Jul 13, 2018 at 4:28 AM, Michel Dänzer wrote: >>> On 2018-07-12 07:03 PM, Marek Olšák wrote: On Thu, Jul 12, 2018, 3:31 AM Michel Dänzer wrote: > > What is the rationale

Re: [PATCH libdrm] amdgpu: add amdgpu_bo_handle_type_kms_noimport

2018-07-16 Thread Michel Dänzer
On 2018-07-13 08:47 PM, Marek Olšák wrote: > On Fri, Jul 13, 2018 at 4:28 AM, Michel Dänzer wrote: >> On 2018-07-12 07:03 PM, Marek Olšák wrote: >>> On Thu, Jul 12, 2018, 3:31 AM Michel Dänzer wrote: What is the rationale for this? I.e. why do you want to not store some handles in

Re: [PATCH libdrm] amdgpu: add amdgpu_bo_handle_type_kms_noimport

2018-07-13 Thread Marek Olšák
On Fri, Jul 13, 2018 at 4:28 AM, Michel Dänzer wrote: > On 2018-07-12 07:03 PM, Marek Olšák wrote: >> On Thu, Jul 12, 2018, 3:31 AM Michel Dänzer wrote: >>> On 2018-07-12 02:47 AM, Marek Olšák wrote: From: Marek Olšák diff --git a/amdgpu/amdgpu_bo.c b/amdgpu/amdgpu_bo.c

Re: [PATCH libdrm] amdgpu: add amdgpu_bo_handle_type_kms_noimport

2018-07-13 Thread Michel Dänzer
On 2018-07-12 07:03 PM, Marek Olšák wrote: > On Thu, Jul 12, 2018, 3:31 AM Michel Dänzer wrote: >> On 2018-07-12 02:47 AM, Marek Olšák wrote: >>> From: Marek Olšák >>> >>> diff --git a/amdgpu/amdgpu_bo.c b/amdgpu/amdgpu_bo.c >>> index 9e37b149..d29be244 100644 >>> --- a/amdgpu/amdgpu_bo.c >>>

Re: [PATCH libdrm] amdgpu: add amdgpu_bo_handle_type_kms_noimport

2018-07-12 Thread Marek Olšák
On Thu, Jul 12, 2018, 3:31 AM Michel Dänzer wrote: > On 2018-07-12 02:47 AM, Marek Olšák wrote: > > From: Marek Olšák > > > > --- > > amdgpu/amdgpu.h| 7 ++- > > amdgpu/amdgpu_bo.c | 4 > > 2 files changed, 10 insertions(+), 1 deletion(-) > > > > diff --git a/amdgpu/amdgpu.h

Re: [PATCH libdrm] amdgpu: add amdgpu_bo_handle_type_kms_noimport

2018-07-12 Thread Michel Dänzer
On 2018-07-12 02:47 AM, Marek Olšák wrote: > From: Marek Olšák > > --- > amdgpu/amdgpu.h| 7 ++- > amdgpu/amdgpu_bo.c | 4 > 2 files changed, 10 insertions(+), 1 deletion(-) > > diff --git a/amdgpu/amdgpu.h b/amdgpu/amdgpu.h > index 36f91058..be83b457 100644 > ---

Re: [PATCH libdrm] amdgpu: add amdgpu_bo_handle_type_kms_noimport

2018-07-11 Thread Marek Olšák
On Wed, Jul 11, 2018 at 10:09 PM, zhoucm1 wrote: > > > On 2018年07月12日 08:47, Marek Olšák wrote: >> >> From: Marek Olšák > > less patch comment to describe why amdgpu_bo_handle_type_kms doesn't meet > requriement and what patch does. The comment in amdgpu.h describes it well. (at least I hope

Re: [PATCH libdrm] amdgpu: add amdgpu_bo_handle_type_kms_noimport

2018-07-11 Thread zhoucm1
On 2018年07月12日 08:47, Marek Olšák wrote: From: Marek Olšák less patch comment to describe why amdgpu_bo_handle_type_kms doesn't meet requriement and what patch does. less Signed-off-by. --- amdgpu/amdgpu.h| 7 ++- amdgpu/amdgpu_bo.c | 4 2 files changed, 10

Re: [PATCH libdrm] amdgpu: add amdgpu_bo_handle_type_kms_noimport

2018-07-11 Thread Zhang, Jerry (Junwei)
On 07/12/2018 09:14 AM, Zhang, Jerry (Junwei) wrote: On 07/12/2018 08:47 AM, Marek Olšák wrote: From: Marek Olšák --- amdgpu/amdgpu.h| 7 ++- amdgpu/amdgpu_bo.c | 4 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/amdgpu/amdgpu.h b/amdgpu/amdgpu.h index

Re: [PATCH libdrm] amdgpu: add amdgpu_bo_handle_type_kms_noimport

2018-07-11 Thread Marek Olšák
On Wed, Jul 11, 2018 at 9:14 PM, Zhang, Jerry (Junwei) wrote: > On 07/12/2018 08:47 AM, Marek Olšák wrote: >> >> From: Marek Olšák >> >> --- >> amdgpu/amdgpu.h| 7 ++- >> amdgpu/amdgpu_bo.c | 4 >> 2 files changed, 10 insertions(+), 1 deletion(-) >> >> diff --git

Re: [PATCH libdrm] amdgpu: add amdgpu_bo_handle_type_kms_noimport

2018-07-11 Thread Zhang, Jerry (Junwei)
On 07/12/2018 08:47 AM, Marek Olšák wrote: From: Marek Olšák --- amdgpu/amdgpu.h| 7 ++- amdgpu/amdgpu_bo.c | 4 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/amdgpu/amdgpu.h b/amdgpu/amdgpu.h index 36f91058..be83b457 100644 --- a/amdgpu/amdgpu.h +++

[PATCH libdrm] amdgpu: add amdgpu_bo_handle_type_kms_noimport

2018-07-11 Thread Marek Olšák
From: Marek Olšák --- amdgpu/amdgpu.h| 7 ++- amdgpu/amdgpu_bo.c | 4 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/amdgpu/amdgpu.h b/amdgpu/amdgpu.h index 36f91058..be83b457 100644 --- a/amdgpu/amdgpu.h +++ b/amdgpu/amdgpu.h @@ -77,21 +77,26 @@ struct