RE: [PATCH libdrm v4 1/1] amdgpu: move asic id table to a separate file

2017-06-02 Thread Li, Samuel
mes. Sam -Original Message- From: Michel Dänzer [mailto:mic...@daenzer.net] Sent: Thursday, June 01, 2017 11:06 PM To: Li, Samuel <samuel...@amd.com> Cc: amd-gfx@lists.freedesktop.org; Yuan, Xiaojie <xiaojie.y...@amd.com> Subject: Re: [PATCH libdrm v4 1/1] amdgpu: move asic i

Re: [PATCH libdrm v4 1/1] amdgpu: move asic id table to a separate file

2017-06-01 Thread Michel Dänzer
On 01/06/17 11:27 PM, Li, Samuel wrote: >> If amdgpu.ids living in the amdgpu directory prevents it from being used by >> libdrm_radeon (why?), let's put it in a new toplevel directory, e.g. >> "data". >>> README is also located in this directory. >> Not the same thing. It documents things about

RE: [PATCH libdrm v4 1/1] amdgpu: move asic id table to a separate file

2017-06-01 Thread Li, Samuel
much time you would like to spend in auditing the names :) Sam -Original Message- From: Michel Dänzer [mailto:mic...@daenzer.net] Sent: Thursday, June 01, 2017 2:09 AM To: Li, Samuel <samuel...@amd.com> Cc: amd-gfx@lists.freedesktop.org; Yuan, Xiaojie <xiaojie.y...@amd.com&g

Re: [PATCH libdrm v4 1/1] amdgpu: move asic id table to a separate file

2017-06-01 Thread Michel Dänzer
On 01/06/17 12:32 AM, Li, Samuel wrote: >> From: Michel Dänzer [mailto:mic...@daenzer.net] >> On 31/05/17 07:31 AM, Li, Samuel wrote: >>> From: Michel Dänzer [mailto:mic...@daenzer.net] On 30/05/17 06:16 AM, Samuel Li wrote: > diff --git a/amdgpu/amdgpu_asic_id.c

Re: [PATCH libdrm v4 1/1] amdgpu: move asic id table to a separate file

2017-05-31 Thread Michel Dänzer
On 31/05/17 10:17 PM, Alex Deucher wrote: > On Wed, May 31, 2017 at 1:15 AM, Michel Dänzer wrote: >> On 31/05/17 07:31 AM, Li, Samuel wrote: >>> From: Michel Dänzer [mailto:mic...@daenzer.net] On 30/05/17 06:16 AM, Samuel Li wrote: > +67FF, CF, 67FF:CF

RE: [PATCH libdrm v4 1/1] amdgpu: move asic id table to a separate file

2017-05-31 Thread Li, Samuel
Please see comments incline, -Original Message- From: Michel Dänzer [mailto:mic...@daenzer.net] Sent: Wednesday, May 31, 2017 1:15 AM To: Li, Samuel <samuel...@amd.com> Cc: amd-gfx@lists.freedesktop.org; Yuan, Xiaojie <xiaojie.y...@amd.com> Subject: Re: [PATCH libdrm v4 1/1]

Re: [PATCH libdrm v4 1/1] amdgpu: move asic id table to a separate file

2017-05-31 Thread Alex Deucher
On Wed, May 31, 2017 at 1:15 AM, Michel Dänzer wrote: > On 31/05/17 07:31 AM, Li, Samuel wrote: >> From: Michel Dänzer [mailto:mic...@daenzer.net] >>> On 30/05/17 06:16 AM, Samuel Li wrote: >>> diff --git a/amdgpu/amdgpu_asic_id.c b/amdgpu/amdgpu_asic_id.c new file

Re: [PATCH libdrm v4 1/1] amdgpu: move asic id table to a separate file

2017-05-30 Thread Michel Dänzer
On 31/05/17 07:31 AM, Li, Samuel wrote: > From: Michel Dänzer [mailto:mic...@daenzer.net] >> On 30/05/17 06:16 AM, Samuel Li wrote: >> >>> diff --git a/amdgpu/amdgpu_asic_id.c b/amdgpu/amdgpu_asic_id.c new >>> file mode 100644 index 000..a43ca33 >>> --- /dev/null >>> +++

RE: [PATCH libdrm v4 1/1] amdgpu: move asic id table to a separate file

2017-05-30 Thread Li, Samuel
Please see comments inline. -Original Message- From: Michel Dänzer [mailto:mic...@daenzer.net] Sent: Monday, May 29, 2017 9:26 PM To: Li, Samuel <samuel...@amd.com> Cc: amd-gfx@lists.freedesktop.org; Yuan, Xiaojie <xiaojie.y...@amd.com> Subject: Re: [PATCH libdrm v4 1/1]

Re: [PATCH libdrm v4 1/1] amdgpu: move asic id table to a separate file

2017-05-29 Thread Michel Dänzer
On 30/05/17 06:16 AM, Samuel Li wrote: > From: Xiaojie Yuan I took a closer look and noticed some details (and some non-details about the amdgpu.ids file at the end). > diff --git a/amdgpu/amdgpu_asic_id.c b/amdgpu/amdgpu_asic_id.c > new file mode 100644 > index

[PATCH libdrm v4 1/1] amdgpu: move asic id table to a separate file

2017-05-29 Thread Samuel Li
From: Xiaojie Yuan v2: fix an off by one error and leading white spaces v3: use thread safe strtok_r(); initialize len before calling getline(); change printf() to drmMsg(); add initial amdgpu.ids v4: integrate some recent internal changes, including format changes