Re: [PATCH v2] drm/amdgpu: expose amdgpu_sensors on pre-powerplay chips

2017-02-14 Thread Tom St Denis
On 14/02/17 12:52 PM, Tom St Denis wrote: On 14/02/17 12:16 PM, Tom St Denis wrote: On 14/02/17 12:01 PM, Samuel Pitoiset wrote: No worries. I thought that check was enough. Anyway, writing code without the hardware should be avoided. :) Can you try the thing suggested by Alex? Because I will

Re: [PATCH v2] drm/amdgpu: expose amdgpu_sensors on pre-powerplay chips

2017-02-14 Thread Tom St Denis
On 14/02/17 12:52 PM, Tom St Denis wrote: On 14/02/17 12:16 PM, Tom St Denis wrote: On 14/02/17 12:01 PM, Samuel Pitoiset wrote: No worries. I thought that check was enough. Anyway, writing code without the hardware should be avoided. :) Can you try the thing suggested by Alex? Because I will

Re: [PATCH v2] drm/amdgpu: expose amdgpu_sensors on pre-powerplay chips

2017-02-14 Thread Tom St Denis
On 14/02/17 12:16 PM, Tom St Denis wrote: On 14/02/17 12:01 PM, Samuel Pitoiset wrote: No worries. I thought that check was enough. Anyway, writing code without the hardware should be avoided. :) Can you try the thing suggested by Alex? Because I will need to fix up the DRM ioctl codepath as we

Re: [PATCH v2] drm/amdgpu: expose amdgpu_sensors on pre-powerplay chips

2017-02-14 Thread Tom St Denis
On 14/02/17 12:01 PM, Samuel Pitoiset wrote: On 02/14/2017 05:41 PM, Tom St Denis wrote: On 14/02/17 10:08 AM, Samuel Pitoiset wrote: Totally untested but as long as read_sensor() has been recently implemented for dpm based boards, amdgpu_sensors can now be exposed. v2: - make sure read_sens

Re: [PATCH v2] drm/amdgpu: expose amdgpu_sensors on pre-powerplay chips

2017-02-14 Thread Samuel Pitoiset
On 02/14/2017 05:41 PM, Tom St Denis wrote: On 14/02/17 10:08 AM, Samuel Pitoiset wrote: Totally untested but as long as read_sensor() has been recently implemented for dpm based boards, amdgpu_sensors can now be exposed. v2: - make sure read_sensor is not NULL on dpm chips - keep sanity

Re: [PATCH v2] drm/amdgpu: expose amdgpu_sensors on pre-powerplay chips

2017-02-14 Thread Tom St Denis
On 14/02/17 10:08 AM, Samuel Pitoiset wrote: Totally untested but as long as read_sensor() has been recently implemented for dpm based boards, amdgpu_sensors can now be exposed. v2: - make sure read_sensor is not NULL on dpm chips - keep sanity check for powerplay chips Cc: Tom St Denis Si

[PATCH v2] drm/amdgpu: expose amdgpu_sensors on pre-powerplay chips

2017-02-14 Thread Samuel Pitoiset
Totally untested but as long as read_sensor() has been recently implemented for dpm based boards, amdgpu_sensors can now be exposed. v2: - make sure read_sensor is not NULL on dpm chips - keep sanity check for powerplay chips Cc: Tom St Denis Signed-off-by: Samuel Pitoiset --- drivers/gpu/