Re: [PATCH v3 1/1] drm/amdgpu: rework sched_list generation

2020-04-01 Thread Nirmoy
On 4/1/20 5:02 PM, Luben Tuikov wrote: On 2020-03-31 08:46, Nirmoy wrote: On 3/31/20 3:01 AM, Luben Tuikov wrote: This patch seems to be using DOS line-endings. Strange, I don't see that in my local patch file. Not sure why "git am" complained about DOS endings the first time I downloaded

Re: [PATCH v3 1/1] drm/amdgpu: rework sched_list generation

2020-04-01 Thread Luben Tuikov
On 2020-03-31 08:46, Nirmoy wrote: > > On 3/31/20 3:01 AM, Luben Tuikov wrote: >> This patch seems to be using DOS line-endings. > > > Strange, I don't see that in my local patch file. > Not sure why "git am" complained about DOS endings the first time I downloaded it. Second time was fine.

Re: [PATCH v3 1/1] drm/amdgpu: rework sched_list generation

2020-03-31 Thread Nirmoy
On 3/31/20 3:01 AM, Luben Tuikov wrote: This patch seems to be using DOS line-endings. Strange, I don't see that in my local patch file. After converting it to UNIX line-endings, the output of "git am" using "scripts/checkpatch.pl" via the pre-commit hook is appended last to my thoughts

Re: [PATCH v3 1/1] drm/amdgpu: rework sched_list generation

2020-03-31 Thread Christian König
Am 31.03.20 um 10:24 schrieb Nirmoy: [SNIP] +const unsigned int amdgpu_ring_type_to_drm_hw_ip[AMDGPU_HW_IP_NUM] = { +    [AMDGPU_RING_TYPE_GFX]  = AMDGPU_HW_IP_GFX, +    [AMDGPU_RING_TYPE_COMPUTE]  = AMDGPU_HW_IP_COMPUTE, +    [AMDGPU_RING_TYPE_SDMA] = AMDGPU_HW_IP_DMA, +   

Re: [PATCH v3 1/1] drm/amdgpu: rework sched_list generation

2020-03-31 Thread Nirmoy
On 3/31/20 9:56 AM, Christian König wrote: Am 30.03.20 um 17:49 schrieb Nirmoy Das: Generate HW IP's sched_list in amdgpu_ring_init() instead of amdgpu_ctx.c. This makes amdgpu_ctx_init_compute_sched(), ring.has_high_prio and amdgpu_ctx_init_sched() unnecessary. This patch also stores

Re: [PATCH v3 1/1] drm/amdgpu: rework sched_list generation

2020-03-31 Thread Christian König
Am 30.03.20 um 17:49 schrieb Nirmoy Das: Generate HW IP's sched_list in amdgpu_ring_init() instead of amdgpu_ctx.c. This makes amdgpu_ctx_init_compute_sched(), ring.has_high_prio and amdgpu_ctx_init_sched() unnecessary. This patch also stores sched_list for all HW IPs in one big array in struct

Re: [PATCH v3 1/1] drm/amdgpu: rework sched_list generation

2020-03-30 Thread Luben Tuikov
This patch seems to be using DOS line-endings. After converting it to UNIX line-endings, the output of "git am" using "scripts/checkpatch.pl" via the pre-commit hook is appended last to my thoughts below. On 2020-03-30 11:49 a.m., Nirmoy Das wrote: > Generate HW IP's sched_list in

[PATCH v3 1/1] drm/amdgpu: rework sched_list generation

2020-03-30 Thread Nirmoy Das
Generate HW IP's sched_list in amdgpu_ring_init() instead of amdgpu_ctx.c. This makes amdgpu_ctx_init_compute_sched(), ring.has_high_prio and amdgpu_ctx_init_sched() unnecessary. This patch also stores sched_list for all HW IPs in one big array in struct amdgpu_device which makes