Re: [RFC] drm/amd/amdgpu: get rid of else branch

2017-05-04 Thread Nikola Pajkovsky
Christian König writes: > Am 27.04.2017 um 18:17 schrieb Nikola Pajkovsky: >> This is super simple elimination of else branch and I should >> probably even use unlikely in >> >> if (ring->count_dw < count_dw) { >> >> However, amdgpu_ring_write() has similar if

Re: [RFC] drm/amd/amdgpu: get rid of else branch

2017-05-04 Thread Christian König
Am 04.05.2017 um 14:57 schrieb Nikola Pajkovsky: Christian König writes: Am 27.04.2017 um 18:17 schrieb Nikola Pajkovsky: This is super simple elimination of else branch and I should probably even use unlikely in if (ring->count_dw < count_dw) { However,

Re: [RFC] drm/amd/amdgpu: get rid of else branch

2017-04-28 Thread Christian König
Am 27.04.2017 um 18:17 schrieb Nikola Pajkovsky: This is super simple elimination of else branch and I should probably even use unlikely in if (ring->count_dw < count_dw) { However, amdgpu_ring_write() has similar if condition, but does not return after DRM_ERROR and it looks

[RFC] drm/amd/amdgpu: get rid of else branch

2017-04-27 Thread Nikola Pajkovsky
This is super simple elimination of else branch and I should probably even use unlikely in if (ring->count_dw < count_dw) { However, amdgpu_ring_write() has similar if condition, but does not return after DRM_ERROR and it looks suspicious. On error, we still adding v to ring and keeping