essed, Reviewed-by: Monk
Liu
*发件人:* Liu, Monk
*发送时间:* 2017年1月12日 11:19:40
*收件人:* Christian König; Yu, Xiangliang; amd-gfx@lists.freedesktop.org
*主题:* 答复: [V3 04/11] drm/amdgpu/virt: use kiq to access registers
Xiangliang
p
> -Original Message-
> From: Michel Dänzer [mailto:mic...@daenzer.net]
> Sent: Thursday, January 12, 2017 1:45 PM
> To: Liu, Monk ; Christian König
> ; Yu, Xiangliang
> Cc: amd-gfx@lists.freedesktop.org
> Subject: Re: [V3 04/11] drm/amdgpu/virt: use kiq to access re
On 12/01/17 12:21 PM, Liu, Monk wrote:
>
>if (in_interrupt())
> BUG();
Current coding style is
BUG_ON(in_interrupt());
according to https://kernelnewbies.org/FAQ/BUG .
--
Earthling Michel Dänzer | http://www.amd.com
Libre software enthusiast
, Reviewed-by: Monk Liu
发件人: Liu, Monk
发送时间: 2017年1月12日 11:19:40
收件人: Christian König; Yu, Xiangliang; amd-gfx@lists.freedesktop.org
主题: 答复: [V3 04/11] drm/amdgpu/virt: use kiq to access registers
Xiangliang
please BUG() when register access occured in RUNTIME and
11日 22:54:52
收件人: Christian König; Yu, Xiangliang; amd-gfx@lists.freedesktop.org
主题: RE: [V3 04/11] drm/amdgpu/virt: use kiq to access registers
We should BUG and not access register at all if found during RUNTIME &&
IRQ_context
By far.
BR Monk
-Original Message-
From: Christi
ktop.org
Subject: Re: [V3 04/11] drm/amdgpu/virt: use kiq to access registers
> do you think that's okay ?
Fine with me, but I'm not sure if the hypervisor doesn't gets a hickup when a
client writes to some registers from interrupt context.
Christian.
Am 11.01.2017 um 15:38 schri
iangliang ;
amd-gfx@lists.freedesktop.org
Subject: Re: [V3 04/11] drm/amdgpu/virt: use kiq to access registers
Because if we are in interrupt , we are forbid to do schedule, and use kiq to
read register will invoke fence_wait() ...
That won't work. Locking a mutext like it is done in the write path
Sent: Wednesday, January 11, 2017 10:16 PM
To: Liu, Monk ; Yu, Xiangliang ;
amd-gfx@lists.freedesktop.org
Subject: Re: [V3 04/11] drm/amdgpu/virt: use kiq to access registers
> Because if we are in interrupt , we are forbid to do schedule, and use kiq to
> read register will invoke fence_wait() ...
Xiangliang ; amd-gfx@lists.freedesktop.org
Cc: Liu, Monk
Subject: Re: [V3 04/11] drm/amdgpu/virt: use kiq to access registers
Am 11.01.2017 um 14:18 schrieb Xiangliang Yu:
For virtualization, it is must for driver to use KIQ to access
registers when it is out of GPU full access mode.
Signed-off-by: Xiang
ing, instead of directly reading them via KIQ )
BR Monk
-Original Message-
From: Christian König [mailto:deathsim...@vodafone.de]
Sent: Wednesday, January 11, 2017 9:38 PM
To: Yu, Xiangliang ; amd-gfx@lists.freedesktop.org
Cc: Liu, Monk
Subject: Re: [V3 04/11] drm/amdgpu/virt: us
Am 11.01.2017 um 14:18 schrieb Xiangliang Yu:
For virtualization, it is must for driver to use KIQ to access
registers when it is out of GPU full access mode.
Signed-off-by: Xiangliang Yu
Signed-off-by: Monk Liu
---
drivers/gpu/drm/amd/amdgpu/Makefile| 2 +-
drivers/gpu/drm/amd/amd
For virtualization, it is must for driver to use KIQ to access
registers when it is out of GPU full access mode.
Signed-off-by: Xiangliang Yu
Signed-off-by: Monk Liu
---
drivers/gpu/drm/amd/amdgpu/Makefile| 2 +-
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 6 +++
drivers/gpu/drm/amd/
12 matches
Mail list logo
