Re: [gpu-drm-radeon] question about potential dead code in vce_v2_0_enable_mgcg()

2017-06-29 Thread Alex Deucher
dor.com] >>> Sent: Wednesday, June 28, 2017 10:22 AM >>> To: Deucher, Alexander; Koenig, Christian; David Airlie >>> Cc: amd-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org; >>> linux- >>> ker...@vger.kernel.org >>> Subject: [gp

Re: [gpu-drm-radeon] question about potential dead code in vce_v2_0_enable_mgcg()

2017-06-28 Thread Gustavo A. R. Silva
ktop.org; dri-de...@lists.freedesktop.org; linux- ker...@vger.kernel.org Subject: [gpu-drm-radeon] question about potential dead code in vce_v2_0_enable_mgcg() Hello everybody, While looking into Coverity ID 1198635 I ran into the following piece of code at drivers/gpu/drm/radeon/vce_v2_0

RE: [gpu-drm-radeon] question about potential dead code in vce_v2_0_enable_mgcg()

2017-06-28 Thread Deucher, Alexander
..@vger.kernel.org > Subject: [gpu-drm-radeon] question about potential dead code in > vce_v2_0_enable_mgcg() > > > Hello everybody, > > While looking into Coverity ID 1198635 I ran into the following piece > of code at drivers/gpu/drm/radeon/vce_v2_0.c:107: > > 107void

[gpu-drm-radeon] question about potential dead code in vce_v2_0_enable_mgcg()

2017-06-28 Thread Gustavo A. R. Silva
Hello everybody, While looking into Coverity ID 1198635 I ran into the following piece of code at drivers/gpu/drm/radeon/vce_v2_0.c:107: 107void vce_v2_0_enable_mgcg(struct radeon_device *rdev, bool enable) 108{ 109bool sw_cg = false; 110 111if (enable && (rdev->cg_flags &