Re: AMDGPU and 16B stack alignment

2019-10-16 Thread Nick Desaulniers
On Wed, Oct 16, 2019 at 11:55 AM Arvind Sankar wrote: > > On Tue, Oct 15, 2019 at 06:51:26PM -0700, Nick Desaulniers wrote: > > On Tue, Oct 15, 2019 at 1:26 PM Arvind Sankar wrote: > > > > > > On Tue, Oct 15, 2019 at 11:05:56AM -0700, Nick Desaulniers wrote: > > > > Hmmm...I would have liked to

Re: AMDGPU and 16B stack alignment

2019-10-16 Thread Arvind Sankar
On Tue, Oct 15, 2019 at 06:51:26PM -0700, Nick Desaulniers wrote: > On Tue, Oct 15, 2019 at 1:26 PM Arvind Sankar wrote: > > > > On Tue, Oct 15, 2019 at 11:05:56AM -0700, Nick Desaulniers wrote: > > > Hmmm...I would have liked to remove it outright, as it is an ABI > > > mismatch that is likely

Re: AMDGPU and 16B stack alignment

2019-10-15 Thread Nick Desaulniers
On Tue, Oct 15, 2019 at 1:26 PM Arvind Sankar wrote: > > On Tue, Oct 15, 2019 at 11:05:56AM -0700, Nick Desaulniers wrote: > > Hmmm...I would have liked to remove it outright, as it is an ABI > > mismatch that is likely to result in instability and non-fun-to-debug > > runtime issues in the

Re: AMDGPU and 16B stack alignment

2019-10-15 Thread Arvind Sankar
On Tue, Oct 15, 2019 at 11:05:56AM -0700, Nick Desaulniers wrote: > Hmmm...I would have liked to remove it outright, as it is an ABI > mismatch that is likely to result in instability and non-fun-to-debug > runtime issues in the future. I suspect my patch does work for GCC > 7.1+. The question

Re: AMDGPU and 16B stack alignment

2019-10-15 Thread Nick Desaulniers
On Tue, Oct 15, 2019 at 11:30 AM Alex Deucher wrote: > > On Tue, Oct 15, 2019 at 2:07 PM Nick Desaulniers > wrote: > > > > On Tue, Oct 15, 2019 at 12:19 AM Arnd Bergmann wrote: > > > > > > On Tue, Oct 15, 2019 at 9:08 AM S, Shirish wrote: > > > > On 10/15/2019 3:52 AM, Nick Desaulniers wrote:

Re: AMDGPU and 16B stack alignment

2019-10-15 Thread Alex Deucher
On Tue, Oct 15, 2019 at 2:07 PM Nick Desaulniers wrote: > > On Tue, Oct 15, 2019 at 12:19 AM Arnd Bergmann wrote: > > > > On Tue, Oct 15, 2019 at 9:08 AM S, Shirish wrote: > > > On 10/15/2019 3:52 AM, Nick Desaulniers wrote: > > > > > My gcc build fails with below errors: > > > > > >

Re: AMDGPU and 16B stack alignment

2019-10-15 Thread Nick Desaulniers
On Tue, Oct 15, 2019 at 11:05 AM Nick Desaulniers wrote: > > On Tue, Oct 15, 2019 at 12:19 AM Arnd Bergmann wrote: > > > > On Tue, Oct 15, 2019 at 9:08 AM S, Shirish wrote: > > > On 10/15/2019 3:52 AM, Nick Desaulniers wrote: > > > > > My gcc build fails with below errors: > > > > > >

Re: AMDGPU and 16B stack alignment

2019-10-15 Thread Nick Desaulniers
On Tue, Oct 15, 2019 at 12:19 AM Arnd Bergmann wrote: > > On Tue, Oct 15, 2019 at 9:08 AM S, Shirish wrote: > > On 10/15/2019 3:52 AM, Nick Desaulniers wrote: > > > My gcc build fails with below errors: > > > > dcn_calcs.c:1:0: error: -mpreferred-stack-boundary=3 is not between 4 and 12 > > > >

RE: AMDGPU and 16B stack alignment

2019-10-15 Thread David Laight
From: Arnd Bergmann > Sent: 15 October 2019 08:19 > > On Tue, Oct 15, 2019 at 9:08 AM S, Shirish wrote: > > On 10/15/2019 3:52 AM, Nick Desaulniers wrote: > > > My gcc build fails with below errors: > > > > dcn_calcs.c:1:0: error: -mpreferred-stack-boundary=3 is not between 4 and 12 > > > >

Re: AMDGPU and 16B stack alignment

2019-10-15 Thread Arnd Bergmann
On Tue, Oct 15, 2019 at 9:08 AM S, Shirish wrote: > On 10/15/2019 3:52 AM, Nick Desaulniers wrote: > My gcc build fails with below errors: > > dcn_calcs.c:1:0: error: -mpreferred-stack-boundary=3 is not between 4 and 12 > > dcn_calc_math.c:1:0: error: -mpreferred-stack-boundary=3 is not between

Re: AMDGPU and 16B stack alignment

2019-10-15 Thread S, Shirish
Hi Nick, On 10/15/2019 3:52 AM, Nick Desaulniers wrote: Hello! The x86 kernel is compiled with an 8B stack alignment via `-mpreferred-stack-boundary=3` for GCC since 3.6-rc1 via commit d9b0cde91c60 ("x86-64, gcc: Use -mpreferred-stack-boundary=3 if supported") or

AMDGPU and 16B stack alignment

2019-10-14 Thread Nick Desaulniers
Hello! The x86 kernel is compiled with an 8B stack alignment via `-mpreferred-stack-boundary=3` for GCC since 3.6-rc1 via commit d9b0cde91c60 ("x86-64, gcc: Use -mpreferred-stack-boundary=3 if supported") or `-mstack-alignment=8` for Clang. Parts of the AMDGPU driver are compiled