RE: [PATCH] drm/amdgpu: Force signal hw_fences that are embedded in non-sched jobs

2023-03-07 Thread Wang, YuBiao
Christian ; amd-gfx@lists.freedesktop.org Cc: Wang, Yang(Kevin) ; Xu, Feifei ; Chen, Horace ; Deucher, Alexander ; Liu, Monk ; Zhang, Hawking Subject: RE: [PATCH] drm/amdgpu: Force signal hw_fences that are embedded in non-sched jobs Hi Luben, I was comparing the bad jobs of failed ib test

RE: [PATCH] drm/amdgpu: Force signal hw_fences that are embedded in non-sched jobs

2023-03-07 Thread Wang, YuBiao
; Xu, Feifei ; Wang, Yang(Kevin) Subject: Re: [PATCH] drm/amdgpu: Force signal hw_fences that are embedded in non-sched jobs On 2023-03-07 15:36, Luben Tuikov wrote: > + job = container_of(old, struct amdgpu_job, hw_fence); > + if (!job->bas

Re: [PATCH] drm/amdgpu: Force signal hw_fences that are embedded in non-sched jobs

2023-03-07 Thread Luben Tuikov
On 2023-03-07 15:36, Luben Tuikov wrote: > + job = container_of(old, struct amdgpu_job, hw_fence); > + if (!job->base.s_fence && !dma_fence_is_signaled(old)) > + dma_fence_signal(old); Thinking about this more, is

Re: [PATCH] drm/amdgpu: Force signal hw_fences that are embedded in non-sched jobs

2023-03-07 Thread Luben Tuikov
Hi, Thanks for your patch! On 2023-03-07 02:07, Christian König wrote: > Am 07.03.23 um 08:02 schrieb YuBiao Wang: >> [Why] >> For engines not supporting soft reset, i.e. VCN, there will be a failed >> ib test before mode 1 reset during asic reset. The fences in this case >> are never signaled

Re: [PATCH] drm/amdgpu: Force signal hw_fences that are embedded in non-sched jobs

2023-03-06 Thread Christian König
Am 07.03.23 um 08:02 schrieb YuBiao Wang: [Why] For engines not supporting soft reset, i.e. VCN, there will be a failed ib test before mode 1 reset during asic reset. The fences in this case are never signaled and next time when we try to free the sa_bo, kernel will hang. [How] During