, Hersen
Cc: Quan, Evan ; amd-gfx@lists.freedesktop.org; Feng,
Kenneth
Subject: Re: [PATCH 2/2] drm/amdgpu/display: navi1x copy dcn watermark clock
settings to smu resume from s3
On Fri, Feb 28, 2020 at 3:59 PM Wu, Hersen wrote:
>
> Follow Evan's review, add smu->mutex.
>
>
&
,
Kenneth
Subject: Re: [PATCH 2/2] drm/amdgpu/display: navi1x copy dcn watermark clock
settings to smu resume from s3
On Fri, Feb 28, 2020 at 3:59 PM Wu, Hersen wrote:
>
> Follow Evan's review, add smu->mutex.
>
>
> This interface is for dGPU Navi1x. Linux dc-pplib interface dep
the mutex here in the failure case.
Alex
> + }
> + smu->watermarks_bitmap |= WATERMARKS_LOADED;
> + }
> +
> + mutex_unlock(>mutex);
> +
> + return 0;
> +}
> +
> /**
> * dm_hw_init() - Initialize DC device
> * @handle: The base driver device containing the amdgpu_dm device.
>
_smu_write_watermarks_table(adev);
+
return 0;
}
--
2.17.1
From: Quan, Evan
Sent: February 27, 2020 9:58 PM
To: Wu, Hersen ; amd-gfx@lists.freedesktop.org
Cc: Feng, Kenneth ; Wu, Hersen
Subject: RE: [PATCH 2/2] drm/amdgpu/display: navi1x copy dcn watermar
Thanks. But could you help to confirm whether this is correctly protected by
"mutex_lock(>mutex)"?
-Original Message-
From: Hersen Wu
Sent: Thursday, February 27, 2020 11:54 PM
To: amd-gfx@lists.freedesktop.org
Cc: Quan, Evan ; Feng, Kenneth ; Wu,
Hersen
Subject: [PATCH 2/2]
On Thu, Feb 27, 2020 at 10:54 AM Hersen Wu wrote:
>
> This interface is for dGPU Navi1x. Linux dc-pplib interface depends
> on window driver dc implementation.
>
> For Navi1x, clock settings of dcn watermarks are fixed. the settings
> should be passed to smu during boot up and resume from s3.
