RE: [PATCH 3/5] drm/amdgpu: Avoid use SOC15_REG_OFFSET in static const array

2017-12-07 Thread Liu, Shaoyun
Thanks a lot . Regards Shaoyun.liu -Original Message- From: Koenig, Christian Sent: Thursday, December 07, 2017 12:13 PM To: Liu, Shaoyun; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH 3/5] drm/amdgpu: Avoid use SOC15_REG_OFFSET in static const array Hi Shaoyun, I didn't have

Re: [PATCH 3/5] drm/amdgpu: Avoid use SOC15_REG_OFFSET in static const array

2017-12-07 Thread Christian König
Hi Shaoyun, I didn't have time to take a closer look. Just skimming over the code I've found one thing that looked like odd coding style: + amdgpu_ring_write(ring, PACKET0(SOC15_REG_OFFSET(UVD, 0, +mmUVD_NO_OP), 0)); } Please make sure to fix those, with that done the series

RE: [PATCH 3/5] drm/amdgpu: Avoid use SOC15_REG_OFFSET in static const array

2017-12-07 Thread Liu, Shaoyun
Hi , Christian Do you have time to continue review them ? Regards Shaoyun.liu -Original Message- From: Liu, Shaoyun Sent: Friday, December 01, 2017 3:13 PM To: amd-gfx@lists.freedesktop.org Cc: Liu, Shaoyun Subject: [PATCH 3/5] drm/amdgpu: Avoid use SOC15_REG_OFFSET in static const

RE: [PATCH 3/5] drm/amdgpu: Avoid use SOC15_REG_OFFSET in static const array

2017-12-01 Thread Liu, Shaoyun
Please ignore this change , forgot to include uvd related changes as suggested . Regards Shaoayun.liu -Original Message- From: Liu, Shaoyun Sent: Friday, December 01, 2017 2:58 PM To: amd-gfx@lists.freedesktop.org Cc: Liu, Shaoyun Subject: [PATCH 3/5] drm/amdgpu: Avoid use