Re: [PATCH libdrm 3/3] amdgpu: A new option to run tests on render node

[Emil Velikov]

On 24 January 2017 at 22:39, Xie, AlexBin  wrote:
> Hi Emil,
>
> Point 1 will be left for future patch.
>
Definitely. I did not mean to ask/push you to address that here.

> Current error message is following.
> Error: Permission denied. Hint:Try to run this test program as root.
>
> I am thinking change it. Error message will be:
> Error: Permission denied. Hint:Try to run this test program as root or in TTY.
>
I'm still leaning that in 2017 asking people to run anything as root
is bad idea. Anyway it's just be being pedantic.

-Emil
___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

RE: [PATCH libdrm 3/3] amdgpu: A new option to run tests on render node

[Xie, AlexBin]

Hi Emil,

Point 1 will be left for future patch.

Current error message is following.
Error: Permission denied. Hint:Try to run this test program as root.

I am thinking change it. Error message will be:
Error: Permission denied. Hint:Try to run this test program as root or in TTY.

Thanks,
Alex Bin Xie

-Original Message-
From: Emil Velikov [mailto:emil.l.veli...@gmail.com] 
Sent: Friday, January 20, 2017 8:31 AM
To: Xie, AlexBin 
Cc: amd-gfx mailing list 
Subject: Re: [PATCH libdrm 3/3] amdgpu: A new option to run tests on render node

HI Alex,

A couple of small idea(s) for future work (?).

On 19 January 2017 at 22:53, Alex Xie  wrote:
> Tested:
> 1. As root, tests passed on primary.
Add auth mechanism and request run outside of X environment (switching
to TTY should work).
Then adjust the suggestion s/run as root/run in TTY/ ?

> 2. As root, BO export/import failed on render node as expected.
Afaict those can never succeed, so might as well change the test to
expect failure [when using the render node], or at least print a
message "the following failure is expected" ?

Thanks the series !
Emil
___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx