Implementations of missing dce6 functions: how should patches be organized?

2016-08-08 Thread Alexandre Demers
Since yesterday was a rainy day over here, I took some time at the unimplemented dce6 functions and I'm almost done with them. I still need to: - mimic how MASKs and SHIFTs are used in dce_v8_0.c (purely for consistency and clarity) -- rename some variables and split imbriqued MASKs and SHIFTs

Re: [PATCH] Standardizing the info message for unimplemented functions

2016-08-08 Thread Alexandre Demers
On Mon, 8 Aug 2016 at 01:22 Huang Rui wrote: > On Sun, Aug 07, 2016 at 05:17:41PM -0400, Alexandre Demers wrote: > > Signed-off-by: Alexandre Demers > > > > --- > > drivers/gpu/drm/amd/amdgpu/dce_v6_0.c | 22 +++--- > > 1 file

Re: [PATCH 0/7] Minor DP aux transaction fixes

2016-08-08 Thread Alex Deucher
On Fri, Aug 5, 2016 at 8:30 PM, Lyude wrote: > While I was investigating an unrelated bug on the radeon driver, I noticed > that > it's become rather difficult to actually read through dmesg with drm.debug > turned on, on account of the huge number of messages we end up

Re: [PATCH 07/14] drm/amd/powerplay: remove enable_clock_power_gatings_tasks from initialize and resume events

2016-08-08 Thread Eric Huang
Hi Tom, I am concerned with the Sclk Deep Sleep feature. If removing this task, UVD/VCE will always power on and Sclk deep sleep will not work. And the power consumption will block our client's Energy start test. So where are you going to re-add this task ? Thanks, Eric On 16-07-28 10:19

Wrong shift in dce_v8_0_afmt_update_ACR() under dce_v8_0.c?

2016-08-08 Thread Alexandre Demers
Hi, While looking into dce_v8_0.c, I stumbled upon something that might be wrong dce_v8_0_afmt_update_ACR(). We can read: WREG32(mmHDMI_ACR_32_0 + offset, (acr.cts_32khz << HDMI_ACR_44_0__HDMI_ACR_CTS_44__SHIFT)); However, I'm mostly sure it should be (luckily, the shift is of the same

RE: [PATCH 09/14] drm/amd/amdgpu: Enable carrizo GFX PG

2016-08-08 Thread Deucher, Alexander
I'm not sure gfx PG works properly with some of the kfd features. I know there were problems in the past. We probably need to add some sort of handshake for when we have kfd running in order to disable gfx PG when necessary. Alex From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org]

[PATCH 3/3] drm/amdgpu: add virtual dce support for iceland

2016-08-08 Thread Alex Deucher
Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/vi.c | 58 +++-- 1 file changed, 56 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/vi.c b/drivers/gpu/drm/amd/amdgpu/vi.c index 2d3e3ed..69c2f81

[PATCH 2/3] drm/amdgpu/virtual_dce: add case for topaz for disable_dce

2016-08-08 Thread Alex Deucher
This asic has no DCE block. Also clarify the error message for unmatched chips. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/dce_virtual.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/dce_virtual.c

[PATCH 1/3] drm/amdgpu: move vsync_timer_enabled setup to dce virtual early_init

2016-08-08 Thread Alex Deucher
Put it in one place. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/cik.c | 1 - drivers/gpu/drm/amd/amdgpu/dce_virtual.c | 1 + drivers/gpu/drm/amd/amdgpu/vi.c | 1 - 3 files changed, 1 insertion(+), 2 deletions(-) diff --git

Re: [PATCH 09/14] drm/amd/amdgpu: Enable carrizo GFX PG

2016-08-08 Thread Felix Kuehling
We're reverting this commit on the KFD branch because it's causing hangs on a bunch of HSA compute tests on CZ. Regards, Felix On 16-07-28 10:19 AM, Tom St Denis wrote: > Signed-off-by: Tom St Denis > --- > drivers/gpu/drm/amd/amdgpu/vi.c | 6 ++ > 1 file changed, 6

RE: [PATCH 09/14] drm/amd/amdgpu: Enable carrizo GFX PG

2016-08-08 Thread Kuehling, Felix
I'm not sure what the specific features are that are causing issues. FWIW, the first KFDTest unit test that fails has the CPU wait for the GPU to signal 256 events using PM4ReleaseMemory packets. It uses IOMMUv2 for coherent memory access from the GPU. Regards, Felix From: Deucher,

[PATCH] drm/amdgpu: Change the virtual_display type from int to char*.

2016-08-08 Thread Emily Deng
For virtual display feature, as there may be mutiple GPUs, for user could choose whiche GPU need to enable this feature, change the type of virtual_display from int to char*. The variable will be set like this virtual_display="xx:xx.x;xx:xx.x;". Signed-off-by: Emily Deng ---

[PATCH] drm/amdgpu: Change the virtual_display type from int to char*.

2016-08-08 Thread Emily Deng
For virtual display feature, as there may be mutiple GPUs, for user could choose whiche GPU need to enable this feature, change the type of virtual_display from int to char*. The variable will be set like this virtual_display="xx:xx.x;xx:xx.x;". Signed-off-by: Emily Deng ---

Re: Wrong shift in dce_v8_0_afmt_update_ACR() under dce_v8_0.c?

2016-08-08 Thread Alex Deucher
On Mon, Aug 8, 2016 at 5:43 PM, Alexandre Demers wrote: > Hi, > > While looking into dce_v8_0.c, I stumbled upon something that might be wrong > dce_v8_0_afmt_update_ACR(). We can read: > > WREG32(mmHDMI_ACR_32_0 + offset, (acr.cts_32khz << >

RE: [PATCH] drm/amdgpu: Change the virtual_display type from int to char*.

2016-08-08 Thread Deng, Emily
> -Original Message- > From: Edward O'Callaghan [mailto:funfunc...@folklore1984.net] > Sent: Tuesday, August 09, 2016 11:54 AM > To: Deng, Emily ; amd-gfx@lists.freedesktop.org > Subject: Re: [PATCH] drm/amdgpu: Change the virtual_display type from int to > char*. >

Re: [PATCH] drm/amdgpu: Change the virtual_display type from int to char*.

2016-08-08 Thread Edward O'Callaghan
On 08/09/2016 01:47 PM, Emily Deng wrote: > For virtual display feature, as there may be mutiple GPUs, > for user could choose whiche GPU need to enable this feature, change > the type of virtual_display from int to char*. The variable will be set > like this virtual_display="xx:xx.x;xx:xx.x;".

RE: [PATCH 2/3] drm/amdgpu/virtual_dce: add case for topaz for disable_dce

2016-08-08 Thread Deng, Emily
Reviewed-By: Emily Deng > -Original Message- > From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf Of > Alex Deucher > Sent: Tuesday, August 09, 2016 2:47 AM > To: amd-gfx@lists.freedesktop.org > Cc: Deucher, Alexander >

RE: [PATCH 3/3] drm/amdgpu: add virtual dce support for iceland

2016-08-08 Thread Deng, Emily
Reviewed-By: Emily Deng > -Original Message- > From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf Of > Alex Deucher > Sent: Tuesday, August 09, 2016 2:47 AM > To: amd-gfx@lists.freedesktop.org > Cc: Deucher, Alexander >

Re: [PATCH 1/6] drm: Add page_flip_target CRTC hook

2016-08-08 Thread Daniel Vetter
On Mon, Aug 08, 2016 at 12:54:45PM +0900, Michel Dänzer wrote: > On 04.08.2016 20:01, Daniel Vetter wrote: > > On Thu, Aug 04, 2016 at 12:47:38PM +0200, Daniel Vetter wrote: > >> On Thu, Aug 04, 2016 at 12:39:36PM +0900, Michel Dänzer wrote: > >>> > >>> @@ -5434,6 +5435,18 @@ int

Re: [PATCH 6/6] drm: Add DRM_MODE_PAGE_FLIP_TARGET_ABSOLUTE/RELATIVE flags

2016-08-08 Thread Michel Dänzer
On 04.08.2016 19:56, Daniel Vetter wrote: > On Thu, Aug 04, 2016 at 12:39:41PM +0900, Michel Dänzer wrote: >> From: Michel Dänzer >> >> @@ -543,15 +549,25 @@ struct drm_color_lut { >> * 'as soon as possible', meaning that it not delay waiting for vblank. >> * This may

Re: [PATCH] Add freesync ioctl interface

2016-08-08 Thread Michel Dänzer
On 04.08.2016 17:22, Christian König wrote: > Am 04.08.2016 um 08:41 schrieb Michel Dänzer: >> On 03.08.2016 10:04, Dave Airlie wrote: >>> On 2 August 2016 at 12:26, Hawking Zhang wrote: @@ -706,4 +708,17 @@ struct drm_amdgpu_virtual_range { uint64_t

Re: [PATCH] Add freesync ioctl interface

2016-08-08 Thread Christian König
Am 08.08.2016 um 09:43 schrieb Michel Dänzer: On 04.08.2016 17:22, Christian König wrote: Am 04.08.2016 um 08:41 schrieb Michel Dänzer: On 03.08.2016 10:04, Dave Airlie wrote: On 2 August 2016 at 12:26, Hawking Zhang wrote: @@ -706,4 +708,17 @@ struct

Re: [PATCH 00/19] shadow page table support V2

2016-08-08 Thread Christian König
Again patch #7 looks like an unrelated fix to me. Please split that from the patch set, add my rb and commit it preliminary. Apart from that patch #1: + amdgpu_ttm_placement_init(adev, , + placements, AMDGPU_GEM_DOMAIN_GTT, +