Re: [PATCH] amdgpu: Fix always_valid bos multiple LRU insertions.

2018-01-31 Thread Christian König
Am 31.01.2018 um 13:07 schrieb Bas Nieuwenhuizen: If these bos are evicted and are in the validated list things blow up, so do not put them in there. Notably, that tries to add the bo to the LRU twice, which results in a BUG_ON in ttm_bo.c. While for the bo_list an alternative would be to not

Re: [PATCH 6/9] drm/amdkfd: Add dGPU support to the MQD manager

2018-01-31 Thread Oded Gabbay
On Fri, Jan 5, 2018 at 12:17 AM, Felix Kuehling wrote: > On dGPUs don't set ATC addressing bits and use MTYPE_UC for coherent > memory. > > Signed-off-by: Felix Kuehling > --- > drivers/gpu/drm/amd/amdkfd/kfd_mqd_manager.c | 7 + >

[PATCH] drm/amdgpu: Fix always_valid bos multiple LRU insertions.

2018-01-31 Thread Bas Nieuwenhuizen
If these bos are evicted and are in the validated list things blow up, so do not put them in there. Notably, that tries to add the bo to the LRU twice, which results in a BUG_ON in ttm_bo.c. While for the bo_list an alternative would be to not allow always valid bos in there, that does not work

[PATCH umr] add support for sub-opcode 1 for POLL_REGMEM in the SDMA ring decoder

2018-01-31 Thread Tom St Denis
Signed-off-by: Tom St Denis --- src/lib/ring_decode.c | 39 +++ 1 file changed, 27 insertions(+), 12 deletions(-) diff --git a/src/lib/ring_decode.c b/src/lib/ring_decode.c index cc23b6299d33..75247aa198d8 100644 ---

[PATCH] amdgpu: Fix always_valid bos multiple LRU insertions.

2018-01-31 Thread Bas Nieuwenhuizen
If these bos are evicted and are in the validated list things blow up, so do not put them in there. Notably, that tries to add the bo to the LRU twice, which results in a BUG_ON in ttm_bo.c. While for the bo_list an alternative would be to not allow always valid bos in there, that does not work

Re: [PATCH 5/9] drm/amdkfd: Add dGPU support to the device queue manager

2018-01-31 Thread Oded Gabbay
On Fri, Jan 5, 2018 at 12:17 AM, Felix Kuehling wrote: > GFXv7 and v8 dGPUs use a different addressing mode for KFD compared > to APUs (GPUVM64 vs HSA64). And dGPUs don't support MTYPE_CC. They > use MTYPE_UC instead for memory that requires coherency. > > Signed-off-by:

Re: [PATCH 2/9] drm/amdkfd: Conditionally enable PCIe atomics

2018-01-31 Thread Oded Gabbay
On Fri, Jan 5, 2018 at 12:17 AM, Felix Kuehling wrote: > This will be needed for most dGPUs. > > CC: linux-...@vger.kernel.org > Signed-off-by: Felix Kuehling > --- > drivers/gpu/drm/amd/amdkfd/kfd_device.c | 17 + >

Re: [PATCH 11/13] drm/amdgpu: add DRM_AMDGPU_ATC config option

2018-01-31 Thread Oded Gabbay
On Tue, Jan 30, 2018 at 6:53 PM, Felix Kuehling wrote: > > On 2018-01-30 08:59 AM, Christian König wrote: >> Am 29.01.2018 um 23:08 schrieb Felix Kuehling: >>> On 2018-01-26 03:13 PM, Christian König wrote: [SNIP] +#ifdef CONFIG_DRM_AMDGPU_ATC +r =

Re: [PATCH 4/9] drm/amdkfd: Make sched_policy a per-device setting

2018-01-31 Thread Oded Gabbay
On Fri, Jan 5, 2018 at 12:17 AM, Felix Kuehling wrote: > Some dGPUs don't support HWS. Allow them to use a per-device > sched_policy that may be different from the global default. > > Signed-off-by: Felix Kuehling > --- >

Re: [PATCH 3/9] drm/amdkfd: Make IOMMUv2 code conditional

2018-01-31 Thread Oded Gabbay
On Wed, Jan 31, 2018 at 4:56 PM, Oded Gabbay wrote: > Hi Felix, > Please don't spread 19 #ifdefs throughout the code. > I suggest to put one #ifdef in linux/amd-iommu.h itself around all the > functions declarations and in the #else section put macros with empty >

Re: [PATCH 11/13] drm/amdgpu: add DRM_AMDGPU_ATC config option

2018-01-31 Thread Christian König
Adding Jean and the IOMMU list as well. Am 31.01.2018 um 13:43 schrieb Oded Gabbay: On Tue, Jan 30, 2018 at 6:53 PM, Felix Kuehling wrote: [SNIP] There was some discussion last year about a generic PASID allocator in the iommu subsystem:

Re: [PATCH 3/9] drm/amdkfd: Make IOMMUv2 code conditional

2018-01-31 Thread Oded Gabbay
Hi Felix, Please don't spread 19 #ifdefs throughout the code. I suggest to put one #ifdef in linux/amd-iommu.h itself around all the functions declarations and in the #else section put macros with empty implementations. This is much more readable and maintainable. Oded On Fri, Jan 5, 2018 at

Re: [PATCH 3/9] drm/amdkfd: Make IOMMUv2 code conditional

2018-01-31 Thread Christian König
Am 31.01.2018 um 16:00 schrieb Oded Gabbay: On Wed, Jan 31, 2018 at 4:56 PM, Oded Gabbay wrote: Hi Felix, Please don't spread 19 #ifdefs throughout the code. I suggest to put one #ifdef in linux/amd-iommu.h itself around all the functions declarations and in the #else

[PATCH] drm/amdgpu: Fix always_valid bos multiple LRU insertions.

2018-01-31 Thread Bas Nieuwenhuizen
If these bos are evicted and are in the validated list things blow up, so do not put them in there. Notably, that tries to add the bo to the LRU twice, which results in a BUG_ON in ttm_bo.c. While for the bo_list an alternative would be to not allow always valid bos in there, that does not work

Re: [PATCH 9/9] drm/amdgpu: Enable KFD initialization on dGPUs

2018-01-31 Thread Christian König
Am 31.01.2018 um 16:25 schrieb Oded Gabbay: On Fri, Jan 5, 2018 at 12:17 AM, Felix Kuehling wrote: Signed-off-by: Felix Kuehling --- drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c | 5 + 1 file changed, 5 insertions(+) diff --git

Re: [PATCH] Revert "drm/amdgpu/gfx8: Fix compute ring failure after resetting"

2018-01-31 Thread Andrey Grodzovsky
On 01/25/2018 11:33 PM, Yu, Xiangliang wrote: You can add amdgpu_sriov_vf() check to avoid breaking sriov. + Haisheng As found out after more debugging  and discussion with Haisheng from HW team, the sequence introduced by this change is is wrong, it causes compute rings test failure

Re: [PATCH 9/9] drm/amdgpu: Enable KFD initialization on dGPUs

2018-01-31 Thread Oded Gabbay
On Fri, Jan 5, 2018 at 12:17 AM, Felix Kuehling wrote: > Signed-off-by: Felix Kuehling > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c >

Re: amdgpu hangs on boot or shutdown on AMD Raven Ridge CPU (Engineer Sample)

2018-01-31 Thread Harry Wentland
On 2018-01-31 09:31 AM, Chris Chiu wrote: > Hi, > We are working with new laptops that have the AMD Ravenl Ridge > chipset with this `/proc/cpuinfo` > https://gist.github.com/mschiu77/b06dba574e89b9a30cf4c450eaec49bc > > With the latest kernel 4.15, there're lots of different >

Re: [PATCH 3/9] drm/amdkfd: Make IOMMUv2 code conditional

2018-01-31 Thread Felix Kuehling
On 2018-01-31 10:00 AM, Oded Gabbay wrote: > On Wed, Jan 31, 2018 at 4:56 PM, Oded Gabbay wrote: >> Hi Felix, >> Please don't spread 19 #ifdefs throughout the code. >> I suggest to put one #ifdef in linux/amd-iommu.h itself around all the >> functions declarations and in

Re: [PATCH 7/9] drm/amdkfd: Add dGPU support to kernel_queue_init

2018-01-31 Thread Felix Kuehling
On 2018-01-31 10:29 AM, Oded Gabbay wrote: > On Wed, Jan 31, 2018 at 5:23 PM, Deucher, Alexander > wrote: >> >> From: amd-gfx on behalf of Oded >> Gabbay >> Sent: Wednesday,

Re: [PATCH 8/9] drm/amdkfd: Add dGPU device IDs and device info

2018-01-31 Thread Felix Kuehling
On 2018-01-31 10:20 AM, Oded Gabbay wrote: > On Fri, Jan 5, 2018 at 12:17 AM, Felix Kuehling > wrote: >> CC: linux-...@vger.kernel.org >> Signed-off-by: Felix Kuehling >> --- >> drivers/gpu/drm/amd/amdkfd/kfd_device.c | 153 >>

Re: [PATCH 9/9] drm/amdgpu: Enable KFD initialization on dGPUs

2018-01-31 Thread Oded Gabbay
On Wed, Jan 31, 2018 at 5:28 PM, Christian König wrote: > Am 31.01.2018 um 16:25 schrieb Oded Gabbay: >> >> On Fri, Jan 5, 2018 at 12:17 AM, Felix Kuehling >> wrote: >>> >>> Signed-off-by: Felix Kuehling >>> ---

[PATCH 24/27] drm/amd/display: Optimize regamma calculations

2018-01-31 Thread Harry Wentland
From: Krunoslav Kovac There are several optimizations: 1) Use predefined SRGB, don't calculate. This is the most common case. 2) Precompute HW X points at boot since they're fixed in ColModule 3) Precompute PQ - it never changes and is very CPU intensive in fixed pt. 4)

[PATCH 26/27] drm/amd/display: enable #PME code path for RV.

2018-01-31 Thread Harry Wentland
From: Charlene Liu Signed-off-by: Charlene Liu Reviewed-by: Yongqiang Sun Acked-by: Harry Wentland --- drivers/gpu/drm/amd/display/dc/core/dc_link.c | 6 +++--- 1 file changed, 3 insertions(+), 3

[PATCH 22/27] drm/amd/display: add eDP 1.2+ polling for T7

2018-01-31 Thread Harry Wentland
From: Charlene Liu Signed-off-by: Charlene Liu Reviewed-by: Charlene Liu Acked-by: Harry Wentland --- drivers/gpu/drm/amd/display/dc/core/dc_link_hwss.c | 22 ++

Re: [PATCH 7/9] drm/amdkfd: Add dGPU support to kernel_queue_init

2018-01-31 Thread Deucher, Alexander
From: amd-gfx on behalf of Oded Gabbay Sent: Wednesday, January 31, 2018 10:17 AM To: Kuehling, Felix Cc: amd-gfx list Subject: Re: [PATCH 7/9] drm/amdkfd: Add dGPU support to kernel_queue_init On

[PATCH 3/8] drm/amdgpu: make VMID owner none atomic

2018-01-31 Thread Christian König
The variable is protected by the VMID mutex anyway. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_ids.c | 10 +- drivers/gpu/drm/amd/amdgpu/amdgpu_ids.h | 2 +- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git

[PATCH 8/8] drm/amdgpu: cache the fence to wait for a VMID

2018-01-31 Thread Christian König
Beneficial when a lot of processes are waiting for VMIDs. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_ids.c | 7 +-- drivers/gpu/drm/amd/amdgpu/amdgpu_ring.c | 3 +++ drivers/gpu/drm/amd/amdgpu/amdgpu_ring.h | 1 + 3 files changed, 9

[PATCH 6/8] drm/amdgpu: move reusing VMIDs into separate function

2018-01-31 Thread Christian König
Let's try this once more. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_ids.c | 130 1 file changed, 81 insertions(+), 49 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ids.c

[PATCH 7/8] drm/amdgpu: restructure amdgpu_vmid_grab

2018-01-31 Thread Christian König
Now that we have the different cases for grabbing a VMID in separate functions, restructure the top level function to only have one place where VMIDs are assigned to jobs. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_ids.c | 89

[PATCH 5/8] drm/amdgpu: cleanup and simplify amdgpu_vmid_grab_reserved

2018-01-31 Thread Christian König
Drop the "_locked" from the name, cleanup and simplify the logic a bit. Add missing comments. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_ids.c | 58 - 1 file changed, 35 insertions(+), 23 deletions(-) diff

[PATCH 4/8] drm/amdgpu: stop checking GPU reset counter during VMID grab

2018-01-31 Thread Christian König
We do this later on when we flush the VMID anyway. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_ids.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ids.c

[PATCH 2/8] drm/amdgpu: split finding idle VMID into separate function

2018-01-31 Thread Christian König
No functional change, but makes it easier to maintain the code. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_ids.c | 116 +++- 1 file changed, 69 insertions(+), 47 deletions(-) diff --git

[PATCH 1/8] drm/amdgpu: make VMID assignment more fair

2018-01-31 Thread Christian König
To guarantee fairness between processes grab reserved VMID only when there is an idle one. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_ids.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git

Re: [PATCH] Revert "drm/amdgpu/gfx8: Fix compute ring failure after resetting"

2018-01-31 Thread Christian König
Am 26.01.2018 um 00:06 schrieb Andrey Grodzovsky: This reverts commit 75737cb4eb78c7f185e4700b4aa20cf7a3381aca. Fixes GFX ring test failure after HW reset. No compute ring test failures were observed with the change reverted. So seems like whatever problem that change was addressing is not

Re: [PATCH 8/9] drm/amdkfd: Add dGPU device IDs and device info

2018-01-31 Thread Oded Gabbay
On Fri, Jan 5, 2018 at 12:17 AM, Felix Kuehling wrote: > CC: linux-...@vger.kernel.org > Signed-off-by: Felix Kuehling > --- > drivers/gpu/drm/amd/amdkfd/kfd_device.c | 153 > +++- > 1 file changed, 151 insertions(+),

Re: [PATCH 7/9] drm/amdkfd: Add dGPU support to kernel_queue_init

2018-01-31 Thread Oded Gabbay
On Wed, Jan 31, 2018 at 5:23 PM, Deucher, Alexander wrote: > > > From: amd-gfx on behalf of Oded > Gabbay > Sent: Wednesday, January 31, 2018 10:17 AM > To: Kuehling, Felix

Re: [PATCH 9/9] drm/amdgpu: Enable KFD initialization on dGPUs

2018-01-31 Thread Christian König
Am 31.01.2018 um 16:31 schrieb Oded Gabbay: On Wed, Jan 31, 2018 at 5:28 PM, Christian König wrote: Am 31.01.2018 um 16:25 schrieb Oded Gabbay: On Fri, Jan 5, 2018 at 12:17 AM, Felix Kuehling wrote: Signed-off-by: Felix Kuehling

Re: [PATCH 9/9] drm/amdgpu: Enable KFD initialization on dGPUs

2018-01-31 Thread Oded Gabbay
On Wed, Jan 31, 2018 at 5:34 PM, Christian König wrote: > Am 31.01.2018 um 16:31 schrieb Oded Gabbay: >> >> On Wed, Jan 31, 2018 at 5:28 PM, Christian König >> wrote: >>> >>> Am 31.01.2018 um 16:25 schrieb Oded Gabbay: On Fri,

Re: [PATCH 4/9] drm/amdkfd: Make sched_policy a per-device setting

2018-01-31 Thread Felix Kuehling
On 2018-01-31 10:06 AM, Oded Gabbay wrote: > On Fri, Jan 5, 2018 at 12:17 AM, Felix Kuehling > wrote: >> Some dGPUs don't support HWS. Allow them to use a per-device >> sched_policy that may be different from the global default. >> >> Signed-off-by: Felix Kuehling

Re: [PATCH 9/9] drm/amdgpu: Enable KFD initialization on dGPUs

2018-01-31 Thread Felix Kuehling
On 2018-01-31 10:25 AM, Oded Gabbay wrote: > On Fri, Jan 5, 2018 at 12:17 AM, Felix Kuehling > wrote: >> Signed-off-by: Felix Kuehling >> --- >> drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c | 5 + >> 1 file changed, 5 insertions(+) >> >> diff

Re: [PATCH 7/9] drm/amdkfd: Add dGPU support to kernel_queue_init

2018-01-31 Thread Oded Gabbay
On Fri, Jan 5, 2018 at 12:17 AM, Felix Kuehling wrote: > Recognize dGPU ASIC families. > > Signed-off-by: Felix Kuehling > --- > drivers/gpu/drm/amd/amdkfd/kfd_kernel_queue.c | 5 + > 1 file changed, 5 insertions(+) > > diff --git

amdgpu hangs on boot or shutdown on AMD Raven Ridge CPU (Engineer Sample)

2018-01-31 Thread Chris Chiu
Hi, We are working with new laptops that have the AMD Ravenl Ridge chipset with this `/proc/cpuinfo` https://gist.github.com/mschiu77/b06dba574e89b9a30cf4c450eaec49bc With the latest kernel 4.15, there're lots of different panics/oops during boot so no chance to get into X. It also

Re: [PATCH 11/13] drm/amdgpu: add DRM_AMDGPU_ATC config option

2018-01-31 Thread Jean-Philippe Brucker
Hi Christian, On 31/01/18 13:04, Christian König wrote: > Adding Jean and the IOMMU list as well. > > Am 31.01.2018 um 13:43 schrieb Oded Gabbay: >> On Tue, Jan 30, 2018 at 6:53 PM, Felix Kuehling >> wrote: >>> [SNIP] >> There was some discussion last year about a

Re: [PATCH] drm/amdkfd: Use ARRAY_SIZE macro in kfd_build_sysfs_node_entry

2018-01-31 Thread Oded Gabbay
On Sat, Jan 20, 2018 at 12:30 AM, Gustavo A. R. Silva wrote: > > Quoting Felix Kuehling : > >> Looks good. This change is Reviewed-by: Felix Kuehling >> >> > > Thanks Felix. > -- > Gustavo > Applied to -next Oded > > > >

[PATCH 10/27] drm/amd/display: Null check for gamma correction.

2018-01-31 Thread Harry Wentland
From: Yongqiang Sun Signed-off-by: Yongqiang Sun Reviewed-by: Tony Cheng Acked-by: Harry Wentland --- drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c | 3 ++- 1 file changed, 2 insertions(+),

[PATCH 11/27] drm/amd/display: Set irq state only on existing crtcs

2018-01-31 Thread Harry Wentland
From: Mikita Lipski Because AMDGPU_CRTC_IRQ_VLINE1 = 6, it expected 6 more crtcs to be programed with disabled irq state in amdgpu_irq_disable_all. That caused errors and accessed the wrong memory location. Signed-off-by: Mikita Lipski

[PATCH 15/27] drm/amd/display: Expose is_rgb_cspace function in hw_sequencer

2018-01-31 Thread Harry Wentland
From: Eric Bernstein Signed-off-by: Eric Bernstein Reviewed-by: Tony Cheng Acked-by: Harry Wentland --- drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c | 2 +-

[PATCH 13/27] drm/amd/display: remove unused function prototypes

2018-01-31 Thread Harry Wentland
From: Eric Yang Signed-off-by: Eric Yang Reviewed-by: Tony Cheng Acked-by: Harry Wentland --- drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c | 4 ++--

[PATCH 00/27] DC Patches Jan 31, 2018

2018-01-31 Thread Harry Wentland
* Fix non-native modes on DVI * Whole bunch of Raven fixes all over * Cleanup for CRC stuff Charlene Liu (5): drm/amd/display: BL setting save/restore drm/amd/display: wait for T9 after backlight off mainlink blank. drm/amd/display: add eDP 1.2+ polling for T7 drm/amd/display: resume from

[PATCH 16/27] drm/amd/display: turn off cursor when disconnect plane

2018-01-31 Thread Harry Wentland
From: Eric Yang As a precaution to prevent cases where cursor is enabled on a pipe that is disabled, always turn off cursor when disconnecting plane. Signed-off-by: Eric Yang Reviewed-by: Tony Cheng Acked-by: Harry Wentland

[PATCH 05/27] drm/amd/display: Fix multiple definitions of handle_crc_irq

2018-01-31 Thread Harry Wentland
From: "Leo (Sunpeng) Li" If CONFIG_DEBUG_FS is disabled, then CRC should also be disabled. Therefore, amdgpu_dm_crtc_handle_crc_irq was redefined as a no-op function within amdgpu_dm.h. However, since amdgpu_dm.h is included in multiple files, this caused conflicts when

[PATCH 12/27] drm/amd/display: fix cursor related Pstate hang

2018-01-31 Thread Harry Wentland
From: Eric Yang Move cursor programming to inside the OTG_MASTER_UPDATE_LOCK If graphics plane go from 1 pipe to hsplit, the cursor updates after mpc programming and unlock. Which means there is a window of time where cursor is enabled on the wrong pipe if it's on the right

[PATCH 14/27] drm/amd/display: WBSCL filter init calculation fixes

2018-01-31 Thread Harry Wentland
From: Ken Chalmers * Previous code did some calculations with a mix of normal integers and integers aligned as U2.24 fixed-point values. * There were bugs in the conversion of the final result into the S4.19 values required for the registers. Signed-off-by: Ken

[PATCH 18/27] drm/amd/display: fix boot-up on vega10

2018-01-31 Thread Harry Wentland
From: Roman Li Fixing null-deref on Vega10 due to regression after 'fix cursor related Pstate hang' change. Added null checks in setting cursor position. Signed-off-by: Roman Li Reviewed-by: Eric Yang Reviewed-by: Harry Wentland

[PATCH 27/27] drm/amd/display: Add primary tmz_c and meta tmz tmz_c.

2018-01-31 Thread Harry Wentland
From: Yongqiang Sun Signed-off-by: Yongqiang Sun Reviewed-by: Tony Cheng Acked-by: Harry Wentland --- drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hubp.c | 19 +--

[PATCH 17/27] drm/amd/display: Remove couple of unused OPTC registers

2018-01-31 Thread Harry Wentland
From: Nikola Cornij Signed-off-by: Nikola Cornij Reviewed-by: Tony Cheng Acked-by: Harry Wentland --- drivers/gpu/drm/amd/display/dc/dcn10/dcn10_optc.h| 8

[PATCH 20/27] drm/amd/display: Fixed if statement parameters to add a delay on disconnect

2018-01-31 Thread Harry Wentland
From: John Barberiz Signed-off-by: John Barberiz Reviewed-by: Tony Cheng Acked-by: Harry Wentland --- drivers/gpu/drm/amd/display/dc/core/dc_link.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff

[PATCH 21/27] drm/amd/display: dal 3.1.31

2018-01-31 Thread Harry Wentland
From: Tony Cheng Signed-off-by: Tony Cheng Reviewed-by: Tony Cheng Acked-by: Harry Wentland --- drivers/gpu/drm/amd/display/dc/dc.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 23/27] drm/amd/display: resume from S3 bypass power down HW block.

2018-01-31 Thread Harry Wentland
From: Charlene Liu Signed-off-by: Charlene Liu Reviewed-by: Krunoslav Kovac Acked-by: Harry Wentland --- drivers/gpu/drm/amd/display/dc/bios/bios_parser.c | 1 +

[PATCH 06/27] drm/amd/display: wait for T9 after backlight off mainlink blank.

2018-01-31 Thread Harry Wentland
From: Charlene Liu Signed-off-by: Charlene Liu Reviewed-by: Tony Cheng Acked-by: Harry Wentland --- drivers/gpu/drm/amd/display/dc/core/dc_link_hwss.c | 3 +--

[PATCH 25/27] drm/amd/display: dal 3.1.32

2018-01-31 Thread Harry Wentland
From: Tony Cheng Signed-off-by: Tony Cheng Reviewed-by: Tony Cheng Acked-by: Harry Wentland --- drivers/gpu/drm/amd/display/dc/dc.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 19/27] drm/amd/display: Add return value for detect dp.

2018-01-31 Thread Harry Wentland
From: Yongqiang Sun System soft hang when hotplug specific 4K DP panel due to link caps read error and incorrect link setting parmas to enable dp. Add status check for DPCD read and add return value for detect dp, in case of false, return from caller, avoid further false

[PATCH 02/27] drm/amd/display: BL setting save/restore

2018-01-31 Thread Harry Wentland
From: Charlene Liu Signed-off-by: Charlene Liu Reviewed-by: Tony Cheng Acked-by: Harry Wentland --- drivers/gpu/drm/amd/display/dc/dce/dce_abm.c | 9 + 1 file changed, 9 insertions(+) diff --git

[PATCH 09/27] drm/amd/display: Check hubp in pipe_ctx not in res_pool.

2018-01-31 Thread Harry Wentland
From: Yongqiang Sun When disable plane, check power gate flag in hubp with pipe_ctx, not with res_pool. Signed-off-by: Yongqiang Sun Reviewed-by: Tony Cheng Acked-by: Harry Wentland ---

[PATCH 03/27] drm/amd/display: Remove return when no EDID read.

2018-01-31 Thread Harry Wentland
From: Martin Tsai Signed-off-by: Martin Tsai Reviewed-by: Tony Cheng Acked-by: Harry Wentland --- drivers/gpu/drm/amd/display/dc/core/dc_link.c | 2 -- 1 file changed, 2 deletions(-) diff --git

[PATCH 04/27] drm/amd/display: Fixed non-native modes not lighting up

2018-01-31 Thread Harry Wentland
From: "Jerry (Fangzhi) Zuo" There is no need to call drm_mode_set_crtcinfo() again once crtc timing is decided. Otherwise non-native/unsupported timing might get overwritten. Signed-off-by: Jerry (Fangzhi) Zuo Reviewed-by: Harry Wentland

[PATCH 08/27] drm/amd/display: dal 3.1.30

2018-01-31 Thread Harry Wentland
From: Tony Cheng Signed-off-by: Tony Cheng Reviewed-by: Tony Cheng Acked-by: Harry Wentland --- drivers/gpu/drm/amd/display/dc/dc.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 01/27] drm/amd/display: Adding missing TMZ sh/mask entries for DCN1 SURFACE_CONTROL

2018-01-31 Thread Harry Wentland
Signed-off-by: Harry Wentland Reviewed-by: Tony Cheng --- drivers/gpu/drm/amd/include/asic_reg/dcn/dcn_1_0_sh_mask.h | 14 ++ 1 file changed, 14 insertions(+) diff --git a/drivers/gpu/drm/amd/include/asic_reg/dcn/dcn_1_0_sh_mask.h

[PATCH 07/27] drm/amd/display: Bypass gamma set if not standard type

2018-01-31 Thread Harry Wentland
From: John Barberiz If non-standard gamma type detected set identity matrix flag so that we can bypass the gamma mode. Signed-off-by: John Barberiz Reviewed-by: Krunoslav Kovac Acked-by: Harry Wentland ---

RE: [PATCH] Revert "drm/amdgpu/gfx8: Fix compute ring failure after resetting"

2018-01-31 Thread Yu, Xiangliang
Ok, thanks! From: Grodzovsky, Andrey Sent: Thursday, February 01, 2018 12:59 AM To: Yu, Xiangliang ; amd-gfx@lists.freedesktop.org; Deng, Emily Cc: Deucher, Alexander ; Koenig, Christian ; Wu,

Re: Deadlocks with multiple applications on AMD RX 460 and RX 550 - Update 2

2018-01-31 Thread Luís Mendes
Hi everyone, I am getting a new issue with amdgpu with RX460, that is, now I can play any videos with Kodi or play web videos with firefox and run OpenGL applications without running into any issues, however after some uptime with XOrg even when almost inactive I get a kmalloc allocation failure,

Re: [PATCH 3/8] drm/amdgpu: make VMID owner none atomic

2018-01-31 Thread Chunming Zhou
On 2018年01月31日 23:47, Christian König wrote: The variable is protected by the VMID mutex anyway. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_ids.c | 10 +- drivers/gpu/drm/amd/amdgpu/amdgpu_ids.h | 2 +- 2 files changed, 6

Re: [PATCH 4/8] drm/amdgpu: stop checking GPU reset counter during VMID grab

2018-01-31 Thread Chunming Zhou
Reviewed-by: Chunming Zhou On 2018年01月31日 23:47, Christian König wrote: We do this later on when we flush the VMID anyway. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_ids.c | 6 +- 1 file changed, 1 insertion(+),

Re: [PATCH 5/8] drm/amdgpu: cleanup and simplify amdgpu_vmid_grab_reserved

2018-01-31 Thread Chunming Zhou
Reviewed-by: Chunming Zhou On 2018年01月31日 23:47, Christian König wrote: Drop the "_locked" from the name, cleanup and simplify the logic a bit. Add missing comments. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_ids.c |

Re: [PATCH 6/8] drm/amdgpu: move reusing VMIDs into separate function

2018-01-31 Thread Chunming Zhou
Reviewed-by: Chunming Zhou On 2018年01月31日 23:47, Christian König wrote: Let's try this once more. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_ids.c | 130 1 file changed, 81

Re: [PATCH 8/8] drm/amdgpu: cache the fence to wait for a VMID

2018-01-31 Thread Chunming Zhou
On 2018年01月31日 23:47, Christian König wrote: Beneficial when a lot of processes are waiting for VMIDs. Yeah, we can save re-creating fence array when vmid is used up. Reviewed-by: Chunming Zhou Signed-off-by: Christian König ---

Re: [PATCH 2/8] drm/amdgpu: split finding idle VMID into separate function

2018-01-31 Thread Chunming Zhou
Reviewed-by: Chunming Zhou On 2018年01月31日 23:47, Christian König wrote: No functional change, but makes it easier to maintain the code. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_ids.c | 116

Re: [PATCH] drm/amdgpu: Fix always_valid bos multiple LRU insertions.

2018-01-31 Thread Alex Deucher
On Wed, Jan 31, 2018 at 7:58 AM, Bas Nieuwenhuizen wrote: > If these bos are evicted and are in the validated list > things blow up, so do not put them in there. Notably, > that tries to add the bo to the LRU twice, which results > in a BUG_ON in ttm_bo.c. > > While for the

Re: Deadlocks with multiple applications on AMD RX 460 and RX 550 - Update 2

2018-01-31 Thread Alex Deucher
On Wed, Jan 31, 2018 at 6:57 PM, Luís Mendes wrote: > Hi everyone, > > I am getting a new issue with amdgpu with RX460, that is, now I can > play any videos with Kodi or play web videos with firefox and run > OpenGL applications without running into any issues, however

[pull] amdgpu, radeon, and ttm drm-next-4.16

2018-01-31 Thread Alex Deucher
Hi Dave, A few more misc fixes for 4.16. The following changes since commit 559f17bec508548850654dd04525fd69d90f6d4e: Merge tag 'drm-misc-next-fixes-2018-01-18' of git://anongit.freedesktop.org/drm/drm-misc into drm-next (2018-01-25 11:42:25 +1000) are available in the git repository at:

Re: [PATCH 06/25] drm/amdgpu: Add KFD eviction fence

2018-01-31 Thread Christian König
Am 31.01.2018 um 00:21 schrieb Felix Kuehling: On 2018-01-30 10:35 AM, Christian König wrote: Am 30.01.2018 um 16:28 schrieb Kasiviswanathan, Harish: [+Harish, forgot to acknowledge him in the commit description, will fix that in v2] Harish, please see Christian's question below in

Re: [PATCH 1/2] [WIP]drm/ttm: add waiter list to prevent allocation not in order

2018-01-31 Thread Christian König
So I think preventing validation on same place is a simpler way: process B bo's place is fpfn~lpfn, it will only try to evict LRU BOs in that range, while eviction, we just prevent those validation to this range(fpfn~lpfn), if out of this range, the allocation/validation still can be go on.

Re: [PATCH 1/2] [WIP]drm/ttm: add waiter list to prevent allocation not in order

2018-01-31 Thread Chunming Zhou
On 2018年01月26日 22:35, Christian König wrote: I just realized that a change I'm thinking about for a while would solve your problem as well, but keep concurrent allocation possible. See ttm_mem_evict_first() unlocks the BO after evicting it:     ttm_bo_del_from_lru(bo);