[BUG] Intermittent hang/deadlock when opening browser tab with Vega gpu

2018-02-02 Thread Daniel Andersson
Hi, I have an intermittent deadlock/hang in the amdgpu driver. It seems to happen when I open a new tab in qutebrowser(v1.1.1), while I am doing other stuff, like watching youtube through mpv or playing dota 2. It seems to be pretty arbitrary how often it happens. Sometimes it is once a week

[PATCH] drm/amd/display: fix incompatible structure layouts

2018-02-02 Thread Arnd Bergmann
Building the amd display driver with link-time optimizations revealed a bug that caused dal_cmd_tbl_helper_dce80_get_table() and dal_cmd_tbl_helper_dce110_get_table() get called with an incompatible return type between the two callers in command_table_helper.c and command_table_helper2.c:

Re: [PATCH] drm/amd/pp: fix mclk fixed in high when no display connected

2018-02-02 Thread Alex Deucher
On Thu, Feb 1, 2018 at 11:52 PM, Rex Zhu wrote: > Change-Id: I2d7663e164ff8eeafe0a4fed99e106b1d130a285 > Signed-off-by: Rex Zhu > --- > drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git

Re: MCLK defaults high on second card

2018-02-02 Thread Tom St Denis
On 02/02/18 12:16 AM, Zhu, Rex wrote: Hi Tom, The attached patch should be able to fix this issue. Best Regards Rex Hi Rex, Yup, works fine with the patch. Cheers, Tom -Original Message- From: StDenis, Tom Sent: Friday, February 02, 2018 2:58 AM To: Deucher, Alexander; amd-gfx

Re: [PATCH] drm/amd/pp: Restore power profile mode in auto dpm level on Vega10

2018-02-02 Thread Deucher, Alexander
Reviewed-by: Alex Deucher From: amd-gfx on behalf of Rex Zhu Sent: Friday, February 2, 2018 4:17 AM To: amd-gfx@lists.freedesktop.org Cc: Zhu, Rex Subject: [PATCH] drm/amd/pp:

[PATCH libdrm] admgpu: add amdgpu_query_sw_info for querying high bits of 32-bit address space

2018-02-02 Thread Marek Olšák
From: Marek Olšák --- amdgpu/amdgpu.h | 21 + amdgpu/amdgpu_device.c | 14 ++ amdgpu/amdgpu_internal.h | 1 + 3 files changed, 36 insertions(+) diff --git a/amdgpu/amdgpu.h b/amdgpu/amdgpu.h index 2eb03bf..928b2a6 100644 ---

Re: [PATCH] drm/amdgpu/display: fix wrong enum type for ddc_result

2018-02-02 Thread Harry Wentland
On 2018-02-01 08:55 PM, db...@chromium.org wrote: > From: Dominik Behr > > v2: now with fixed result comparison and spelling fixes > > Signed-off-by: Dominik Behr > --- > drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c | 2 +- >

Re: [PATCH] drm/amd/display: fix incompatible structure layouts

2018-02-02 Thread Harry Wentland
On 2018-02-02 11:02 AM, Arnd Bergmann wrote: > On Fri, Feb 2, 2018 at 4:39 PM, Harry Wentland wrote: >> On 2018-02-02 07:31 AM, Arnd Bergmann wrote: >>> Building the amd display driver with link-time optimizations revealed a bug >> >> Curious how I'd go about building with

Re: [AMDGPU] module does not link without DEBUG_FS configuration option

2018-02-02 Thread Michel Dänzer
On 2018-02-02 05:29 PM, sylvain.bertr...@gmail.com wrote: > Hi, > > I did not look into details, but on amd-staging-drm-next > (495e9e174feaec6e5aeb6f8224f0d3bda4c96114), linking the amdgpu module fails if > DEBUG_FS is not enabled (probably some weird things happen in the code with > the

[PATCH 2/2] drm/amdgpu: remove unused display_vblank_wait interface

2018-02-02 Thread Alex Deucher
No longer used since we changed the MC programming sequence. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 1 - drivers/gpu/drm/amd/amdgpu/amdgpu_mode.h | 2 - drivers/gpu/drm/amd/amdgpu/dce_v10_0.c| 61

[PATCH 1/2] drm/amdgpu/dce: fix mask in dce_v*_0_is_in_vblank

2018-02-02 Thread Alex Deucher
Using the wrong mask. Noticed-by: Hans de Ruiter Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/dce_v10_0.c | 2 +- drivers/gpu/drm/amd/amdgpu/dce_v11_0.c | 2 +- drivers/gpu/drm/amd/amdgpu/dce_v8_0.c | 2 +- 3 files changed, 3

Re: [PATCH] drm/amd/display: fix incompatible structure layouts

2018-02-02 Thread Harry Wentland
On 2018-02-02 07:31 AM, Arnd Bergmann wrote: > Building the amd display driver with link-time optimizations revealed a bug Curious how I'd go about building with link-time optimizations. > that caused dal_cmd_tbl_helper_dce80_get_table() and > dal_cmd_tbl_helper_dce110_get_table() get called

Re: [BUG] Intermittent hang/deadlock when opening browser tab with Vega gpu

2018-02-02 Thread Alex Deucher
On Fri, Feb 2, 2018 at 6:24 AM, Daniel Andersson wrote: > Hi, > > I have an intermittent deadlock/hang in the amdgpu driver. It seems to > happen when I open a new tab in qutebrowser(v1.1.1), while I am doing other > stuff, like watching youtube through mpv or playing dota 2.

Re: [PATCH] drm/amd/pp: Fix logic error of disable mclk switch on Vega10

2018-02-02 Thread Alex Deucher
On Fri, Feb 2, 2018 at 1:56 AM, Rex Zhu wrote: > Change-Id: I38b60d0be9dc800a3492dd9fb17dc56ade77c0db > Signed-off-by: Rex Zhu > --- > drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c | 11 --- > 1 file changed, 4 insertions(+), 7 deletions(-) > >

Re: [PATCH] drm/amd/display: fix incompatible structure layouts

2018-02-02 Thread Arnd Bergmann
On Fri, Feb 2, 2018 at 4:39 PM, Harry Wentland wrote: > On 2018-02-02 07:31 AM, Arnd Bergmann wrote: >> Building the amd display driver with link-time optimizations revealed a bug > > Curious how I'd go about building with link-time optimizations. I got the idea from last

Re: All games maded with Unity engine in steam catalog crashes on AMD GPU, but worked on Intel GPU on same machine.

2018-02-02 Thread mikhail
On Thu, 2018-02-01 at 21:31 +0100, Marek Olšák wrote: > > Valgrind doesn't show any memory-related issue with Mesa. It does show > an issue with "New Unity Project". This can corrupt the heap and cause > a random crash on the next call of malloc/free/new/delete: > > ==17721== Mismatched free() /

Re: All games maded with Unity engine in steam catalog crashes on AMD GPU, but worked on Intel GPU on same machine.

2018-02-02 Thread Michel Dänzer
On 2018-02-02 05:13 PM, mikhail wrote: > On Thu, 2018-02-01 at 21:31 +0100, Marek Olšák wrote: >> >> Valgrind doesn't show any memory-related issue with Mesa. It does show >> an issue with "New Unity Project". This can corrupt the heap and cause >> a random crash on the next call of

Re: All games maded with Unity engine in steam catalog crashes on AMD GPU, but worked on Intel GPU on same machine.

2018-02-02 Thread Marek Olšák
On Fri, Feb 2, 2018 at 5:13 PM, mikhail wrote: > On Thu, 2018-02-01 at 21:31 +0100, Marek Olšák wrote: >> >> Valgrind doesn't show any memory-related issue with Mesa. It does show >> an issue with "New Unity Project". This can corrupt the heap and cause >> a random

Re: [PATCH 1/2] drm/amdgpu/dce: fix mask in dce_v*_0_is_in_vblank

2018-02-02 Thread Michel Dänzer
On 2018-02-02 06:33 PM, Alex Deucher wrote: > Using the wrong mask. > > Noticed-by: Hans de Ruiter > Signed-off-by: Alex Deucher The series is Reviewed-by: Michel Dänzer Thanks for taking care of this! --

Re: Deadlocks with multiple applications on AMD RX 460 and RX 550 - Update 2

2018-02-02 Thread Luís Mendes
Hi Christian, Alexander, I have enabled kmemleak, but memleak didn't detect anything special, in fact this time, I don't know why, I didn't get any allocation failure at all, but the GPU did hang after around 4h 6m of uptime with Xorg. The log can be found in attachment. I will try again to see

Re: [PATCH libdrm] admgpu: add amdgpu_query_sw_info for querying high bits of 32-bit address space

2018-02-02 Thread Christian König
Reviewed-by: Christian König Am 02.02.2018 um 18:34 schrieb Marek Olšák: From: Marek Olšák --- amdgpu/amdgpu.h | 21 + amdgpu/amdgpu_device.c | 14 ++ amdgpu/amdgpu_internal.h | 1 + 3 files

[PATCH 3/5] drm/radeon: remove extra TT unpopulated check

2018-02-02 Thread Christian König
The subsystem chould check that, not the driver. Signed-off-by: Christian König --- drivers/gpu/drm/radeon/radeon_ttm.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/gpu/drm/radeon/radeon_ttm.c b/drivers/gpu/drm/radeon/radeon_ttm.c index

[PATCH 5/5] drm/amdgpu: replace iova debugfs file with iomem

2018-02-02 Thread Christian König
This allows access to pages allocated through the driver with optional IOMMU mapping. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 57 - 1 file changed, 35 insertions(+), 22 deletions(-) diff --git

Re: [PATCH] drm/amdgpu/display: fix wrong enum type for ddc_result

2018-02-02 Thread Dominik Behr
Aww, you are right. Let me redo it and do the spelling fix separately because I cannot unsee it now. On Fri, Feb 2, 2018 at 7:48 AM, Harry Wentland wrote: > On 2018-02-01 08:55 PM, db...@chromium.org wrote: >> From: Dominik Behr >> >> v2: now with

Re: [PATCH 2/2] drm/amdgpu/display: successful spelling fix

2018-02-02 Thread Harry Wentland
On 2018-02-02 04:37 PM, db...@chromium.org wrote: > From: Dominik Behr > > Replace SUCESSFULL with SUCCESSFUL. > > Signed-off-by: Dominik Behr Series is Reviewed-by: Harry Wentland Will pull it into amd-stg over the weekend or

Re: [PATCH 5/5] drm/amdgpu: replace iova debugfs file with iomem

2018-02-02 Thread StDenis, Tom
I haven't tried the patch but just like to point out this breaks umr :-) I'll have to craft something on Monday to support this and iova in parallel until the iova kernels are realistically EOL'ed. On the other hand I support this idea since it eliminates the need for an fmem hack. So much

[PATCH 4/5] drm/ttm: set page mapping during allocation

2018-02-02 Thread Christian König
To aid debugging set the page mapping during allocation instead of during VM faults. Signed-off-by: Christian König --- drivers/gpu/drm/ttm/ttm_bo_vm.c | 1 - drivers/gpu/drm/ttm/ttm_tt.c| 18 +- 2 files changed, 17 insertions(+), 2 deletions(-)

[PATCH 1/5] drm/ttm: add ttm_tt_populate wrapper

2018-02-02 Thread Christian König
Stop calling the driver callback directly. Signed-off-by: Christian König --- drivers/gpu/drm/ttm/ttm_bo_util.c | 12 +--- drivers/gpu/drm/ttm/ttm_bo_vm.c | 2 +- drivers/gpu/drm/ttm/ttm_tt.c | 10 +- include/drm/ttm/ttm_bo_driver.h | 9

[PATCH 2/5] drm/amdgpu: remove extra TT unpopulated check

2018-02-02 Thread Christian König
The subsystem chould check that, not the driver. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c index

[PATCH 2/2] drm/amdgpu: clear the shadow fence as well

2018-02-02 Thread Christian König
It also needs to be initialized. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c index

[PATCH 1/2] drm/amdgpu: release the VM shadow in the error path as well

2018-02-02 Thread Christian König
Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c index 61cf93867b8e..b43098f02a40 100644 ---

Re: [PATCH 3/9] drm/amdkfd: Make IOMMUv2 code conditional

2018-02-02 Thread Felix Kuehling
The attached patch is my attempt to keep most of the IOMMU code in one place (new kfd_iommu.c) to avoid #ifdefs all over the place. This way I can still conditionally compile a bunch of KFD code that is only needed for IOMMU handling, with stub functions for kernel configs without IOMMU support.

Re: [PATCH libdrm 3/4] amdgpu: use the high VA range if possible v2

2018-02-02 Thread Marek Olšák
Hi Christian, How does this work with 48-bit addresses that the 3D engine uses? It can't set 0x8000 for the high bits. It's trimmed to 0x8000. Thanks, Marek On Sun, Jan 7, 2018 at 10:11 AM, Christian König wrote: > Retire the low range on Vega10 this frees

Re: [PATCH] drm/amdgpu/display: fix wrong enum type for ddc_result

2018-02-02 Thread Michel Dänzer
Adding the amd-gfx list, please always send amdgpu patches there. On 2018-02-02 02:55 AM, db...@chromium.org wrote: > From: Dominik Behr > > v2: now with fixed result comparison and spelling fixes > > Signed-off-by: Dominik Behr > --- >

[PATCH] drm/amd/pp: Restore power profile mode in auto dpm level on Vega10

2018-02-02 Thread Rex Zhu
As auto power profile mode still not support on vega10, so just restore default profile mode in auto dpm level. Change-Id: I36359c1d11a48308bc9482f7aafe4c98767ac715 Signed-off-by: Rex Zhu --- drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c | 10 +++---