Re: [PATCH 1/2] drm/amd: remove inclusion of non-existing scheduler directory

Am 22.02.2018 um 09:21 schrieb Corentin Labbe: The scheduler directory was removed via commit 1b1f42d8fde4 ("drm: move amd_gpu_scheduler into common location") Remove it from include path. Signed-off-by: Corentin Labbe Reviewed-by: Christian König --- drivers/gpu/drm/amd/amdgpu/Makefile

Re: [PATCH 2/2] drm/amd: Remove inclusion of non-existing include directories

Am 22.02.2018 um 09:21 schrieb Corentin Labbe: This patch fix the following build warnings: CC [M] drivers/gpu/drm/amd/amdgpu/amdgpu_drv.o cc1: warning: ../display/: No such file or directory [-Wmissing-include-dirs] cc1: warning: ../display/include: No such file or directory [-Wmissing-incl

[PATCH] drm/amdgpu: use the TTM dummy page instead of allocating one

We have a global dummy page in TTM, use that one instead of allocating a new one. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 10 +- drivers/gpu/drm/amd/amdgpu/amdgpu_gart.c | 29 + drivers/gpu/drm/amd/amdgpu/cik_ih.c |

Re: AMD E8860 on PowerPC with u-boot (T2080)

On Wed, Feb 21, 2018 at 6:22 PM, Alex Deucher wrote: > On Wed, Feb 21, 2018 at 7:43 AM, Christian König > wrote: > >> The failed VCE resume (-22) seems to be caused by > >> > >> if (rdev->vce.vcpu_bo == NULL) > >> return -EINVAL; > >> > >> in radeon_vce.c line 226. > > >

Re: [PATCH] drm/amdgpu: use the TTM dummy page instead of allocating one

On 2018-02-22 09:29 AM, Christian König wrote: > We have a global dummy page in TTM, use that one instead of allocating a > new one. > > Signed-off-by: Christian König Reviewed-by: Michel Dänzer -- Earthling Michel Dänzer | http://www.amd.com Libre software enthus

Re: AMD E8860 on PowerPC with u-boot (T2080)

Am 22.02.2018 um 09:37 schrieb Bas Vermeulen: On Wed, Feb 21, 2018 at 6:22 PM, Alex Deucher > wrote: On Wed, Feb 21, 2018 at 7:43 AM, Christian König [SNIP] > Apart from that I don't have any good idea any more why that shouldn't work. Does your

Re: [PATCH] fix double ;;s in code

Hi Pavel, On Sat, Feb 17, 2018 at 10:19:55PM +0100, Pavel Machek wrote: ... > diff --git a/drivers/soc/imx/gpc.c b/drivers/soc/imx/gpc.c > index 53f7275..cfb42f5 100644 > --- a/drivers/soc/imx/gpc.c > +++ b/drivers/soc/imx/gpc.c > @@ -348,7 +348,7 @@ static int imx_gpc_old_dt_init(struct device *d

[PATCH 1/3] drm/amd/pp: Remove duplicated vega10_is_smc_ram_running calls

Avoid conflicts in reading the same register mmPCIE_INDEX2 with other clients Change-Id: Iff93db1d47b732ef993ff1a37ad3778c44253da0 Signed-off-by: Rex Zhu --- drivers/gpu/drm/amd/powerplay/smumgr/vega10_smumgr.c | 15 +++ 1 file changed, 3 insertions(+), 12 deletions(-) diff --git a/

[PATCH 3/3] drm/amd/pp: Remove dead error checking code on Vega10

when smu failed, print out the error info in smumgr immediately for debug. smum_send_msg_to_smu always return true, so delete error check code under hwmgr. Change-Id: I905073374826ef139d0264bedd590f53b6fd3c17 Signed-off-by: Rex Zhu --- drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c | 113 +++

[PATCH 2/3] drm/amd/pp: Add debug info when smu failed on Vega10

When smu msssage failed, print out return value in dmesg. Change-Id: Ia8a0d4486ff39d6c2a0f5420e1e5ff4f7ae9cada Signed-off-by: Rex Zhu --- drivers/gpu/drm/amd/powerplay/smumgr/vega10_smumgr.c | 18 +- 1 file changed, 13 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/a

[PATCH 1/2] drm/amdgpu: Change default value of module parameter amdgpu_pp_feature_mask

Currently all pp features are enabled by default except OVERDRIVE Change-Id: I0c0400db966fb8f2a1278c467fd6d0ccef947407 Signed-off-by: Rex Zhu --- drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c b

[PATCH 2/2] drm/amd/pp: Add a pp feature mask bit for AutoWattman feature

Change-Id: I6a919f7512b89894f230d45f1ddb6b0b1d971ef8 Signed-off-by: Rex Zhu --- drivers/gpu/drm/amd/powerplay/inc/hwmgr.h | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/amd/powerplay/inc/hwmgr.h b/drivers/gpu/drm/amd/powerplay/inc/hwmgr.h index 2a59ee8..77d7f49 100644 --- a/

[PATCH 1/2] drm/amd/pp: Refine code in powerplay for Cz/Vega10

Move dpm check functions on CZ/Vega10 to smu backend function table. Change-Id: I084f586ced5dbbcded54176a06b857c75303e553 Signed-off-by: Rex Zhu --- drivers/gpu/drm/amd/powerplay/hwmgr/cz_hwmgr.c | 27 ++ drivers/gpu/drm/amd/powerplay/hwmgr/cz_hwmgr.h | 1 - drivers/

[PATCH 2/2] drm/amd/pp: Move common dpm check functions to hardwaremanager.c

Change-Id: I90dbff04585d835a68a2bd1b80426b211609e81c Signed-off-by: Rex Zhu --- drivers/gpu/drm/amd/powerplay/hwmgr/cz_hwmgr.c| 9 - drivers/gpu/drm/amd/powerplay/hwmgr/hardwaremanager.c | 10 ++ drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c | 10 -- drive

[PATCH 1/2] drm/amd: remove inclusion of non-existing scheduler directory

The scheduler directory was removed via commit 1b1f42d8fde4 ("drm: move amd_gpu_scheduler into common location") Remove it from include path. Signed-off-by: Corentin Labbe --- drivers/gpu/drm/amd/amdgpu/Makefile | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/Makef

[PATCH 2/2] drm/amd: Remove inclusion of non-existing include directories

This patch fix the following build warnings: CC [M] drivers/gpu/drm/amd/amdgpu/amdgpu_drv.o cc1: warning: ../display/: No such file or directory [-Wmissing-include-dirs] cc1: warning: ../display/include: No such file or directory [-Wmissing-include-dirs] CC [M] drivers/gpu/drm/amd/amdgpu/amd

Re: [PATCH] drm/amdgpu: use the TTM dummy page instead of allocating one

On Thu, Feb 22, 2018 at 3:29 AM, Christian König wrote: > We have a global dummy page in TTM, use that one instead of allocating a > new one. > > Signed-off-by: Christian König > --- > drivers/gpu/drm/amd/amdgpu/amdgpu.h | 10 +- > drivers/gpu/drm/amd/amdgpu/amdgpu_gart.c | 29 +

Re: [PATCH 3/3] drm/amd/pp: Remove dead error checking code on Vega10

On Thu, Feb 22, 2018 at 4:31 AM, Rex Zhu wrote: > when smu failed, print out the error info in smumgr immediately > for debug. smum_send_msg_to_smu always return true, so delete > error check code under hwmgr. > > Change-Id: I905073374826ef139d0264bedd590f53b6fd3c17 > Signed-off-by: Rex Zhu Seri

Re: [PATCH 2/2] drm/amd/pp: Add a pp feature mask bit for AutoWattman feature

On Thu, Feb 22, 2018 at 5:26 AM, Rex Zhu wrote: > Change-Id: I6a919f7512b89894f230d45f1ddb6b0b1d971ef8 > Signed-off-by: Rex Zhu Series is: Reviewed-by: Alex Deucher > --- > drivers/gpu/drm/amd/powerplay/inc/hwmgr.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/amd/p

Re: [PATCH 1/2] drm/amd/pp: Refine code in powerplay for Cz/Vega10

On Thu, Feb 22, 2018 at 7:48 AM, Rex Zhu wrote: > Move dpm check functions on CZ/Vega10 to smu backend > function table. > > Change-Id: I084f586ced5dbbcded54176a06b857c75303e553 > Signed-off-by: Rex Zhu > --- > drivers/gpu/drm/amd/powerplay/hwmgr/cz_hwmgr.c | 27 > ++ >

Re: [PATCH] drm/radeon: insist on 32-bit DMA for Cedar

Alex, Christian, et al. Thanks for your rapid response! I can certainly make the change PPC-only (#ifdef CONFIG_PPC64...) and I think that's the safest way to go right now. It makes the patch very specific to Cedar on PowerPC64, so it doesn't break anything that may have come to depend on Russel

Re: [PATCH] drm/radeon: insist on 32-bit DMA for Cedar

On Thu, Feb 22, 2018 at 10:55 AM, Ben Crocker wrote: > Alex, Christian, et al. > > Thanks for your rapid response! > > I can certainly make the change PPC-only (#ifdef CONFIG_PPC64...) and I > think > that's the safest way to go right now. It makes the patch very specific to > Cedar > on PowerPC6

[PATCH xf86-video-ati] Disable all unused CRTCs before setting desired modes

From: Michel Dänzer This might avoid modeset failures in some cases where a CRTC which isn't used by Xorg was enabled before. (Ported from amdgpu commit e3aae7a24296f640c0153d1459f3e0820485468a) Signed-off-by: Michel Dänzer --- src/drmmode_display.c | 33 + 1 f

Re: [PATCH] drm/radeon: insist on 32-bit DMA for Cedar

I considered that, but I'm only equipped to test on a few cards--the ones IBM is interested in. So this Cedar-specific change fixes the problem on the FirePro 2270; the other cards seem perfectly capable of handling 40+ bit DMA addresses on the Power8 platform. On Thu, Feb 22, 2018 at 11:07 AM, A

Re: [PATCH xf86-video-ati] Disable all unused CRTCs before setting desired modes

On Thu, Feb 22, 2018 at 11:42 AM, Michel Dänzer wrote: > From: Michel Dänzer > > This might avoid modeset failures in some cases where a CRTC which isn't > used by Xorg was enabled before. > > (Ported from amdgpu commit e3aae7a24296f640c0153d1459f3e0820485468a) > > Signed-off-by: Michel Dänzer

Re: [PATCH] drm/radeon: insist on 32-bit DMA for Cedar

On Thu, Feb 22, 2018 at 11:45 AM, Ben Crocker wrote: > I considered that, but I'm only equipped to test on a few cards--the ones > IBM is interested in. > So this Cedar-specific change fixes the problem on the FirePro 2270; the > other cards seem > perfectly capable of handling 40+ bit DMA address

[PATCH] drm/radeon: insist on 32-bit DMA for Cedar on PPC64/PPC64LE

In radeon_device_init, set the need_dma32 flag for Cedar chips (e.g. FirePro 2270). This fixes, or at least works around, a bug on PowerPC exposed by last year's commits 8e3f1b1d8255105f31556aacf8aeb6071b00d469 (Russell Currey) and 253fd51e2f533552ae35a0c661705da6c4842c1b (Alistair Popple) whi

Re: [PATCH] drm/radeon: insist on 32-bit DMA for Cedar on PPC64/PPC64LE

On Thu, Feb 22, 2018 at 4:51 PM, Ben Crocker wrote: > In radeon_device_init, set the need_dma32 flag for Cedar chips > (e.g. FirePro 2270). This fixes, or at least works around, a bug > on PowerPC exposed by last year's commits > > 8e3f1b1d8255105f31556aacf8aeb6071b00d469 (Russell Currey) > > and

[PATCH] drm/radeon: insist on 32-bit DMA for Cedar on PPC64/PPC64LE

In radeon_device_init, set the need_dma32 flag for Cedar chips (e.g. FirePro 2270). This fixes, or at least works around, a bug on PowerPC exposed by last year's commits 8e3f1b1d8255105f31556aacf8aeb6071b00d469 (Russell Currey) and 253fd51e2f533552ae35a0c661705da6c4842c1b (Alistair Popple) whi

Re: [PATCH] drm/amdgpu: Remove duplicate setting of ->need_swiotlb

On Tue, Feb 20, 2018 at 5:44 AM, Thierry Reding wrote: > From: Thierry Reding > > There's no need to set this before the number of DMA bits has been > properly determined. > > Signed-off-by: Thierry Reding Applied. thanks! Alex > --- > drivers/gpu/drm/amd/amdgpu/gmc_v8_0.c | 1 - > 1 file c

Re: [PATCH] drm/radeon: insist on 32-bit DMA for Cedar on PPC64/PPC64LE

On 2018-02-22 10:57 PM, Ben Crocker wrote: > In radeon_device_init, set the need_dma32 flag for Cedar chips > (e.g. FirePro 2270). This fixes, or at least works around, a bug > on PowerPC exposed by last year's commits > > 8e3f1b1d8255105f31556aacf8aeb6071b00d469 (Russell Currey) > > and > > 25

Re: [PATCH] drm/radeon: insist on 32-bit DMA for Cedar on PPC64/PPC64LE

One of my colleagues did discover a "Radeon HG 5450 PCI" from February 2010 which did, apparently, have a Cedar GPU and very definitely had a (plain old) PCI connector. But I take your point, and will just drop the PCI/PCIE check. On Thu, Feb 22, 2018 at 12:04 PM, Michel Dänzer wrote: > On 201

[PATCH] drm/radeon: insist on 32-bit DMA for Cedar on PPC64/PPC64LE

In radeon_device_init, set the need_dma32 flag for Cedar chips (e.g. FirePro 2270). This fixes, or at least works around, a bug on PowerPC exposed by last year's commits 8e3f1b1d8255105f31556aacf8aeb6071b00d469 (Russell Currey) and 253fd51e2f533552ae35a0c661705da6c4842c1b (Alistair Popple) whi

[PATCH xf86-video-amdgpu 3/3] modesetting: Update property values at detect and uevent time

From: Keith Packard We were updating the link-status property when a uevent came in, but we also want to update the non-desktop property, and potentially others as well. We also want to check at detect time in case we don't get a hotplug event. This patch updates every property provided by the k

[PATCH xf86-video-amdgpu 1/3] modesetting: Use helper to fetch drmModeProperty(Blob)s

From: Daniel Martin Replace the various loops to lookup drmModeProperty(Blob)s by introducing helper functions. Signed-off-by: Daniel Martin (Ported from xserver commit f44935cdb7321af242ce9f242975f096807b97f7) Signed-off-by: Michel Dänzer --- src/drmmode_display.c | 128 +++

[PATCH xf86-video-amdgpu 2/3] modesetting: Reset output_id if drmModeGetConnector failed

From: Daniel Martin If drmModeGetConnector() fails in drmmode_output_detect(), we have to reset the output_id to -1 too. Yet another spot leading to a potential NULL dereference when handling the mode_output member as output_id was != -1. Though, this case should be very hard to hit. Signed-off

Re: [PATCH] drm/radeon: insist on 32-bit DMA for Cedar on PPC64/PPC64LE

On 2018-02-22 06:37 PM, Ben Crocker wrote: > One of my colleagues did discover a "Radeon HG 5450 PCI" from February > 2010 which did, apparently, have a Cedar GPU and very definitely had a > (plain old) PCI connector. There must be a PCIe-to-PCI bridge on that board. The GPU itself is always PCIe,

[PATCH] drm/amd/powerplay: fix thermal interrupts on vega10

a bug in programming thermal interrupt register masks out interrupts and driver cannot receive interrupts. Setting 0 to mask bits will fix it. Signed-off-by: Eric Huang --- drivers/gpu/drm/amd/powerplay/hwmgr/vega10_thermal.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a

Re: [PATCH] drm/amd/powerplay: fix thermal interrupts on vega10

Acked-by: Alex Deucher From: amd-gfx on behalf of Eric Huang Sent: Thursday, February 22, 2018 1:21 PM To: amd-gfx@lists.freedesktop.org Cc: Huang, JinHuiEric Subject: [PATCH] drm/amd/powerplay: fix thermal interrupts on vega10 a bug in programming thermal int

Re: [PATCH] drm/radeon: insist on 32-bit DMA for Cedar on PPC64/PPC64LE

Alex asked what other GPUs I've tested on, and the answer is: E6465 (Caicos GPU). -- Ben On Thu, Feb 22, 2018 at 1:33 PM, Ben Crocker wrote: > I think that last version I sent a few minutes ago is final form, now. > Thanks for all your help! > > If there's anything you could do to expedite pos

Re: [PATCH] drm/radeon: insist on 32-bit DMA for Cedar on PPC64/PPC64LE

That's what IBM is most interested in at this juncture: FirePro 2270 Embedded Radeon E6465 The E6465 already worked without this patch. On Thu, Feb 22, 2018 at 6:39 PM, Ben Crocker wrote: > Alex asked what other GPUs I've tested on, and the answer is: E6465 > (Caicos GPU). > > -- Ben > > > On

Re: [PATCH] drm/radeon: insist on 32-bit DMA for Cedar on PPC64/PPC64LE

On Thu, Feb 22, 2018 at 5:52 PM, Ben Crocker wrote: > In radeon_device_init, set the need_dma32 flag for Cedar chips > (e.g. FirePro 2270). This fixes, or at least works around, a bug > on PowerPC exposed by last year's commits > > 8e3f1b1d8255105f31556aacf8aeb6071b00d469 (Russell Currey) > > and

[PATCH] drm/amd/pp: Cleaning up vega10_enable_dpm_tasks function

move out functions that unrelated to enable dpm task. Change-Id: I93416e0eea82325040557a64af2b82a38d8c32ce Signed-off-by: Rex Zhu --- drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c | 14 +- drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.h | 1 - 2 files changed, 5 insertions(+

[PATCH 0/1] radeon and amdgpu drm-fixes-4.16

Hi Dave, A few fixes for 4.16: - Powerplay fixes for cards with no displays attached - Couple of DC fixes - radeon workaround for PPC64 The following changes since commit bfad2d08e540b18cfd92694fbb388e7d202df31f: Merge branch 'linux-4.16' of git://github.com/skeggsb/linux into drm-fixes (2018

[pull] radeon and amdgpu drm-fixes-4.16

Hi Dave, A few fixes for 4.16: - Powerplay fixes for cards with no displays attached - Couple of DC fixes - radeon workaround for PPC64 The following changes since commit bfad2d08e540b18cfd92694fbb388e7d202df31f: Merge branch 'linux-4.16' of git://github.com/skeggsb/linux into drm-fixes (2018

Re: [PATCH] drm/amd/pp: Cleaning up vega10_enable_dpm_tasks function

On Thu, Feb 22, 2018 at 11:21 PM, Rex Zhu wrote: > move out functions that unrelated to enable dpm task. > > Change-Id: I93416e0eea82325040557a64af2b82a38d8c32ce > Signed-off-by: Rex Zhu > --- > drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c | 14 +- > drivers/gpu/drm/amd/powerpl

Re: [PATCH xf86-video-amdgpu 3/3] modesetting: Update property values at detect and uevent time

On Thu, Feb 22, 2018 at 12:52 PM, Michel Dänzer wrote: > From: Keith Packard > > We were updating the link-status property when a uevent came in, but > we also want to update the non-desktop property, and potentially > others as well. We also want to check at detect time in case we don't > get a

[PATCH] drm/amd/pp: Cleaning up vega10_enable_dpm_tasks function

1. move display num initialize out of dpm enable tasks. 2. do not set/restore smc telemetry if dpm is runing. Change-Id: I63431b169bb077fa60cca02f0db7038af1ba1601 Signed-off-by: Rex Zhu --- drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c | 11 +-- 1 file changed, 5 insertions(+), 6 de

Re: [PATCH] drm/amd/pp: Cleaning up vega10_enable_dpm_tasks function

>I don't think backend_init actually touches the hw anywhere else. >Seems like it might be better to move this to setup_asic_task for >consistency. Thanks Alex, you are right. the change for telemetry will cause telemetry setting not restore after s3/s4 resume back. Best Regards Rex

Re: [PATCH] drm/amd/pp: Cleaning up vega10_enable_dpm_tasks function

On Fri, Feb 23, 2018 at 12:22 AM, Rex Zhu wrote: > 1. move display num initialize out of dpm enable tasks. > 2. do not set/restore smc telemetry if dpm is runing. > > Change-Id: I63431b169bb077fa60cca02f0db7038af1ba1601 > Signed-off-by: Rex Zhu Reviewed-by: Alex Deucher > --- > drivers/gpu/dr

Re: [PATCH] drm/radeon: insist on 32-bit DMA for Cedar on PPC64/PPC64LE

Am 22.02.2018 um 18:56 schrieb Michel Dänzer: On 2018-02-22 06:37 PM, Ben Crocker wrote: One of my colleagues did discover a "Radeon HG 5450 PCI" from February 2010 which did, apparently, have a Cedar GPU and very definitely had a (plain old) PCI connector. There must be a PCIe-to-PCI bridge on