Re: [PATCH xf86-video-amdgpu 02/19] Guard ODEV_ATTRIB_FD usage with the correct ifdef

2018-04-10 Thread Emil Velikov
On 10 April 2018 at 09:27, Michel Dänzer wrote: > On 2018-04-04 04:29 PM, Emil Velikov wrote: >> From: Emil Velikov >> >> Signed-off-by: Emil Velikov >> --- >> src/amdgpu_probe.c | 2 +- >> 1 file changed, 1

Re: [PATCH xf86-video-amdgpu 11/19] Don't leak a AMDGPUEntRec instance if amdgpu_device_setup fails

2018-04-10 Thread Emil Velikov
On 10 April 2018 at 10:58, Michel Dänzer wrote: > On 2018-04-10 11:47 AM, Emil Velikov wrote: >> On 10 April 2018 at 09:28, Michel Dänzer wrote: >>> On 2018-04-04 04:29 PM, Emil Velikov wrote: From: Emil Velikov

Re: [PATCH xf86-video-amdgpu 17/19] Store device_name as AMDGPUEntRec::master_node

2018-04-10 Thread Michel Dänzer
On 2018-04-10 11:51 AM, Emil Velikov wrote: > On 10 April 2018 at 09:29, Michel Dänzer wrote: >> On 2018-04-04 04:29 PM, Emil Velikov wrote: >>> From: Emil Velikov >>> >>> Rename the variable to reflect what it is. Plus move it out of the dri2 >>>

Re: [PATCH 1/2] drm/amdgpu/gmc: steal the appropriate amount of vram for fw hand-over (v2)

2018-04-10 Thread Huang Rui
On Mon, Apr 09, 2018 at 09:50:19PM +0800, Christian König wrote: > Hi Andrey, > > I think the problem Ray wants to point to is that we now release the > stolen memory after device initialization. > > So during S3 we might run into issues because the first 8MB of VRAM are > corrupted after

[PATCH] drm/amdgpu: defer initing UVD & VCE IP blocks

2018-04-10 Thread Shirish S
UVD & VCE blocks take up around 1200 msecs of boot time. This patch adds them to the late init work function so as to reduce boot time. Signed-off-by: Shirish S --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 28 ++-- 1 file changed, 22 insertions(+),

Re: [PATCH 3/3] drm/amdgpu: remove AMDGPU_GEM_CREATE_NO_FALLBACK handling from CS again

2018-04-10 Thread zhoucm1
On 2018年04月10日 17:00, Christian König wrote: Am 10.04.2018 um 04:43 schrieb zhoucm1: On 2018年04月09日 18:19, Christian König wrote: That should purely be handled by preferred/allowed domains. Although this flag isn't exported to user space yet, I'm curious that how preferred/allowed domains

Re: [PATCH xf86-video-amdgpu 04/19] Remove drmCheckModesettingSupported and kernel module loading

2018-04-10 Thread Michel Dänzer
On 2018-04-10 11:20 AM, Emil Velikov wrote: > On 10 April 2018 at 09:26, Michel Dänzer wrote: >> On 2018-04-04 04:29 PM, Emil Velikov wrote: >>> From: Emil Velikov >>> >>> The former of these is a UMS artefact which gives incorrect and >>>

Re: [PATCH xf86-video-amdgpu 17/19] Store device_name as AMDGPUEntRec::master_node

2018-04-10 Thread Emil Velikov
On 10 April 2018 at 09:29, Michel Dänzer wrote: > On 2018-04-04 04:29 PM, Emil Velikov wrote: >> From: Emil Velikov >> >> Rename the variable to reflect what it is. Plus move it out of the dri2 >> section - it's used in dri2 and dri3. >> >>

Re: [PATCH xf86-video-amdgpu 11/19] Don't leak a AMDGPUEntRec instance if amdgpu_device_setup fails

2018-04-10 Thread Michel Dänzer
On 2018-04-10 11:47 AM, Emil Velikov wrote: > On 10 April 2018 at 09:28, Michel Dänzer wrote: >> On 2018-04-04 04:29 PM, Emil Velikov wrote: >>> From: Emil Velikov >>> >>> Seems like we've been leaking this for years. It became more obvious >>>

[PATCH] drm/amdgpu: defer initing UVD & VCE IP blocks

2018-04-10 Thread Shirish S
UVD & VCE blocks take up around 1200 msecs of boot time. This patch adds them to the late init work function so as to reduce boot time. Signed-off-by: Shirish S --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 28 ++-- 1 file changed, 22 insertions(+),

Recall: [PATCH] drm/amdgpu: defer initing UVD & VCE IP blocks

2018-04-10 Thread S, Shirish
S, Shirish would like to recall the message, "[PATCH] drm/amdgpu: defer initing UVD & VCE IP blocks". ___ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Re: [PATCH xf86-video-amdgpu 19/19] TODO

2018-04-10 Thread Emil Velikov
On 10 April 2018 at 09:30, Michel Dänzer wrote: > On 2018-04-04 04:29 PM, Emil Velikov wrote: >> From: Emil Velikov >> >> Signed-off-by: Emil Velikov >> --- >> todo | 9 + >> 1 file changed, 9 insertions(+) >>

Re: [PATCH xf86-video-amdgpu 04/19] Remove drmCheckModesettingSupported and kernel module loading

2018-04-10 Thread Emil Velikov
On 10 April 2018 at 09:26, Michel Dänzer wrote: > On 2018-04-04 04:29 PM, Emil Velikov wrote: >> From: Emil Velikov >> >> The former of these is a UMS artefact which gives incorrect and >> misleading promise whether "KMS" is supported. Not to

Re: [PATCH xf86-video-amdgpu 02/19] Guard ODEV_ATTRIB_FD usage with the correct ifdef

2018-04-10 Thread Michel Dänzer
On 2018-04-10 11:24 AM, Emil Velikov wrote: > On 10 April 2018 at 09:27, Michel Dänzer wrote: >> On 2018-04-04 04:29 PM, Emil Velikov wrote: >>> From: Emil Velikov >>> >>> Signed-off-by: Emil Velikov >>> --- >>>

Re: [PATCH 3/3] drm/amdgpu: remove AMDGPU_GEM_CREATE_NO_FALLBACK handling from CS again

2018-04-10 Thread Christian König
Am 10.04.2018 um 04:43 schrieb zhoucm1: On 2018年04月09日 18:19, Christian König wrote: That should purely be handled by preferred/allowed domains. Although this flag isn't exported to user space yet, I'm curious that how preferred/allowed domains handle no_fallback? IIRC, currently, our

Re: [PATCH xf86-video-amdgpu 11/19] Don't leak a AMDGPUEntRec instance if amdgpu_device_setup fails

2018-04-10 Thread Emil Velikov
On 10 April 2018 at 09:28, Michel Dänzer wrote: > On 2018-04-04 04:29 PM, Emil Velikov wrote: >> From: Emil Velikov >> >> Seems like we've been leaking this for years. It became more obvious >> with the recent refactoring. >> >> Signed-off-by: Emil

[PATCH umr] Fix VMID of chained IBs

2018-04-10 Thread Tom St Denis
We were using the VMID field literally when inside an IB it's inherited instead Signed-off-by: Tom St Denis --- src/lib/dump_ib.c | 8 src/lib/ring_decode.c | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/lib/dump_ib.c

Re: [PATCH 1/2] drm/amdgpu/gmc: steal the appropriate amount of vram for fw hand-over (v2)

2018-04-10 Thread Andrey Grodzovsky
So with my and Alex's patches you still observe corruption ? What if you remove my patch and keep Alex's patch ? Andrey On 04/10/2018 06:53 AM, Huang Rui wrote: On Mon, Apr 09, 2018 at 11:17:58AM -0400, Andrey Grodzovsky wrote: OK, tested with DC disabled , no issues on resume (no visible

Re: RFC for a render API to support adaptive sync and VRR

2018-04-10 Thread Harry Wentland
Adding Anthony and Aric who've been working on Freesync with DC on other OSes for a while. On 2018-04-09 05:45 PM, Manasi Navare wrote: > Thanks for initiating the discussion. Find my comments below: > > On Mon, Apr 09, 2018 at 04:00:21PM -0400, Harry Wentland wrote: >> Adding dri-devel, which

Re: [PATCH umr] Fix VMID of chained IBs

2018-04-10 Thread Christian König
Am 10.04.2018 um 17:23 schrieb Tom St Denis: We were using the VMID field literally when inside an IB it's inherited instead Signed-off-by: Tom St Denis Acked-by: Christian König --- src/lib/dump_ib.c | 8

Re: RFC for a render API to support adaptive sync and VRR

2018-04-10 Thread Christian König
Am 10.04.2018 um 17:08 schrieb Harry Wentland: On 2018-04-10 03:37 AM, Michel Dänzer wrote: On 2018-04-10 08:45 AM, Christian König wrote: Am 09.04.2018 um 23:45 schrieb Manasi Navare: Thanks for initiating the discussion. Find my comments below: On Mon, Apr 09, 2018 at 04:00:21PM -0400,

[PATCH 1/3] drm/amdgpu: revert "add new bo flag that indicates BOs don't need fallback (v2)"

2018-04-10 Thread Christian König
This reverts commit 6f51d28bfe8e1a676de5cd877639245bed3cc818. Makes fallback handling to complicated. This is just a feature for the GEM interface and shouldn't leak into the core BO create function. Signed-off-by: Christian König ---

[PATCH 3/3] drm/amdgpu: set preferred_domain independent of fallback handling

2018-04-10 Thread Christian König
When GEM needs to fallback to GTT for VRAM BOs we still want the preferred domain to be untouched so that the BO has a cance to move back to VRAM in the future. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c| 14 +++---

Re: RFC for a render API to support adaptive sync and VRR

2018-04-10 Thread Harry Wentland
On 2018-04-10 03:37 AM, Michel Dänzer wrote: > On 2018-04-10 08:45 AM, Christian König wrote: >> Am 09.04.2018 um 23:45 schrieb Manasi Navare: >>> Thanks for initiating the discussion. Find my comments below: >>> On Mon, Apr 09, 2018 at 04:00:21PM -0400, Harry Wentland wrote: On 2018-04-09

[PATCH 2/3] drm/amdgpu: revert "Don't change preferred domian when fallback GTT v6"

2018-04-10 Thread Christian König
This reverts commit 7d1ca1325260a9e9329b10a21e3692e6f188936f. Makes fallback handling to complicated. This is just a feature for the GEM interface and shouldn't leak into the core BO create function. The intended change to preserve the preferred domains is implemented in a follow up patch.

[PATCH] drm/amdgpu/gfx9: cache DB_DEBUG2 and make it available to userspace

2018-04-10 Thread Alex Deucher
Userspace needs to query this value to work around a hw bug in certain cases. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 2 ++ drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 1 + drivers/gpu/drm/amd/amdgpu/soc15.c| 3 +++ 3 files changed, 6

Re: RFC for a render API to support adaptive sync and VRR

2018-04-10 Thread Harry Wentland
On 2018-04-10 07:44 AM, Chris Wilson wrote: > Quoting Christian König (2018-04-10 07:45:04) >> Am 09.04.2018 um 23:45 schrieb Manasi Navare: >>> Properties that you mentioned above that the UMD can set before kernel can >>> enable VRR functionality >>> *bool vrr_enable or vrr_compatible >>>

RE: RFC for a render API to support adaptive sync and VRR

2018-04-10 Thread Cyr, Aric
From: Koenig, Christian Sent: Tuesday, April 10, 2018 11:43 Am 10.04.2018 um 17:35 schrieb Cyr, Aric: -Original Message- From: Wentland, Harry Sent: Tuesday, April 10, 2018 11:08 To: Michel Dänzer ; Koenig, Christian

Re: RFC for a render API to support adaptive sync and VRR

2018-04-10 Thread Harry Wentland
On 2018-04-10 12:37 PM, Nicolai Hähnle wrote: > On 10.04.2018 18:26, Cyr, Aric wrote: >> That presentation time doesn’t need to come to kernel as such and actually >> is fine as-is completely decoupled from adaptive sync.  As long as the video >> player provides the new target_frame_duration_ns

Re: RFC for a render API to support adaptive sync and VRR

2018-04-10 Thread Christian König
Am 10.04.2018 um 17:35 schrieb Cyr, Aric: -Original Message- From: Wentland, Harry Sent: Tuesday, April 10, 2018 11:08 To: Michel Dänzer ; Koenig, Christian ; Manasi Navare Cc: Haehnle, Nicolai

Re: [PATCH] drm/amdgpu/gfx9: cache DB_DEBUG2 and make it available to userspace

2018-04-10 Thread Nicolai Hähnle
Thanks! Acked-by: Nicolai Hähnle On 10.04.2018 17:18, Alex Deucher wrote: Userspace needs to query this value to work around a hw bug in certain cases. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 2 ++

Re: RFC for a render API to support adaptive sync and VRR

2018-04-10 Thread Nicolai Hähnle
On 10.04.2018 18:26, Cyr, Aric wrote: That presentation time doesn’t need to come to kernel as such and actually is fine as-is completely decoupled from adaptive sync.  As long as the video player provides the new target_frame_duration_ns on the flip, then the driver/HW will target the correct

[PATCH umr] Add 'disasm_early_term' option.

2018-04-10 Thread Tom St Denis
For UMDs that don't use the 0xBF9F shader terminator marker this option allows the disassembler to stop once it hits the first s_endpgm opcode. Signed-off-by: Tom St Denis --- doc/sphinx/source/basic.rst | 69 +++-- doc/umr.1

Re: [PATCH xf86-video-amdgpu 2/5] Hook up CRTC color management functions

2018-04-10 Thread Leo Li
On 2018-04-09 11:03 AM, Michel Dänzer wrote: On 2018-03-26 10:00 PM, sunpeng...@amd.com wrote: From: "Leo (Sunpeng) Li" The functions insert into the output resource creation, and property change functions. CRTC destroy is also hooked-up for proper cleanup of the CRTC

Re: [PATCH xf86-video-amdgpu 1/5] Add functions for changing CRTC color management properties

2018-04-10 Thread Leo Li
On 2018-04-09 11:03 AM, Michel Dänzer wrote: On 2018-03-26 10:00 PM, sunpeng...@amd.com wrote: From: "Leo (Sunpeng) Li" This change adds a few functions in preparation of enabling CRTC color managment via the randr interface. The driver-private CRTC object now contains

Re: [PATCH xf86-video-amdgpu 3/5] Keep CRTC properties consistent

2018-04-10 Thread Leo Li
On 2018-04-09 11:03 AM, Michel Dänzer wrote: On 2018-03-26 10:00 PM, sunpeng...@amd.com wrote: From: "Leo (Sunpeng) Li" In cases where CRTC properties are updated without going through RRChangeOutputProperty, we don't update the properties in user land. Consider setting

Re: [PATCH xf86-video-amdgpu 0/5] Implementing non-legacy color management

2018-04-10 Thread Leo Li
On 2018-04-09 10:10 AM, Michel Dänzer wrote: Hi Leo, apologies for the late follow-up; I was on vacation and then backlogged. No worries, thanks for the review :) On 2018-03-26 10:00 PM, sunpeng...@amd.com wrote: From: "Leo (Sunpeng) Li" These patches will

RE: RFC for a render API to support adaptive sync and VRR

2018-04-10 Thread Cyr, Aric
> -Original Message- > From: Wentland, Harry > Sent: Tuesday, April 10, 2018 11:08 > To: Michel Dänzer ; Koenig, Christian > ; Manasi Navare > > Cc: Haehnle, Nicolai ; Daniel Vetter >

Re: [PATCH 1/2] drm/amdgpu/gmc: steal the appropriate amount of vram for fw hand-over (v2)

2018-04-10 Thread Andrey Grodzovsky
Indeed :( After 2 tries i see the problem, if I remove "drm/amdgpu: Free VGA stolen memory as soon as possible." problem goes away. Andrey On 04/10/2018 06:53 AM, Huang Rui wrote: On Mon, Apr 09, 2018 at 11:17:58AM -0400, Andrey Grodzovsky wrote: OK, tested with DC disabled , no issues on

Re: RFC for a render API to support adaptive sync and VRR

2018-04-10 Thread Michel Dänzer
On 2018-04-10 06:26 PM, Cyr, Aric wrote: > From: Koenig, Christian Sent: Tuesday, April 10, 2018 11:43 > >> For video games we have a similar situation where a frame is rendered >> for a certain world time and in the ideal case we would actually >> display the frame at this world time. > > That

Re: RFC for a render API to support adaptive sync and VRR

2018-04-10 Thread Michel Dänzer
On 2018-04-10 05:35 PM, Cyr, Aric wrote: >> On 2018-04-10 03:37 AM, Michel Dänzer wrote: >>> On 2018-04-10 08:45 AM, Christian König wrote: Am 09.04.2018 um 23:45 schrieb Manasi Navare: > Thanks for initiating the discussion. Find my comments > below: On Mon, Apr 09, 2018 at

RE: RFC for a render API to support adaptive sync and VRR

2018-04-10 Thread Cyr, Aric
> -Original Message- > From: Michel Dänzer [mailto:mic...@daenzer.net] > Sent: Tuesday, April 10, 2018 13:06 > On 2018-04-10 06:26 PM, Cyr, Aric wrote: > > From: Koenig, Christian Sent: Tuesday, April 10, 2018 11:43 > > > >> For video games we have a similar situation where a frame is

Re: RFC for a render API to support adaptive sync and VRR

2018-04-10 Thread Nicolai Hähnle
On 10.04.2018 19:25, Cyr, Aric wrote: -Original Message- From: Michel Dänzer [mailto:mic...@daenzer.net] Sent: Tuesday, April 10, 2018 13:16 On 2018-04-10 07:13 PM, Cyr, Aric wrote: -Original Message- From: Michel Dänzer [mailto:mic...@daenzer.net] Sent: Tuesday, April 10, 2018

Re: RFC for a render API to support adaptive sync and VRR

2018-04-10 Thread Harry Wentland
On 2018-04-10 01:52 PM, Harry Wentland wrote: > On 2018-04-10 12:37 PM, Nicolai Hähnle wrote: >> On 10.04.2018 18:26, Cyr, Aric wrote: >>> That presentation time doesn’t need to come to kernel as such and actually >>> is fine as-is completely decoupled from adaptive sync.  As long as the >>>

Re: [PATCH 2/2] drm/amd/pp: remove unnecessary forward declaration

2018-04-10 Thread Alex Deucher
On Tue, Apr 10, 2018 at 1:18 AM, Rex Zhu wrote: > Signed-off-by: Rex Zhu Series is: Reviewed-by: Alex Deucher > --- > drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c | 84 > +++--- > 1 file changed, 41

Re: [PATCH] drm/amdkfd: Remove vla

2018-04-10 Thread Felix Kuehling
Thanks Christian for catching that. I'm working on a patch series to upstream Vega10 support, about 95% done. It will add this ASIC info for Vega10: static const struct kfd_device_info vega10_device_info = { .asic_family = CHIP_VEGA10, .max_pasid_bits = 16, .max_no_of_hqd

Re: [PATCH] drm/amdkfd: Remove vla

2018-04-10 Thread Laura Abbott
On 04/09/2018 11:38 PM, Christian König wrote: Am 09.04.2018 um 23:06 schrieb Laura Abbott: There's an ongoing effort to remove VLAs[1] from the kernel to eventually turn on -Wvla. The single VLA usage in the amdkfd driver is actually constant across all current platforms. Actually that isn't

Re: [PATCH] drm/amdgpu: limit DMA size to PAGE_SIZE for scatter-gather buffers

2018-04-10 Thread Christian König
Am 10.04.2018 um 20:25 schrieb Sinan Kaya: Code is expecing to observe the same number of buffers returned from dma_map_sg() function compared to sg_alloc_table_from_pages(). This doesn't hold true universally especially for systems with IOMMU. IOMMU driver tries to combine buffers into a

[PATCH] drm/amdgpu: limit DMA size to PAGE_SIZE for scatter-gather buffers

2018-04-10 Thread Sinan Kaya
Code is expecing to observe the same number of buffers returned from dma_map_sg() function compared to sg_alloc_table_from_pages(). This doesn't hold true universally especially for systems with IOMMU. IOMMU driver tries to combine buffers into a single DMA address as much as it can. The right

Re: RFC for a render API to support adaptive sync and VRR

2018-04-10 Thread Michel Dänzer
On 2018-04-10 07:13 PM, Cyr, Aric wrote: >> -Original Message- >> From: Michel Dänzer [mailto:mic...@daenzer.net] >> Sent: Tuesday, April 10, 2018 13:06 >> On 2018-04-10 06:26 PM, Cyr, Aric wrote: >>> From: Koenig, Christian Sent: Tuesday, April 10, 2018 11:43 >>> For video games we

RE: RFC for a render API to support adaptive sync and VRR

2018-04-10 Thread Cyr, Aric
> -Original Message- > From: Michel Dänzer [mailto:mic...@daenzer.net] > Sent: Tuesday, April 10, 2018 13:16 > > On 2018-04-10 07:13 PM, Cyr, Aric wrote: > >> -Original Message- > >> From: Michel Dänzer [mailto:mic...@daenzer.net] > >> Sent: Tuesday, April 10, 2018 13:06 > >> On

Re: [PATCH] drm/amd/display: Fix 64-bit division in hwss_edp_power_control

2018-04-10 Thread Alex Deucher
On Tue, Apr 10, 2018 at 4:10 PM, Harry Wentland wrote: > Signed-off-by: Harry Wentland Reviewed-by: Alex Deucher > --- > drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c | 2 +- > 1 file changed, 1

Re: [PATCH] drm/amd/display: Don't spam debug messages

2018-04-10 Thread Harry Wentland
Ping On 2018-04-09 02:06 PM, Harry Wentland wrote: > Signed-off-by: Harry Wentland > --- > drivers/gpu/drm/amd/display/include/logger_types.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/amd/display/include/logger_types.h >

[PATCH 07/21] drm/amd/display: fix segfault on insufficient TG during validation

2018-04-10 Thread Harry Wentland
From: Dmytro Laktyushkin Signed-off-by: Dmytro Laktyushkin Reviewed-by: Dmytro Laktyushkin Acked-by: Harry Wentland --- drivers/gpu/drm/amd/display/dc/core/dc_resource.c | 2 +- 1 file

[PATCH 11/21] drm/amd/display: Check lid state to determine fast boot optimization.

2018-04-10 Thread Harry Wentland
From: Yongqiang Sun For legacy enable boot up with lid closed, eDP information couldn't be read correctly via SBIOS_SCRATCH_3 results in eDP cannot be light up properly when open lid. Check lid state instead can resolve the issue. Signed-off-by: Yongqiang Sun

[PATCH 03/21] drm/amd/display: Move dp_pixel_encoding_type to stream_encoder include

2018-04-10 Thread Harry Wentland
From: Eric Bernstein Signed-off-by: Eric Bernstein Reviewed-by: Nikola Cornij Acked-by: Harry Wentland --- drivers/gpu/drm/amd/display/dc/inc/hw/hw_shared.h | 17 -

[PATCH 18/21] drm/amd/display: add rq/dlg/ttu to dtn log

2018-04-10 Thread Harry Wentland
From: Dmytro Laktyushkin Signed-off-by: Dmytro Laktyushkin Reviewed-by: Dmytro Laktyushkin Acked-by: Harry Wentland --- drivers/gpu/drm/amd/display/dc/dc_helper.c | 59

[PATCH 13/21] drm/amd/display: Move DCC support functions into dchubbub

2018-04-10 Thread Harry Wentland
From: Eric Bernstein Added dchububu.h header file for common enum/struct definitions. Added new interface functions get_dcc_compression_cap, dcc_support_swizzle, dcc_support_pixel_format. Signed-off-by: Eric Bernstein Reviewed-by: Dmytro

[PATCH 02/21] drm/amd/display: fix brightness level after resume from suspend

2018-04-10 Thread Harry Wentland
From: Roman Li Adding missing call to cache current backlight values. Otherwise the brightness resets to default value on resume. Signed-off-by: Roman Li Reviewed-by: Charlene Liu Acked-by: Harry Wentland ---

[PATCH 17/21] drm/amd/display: Check SCRATCH reg to determine S3 resume.

2018-04-10 Thread Harry Wentland
From: Yongqiang Sun Use lid state only to determine fast boot optimization is not enough. For S3/Resume, due to bios isn't involved in boot, eDP wasn't light up, while lid state is open, if do fast boot optimization, eDP panel will skip enable link and result in black

[PATCH 06/21] drm/amd/display: Fix bug where refresh rate becomes fixed

2018-04-10 Thread Harry Wentland
From: Anthony Koo This issue occurs if refresh rate range is very small and lfc is not used. When frame spikes occur, refresh rate becomes fixed and will not restore properly Signed-off-by: Anthony Koo Reviewed-by: Aric Cyr

[PATCH 15/21] drm/amd/display: HDMI has no sound after Panel power off/on

2018-04-10 Thread Harry Wentland
From: Charlene Liu Signed-off-by: Charlene Liu Reviewed-by: Krunoslav Kovac Acked-by: Harry Wentland Cc: sta...@vger.kernel.org --- drivers/gpu/drm/amd/display/dc/dce/dce_stream_encoder.c | 2 ++ 1

[PATCH 19/21] drm/amd/display: add calculated clock logging to DTN

2018-04-10 Thread Harry Wentland
From: Dmytro Laktyushkin Signed-off-by: Dmytro Laktyushkin Reviewed-by: Dmytro Laktyushkin Acked-by: Harry Wentland --- drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c | 11

[PATCH 00/21] DC Patches Apr 10, 2018

2018-04-10 Thread Harry Wentland
* Fix audio enablement on HDMI after panel power off/on * Fix brightness after resume Anthony Koo (7): drm/amd/display: add method to check for supported range drm/amd/display: Fix bug where refresh rate becomes fixed drm/amd/display: Fix bug that causes black screen drm/amd/display:

[PATCH 04/21] drm/amd/display: Fix regamma not affecting full-intensity color values

2018-04-10 Thread Harry Wentland
From: "Leo (Sunpeng) Li" Hardware understands the regamma LUT as a piecewise linear function, with points spaced exponentially along the range. We previously programmed the LUT for range [2^-10, 2^0). This causes (normalized) color values of 1 (=2^0) to miss the programmed

[PATCH 21/21] drm/amd/display: Use dig enable to determine fast boot optimization.

2018-04-10 Thread Harry Wentland
From: Yongqiang Sun Linux doesn't know lid state, better to check dig enable value from register. Signed-off-by: Yongqiang Sun Reviewed-by: Tony Cheng Acked-by: Harry Wentland ---

[PATCH 20/21] drm/amd/display: add missing colorspace for set black color

2018-04-10 Thread Harry Wentland
From: Yue Hin Lau Signed-off-by: Yue Hin Lau Reviewed-by: Tony Cheng Acked-by: Harry Wentland --- .../gpu/drm/amd/display/dc/core/dc_hw_sequencer.c | 21 - 1 file changed, 20

[PATCH 05/21] drm/amd/display: add method to check for supported range

2018-04-10 Thread Harry Wentland
From: Anthony Koo Signed-off-by: Anthony Koo Reviewed-by: Aric Cyr Acked-by: Harry Wentland --- .../drm/amd/display/modules/freesync/freesync.c| 64 --

[PATCH 09/21] drm/amd/display: change dml init to use default structs

2018-04-10 Thread Harry Wentland
From: Dmytro Laktyushkin Signed-off-by: Dmytro Laktyushkin Reviewed-by: Eric Bernstein Acked-by: Harry Wentland --- .../gpu/drm/amd/display/dc/dml/display_mode_lib.c | 138

[PATCH 16/21] drm/amd/display: refactor vupdate interrupt registration

2018-04-10 Thread Harry Wentland
From: Anthony Koo We only need to register once OS calls the interrupt control. Also, if we are entering static screen mode, disable after ramping is done. Disable shall be done via timer of 2 seconds regardless of ramping complete or not, just to simplify. Also, ramp to

[PATCH 01/21] drm/amd/display: dal 3.1.42

2018-04-10 Thread Harry Wentland
From: Eric Yang Signed-off-by: Eric Yang Reviewed-by: Anthony Koo Acked-by: Harry Wentland --- drivers/gpu/drm/amd/display/dc/dc.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 14/21] drm/amd/display: fix LFC tearing at top of screen

2018-04-10 Thread Harry Wentland
From: Anthony Koo Tearing occurred because new VTOTAL MIN/MAX was being programmed too early. The flip can happen within the VUPDATE high region, and the new min/max would take effect immediately. But this means that frame is not variable anymore, and tearing would occur

[PATCH 10/21] drm/amd/display: Add back code to allow for rounding error

2018-04-10 Thread Harry Wentland
From: Anthony Koo Signed-off-by: Anthony Koo Reviewed-by: Aric Cyr Acked-by: Harry Wentland --- drivers/gpu/drm/amd/display/modules/freesync/freesync.c | 13 - 1 file changed, 12 insertions(+), 1

[PATCH 12/21] drm/amd/display: Do not create memory allocation if stats not enabled

2018-04-10 Thread Harry Wentland
From: Anthony Koo Signed-off-by: Anthony Koo Reviewed-by: Aric Cyr Acked-by: Harry Wentland --- drivers/gpu/drm/amd/display/modules/stats/stats.c | 26 +-- 1 file changed, 15

[PATCH] drm/amdkfd: fix clock counter retrieval for node without GPU

2018-04-10 Thread Felix Kuehling
From: Andres Rodriguez Currently if a user requests clock counters for a node without a GPU resource we will always return EINVAL. Instead if no GPU resource is attached, fill the gpu_clock_counter argument with zeroes so that we may proceed and return valid CPU

[PATCH] drm/amd/display: Fix 64-bit division in hwss_edp_power_control

2018-04-10 Thread Harry Wentland
Signed-off-by: Harry Wentland --- drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c

RE: RFC for a render API to support adaptive sync and VRR

2018-04-10 Thread Cyr, Aric
> From: Haehnle, Nicolai > Sent: Tuesday, April 10, 2018 13:48 > On 10.04.2018 19:25, Cyr, Aric wrote: > >> -Original Message- > >> From: Michel Dänzer [mailto:mic...@daenzer.net] > >> Sent: Tuesday, April 10, 2018 13:16 > >> > >> On 2018-04-10 07:13 PM, Cyr, Aric wrote: >

Re: [PATCH] drm/amd/display: Don't spam debug messages

2018-04-10 Thread Leo Li
On 2018-04-10 04:44 PM, Harry Wentland wrote: Ping On 2018-04-09 02:06 PM, Harry Wentland wrote: Signed-off-by: Harry Wentland Reviewed-by: Leo (Sunpeng) Li --- drivers/gpu/drm/amd/display/include/logger_types.h | 2 +- 1 file changed, 1

[PATCH 19/21] drm/amdkfd: Add GFXv9 CWSR trap handler

2018-04-10 Thread Felix Kuehling
Signed-off-by: Shaoyun Liu Signed-off-by: Jay Cornwall Signed-off-by: Felix Kuehling --- .../gpu/drm/amd/amdkfd/cwsr_trap_handler_gfx9.asm | 1495 drivers/gpu/drm/amd/amdkfd/kfd_device.c| 13

[PATCH 15/21] drm/amdkfd: Fix kernel queue rollback_packet

2018-04-10 Thread Felix Kuehling
kq->queue->properties.write_ptr is a GPU address which can'd be derefenced in the kernel. Use kq->wptr_kernel instead, which is the kernel CPU address of the same buffer. Signed-off-by: Felix Kuehling --- drivers/gpu/drm/amd/amdkfd/kfd_kernel_queue.c | 2 +- 1 file

[PATCH 16/21] drm/amdkfd: Add 64-bit doorbell and wptr support to kernel queue

2018-04-10 Thread Felix Kuehling
Signed-off-by: Felix Kuehling --- drivers/gpu/drm/amd/amdkfd/kfd_doorbell.c | 10 + drivers/gpu/drm/amd/amdkfd/kfd_kernel_queue.c | 25 +-- drivers/gpu/drm/amd/amdkfd/kfd_kernel_queue.h | 7 ++-

[PATCH 12/21] drm/amdkfd: Add GFXv9 device queue manager

2018-04-10 Thread Felix Kuehling
Signed-off-by: John Bridgman Signed-off-by: Felix Kuehling --- drivers/gpu/drm/amd/amdkfd/Makefile| 2 +- .../gpu/drm/amd/amdkfd/kfd_device_queue_manager.c | 10 ++- .../gpu/drm/amd/amdkfd/kfd_device_queue_manager.h | 2 +

[PATCH 10/21] drm/amdkfd: Add GFXv9 PM4 packet writer functions

2018-04-10 Thread Felix Kuehling
Signed-off-by: Shaoyun Liu Signed-off-by: Felix Kuehling --- drivers/gpu/drm/amd/amdkfd/Makefile | 7 +- drivers/gpu/drm/amd/amdkfd/kfd_kernel_queue_v9.c | 331 + drivers/gpu/drm/amd/amdkfd/kfd_kernel_queue_vi.c | 18 +-

[PATCH 20/21] drm/amdkfd: Try to enable atomics for all GPUs

2018-04-10 Thread Felix Kuehling
From: welu Report failure to enable atomics only on GPUs that require them. This allows GPUs that don't require atomics to function, but can benefit if they are available. This is the case for Vega10, which doesn't use atomics for basic functioning of the MEC, AQL and HWS

[PATCH 11/21] drm/amdkfd: Add GFXv9 MQD manager

2018-04-10 Thread Felix Kuehling
Signed-off-by: John Bridgman Signed-off-by: Jay Cornwall Signed-off-by: Felix Kuehling --- drivers/gpu/drm/amd/amdkfd/Makefile | 1 + drivers/gpu/drm/amd/amdkfd/kfd_device.c | 2 +-

[PATCH 08/21] drm/amdkfd: Implement doorbell allocation for SOC15

2018-04-10 Thread Felix Kuehling
Allocate doorbells according to the doorbell routing information on SOC15 ASICs (Vega10 and later). On older ASICs we continue to use the queue_id as the doorbell ID to maintain compatibility with the Thunk. Signed-off-by: Shaoyun Liu Signed-off-by: Felix Kuehling

[PATCH 17/21] drm/amdkfd: Remove limit on number of GPUs (follow-up)

2018-04-10 Thread Felix Kuehling
This condition was missed in a previous commit with the same title. Signed-off-by: Felix Kuehling --- drivers/gpu/drm/amd/amdkfd/kfd_flat_memory.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_flat_memory.c

[PATCH 21/21] drm/amdkfd: Add Vega10 topology and device info

2018-04-10 Thread Felix Kuehling
* Report 64-bit doorbells as HSA_CAP_DOORBELL_TYPE_2_0 in topology * Report cache information in topology (duplicates GFXv8 info for now) * Add device info for Vega10 support in KFD Raven is not enabled at this time as it needs additional changes in DQM to work with a single SDMA engine.

Re: RFC for a render API to support adaptive sync and VRR

2018-04-10 Thread Manasi Navare
On Tue, Apr 10, 2018 at 11:03:02AM -0400, Harry Wentland wrote: > Adding Anthony and Aric who've been working on Freesync with DC on other OSes > for a while. > > On 2018-04-09 05:45 PM, Manasi Navare wrote: > > Thanks for initiating the discussion. Find my comments below: > > > > On Mon, Apr

Re: [PATCH 00/21] GFXv9/Vega10 support for KFD

2018-04-10 Thread Oded Gabbay
Hi Felix, Just to let you know that I am currently on vacation and will be back home only on 4/21 so all patch reviews from my side will be done after that date. Thanks, Oded On Tue, 10 Apr 2018, 17:33 Felix Kuehling wrote: > This patch series adds support for GFXv9

[PATCH 08/21] drm/amd/display: Fix bug that causes black screen

2018-04-10 Thread Harry Wentland
From: Anthony Koo Ignore MSA bit on DP display is usually set during SetTimings, but there was a case where the module thought refresh rate was not valid and ignore MSA bit was not set. Later, a valid refresh rate range was requested but since ignore MSA bit not set, it

[PATCH 18/21] drm/amdkfd: Support flat memory apertures for GFXv9

2018-04-10 Thread Felix Kuehling
Signed-off-by: Felix Kuehling --- drivers/gpu/drm/amd/amdkfd/kfd_flat_memory.c | 115 --- 1 file changed, 87 insertions(+), 28 deletions(-) diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_flat_memory.c b/drivers/gpu/drm/amd/amdkfd/kfd_flat_memory.c

[PATCH 09/21] drm/amdkfd: Move packet writer functions into ASIC-specific file

2018-04-10 Thread Felix Kuehling
This is in preparation for GFXv9 (Vega10) which uses incompatible PM4 packet formats from previous ASIC generations. Signed-off-by: Shaoyun Liu Signed-off-by: Felix Kuehling --- .../gpu/drm/amd/amdkfd/kfd_device_queue_manager.c | 10 +-

[PATCH 13/21] drm/amdkfd: Add SOC15 interrupt processing support

2018-04-10 Thread Felix Kuehling
Signed-off-by: Shaoyun Liu Signed-off-by: Oak Zeng Signed-off-by: Felix Kuehling --- drivers/gpu/drm/amd/amdkfd/Makefile | 2 +- drivers/gpu/drm/amd/amdkfd/kfd_int_process_v9.c | 84 +

[PATCH 14/21] drm/amdkfd: Fix goto usage

2018-04-10 Thread Felix Kuehling
Missed a spot in previous cleanup commit: Remove gotos that do not feature any common cleanup, and use gotos instead of repeating cleanup commands. According to kernel.org: "The goto statement comes in handy when a function exits from multiple locations and some common work such as cleanup has to

[PATCH 07/21] drm/amdkfd: Clean up KFD_MMAP_ offset handling

2018-04-10 Thread Felix Kuehling
From: Harish Kasiviswanathan Use bit-rotate for better clarity and remove _MASK from the #defines as these represent mmap types. Centralize all the parsing of the mmap offset in kfd_mmap and add device parameter to doorbell and reserved_mem map functions. Encode

[PATCH 04/21] drm/amdgpu: Add GFXv9 kfd2kgd interface functions

2018-04-10 Thread Felix Kuehling
Signed-off-by: John Bridgman Signed-off-by: Shaoyun Liu Signed-off-by: Jay Cornwall Signed-off-by: Yong Zhao Signed-off-by: Felix Kuehling --- MAINTAINERS

[PATCH 03/21] drm/amdgpu: Add GFXv9 TLB invalidation packet definition

2018-04-10 Thread Felix Kuehling
Signed-off-by: Shaoyun Liu Signed-off-by: Jay Cornwall Signed-off-by: Felix Kuehling --- drivers/gpu/drm/amd/amdgpu/soc15d.h | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/soc15d.h

[PATCH 00/21] GFXv9/Vega10 support for KFD

2018-04-10 Thread Felix Kuehling
This patch series adds support for GFXv9 GPUs to KFD. In this series it enables support for Vega10. Raven support requires some extra work that will follow shortly, but Raven support is already included and I didn't go out of my way to keep it out. Felix Kuehling (19): drm/amdgpu: Remove unused

[PATCH 01/21] drm/amdgpu: Remove unused interface from kfd2kgd interface

2018-04-10 Thread Felix Kuehling
Signed-off-by: Felix Kuehling --- drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gfx_v7.c | 10 -- drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gfx_v8.c | 10 -- drivers/gpu/drm/amd/include/kgd_kfd_interface.h | 5 - 3 files changed, 25 deletions(-) diff

  1   2   >