Re: [PATCHv3] drm/amdkfd: Remove vla

On Fri, Apr 13, 2018 at 2:24 PM, Laura Abbott wrote: > > There's an ongoing effort to remove VLAs[1] from the kernel to eventually > turn on -Wvla. Switch to a constant value that covers all hardware. > > [1] https://lkml.org/lkml/2018/3/7/621 > > Reviewed-by: Felix Kuehling

[PATCH] drm/amd/display: clean up assignment of amdgpu_crtc

From: Colin Ian King The declaration of pointer amdgpu_crtc has a redundant assignment to amdgpu_crtc. Clean this up by removing it. Detected by CoverityScan, CID#1460299 ("Evaluation order violation") Signed-off-by: Colin Ian King ---

Re: [PATCH] drm/amd/display: remove need of modeset flag for overlay planes

On 5/2/2018 7:21 PM, Harry Wentland wrote: On 2018-04-27 06:27 AM, Shirish S wrote: This patch is in continuation to the "843e3c7 drm/amd/display: defer modeset check in dm_update_planes_state" where we started to eliminate the dependency on DRM_MODE_ATOMIC_ALLOW_MODESET to be set by the user

Re: Ryzen 1600X with mem_encrypt=on

Am 26.04.2018 um 08:45 schrieb Sami Farin: On Wed, Apr 25, 2018 at 16:59:43 -0400, Alex Deucher wrote: On Wed, Apr 25, 2018 at 1:13 PM, Sami Farin wrote: Is it supposed to work? Now if I use that option, monitor powers off (no signal) when it's initializing amdgpu

Re: [PATCH] drm/amd/display: remove need of modeset flag for overlay planes

On 2018-05-03 04:00 AM, S, Shirish wrote: > > > On 5/2/2018 7:21 PM, Harry Wentland wrote: >> On 2018-04-27 06:27 AM, Shirish S wrote: >>> This patch is in continuation to the >>> "843e3c7 drm/amd/display: defer modeset check in dm_update_planes_state" >>> where we started to eliminate the

[PATCH xf86-video-amdgpu 05/13] Enable setting of color properties though RandR

From: "Leo (Sunpeng) Li" Setting a color property involves: 1. Staging the property onto the driver-private CRTC object 2. Pushing the staged property into kernel DRM, for HW programming 3. Update all RandR outputs using this CRTC to list the new property Add a function to

[PATCH xf86-video-amdgpu 06/13] Compose non-legacy with legacy gamma LUT before pushing to kernel DRM

From: "Leo (Sunpeng) Li" Frequently, a user may have non-legacy gamma enabled for monitor correction, while using legacy gamma for things like redshift/nightlight. To do so, we compose the two LUTs. Legacy gamma will be applied first, then non-legacy. i.e.

[PATCH xf86-video-amdgpu 00/13] Enabling Color Management - Round 2

From: "Leo (Sunpeng) Li" This patchset ended up looking quite different from the first. To address some fundamental issues, the design had to be reworked. Things gathered from previous review: 1. User client should not have to handle DRM blob objects. That should be the

[PATCH xf86-video-amdgpu 07/13] Also compose LUT when setting legacy gamma.

From: "Leo (Sunpeng) Li" We compose the two LUTs when pushing non-legacy gamma changes, and the same needs to be done when setting legacy gamma. If a non-legacy LUT has not been set (i.e. using the default value), the legacy LUT will act independantly. However, instead of

[PATCH xf86-video-amdgpu 04/13] Use CRTC's color properties if output has a CRTC attached

From: "Leo (Sunpeng) Li" Previously, all outputs will have disabled color properties initialized. However, an output with a CRTC attached should use the properties on the attached CRTC. To do so, an color properties "update" function is added. It takes staged properties

[PATCH xf86-video-amdgpu 01/13] Add color management properties to driver-private CRTC object

From: "Leo (Sunpeng) Li" Non-legacy color management consists of 3 properties on the CRTC: Degamma LUT, Color Transformation Matrix (CTM), and Gamma LUT. Add these properties to the driver-private CRTC, and initialize them when the CRTC is initialized. These values are

[PATCH xf86-video-amdgpu 02/13] Push color properties to kernel DRM on CRTC init

From: "Leo (Sunpeng) Li" Push staged values on the driver-private CRTC, to kernel DRM when it's initialized. This is to flush out any previous state that hardware was in, and set them to their default values. Signed-off-by: Leo (Sunpeng) Li ---

[PATCH xf86-video-amdgpu 03/13] List disabled color properties on RandR outputs without a CRTC

From: "Leo (Sunpeng) Li" The properties on an RandR output needs to stay consistent throughout it's lifecycle. However, we cannot list color properties on an output if there is no CRTC attached. Therefore, create a fake CRTC, and initialize "disabled" color properites on

[PATCH xf86-video-amdgpu 13/13] Refactor pushing color management properties into a function

From: "Leo (Sunpeng) Li" Pushing all color properties to kernel DRM is done in a few places. Reduce repetition by refactoring into a function. Signed-off-by: Leo (Sunpeng) Li --- src/drmmode_display.c | 41 - 1

[PATCH xf86-video-amdgpu 12/13] Update color properties on modeset major

From: "Leo (Sunpeng) Li" This is needed for cases such as enabling a CRTC on an output that did not previously have a CRTC attached. Doing so will update the output properties listed with the correct color properties. Signed-off-by: Leo (Sunpeng) Li ---

[PATCH xf86-video-amdgpu 10/13] Push staged color properties when DPMS state toggles On

From: "Leo (Sunpeng) Li" This will persist color management properties on a CRTC across DPMS state changes. Signed-off-by: Leo (Sunpeng) Li --- src/drmmode_display.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/drmmode_display.c

[PATCH xf86-video-amdgpu 09/13] Move drmmode_do_crtc_dpms

From: "Leo (Sunpeng) Li" To avoid forward declarations in upcomming changes Signed-off-by: Leo (Sunpeng) Li --- src/drmmode_display.c | 118 +- 1 file changed, 59 insertions(+), 59 deletions(-) diff --git

[PATCH xf86-video-amdgpu 08/13] Set driver-private CRTC's dpms mode on disable

From: "Leo (Sunpeng) Li" The dpms_mode flag on the driver-private CRTC was not being set when it's DPMS state is set to off. This causes some problems when toggling it back on, as some conditionals check this flag. Signed-off-by: Leo (Sunpeng) Li ---

[PATCH xf86-video-amdgpu 11/13] Push staged color properties on output detect

From: "Leo (Sunpeng) Li" This will persist color management properties on a CRTC across hot-plugs. Signed-off-by: Leo (Sunpeng) Li --- src/drmmode_display.c | 8 1 file changed, 8 insertions(+) diff --git a/src/drmmode_display.c

[PATCH] drm/amdgpu: Don't default to DC support for Kaveri and older

We've had a number of users report failures to detect and light up display with DC with LVDS and VGA. These connector types are not currently supported with DC. I'd like to add support but unfortunately don't have a system with LVDS or VGA available. In order not to cause regressions we should

Re: [PATCH] drm/scheduler: don't update last scheduled fence in TDR

That change is indeed fixing a problem. When drm_sched_job_recovery() is called s_job->entity should already be NULL. And even when the process is killed we should still either re-submit the jobs or set the error. BTW: There is another bug in that function: guilty_context needs to be kept

Re: [PATCH] drm/amd/amdgpu: Add some documentation to the debugfs entries

On Wed, May 02, 2018 at 01:53:50PM -0400, Tom St Denis wrote: > Signed-off-by: Tom St Denis Reviewed-by: Huang Rui > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c | 193 > +++- > 1 file changed, 189 insertions(+), 4

Re: [PATCH] drm/amdgpu/sriov: reject kms open if TDR not finished or failed

Am 27.04.2018 um 10:22 schrieb Michel Dänzer: On 2018-04-27 10:15 AM, Deng, Emily wrote: No, I mean during GPU reset, the app will fail, it is reasonable. I understand, but I don't agree that it's reasonable. :) I agree with Michel here that this is a really bad idea. Even while the GPU is

Re: [PATCH 2/2] drm/amdgpu: link shadow bo as well

Am 24.04.2018 um 09:35 schrieb Chunming Zhou: Shadow BO is located on GTT and its parent (PT and PD) BO could located on VRAM. In some case, the BO on GTT could be evicted but the parent did not. This may cause the shadow BO not be put in the evict list and could not be invalidate correctly.

Re: [PATCH 1/2] drm/amdgpu: abstract bo_base init function

Am 26.04.2018 um 05:01 schrieb Zhang, Jerry (Junwei): On 04/24/2018 03:35 PM, Chunming Zhou wrote: Change-Id: Ia3e57dbacff05f32b6c02e29aeadabd36f08028e Signed-off-by: Chunming Zhou Reviewed-by: Junwei Zhang some trivial comments. Both a nice

Re: [PATCH] drm/amdgpu: For sriov reset, move IB test into exclusive mode

At least of hand sounds like it makes sense. But one comment below. Am 26.04.2018 um 04:06 schrieb Deng, Emily: Ping... -Original Message- From: Emily Deng [mailto:emily.d...@amd.com] Sent: Wednesday, April 25, 2018 11:26 AM To: amd-gfx@lists.freedesktop.org Cc: Deng, Emily