Re: [RFC] drm/amd/display: add SI support to AMD DC

2018-10-15 Thread Harry Wentland
On 2018-10-14 5:47 p.m., Mauro Rossi wrote: > Hi, > > reporting about some progress made during the weekend, > thanks to Sylvain feedback & suggestions. > > I have rebased and updated the series on top of > https://cgit.freedesktop.org/~agd5f/linux/?h=amd-staging-drm-next > > Here is the

Re: [RFC] drm/amd/display: add SI support to AMD DC

2018-10-15 Thread Harry Wentland
On 2018-10-15 5:06 p.m., Harry Wentland wrote: > On 2018-10-14 5:47 p.m., Mauro Rossi wrote: >> Hi, >> >> reporting about some progress made during the weekend, >> thanks to Sylvain feedback & suggestions. >> >> I have rebased and updated the series on top of >>

[PATCH 2/3] drm/amd/powerplay: added I2C controller configuration

2018-10-15 Thread Evan Quan
PPTABLE structure is stretched to add I2C controller configuration. Hold on the PPTABLE_V20_SMU_VERSION bump until the VBIOS is ready. Change-Id: I079154b36e4bddba9fa40ce3abc6517ad9e9b5f1 Signed-off-by: Evan Quan --- drivers/gpu/drm/amd/include/atomfirmware.h| 88 ++

[PATCH 3/3] drm/amd/powerplay: update PPtable with DC BTC and Tvr SocLimit fields

2018-10-15 Thread Evan Quan
Update the PPtable structure to fit the latest SMC firmware. Change-Id: I97db5955085efa1ecf44ae23d26fdcc70ec2fc9a Signed-off-by: Evan Quan --- .../amd/powerplay/hwmgr/vega20_processpptables.c| 10 ++ drivers/gpu/drm/amd/powerplay/inc/smu11_driver_if.h | 13 - 2 files

[PATCH 1/3] drm/amdgpu: update Vega20 SDMA golden setting

2018-10-15 Thread Evan Quan
Update SDMA golden settings. Change-Id: Icffa86e1a2c057466e1280fb195070c769d51eab Signed-off-by: Evan Quan --- drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c b/drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c index

RE: [PATCH 3/3] drm/amd/powerplay: update PPtable with DC BTC and Tvr SocLimit fields

2018-10-15 Thread Xu, Feifei
Series reviewed by: Feifei Xu Regards, Feifei -Original Message- From: Evan Quan Sent: 2018年10月16日 10:52 To: amd-gfx@lists.freedesktop.org Cc: Xu, Feifei ; Deucher, Alexander ; Quan, Evan Subject: [PATCH 3/3] drm/amd/powerplay: update PPtable with DC BTC and Tvr SocLimit fields

Re: [PATCH v5 2/4] drm: Add vrr_enabled property to drm CRTC

2018-10-15 Thread Michel Dänzer
On 2018-10-15 11:47 a.m., Christian König wrote: > Am 15.10.2018 um 11:40 schrieb Michel Dänzer: >> On 2018-10-13 7:38 p.m., Christian König wrote: >>> Am 12.10.2018 um 18:44 schrieb Nicholas Kazlauskas: This patch introduces the 'vrr_enabled' CRTC property to allow dynamic control over

[PATCH 5/7] drm: add timeline support for syncobj export/import

2018-10-15 Thread Chunming Zhou
user space can specify timeline point fence to export/import. Signed-off-by: Chunming Zhou --- drivers/gpu/drm/drm_internal.h | 4 ++ drivers/gpu/drm/drm_ioctl.c| 4 ++ drivers/gpu/drm/drm_syncobj.c | 76 ++ include/uapi/drm/drm.h | 11 + 4

[PATCH 4/7] drm: add timeline syncobj payload query ioctl v2

2018-10-15 Thread Chunming Zhou
user mode can query timeline payload. v2: check return value of copy_to_user Signed-off-by: Chunming Zhou --- drivers/gpu/drm/drm_internal.h | 2 ++ drivers/gpu/drm/drm_ioctl.c| 2 ++ drivers/gpu/drm/drm_syncobj.c | 52 ++ include/uapi/drm/drm.h |

[PATCH 6/7] drm/amdgpu: add timeline support in amdgpu CS v2

2018-10-15 Thread Chunming Zhou
syncobj wait/signal operation is appending in command submission. v2: separate to two kinds in/out_deps functions Signed-off-by: Chunming Zhou --- drivers/gpu/drm/amd/amdgpu/amdgpu.h| 8 +- drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 111 +

[PATCH 3/7] drm: add support of syncobj timeline point wait v2

2018-10-15 Thread Chunming Zhou
points array is one-to-one match with syncobjs array. v2: add seperate ioctl for timeline point wait, otherwise break uapi. v3: userspace can specify two kinds waits:: a. Wait for time point to be completed. b. and wait for time point to become available Signed-off-by: Chunming Zhou ---

Re: [PATCH v5 2/4] drm: Add vrr_enabled property to drm CRTC

2018-10-15 Thread Koenig, Christian
Am 15.10.2018 um 12:06 schrieb Michel Dänzer: > [SNIP] > Apart from the above, another issue is that this would give direct > control to the client on whether or not VRR should be used. But we want > to allow the user to disable VRR even if a client wants to use it, via > an RandR output property.

[PATCH 2/7] drm: add syncobj timeline support v8

2018-10-15 Thread Chunming Zhou
This patch is for VK_KHR_timeline_semaphore extension, semaphore is called syncobj in kernel side: This extension introduces a new type of syncobj that has an integer payload identifying a point in a timeline. Such timeline syncobjs support the following operations: * CPU query - A host

[PATCH 1/7] drm: add flags to drm_syncobj_find_fence

2018-10-15 Thread Chunming Zhou
flags can be used by driver to decide whether need to block wait submission. Signed-off-by: Chunming Zhou --- drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 2 +- drivers/gpu/drm/drm_syncobj.c | 4 ++-- drivers/gpu/drm/v3d/v3d_gem.c | 4 ++-- drivers/gpu/drm/vc4/vc4_gem.c |

RE: [PATCH 7/7] drm/amdgpu: update version for timeline syncobj support in amdgpu

2018-10-15 Thread Zhou, David(ChunMing)
Ping... Christian, Could I get your RB on the series? And help me to push to drm-misc? After that I can rebase libdrm header file based on drm-next. Thanks, David Zhou > -Original Message- > From: amd-gfx On Behalf Of > Chunming Zhou > Sent: Monday, October 15, 2018 4:56 PM > To:

[PATCH 7/7] drm/amdgpu: update version for timeline syncobj support in amdgpu

2018-10-15 Thread Chunming Zhou
Signed-off-by: Chunming Zhou --- drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c index 6870909da926..58cba492ba55 100644 ---

Re: [PATCH 7/7] drm/amdgpu: update version for timeline syncobj support in amdgpu

2018-10-15 Thread Koenig, Christian
I'm on sick leave today. But I will see what I can do later in the afternoon, Christian. Am 15.10.2018 um 11:01 schrieb Zhou, David(ChunMing): > Ping... > Christian, Could I get your RB on the series? And help me to push to drm-misc? > After that I can rebase libdrm header file based on

Re: [PATCH v5 2/4] drm: Add vrr_enabled property to drm CRTC

2018-10-15 Thread Michel Dänzer
On 2018-10-13 7:38 p.m., Christian König wrote: > Am 12.10.2018 um 18:44 schrieb Nicholas Kazlauskas: >> This patch introduces the 'vrr_enabled' CRTC property to allow >> dynamic control over variable refresh rate support for a CRTC. >> >> This property should be treated like a content hint to the

Re: [PATCH v5 2/4] drm: Add vrr_enabled property to drm CRTC

2018-10-15 Thread Christian König
Am 15.10.2018 um 11:40 schrieb Michel Dänzer: On 2018-10-13 7:38 p.m., Christian König wrote: Am 12.10.2018 um 18:44 schrieb Nicholas Kazlauskas: This patch introduces the 'vrr_enabled' CRTC property to allow dynamic control over variable refresh rate support for a CRTC. This property should

Re: [RFC] drm/amd/display: add SI support to AMD DC

2018-10-15 Thread sylvain . bertrand
On Mon, Oct 15, 2018 at 07:28:57AM +0200, Mauro Rossi wrote: > dpm for SI is available, while powerplay for SI is not, but > display/amdgpu_dm uses some powerplay calls, where get_static_clock > functions not available and the *ERROR* DM_PPLIB is due to missing handling > in powerplay I though

[PATCH v2] drm: Get ref on CRTC commit object when waiting for flip_done

2018-10-15 Thread sunpeng.li
From: Leo Li This fixes a general protection fault, caused by accessing the contents of a flip_done completion object that has already been freed. It occurs due to the preemption of a non-blocking commit worker thread W by another commit thread X. X continues to clear its atomic state at the

Re: [PATCH v2 2/3] drm: Add variable refresh property to DRM CRTC

2018-10-15 Thread Pekka Paalanen
On Fri, 12 Oct 2018 08:58:23 -0400 "Kazlauskas, Nicholas" wrote: > On 10/12/2018 07:20 AM, Koenig, Christian wrote: > > Am 12.10.2018 um 11:21 schrieb Pekka Paalanen: > >> On Fri, 12 Oct 2018 07:35:57 + > >> "Koenig, Christian" wrote: > >> > >>> Am 12.10.2018 um 09:23 schrieb Pekka

amd gpu hung with opensource driver

2018-10-15 Thread Sunnanyong (Nanyong Sun, Intelligent Computing Solution Development Dep)
Hi All, When use amd radeon pro wx5100 with opensource driver(mesa17.2.8 , kernel v4.17, Ubuntu17.10), GPU hung happened: [260362.362835] amdgpu 0005:01:00.0: GPU fault detected: 146 0x02c0082c [260362.369366] amdgpu 0005:01:00.0: VM_CONTEXT1_PROTECTION_FAULT_ADDR 0x00100058

Re: [PATCH 17/26] drm/amd/display: implement PERF_TRACE on Linux

2018-10-15 Thread Francis, David
Fully agreed. Will redesign this. From: Christian König Sent: October 13, 2018 1:40:24 PM To: Michel Dänzer; Lakha, Bhawanpreet Cc: Francis, David; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH 17/26] drm/amd/display: implement PERF_TRACE on Linux Am

[PATCH] drm/amdgpu: Poweroff uvd/vce/vcn/acp block if they were disabled by user

2018-10-15 Thread Rex Zhu
If user disable uvd/vce/vcn/acp blocks via module parameter ip_block_mask, driver power off thoser blocks to save power. Signed-off-by: Rex Zhu --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 19 +++ 1 file changed, 19 insertions(+) diff --git

Re: [PATCH v2 2/3] drm: Add variable refresh property to DRM CRTC

2018-10-15 Thread Kazlauskas, Nicholas
On 10/15/2018 09:57 AM, Pekka Paalanen wrote: On Fri, 12 Oct 2018 08:58:23 -0400 "Kazlauskas, Nicholas" wrote: On 10/12/2018 07:20 AM, Koenig, Christian wrote: Am 12.10.2018 um 11:21 schrieb Pekka Paalanen: On Fri, 12 Oct 2018 07:35:57 + "Koenig, Christian" wrote: Am 12.10.2018 um

Re: [RFC] drm/amd/display: add SI support to AMD DC

2018-10-15 Thread Deucher, Alexander
There are two sets of power management code in amdgpu, the older dpm code which was ported from radeon, and the newer powerplay code which was rewritten to align closer with the power management code for other OSes and the hw teams. The "powerplay" code has more features than the older dpm