Reasons to drop it:
1) simplify the code: just introduce field member "need_pipe_sync"
for job is good enough to tell if the explicit dependency fence
need followed by a pipeline sync.
2) after GPU_recover the explicit fence from sched_syn will not
come back so the required pipeline_sync
use a flag to hold need_flush and need_pipe_sync
Signed-off-by: Monk Liu
---
drivers/gpu/drm/amd/amdgpu/amdgpu_ib.c| 2 +-
drivers/gpu/drm/amd/amdgpu/amdgpu_ids.c | 14 +-
drivers/gpu/drm/amd/amdgpu/amdgpu_job.c | 2 +-
drivers/gpu/drm/amd/amdgpu/amdgpu_job.h | 6 --
and differentiate it with explicit_bo flag
Signed-off-by: Monk Liu
---
drivers/gpu/drm/amd/amdgpu/amdgpu_job.c | 6 +++---
drivers/gpu/drm/amd/amdgpu/amdgpu_sync.c | 7 +--
2 files changed, 8 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_job.c
Am 31.10.18 um 23:12 schrieb Marek Olšák:
On Wed, Oct 31, 2018 at 3:59 AM Koenig, Christian
mailto:christian.koe...@amd.com>> wrote:
Am 30.10.18 um 16:59 schrieb Michel Dänzer:
> On 2018-10-30 4:52 p.m., Marek Olšák wrote:
>> On Tue, Oct 30, 2018, 11:49 AM Marek Olšák
>>
Reviewed-by: Chunming Zhou
> -Original Message-
> From: amd-gfx On Behalf Of
> Christian K?nig
> Sent: Friday, November 02, 2018 4:45 PM
> To: amd-gfx@lists.freedesktop.org
> Subject: [PATCH] drm/amdgpu: wait for IB test on first device open
>
> Instead of delaying that to the first
Instead of delaying that to the first query. Otherwise we could try to use the
SDMA for VM updates before the IB tests are done.
Signed-off-by: Christian König
---
drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git
On 11/2/18 4:44 PM, Christian König wrote:
Instead of delaying that to the first query. Otherwise we could try to use the
SDMA for VM updates before the IB tests are done.
Be curious:
Does that happen when App opens dri node without libdrm?
since device init always queries info at first.
v2: symbos are stored in lexical order.
Signed-off-by: Chunming Zhou
---
amdgpu/amdgpu-symbol-check | 4 +++
amdgpu/amdgpu.h| 73 ++
amdgpu/amdgpu_cs.c | 62
3 files changed, 139 insertions(+)
diff --git
Signed-off-by: Chunming Zhou
---
tests/amdgpu/Makefile.am | 3 +-
tests/amdgpu/amdgpu_test.c | 12 ++
tests/amdgpu/amdgpu_test.h | 21 +++
tests/amdgpu/meson.build | 2 +-
tests/amdgpu/syncobj_tests.c | 263 +++
5 files changed, 299
Am 02.11.18 um 10:19 schrieb Zhang, Jerry(Junwei):
On 11/2/18 4:44 PM, Christian König wrote:
Instead of delaying that to the first query. Otherwise we could try
to use the
SDMA for VM updates before the IB tests are done.
Be curious:
Does that happen when App opens dri node without libdrm?
On 11/2/18 5:32 PM, Christian König wrote:
Am 02.11.18 um 10:19 schrieb Zhang, Jerry(Junwei):
On 11/2/18 4:44 PM, Christian König wrote:
Instead of delaying that to the first query. Otherwise we could try
to use the
SDMA for VM updates before the IB tests are done.
Be curious:
Does that
On 2018-11-01 8:07 p.m., David Francis wrote:
> This will clean up powerplay code, as we are no longer
> multiplying the clocks by 1000 in DM and then dividing them
> by 1000 in powerplay
>
> Signed-off-by: David Francis
In the shortlog, "mHz" means millihertz, should be "MHz" for megahertz.
From: Leo Li
Mainly adding the WAFL spread spectrum info, for adjusting display
clocks when XGMI is enabled.
Signed-off-by: Leo Li
---
drivers/gpu/drm/amd/include/atomfirmware.h | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git
On 2018-10-31 7:33 p.m., Andrey Grodzovsky wrote:
> Illegal access will cause CP hang followed by job timeout and
> recovery kicking in.
> Also, disable the suite for all APU ASICs until GPU
> reset issues for them will be resolved and GPU reset recovery
> will be enabled by default.
>
>
Acked-by: Alex Deucher
From: amd-gfx on behalf of Christian
König
Sent: Friday, November 2, 2018 9:48:07 AM
To: amd-gfx@lists.freedesktop.org
Subject: [PATCH] drm/amdkfd: fix interrupt spin lock
Vega10 has multiple interrupt rings, so this can be called from
Acked-by: Alex Deucher
From: amd-gfx on behalf of
sunpeng...@amd.com
Sent: Friday, November 2, 2018 9:29:24 AM
To: amd-gfx@lists.freedesktop.org
Cc: Deucher, Alexander; Li, Sun peng (Leo); Wentland, Harry
Subject: [PATCH] drm/amd: Update atom_smu_info_v3_3
The default unit in powerplay is 10kHz
To convert from 10kHz to kHz, multiply by 10
Signed-off-by: David Francis
---
drivers/gpu/drm/amd/powerplay/hwmgr/vega12_hwmgr.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/vega12_hwmgr.c
This will clean up powerplay code, as we are no longer
multiplying the clocks by 1000 in DM and then dividing them
by 1000 in powerplay
Signed-off-by: David Francis
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_pp_smu.c | 6 +++---
drivers/gpu/drm/amd/include/dm_pp_interface.h
Watermarks were being multiplied by 1000 in amdgpu_dm
and divided by 1000 in powerplay. Change watermarks
to units of MHz to stop doing that.
Signed-off-by: David Francis
---
.../amd/display/amdgpu_dm/amdgpu_dm_pp_smu.c | 24 +-
.../drm/amd/display/dc/dm_services_types.h| 16
Vega10 has multiple interrupt rings, so this can be called from multiple
calles at the same time resulting in:
[ 71.779334]
[ 71.779406] WARNING: inconsistent lock state
[ 71.779478] 4.19.0-rc1+ #44 Tainted: GW
[ 71.779565]
On 11/02/2018 10:24 AM, Michel Dänzer wrote:
> On 2018-10-31 7:33 p.m., Andrey Grodzovsky wrote:
>> Illegal access will cause CP hang followed by job timeout and
>> recovery kicking in.
>> Also, disable the suite for all APU ASICs until GPU
>> reset issues for them will be resolved and GPU reset
Am 01.11.18 um 02:44 schrieb Alex Deucher:
On Wed, Oct 31, 2018 at 4:05 PM Grodzovsky, Andrey
wrote:
On 10/31/2018 03:49 PM, Alex Deucher wrote:
On Wed, Oct 31, 2018 at 2:33 PM Andrey Grodzovsky
wrote:
Illegal access will cause CP hang followed by job timeout and
recovery kicking in.
Signed-off-by: Chunming Zhou
---
xf86drm.c | 78 +++
xf86drm.h | 8 ++
2 files changed, 86 insertions(+)
diff --git a/xf86drm.c b/xf86drm.c
index 49150d74..13f36b04 100644
--- a/xf86drm.c
+++ b/xf86drm.c
@@ -4212,6 +4212,40 @@ drm_public
Signed-off-by: Chunming Zhou
---
include/drm/drm.h | 38 ++
1 file changed, 38 insertions(+)
diff --git a/include/drm/drm.h b/include/drm/drm.h
index 85c685a2..43d7420a 100644
--- a/include/drm/drm.h
+++ b/include/drm/drm.h
@@ -711,6 +711,7 @@ struct
Signed-off-by: Chunming Zhou
---
include/drm/amdgpu_drm.h | 9 +
1 file changed, 9 insertions(+)
diff --git a/include/drm/amdgpu_drm.h b/include/drm/amdgpu_drm.h
index 1ceec56d..a3c067dd 100644
--- a/include/drm/amdgpu_drm.h
+++ b/include/drm/amdgpu_drm.h
@@ -517,6 +517,8 @@ struct
There is a pplib messaging related failure currently during GPU reset. I will
put this issue on my TODO
list for later time after handling more prioritized stuff and will disable the
deadlock test suite for all non dGPU gfx8/9 ASICs until then.
Andrey
On 11/02/2018 02:14 PM, Grodzovsky,
Since only for those ASICs gpu reset is enabled by deafult.
Also update disable message and fix identation .
Signed-off-by: Andrey Grodzovsky
---
tests/amdgpu/deadlock_tests.c | 12 +++-
1 file changed, 7 insertions(+), 5 deletions(-)
diff --git a/tests/amdgpu/deadlock_tests.c
On Fri, Nov 2, 2018 at 3:36 PM Andrey Grodzovsky
wrote:
>
> Since only for those ASICs gpu reset is enabled by deafult.
> Also update disable message and fix identation .
>
> Signed-off-by: Andrey Grodzovsky
> ---
> tests/amdgpu/deadlock_tests.c | 12 +++-
> 1 file changed, 7
On Fri, Nov 2, 2018 at 3:39 AM Koenig, Christian
wrote:
> Am 31.10.18 um 23:12 schrieb Marek Olšák:
>
> On Wed, Oct 31, 2018 at 3:59 AM Koenig, Christian <
> christian.koe...@amd.com> wrote:
>
>> Am 30.10.18 um 16:59 schrieb Michel Dänzer:
>> > On 2018-10-30 4:52 p.m., Marek Olšák wrote:
>> >>
On Fri, Nov 2, 2018 at 11:59 AM Grodzovsky, Andrey
wrote:
>
>
>
> On 11/02/2018 10:24 AM, Michel Dänzer wrote:
> > On 2018-10-31 7:33 p.m., Andrey Grodzovsky wrote:
> >> Illegal access will cause CP hang followed by job timeout and
> >> recovery kicking in.
> >> Also, disable the suite for all
On 11/02/2018 02:12 PM, Alex Deucher wrote:
> On Fri, Nov 2, 2018 at 11:59 AM Grodzovsky, Andrey
> wrote:
>>
>>
>> On 11/02/2018 10:24 AM, Michel Dänzer wrote:
>>> On 2018-10-31 7:33 p.m., Andrey Grodzovsky wrote:
Illegal access will cause CP hang followed by job timeout and
recovery
On 2018-11-02 9:48 a.m., Christian König wrote:
> Vega10 has multiple interrupt rings,
I don't think I've seen your code that implements multiple interrupt
rings. So it's a bit hard to comment. As I understand it, the only way
this could happen is, if the two interrupt rings are handled by
32 matches
Mail list logo
