RE: [PATCH 1/2] drm/amdgpu/sdma4: use paging queue for buffer funcs

2018-11-08 Thread Gong, Curry
Result is pass -Original Message- From: Gong, Curry Sent: Thursday, November 8, 2018 4:14 PM To: Zhang, Jerry ; Alex Deucher Cc: amd-gfx list ; Deucher, Alexander Subject: RE: [PATCH 1/2] drm/amdgpu/sdma4: use paging queue for buffer funcs Hi Alex: I have tested this patch base on

RE: [PATCH 1/2] drm/amdgpu/sdma4: use paging queue for buffer funcs

2018-11-08 Thread Gong, Curry
Hi Alex: I have tested this patch base on branch "amd-staging-dkms-4.18" glmark2 and unigine_heaven Tested-by: Chen Gong -Original Message- From: Zhang, Jerry Sent: Thursday, November 8, 2018 3:45 PM To: Alex Deucher ; Gong, Curry Cc: amd-gfx list ; Deucher, Alexander Subject:

Re: [PATCH 1/2] drm/amdgpu/sdma4: use paging queue for buffer funcs

2018-11-08 Thread Christian König
Am 07.11.18 um 18:29 schrieb Alex Deucher: Use the paging queue for buffer functions to avoid contention with the other queues. Signed-off-by: Alex Deucher Reviewed-by: Christian König --- drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c | 12 +++- 1 file changed, 11 insertions(+), 1

Re: [PATCH 2/2] drm/amdgpu/sdma4: use page queue 1 for buffer funcs

2018-11-08 Thread Christian König
Am 07.11.18 um 18:29 schrieb Alex Deucher: Use page queue 0 rather than 1 to avoid contention with GPUVM updates using page queue 0. Well NAK for two reasons: 1. VM updates are currently balanced between page queue 0 and 1. 2. I want to keep one paging queue reserved for fault processing in

[PATCH v2 2/3] drm/amdgpu: separate amdgpu_rlc into a single file

2018-11-08 Thread likun Gao
From: Likun Gao Separate the function and struct of RLC from the file of GFX. Abstract the function of amdgpu_gfx_rlc_fini. Signed-off-by: Likun Gao --- drivers/gpu/drm/amd/amdgpu/Makefile | 1 + drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c | 1 + drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.h | 60

[PATCH v2 3/3] drm/amdgpu: abstract the function of enter/exit safe mode for RLC

2018-11-08 Thread likun Gao
From: Likun Gao Abstract the function of amdgpu_gfx_rlc_enter/exit_safe_mode and some part of rlc_init to improve the reusability of RLC. Signed-off-by: Likun Gao --- drivers/gpu/drm/amd/amdgpu/amdgpu_rlc.c| 229 - drivers/gpu/drm/amd/amdgpu/amdgpu_rlc.h

[PATCH v2 1/3] drm/amdgpu: unify rlc function into structure

2018-11-08 Thread likun Gao
From: Likun Gao Put function rlc_init,rlc_fini,rlc_resume,rlc_stop,rlc_start into structure amdgpu_rlc_funcs and change the method to call rlc function for each verssion of GFX. Signed-off-by: Likun Gao --- drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.h | 6 ++

[PATCH -next] drm/radeon: remove set but not used variable 'rdev'

2018-11-08 Thread YueHaibing
From: Yue Haibing Fixes gcc '-Wunused-but-set-variable' warning: drivers/gpu/drm/radeon/radeon_object.c: In function 'radeon_bo_unref': drivers/gpu/drm/radeon/radeon_object.c:317:24: warning: variable 'rdev' set but not used [-Wunused-but-set-variable] It not used any more after commit

[PATCH v2 0/3] RLC kernel code update to improve resuabillity

2018-11-08 Thread likun Gao
From: Likun Gao Hi, Patches for RLC which is used for improving the resuabillity of RLC's code have update, the changes between the old patch are as follow: PATCH 1/3: have not changed and it unified RLC's function into the struct amdgpu_rlc_funcs and change the method of calling RLC. PATCH 2/3

[PATCH v7 0/5] A DRM API for adaptive sync and variable refresh rate support

2018-11-08 Thread Nicholas Kazlauskas
These patches are part of a proposed new interface for supporting variable refresh rate via DRM properties. === Changes from v6 === drm changes: * Updated documentation typos, added more information about potential issues with luminance changes === Changes from v5 === drm changes: *

[PATCH v7 4/5] drm/amdgpu: Correct get_crtc_scanoutpos behavior when vpos >= vtotal

2018-11-08 Thread Nicholas Kazlauskas
When variable refresh rate is active the hardware counter can return a position >= vtotal. This results in a vpos being returned from amdgpu_display_get_crtc_scanoutpos that's a positive value. The positive value indicates to the caller that the display is currently in scanout when the display is

[PATCH v7 1/5] drm: Add vrr_capable property to the drm connector

2018-11-08 Thread Nicholas Kazlauskas
Modern display hardware is capable of supporting variable refresh rates. This patch introduces the "vrr_capable" property on the connector to allow userspace to query support for variable refresh rates. Atomic drivers should attach this property to connectors that are capable of driving variable

[PATCH v7 5/5] drm/amdgpu: Set FreeSync state using drm VRR properties

2018-11-08 Thread Nicholas Kazlauskas
Support for AMDGPU specific FreeSync properties and ioctls are dropped from amdgpu_dm in favor of supporting drm variable refresh rate properties. The notify_freesync and set_freesync_property functions are dropped from amdgpu_display_funcs. The drm vrr_capable property is now attached to any

[PATCH v7 3/5] drm: Document variable refresh properties

2018-11-08 Thread Nicholas Kazlauskas
These include the drm_connector 'vrr_capable' and the drm_crtc 'vrr_enabled' properties. Signed-off-by: Nicholas Kazlauskas Cc: Harry Wentland Cc: Manasi Navare Cc: Pekka Paalanen Cc: Ville Syrjälä Cc: Michel Dänzer --- Documentation/gpu/drm-kms.rst | 7

[PATCH] drm/amdgpu: support Vega20 A1 ASICs

2018-11-08 Thread Evan Quan
Since they use different PSP firmwares from A0 ASICs for now. This will be dropped after they are unified to share the same PSP firmwares. Change-Id: I3bc8956dac62607e8771757858b1286a87f76cf3 Signed-off-by: Evan Quan Acked-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/psp_v11_0.c | 12

Re: [PATCH v2 0/3] RLC kernel code update to improve resuabillity

2018-11-08 Thread Christian König
Acked-by: Christian König to the whole series. Alex or somebody else with more RLC knowledge than me should probably take a look as well, but in general that looks like a really nice cleanup to me. Christian. Am 08.11.18 um 14:04 schrieb likun Gao: From: Likun Gao Hi, Patches for RLC

Re: [PATCH 6/8] drm/amdgpu: meld together VM fragment and huge page handling

2018-11-08 Thread Samuel Pitoiset
On 11/8/18 5:50 PM, Christian König wrote: Hi Samuel, yeah, that is a known issue and I was already looking into that all day today. Problem is that I can't reproduce it reliable. Do you have any hint how to trigger that? E.g. memory exhaustion maybe? Hi Christian, Good to hear that you

Re: [PATCH -next] drm/radeon: remove set but not used variable 'rdev'

2018-11-08 Thread Alex Deucher
On Thu, Nov 8, 2018 at 9:04 AM YueHaibing wrote: > > From: Yue Haibing > > Fixes gcc '-Wunused-but-set-variable' warning: > > drivers/gpu/drm/radeon/radeon_object.c: In function 'radeon_bo_unref': > drivers/gpu/drm/radeon/radeon_object.c:317:24: warning: > variable 'rdev' set but not used

Re: [PATCH] drm/amd: update ATIF functions in AMD ACPI header

2018-11-08 Thread Alex Deucher
On Thu, Nov 8, 2018 at 3:57 PM David Francis wrote: > > The ACPI interface in AMD was a few years out of date > and contained some unused and deprecated functions > > Remove functions: Select Active Displays, Get Lid State, > Get TV Standard, Set TV Standard, Get Panel Expansion Mode, > Set Panel

[PATCH] drm/amd: update ATIF functions in AMD ACPI header

2018-11-08 Thread David Francis
The ACPI interface in AMD was a few years out of date and contained some unused and deprecated functions Remove functions: Select Active Displays, Get Lid State, Get TV Standard, Set TV Standard, Get Panel Expansion Mode, Set Panel Expansion Mode, Get Graphics Device Types Add functions: Query

Re: [PATCH] drm/amdgpu: Each PSP need to get latest topology info on XGMI configuration

2018-11-08 Thread Zhang, Hawking
Reviewed-by: Hawking Zhang Regards, Hawking Sent from my iPhone > On Nov 9, 2018, at 00:17, Liu, Shaoyun wrote: > > From: shaoyunl > > Driver need to call each psp instance to get topology info before set topology > > Change-Id: I20d914a0c678686db3f1f99edf250f3656ec9fc1 > Signed-off-by:

[PATCH] drm/amdgpu/gfx9: rework lbpw enable code

2018-11-08 Thread Alex Deucher
To avoid changing the global lbpw module parameter directly. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 29 - 1 file changed, 12 insertions(+), 17 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c

[PATCH] drm/amdgpu: Each PSP need to get latest topology info on XGMI configuration

2018-11-08 Thread Liu, Shaoyun
From: shaoyunl Driver need to call each psp instance to get topology info before set topology Change-Id: I20d914a0c678686db3f1f99edf250f3656ec9fc1 Signed-off-by: shaoyunl --- drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c | 19 --- 1 file changed, 12 insertions(+), 7 deletions(-)

Re: [PATCH 6/8] drm/amdgpu: meld together VM fragment and huge page handling

2018-11-08 Thread Christian König
Hi Samuel, yeah, that is a known issue and I was already looking into that all day today. Problem is that I can't reproduce it reliable. Do you have any hint how to trigger that? E.g. memory exhaustion maybe? Thanks, Christian. Am 08.11.18 um 17:17 schrieb Samuel Pitoiset: Hi, This change

Re: [PATCH 6/8] drm/amdgpu: meld together VM fragment and huge page handling

2018-11-08 Thread Samuel Pitoiset
Hi, This change introduces GPU hangs with F1 2017 and Rise of Tomb Raider on RADV/GFX9. I bisected the issue. Can you have a look? Thanks! On 9/12/18 10:54 AM, Christian König wrote: This optimizes the generating of PTEs by walking the hierarchy only once for a range and making changes as

Re: [PATCH v2 0/3] RLC kernel code update to improve resuabillity

2018-11-08 Thread Alex Deucher
On Thu, Nov 8, 2018 at 9:45 AM Christian König wrote: > > Acked-by: Christian König to the whole series. > > Alex or somebody else with more RLC knowledge than me should probably > take a look as well, but in general that looks like a really nice > cleanup to me. Yeah, looks good. Series is: