[bug report] drm/amd/display: wait for fence without holding reservation lock

2019-05-02 Thread Dan Carpenter
Hello Christian König, The patch 2fac0f53fe59: "drm/amd/display: wait for fence without holding reservation lock" from Apr 2, 2019, leads to the following static checker warning: drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:5338 amdgpu_dm_commit_planes() warn: 'r'

Re: [PATCH 1/2] drm/amdgpu: Fix CIK references in gmc_v8

2019-05-02 Thread Christian König
Am 01.05.19 um 14:31 schrieb Russell, Kent: gmc_v8 is for VI, not CIK, so fix those references Change-Id: Ifa46212fbeadbec7e73ba28d02e97339ffcfb5d1 Signed-off-by: Kent Russell Reviewed-by: Christian König --- drivers/gpu/drm/amd/amdgpu/gmc_v8_0.c | 14 +++--- 1 file changed, 7

Re: [PATCH] drm/amd/display: Use int for signed error code checks in commit planes

2019-05-02 Thread Kazlauskas, Nicholas
On 5/2/19 9:09 AM, Christian König wrote: > > Am 02.05.19 um 15:08 schrieb Christian König: >> Am 02.05.19 um 15:03 schrieb Nicholas Kazlauskas: >>> [Why] >>> >>> The type of 'r' is uint32_t and the return codes for both: >>> >>> - reservation_object_wait_timeout_rcu >>> - amdgpu_bo_reserve >>>

Re: [bug report] drm/amd/display: wait for fence without holding reservation lock

2019-05-02 Thread Kazlauskas, Nicholas
On 5/2/19 4:04 AM, Dan Carpenter wrote: > [CAUTION: External Email] > > Hello Christian König, > > The patch 2fac0f53fe59: "drm/amd/display: wait for fence without > holding reservation lock" from Apr 2, 2019, leads to the following > static checker warning: > >

[PATCH] drm/amdgpu: Use FW addr returned by PSP for VF MM

2019-05-02 Thread Trigger Huang
One Vega10 SR-IOV VF, the FW address returned by PSP should be set into the init table, while not the original BO mc address. otherwise, UVD and VCE IB test will fail under Vega10 SR-IOV reference: commit bfcea5204287 ("drm/amdgpu:change VEGA booting with firmware loaded by PSP")

Re: [PATCH] drm/amd/display: Use int for signed error code checks in commit planes

2019-05-02 Thread Christian König
Am 02.05.19 um 15:08 schrieb Christian König: Am 02.05.19 um 15:03 schrieb Nicholas Kazlauskas: [Why] The type of 'r' is uint32_t and the return codes for both: - reservation_object_wait_timeout_rcu - amdgpu_bo_reserve ...are signed. While it works for the latter since the check is done on

Re: [PATCH] drm/amd/display: Use int for signed error code checks in commit planes

2019-05-02 Thread Christian König
Am 02.05.19 um 15:03 schrieb Nicholas Kazlauskas: [Why] The type of 'r' is uint32_t and the return codes for both: - reservation_object_wait_timeout_rcu - amdgpu_bo_reserve ...are signed. While it works for the latter since the check is done on != 0 it doesn't work for the former since we

Re: [PATCH v2] drm/amd/display: Use long for signed error code checks in commit planes

2019-05-02 Thread Christian König
Am 02.05.19 um 15:14 schrieb Nicholas Kazlauskas: [Why] The type of 'r' is uint32_t and the return codes for both: - reservation_object_wait_timeout_rcu - amdgpu_bo_reserve ...are signed. While it works for the latter since the check is done on != 0 it doesn't work for the former since we

[PATCH] drm/amd/amdgpu: Add MEM_LOAD to amdgpu_pm_info debugfs file

2019-05-02 Thread StDenis, Tom
Signed-off-by: Tom St Denis --- drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c index 5e2d039e09ad..e0789f0f2670 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c +++

[PATCH] drm/amd/display: Use int for signed error code checks in commit planes

2019-05-02 Thread Nicholas Kazlauskas
[Why] The type of 'r' is uint32_t and the return codes for both: - reservation_object_wait_timeout_rcu - amdgpu_bo_reserve ...are signed. While it works for the latter since the check is done on != 0 it doesn't work for the former since we check <= 0. [How] Make 'r' an int in commit planes so

Re: [PATCH 27/27] drm/amdgpu: Fix GTT size calculation

2019-05-02 Thread Koenig, Christian
Am 30.04.19 um 19:25 schrieb Kuehling, Felix: > [SNIP] To sum it up the requirement of using almost all system memory by a GPU is simply not possible upstream and even in any production system rather questionable. >>> It should be doable with userptr, which now uses unpinned pages

[PATCH v2] drm/amd/display: Use long for signed error code checks in commit planes

2019-05-02 Thread Nicholas Kazlauskas
[Why] The type of 'r' is uint32_t and the return codes for both: - reservation_object_wait_timeout_rcu - amdgpu_bo_reserve ...are signed. While it works for the latter since the check is done on != 0 it doesn't work for the former since we check <= 0. [How] Make 'r' a long in commit planes so

[pull] amdgpu drm-next-5.2

2019-05-02 Thread Alex Deucher
Hi Dave, Daniel, Fixes for 5.2: - SR-IOV fixes - Raven flickering fix - Misc spelling fixes - Vega20 power fixes - Freesync improvements - DC fixes The following changes since commit f55be0be5b7296e73f1634e2839a1953dc12d11e: drm/amd/display: Add profiling tools for bandwidth validation

Re: [PATCH] drm/amd/amdgpu: Add MEM_LOAD to amdgpu_pm_info debugfs file

2019-05-02 Thread Deucher, Alexander
Reviewed-by: Alex Deucher From: amd-gfx on behalf of StDenis, Tom Sent: Thursday, May 2, 2019 10:22 AM To: amd-gfx@lists.freedesktop.org Cc: StDenis, Tom Subject: [PATCH] drm/amd/amdgpu: Add MEM_LOAD to amdgpu_pm_info debugfs file [CAUTION: External Email]