[PATCH 3/3] drm/amd/powerplay: support ppfeatures sysfs interface on sw smu routine

2019-05-13 Thread Evan Quan
Support ppfeatures sysfs interface on Vega20 sw smu routine. Change-Id: If67f2d87e7d5aa09cfd61e86df88d5f2f4dd Signed-off-by: Evan Quan --- drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c| 10 +- .../gpu/drm/amd/powerplay/inc/amdgpu_smu.h| 7 +-

[PATCH 1/3] drm/amd/powerplay: drop unnecessary sw smu check

2019-05-13 Thread Evan Quan
There is already sw smu check on IP block adding. Change-Id: I070290f4fd7acb2c425e8fded5696d4ac9e80ed8 Signed-off-by: Evan Quan --- drivers/gpu/drm/amd/powerplay/amdgpu_smu.c | 18 -- 1 file changed, 18 deletions(-) diff --git a/drivers/gpu/drm/amd/powerplay/amdgpu_smu.c

[PATCH 2/3] drm/amd/powerplay: drop redundant smu call

2019-05-13 Thread Evan Quan
smu_get_clk_info_from_vbios() was called repeatedly. It seems a merge error. Change-Id: Ice22a171cbb976d0aebd6609344a10b008d18f14 Signed-off-by: Evan Quan --- drivers/gpu/drm/amd/powerplay/amdgpu_smu.c | 4 1 file changed, 4 deletions(-) diff --git

RE: [PATCH] drm/amdgpu: avoid duplicated tmo report on same job

2019-05-13 Thread Liu, Monk
I think it's a neat approach, thanks ! /Monk -Original Message- From: Koenig, Christian Sent: Friday, May 10, 2019 8:07 PM To: Liu, Monk ; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH] drm/amdgpu: avoid duplicated tmo report on same job Yeah, that's indeed a bit problematic. How

[PATCH] drm/amdgpu: suppress repeating tmo report

2019-05-13 Thread Monk Liu
only report once per TMO job and the timer would be restarted upon the job finished if it's just slow. Suggested-by: Christian König Signed-off-by: Monk Liu --- drivers/gpu/drm/amd/amdgpu/amdgpu_job.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_job.c

[PATCH libdrm 3/7] wrap syncobj timeline query/wait APIs for amdgpu v3

2019-05-13 Thread Chunming Zhou
v2: symbos are stored in lexical order. v3: drop export/import and extra query indirection Signed-off-by: Chunming Zhou Acked-by: Christian König --- amdgpu/amdgpu-symbol-check | 2 ++ amdgpu/amdgpu.h| 39 ++ amdgpu/amdgpu_cs.c | 23

Re: [PATCH] drm/amdgpu: suppress repeating tmo report

2019-05-13 Thread Christian König
Am 13.05.19 um 08:01 schrieb Monk Liu: only report once per TMO job and the timer would be restarted upon the job finished if it's just slow. Suggested-by: Christian König Signed-off-by: Monk Liu Reviewed-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_job.c | 2 ++ 1 file

[PATCH] drm/amd/powerplay: honor hw limit on fetching metrics data

2019-05-13 Thread Evan Quan
Request too frequently may get corrupt data. Change-Id: Ided23ab7dd0143575479644c5030cea71bdc53fd Signed-off-by: Evan Quan --- .../gpu/drm/amd/powerplay/inc/amdgpu_smu.h| 3 ++ drivers/gpu/drm/amd/powerplay/smu_v11_0.c | 33 +-- 2 files changed, 34 insertions(+), 2

[PATCH libdrm 2/7] add timeline wait/query ioctl v2

2019-05-13 Thread Chunming Zhou
v2: drop export/import Signed-off-by: Chunming Zhou --- xf86drm.c | 44 xf86drm.h | 6 ++ 2 files changed, 50 insertions(+) diff --git a/xf86drm.c b/xf86drm.c index 2c19376b..17e3d880 100644 --- a/xf86drm.c +++ b/xf86drm.c @@ -4256,3 +4256,47

[PATCH libdrm 7/7] add syncobj timeline tests v3

2019-05-13 Thread Chunming Zhou
v2: drop DRM_SYNCOBJ_CREATE_TYPE_TIMELINE, fix timeout calculation, fix some warnings v3: add export/import and cpu signal testing cases Signed-off-by: Chunming Zhou Acked-by: Christian König --- tests/amdgpu/Makefile.am | 3 +- tests/amdgpu/amdgpu_test.c | 11 ++

[PATCH libdrm 6/7] wrap transfer interfaces

2019-05-13 Thread Chunming Zhou
Signed-off-by: Chunming Zhou Acked-by: Christian König --- amdgpu/amdgpu.h| 22 ++ amdgpu/amdgpu_cs.c | 16 2 files changed, 38 insertions(+) diff --git a/amdgpu/amdgpu.h b/amdgpu/amdgpu.h index d2480dbe..9d9b0832 100644 --- a/amdgpu/amdgpu.h +++

[PATCH libdrm 4/7] add timeline signal/transfer ioctls v2

2019-05-13 Thread Chunming Zhou
v2: use one transfer ioctl Signed-off-by: Chunming Zhou --- xf86drm.c | 33 + xf86drm.h | 6 ++ 2 files changed, 39 insertions(+) diff --git a/xf86drm.c b/xf86drm.c index 17e3d880..acd16fab 100644 --- a/xf86drm.c +++ b/xf86drm.c @@ -4257,6 +4257,21 @@

[PATCH libdrm 5/7] expose timeline signal/export/import interfaces v2

2019-05-13 Thread Chunming Zhou
v2: adapt to new one transfer ioctl Signed-off-by: Chunming Zhou Acked-by: Christian König --- amdgpu/amdgpu-symbol-check | 3 ++ amdgpu/amdgpu.h| 51 amdgpu/amdgpu_cs.c | 68 ++ 3 files changed, 122

[PATCH libdrm 1/7] addr cs chunk for syncobj timeline

2019-05-13 Thread Chunming Zhou
Signed-off-by: Chunming Zhou --- include/drm/amdgpu_drm.h | 9 + 1 file changed, 9 insertions(+) diff --git a/include/drm/amdgpu_drm.h b/include/drm/amdgpu_drm.h index d0701ffc..3d0318e6 100644 --- a/include/drm/amdgpu_drm.h +++ b/include/drm/amdgpu_drm.h @@ -528,6 +528,8 @@ struct

Re: [PATCH] Revert "vgaarb: Keep adding VGA device in queue"

2019-05-13 Thread Michel Dänzer
On 2019-05-10 8:01 p.m., Aaron Ma wrote: > On 5/10/19 11:46 PM, Michel Dänzer wrote: >>> Given that the bug is a bit a mess I think we need to add a bit more >>> context here in the commit message. My understanding: >>> >>> Goal of the revert commit was to make the integrated boot device the >>>

Re: [PATCH libdrm 1/7] addr cs chunk for syncobj timeline

2019-05-13 Thread zhoucm1
ping... for patch set. On 2019年05月13日 17:52, Chunming Zhou wrote: [CAUTION: External Email] Signed-off-by: Chunming Zhou --- include/drm/amdgpu_drm.h | 9 + 1 file changed, 9 insertions(+) diff --git a/include/drm/amdgpu_drm.h b/include/drm/amdgpu_drm.h index d0701ffc..3d0318e6

[PATCH] drm/amdkfd: Add missing Polaris10 ID

2019-05-13 Thread Russell, Kent
This was added to amdgpu but was missed in amdkfd Change-Id: Iab59ccfd5a42efae18846749deeb7c96490812d4 Signed-off-by: Kent Russell --- drivers/gpu/drm/amd/amdkfd/kfd_device.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_device.c

RE: [PATCH] drm/amd/powerplay: honor hw limit on fetching metrics data

2019-05-13 Thread Xu, Feifei
Reviewed-by: Feifei Xu -Original Message- From: amd-gfx On Behalf Of Evan Quan Sent: Monday, May 13, 2019 5:36 PM To: amd-gfx@lists.freedesktop.org Cc: Quan, Evan Subject: [PATCH] drm/amd/powerplay: honor hw limit on fetching metrics data [CAUTION: External Email] Request too

Re: [PATCH 7/8] drm/amdkfd: New IOCTL to allocate queue GWS

2019-05-13 Thread Kuehling, Felix
On 2019-05-13 12:03 p.m., Zeng, Oak wrote: > Hi Felix, > > See comments inline [Oak] > > Hi Kent, there is one FYI embedded, so be careful when you merge this change > back to kfd-staging branch. > > Regards, > Oak > > -Original Message- > From: Kuehling, Felix > Sent: Friday, May 10,

[PATCH 5/8] drm/amdkfd: Add function to set queue gws

2019-05-13 Thread Zeng, Oak
Add functions in process queue manager to set/get queue gws. Also set process's number of gws used. Currently only one queue in process can use and use all gws. Change-Id: I03e480c8692db3eabfc3a188cce8904d5d962ab7 Signed-off-by: Oak Zeng --- drivers/gpu/drm/amd/amdkfd/kfd_priv.h |

[PATCH 7/8] drm/amdkfd: New IOCTL to allocate queue GWS

2019-05-13 Thread Zeng, Oak
Add a new kfd ioctl to allocate queue GWS. Queue GWS is released on queue destroy. Change-Id: I60153c26a577992ad873e4292e759e5c3d5bbd15 Signed-off-by: Oak Zeng --- drivers/gpu/drm/amd/amdkfd/kfd_chardev.c | 39 ++ .../gpu/drm/amd/amdkfd/kfd_process_queue_manager.c

[PATCH 6/8] drm/amdgpu: Add function to add/remove gws to kfd process

2019-05-13 Thread Zeng, Oak
GWS bo is shared between all kfd processes. Add function to add gws to kfd process's bo list so gws can be evicted from and restored for process. Change-Id: I75d74cfdadb7075ff8b2b68634e205deb73dc1ea Signed-off-by: Oak Zeng --- drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.h | 2 +

Re: [PATCH 2/2] mm/hmm: Only set FAULT_FLAG_ALLOW_RETRY for non-blocking

2019-05-13 Thread Kuehling, Felix
Hi Jerome, Do you want me to push the patches to your branch? Or are you going to apply them yourself? Is your hmm-5.2-v3 branch going to make it into Linux 5.2? If so, do you know when? I'd like to coordinate with Dave Airlie so that we can also get that update into a drm-next branch soon.

Re: [PATCH 7/8] drm/amdkfd: New IOCTL to allocate queue GWS

2019-05-13 Thread Christian König
Am 13.05.19 um 20:12 schrieb Kuehling, Felix: On 2019-05-13 12:03 p.m., Zeng, Oak wrote: Hi Felix, See comments inline [Oak] Hi Kent, there is one FYI embedded, so be careful when you merge this change back to kfd-staging branch. Regards, Oak -Original Message- From: Kuehling,

Re: [PATCH libdrm 1/7] addr cs chunk for syncobj timeline

2019-05-13 Thread Lionel Landwerlin
Sorry for the delay, I'll try to review this tomorrow. -Lionel On 13/05/2019 11:15, zhoucm1 wrote: ping... for patch set. On 2019年05月13日 17:52, Chunming Zhou wrote: [CAUTION: External Email] Signed-off-by: Chunming Zhou ---   include/drm/amdgpu_drm.h | 9 +   1 file changed, 9

Re: [PATCH 2/2] mm/hmm: Only set FAULT_FLAG_ALLOW_RETRY for non-blocking

2019-05-13 Thread Deucher, Alexander
I reverted all the amdgpu HMM patches for 5.2 because they also depended on this patch: https://cgit.freedesktop.org/~agd5f/linux/commit/?h=drm-next-5.2-wip=ce05ef71564f7cbe270cd4337c36ee720ea534db which did not have a clear line of sight for 5.2 either. Alex

Re: [PATCH 2/2] mm/hmm: Only set FAULT_FLAG_ALLOW_RETRY for non-blocking

2019-05-13 Thread Kuehling, Felix
[Fixed Alex's email address, sorry for getting it wrong first] On 2019-05-13 3:49 p.m., Jerome Glisse wrote: > [CAUTION: External Email] > > Andrew can we get this 2 fixes line up for 5.2 ? > > On Mon, May 13, 2019 at 07:36:44PM +, Kuehling, Felix wrote: >> Hi Jerome, >> >> Do you want me to

Re: [PATCH 3/4] device_cgroup: Export __devcgroup_check_permission

2019-05-13 Thread Kasiviswanathan, Harish
Hello Everyone, Could you please review this patch? Best Regards, Harish On 2019-05-01 10:59 a.m., Kasiviswanathan, Harish wrote: > For AMD compute (amdkfd) driver. > > All AMD compute devices are exported via single device node /dev/kfd. As > a result devices cannot be controlled

Re: [PATCH 2/2] drm/amdgpu: make VCN DPG pause mode detached from general VCN

2019-05-13 Thread Alex Deucher
On Mon, May 13, 2019 at 1:19 PM Liu, Leo wrote: > > It should be attached to VCN 1.0 > > Signed-off-by: Leo Liu > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c | 130 +-- > drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.h | 2 + > drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c | 132

Re: [PATCH 2/2] mm/hmm: Only set FAULT_FLAG_ALLOW_RETRY for non-blocking

2019-05-13 Thread Jerome Glisse
Andrew can we get this 2 fixes line up for 5.2 ? On Mon, May 13, 2019 at 07:36:44PM +, Kuehling, Felix wrote: > Hi Jerome, > > Do you want me to push the patches to your branch? Or are you going to > apply them yourself? > > Is your hmm-5.2-v3 branch going to make it into Linux 5.2? If so,

Re: [RFC PATCH v2 4/5] drm, cgroup: Add total GEM buffer allocation limit

2019-05-13 Thread Daniel Vetter
On Fri, May 10, 2019 at 02:50:39PM -0400, Kenny Ho wrote: > On Fri, May 10, 2019 at 1:48 PM Koenig, Christian > wrote: > > Well another question is why do we want to prevent that in the first place? > > > > I mean the worst thing that can happen is that we account a BO multiple > > times. >

Re: [PATCH] drm/amdkfd: Add missing Polaris10 ID

2019-05-13 Thread Alex Deucher
On Mon, May 13, 2019 at 9:02 AM Russell, Kent wrote: > > This was added to amdgpu but was missed in amdkfd > Change-Id: Iab59ccfd5a42efae18846749deeb7c96490812d4 > > Signed-off-by: Kent Russell Reviewed-by: Alex Deucher > --- > drivers/gpu/drm/amd/amdkfd/kfd_device.c | 1 + > 1 file changed,

Re: [PATCH 3/3] drm/amd/powerplay: support ppfeatures sysfs interface on sw smu routine

2019-05-13 Thread Alex Deucher
On Mon, May 13, 2019 at 3:53 AM Evan Quan wrote: > > Support ppfeatures sysfs interface on Vega20 sw smu routine. > > Change-Id: If67f2d87e7d5aa09cfd61e86df88d5f2f4dd > Signed-off-by: Evan Quan Series is: Reviewed-by: Alex Deucher > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c|

Re: [PATCH] Revert "vgaarb: Keep adding VGA device in queue"

2019-05-13 Thread Daniel Vetter
On Mon, May 13, 2019 at 12:14:29PM +0200, Michel Dänzer wrote: > On 2019-05-10 8:01 p.m., Aaron Ma wrote: > > On 5/10/19 11:46 PM, Michel Dänzer wrote: > >>> Given that the bug is a bit a mess I think we need to add a bit more > >>> context here in the commit message. My understanding: > >>> > >>>

RE: [PATCH 7/8] drm/amdkfd: New IOCTL to allocate queue GWS

2019-05-13 Thread Zeng, Oak
Hi Felix, See comments inline [Oak] Hi Kent, there is one FYI embedded, so be careful when you merge this change back to kfd-staging branch. Regards, Oak -Original Message- From: Kuehling, Felix Sent: Friday, May 10, 2019 4:28 PM To: Zeng, Oak ; amd-gfx@lists.freedesktop.org Cc:

[PATCH 1/2] drm/amdgpu: move the VCN DPG mode read and write to VCN

2019-05-13 Thread Liu, Leo
Since this is VCN specific and only used by VCN Signed-off-by: Leo Liu --- drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.h | 20 drivers/gpu/drm/amd/amdgpu/soc15_common.h | 21 - 2 files changed, 20 insertions(+), 21 deletions(-) diff --git

[PATCH 2/2] drm/amdgpu: make VCN DPG pause mode detached from general VCN

2019-05-13 Thread Liu, Leo
It should be attached to VCN 1.0 Signed-off-by: Leo Liu --- drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c | 130 +-- drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.h | 2 + drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c | 132 +++- 3 files changed, 135 insertions(+), 129

Re: [PATCH 1/2] mm/hmm: support automatic NUMA balancing

2019-05-13 Thread Andrew Morton
On Fri, 10 May 2019 19:53:23 + "Kuehling, Felix" wrote: > From: Philip Yang > > While the page is migrating by NUMA balancing, HMM failed to detect this > condition and still return the old page. Application will use the new > page migrated, but driver pass the old page physical address

Re: [PATCH 4/4] drm/amdkfd: Check against device cgroup

2019-05-13 Thread Roman Gushchin
On Wed, May 01, 2019 at 02:59:29PM +, Kasiviswanathan, Harish wrote: > Participate in device cgroup. All kfd devices are exposed via /dev/kfd. > So use /dev/dri/renderN node. > > Before exposing the device to a task check if it has permission to > access it. If the task (based on its cgroup)

[PATCH] drm/amdgpu/sriov: Need to initialize the HDP_NONSURFACE_BAStE

2019-05-13 Thread Tiecheng Zhou
it requires to initialize HDP_NONSURFACE_BASE, so as to avoid using the value left by a previous VM under sriov scenario. Signed-off-by: Emily Deng Signed-off-by: Tiecheng Zhou --- drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c | 5 + 1 file changed, 5 insertions(+) diff --git

Re: [PATCH 1/2] mm/hmm: support automatic NUMA balancing

2019-05-13 Thread Jerome Glisse
On Mon, May 13, 2019 at 02:27:20PM -0700, Andrew Morton wrote: > On Fri, 10 May 2019 19:53:23 + "Kuehling, Felix" > wrote: > > > From: Philip Yang > > > > While the page is migrating by NUMA balancing, HMM failed to detect this > > condition and still return the old page. Application will

RE: [PATCH 3/3] drm/amd/powerplay: support ppfeatures sysfs interface on sw smu routine

2019-05-13 Thread Huang, Ray
> -Original Message- > From: amd-gfx On Behalf Of Evan > Quan > Sent: Monday, May 13, 2019 3:53 PM > To: amd-gfx@lists.freedesktop.org > Cc: Quan, Evan > Subject: [PATCH 3/3] drm/amd/powerplay: support ppfeatures sysfs > interface on sw smu routine > > Support ppfeatures sysfs