Re: [PATCH 05/18] drm/amd/display: Use mdelay to avoid crashes

2022-12-15 Thread Alex Hung
On 2022-12-15 08:17, Harry Wentland wrote: On 12/15/22 05:29, Michel Dänzer wrote: On 12/15/22 09:09, Christian König wrote: Am 15.12.22 um 00:33 schrieb Alex Hung: On 2022-12-14 16:06, Alex Deucher wrote: On Wed, Dec 14, 2022 at 5:56 PM Alex Hung wrote: On 2022-12-14 15:35, Alex

[PATCH 4/7] drm/amdgpu: don't mess with SDMA clock or powergating in S0ix

2022-12-15 Thread Alex Deucher
It's handled by GFXOFF for SDMA 5.x and SMU saves the state on SDMA 4.x. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c

[PATCH 7/7] Revert "drm/amdgpu: force exit gfxoff on sdma resume for rmb s0ix"

2022-12-15 Thread Alex Deucher
This reverts commit e5d59cfa330523e47cba62a496864acc3948fc27. This is no longer needed since we no longer suspend SDMA during S0ix. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/sdma_v5_2.c | 8 1 file changed, 8 deletions(-) diff --git

[PATCH 2/7] drm/amdgpu/gmc10: don't touch gfxhub registers during S0ix

2022-12-15 Thread Alex Deucher
gfxhub registers are part of gfx IP and should not need to be changed. Doing so without disabling gfxoff can hang the gfx IP. v2: add comments explaining why we can skip the interrupt control for S0i3 Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/gmc_v10_0.c | 36

[PATCH 1/7] drm/amdgpu/gmc9: don't touch gfxhub registers during S0ix

2022-12-15 Thread Alex Deucher
gfxhub registers are part of gfx IP and should not need to be changed. Doing so without disabling gfxoff can hang the gfx IP. v2: add comments explaining why we can skip the interrupt control for S0i3 Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c | 36

[PATCH 5/7] drm/amdgpu: for S0ix, skip SMDA 5.x+ suspend/resume

2022-12-15 Thread Alex Deucher
SDMA 5.x is part of the GFX block so it's controlled via GFXOFF. Skip suspend as it should be handled the same as GFX. v2: drop SDMA 4.x. That requires special handling. Acked-by: Rajneesh Bhardwaj Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 6 ++ 1 file

[PATCH 6/7] Revert "drm/amdgpu: disallow gfxoff until GC IP blocks complete s2idle resume"

2022-12-15 Thread Alex Deucher
This reverts commit f543d28687480fad06b708bc6e0b0b6ec953b078. This is no longer needed since we no longer touch SDMA 5.x for s0i3. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 16 1 file changed, 16 deletions(-) diff --git

[PATCH 3/7] drm/amdgpu/gmc11: don't touch gfxhub registers during S0ix

2022-12-15 Thread Alex Deucher
gfxhub registers are part of gfx IP and should not need to be changed. Doing so without disabling gfxoff can hang the gfx IP. v2: add comments explaining why we can skip the interrupt control for S0i3 Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/gmc_v11_0.c | 16

[PATCH 0/7 v2] Improve S0ix stability

2022-12-15 Thread Alex Deucher
This series improves S0ix stability by avoiding touching registers that should be handled as part of gfxoff. v2: add comments in gmc code to explain why we can skip the vm fault state setting for gfxhub. Alex Deucher (7): drm/amdgpu/gmc9: don't touch gfxhub registers during S0ix

[PATCH] drm/amdgpu: Fixed bug on error when uninstalling amdgpu

2022-12-15 Thread YiPeng Chai
Fixed bug on error when uninstalling amdgpu. The error message is as follows: [ 304.852489] kernel BUG at drivers/gpu/drm/drm_buddy.c:278! [ 304.852503] invalid opcode: [#1] PREEMPT SMP NOPTI [ 304.852510] CPU: 2 PID: 4192 Comm: modprobe Tainted: GW IOE 5.19.0-thomas #1 [

Re: [PATCH] drm/amd/pm: avoid large variable on kernel stack

2022-12-15 Thread Christophe JAILLET
Le 15/12/2022 à 17:36, Arnd Bergmann a écrit : From: Arnd Bergmann The activity_monitor_external[] array is too big to fit on the kernel stack, resulting in this warning with clang: drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu13/smu_v13_0_7_ppt.c:1438:12: error: stack frame size (1040) exceeds

Re: [PATCH] drm/amd/pm: avoid large variable on kernel stack

2022-12-15 Thread Marion & Christophe JAILLET
Le 15/12/2022 à 20:46, Christophe JAILLET a écrit : Le 15/12/2022 à 17:36, Arnd Bergmann a écrit : From: Arnd Bergmann The activity_monitor_external[] array is too big to fit on the kernel stack, resulting in this warning with clang:

Re: [RESEND PATCH] drm/plane-helper: Add the missing declaration of drm_atomic_state

2022-12-15 Thread Ma, Jun
On 12/15/2022 4:40 PM, Thomas Zimmermann wrote: > Hi > > Am 15.12.22 um 04:01 schrieb Ma Jun: >> Add the missing declaration of struct drm_atomic_state to fix the >> compile error below: >> >> error: 'struct drm_atomic_state' declared inside parameter >> list will not be visible outside of

Re: [PATCH 1/7] drm/amdgpu/gmc9: don't touch gfxhub registers during S0ix

2022-12-15 Thread Alex Deucher
On Thu, Dec 15, 2022 at 2:45 AM Christian König wrote: > > Am 14.12.22 um 23:16 schrieb Alex Deucher: > > gfxhub registers are part of gfx IP and should not need to be > > changed. Doing so without disabling gfxoff can hang the gfx IP. > > > > Signed-off-by: Alex Deucher > > --- > >

[PATCH V2] drm/plane-helper: Add the missing declaration of drm_atomic_state

2022-12-15 Thread Ma Jun
Add the missing declaration of struct drm_atomic_state to fix the compile error below: error: 'struct drm_atomic_state' declared inside parameter list will not be visible outside of this definition or declaration [-Werror] Signed-off-by: Ma Jun --- include/drm/drm_plane_helper.h | 1 + 1 file

[pull] amdgpu drm-fixes-6.2

2022-12-15 Thread Alex Deucher
Hi Dave, Daniel, Fixes for 6.2. The following changes since commit 66efff515a6500d4b4976fbab3bee8b92a1137fb: Merge tag 'amd-drm-next-6.2-2022-12-07' of https://gitlab.freedesktop.org/agd5f/linux into drm-next (2022-12-09 12:08:33 +1000) are available in the Git repository at:

Re: [PATCH 05/18] drm/amd/display: Use mdelay to avoid crashes

2022-12-15 Thread Aurabindo Pillai
On 12/15/22 10:17, Harry Wentland wrote: On 12/15/22 05:29, Michel Dänzer wrote: On 12/15/22 09:09, Christian König wrote: Am 15.12.22 um 00:33 schrieb Alex Hung: On 2022-12-14 16:06, Alex Deucher wrote: On Wed, Dec 14, 2022 at 5:56 PM Alex Hung wrote: On 2022-12-14 15:35, Alex Deucher

Re: [PATCH v3 0/3] Adjust ACPI video detection fallback path

2022-12-15 Thread Rafael J. Wysocki
On Thu, Dec 15, 2022 at 8:20 PM Limonciello, Mario wrote: > > [Public] > > > -Original Message- > > From: Limonciello, Mario > > Sent: Thursday, December 8, 2022 10:42 > > To: Rafael J . Wysocki ; Deucher, Alexander > > ; Hans de Goede > > > > Cc: amd-gfx@lists.freedesktop.org;

Re: [PATCH 6/9] drm/qxl: stop using ttm_bo_wait

2022-12-15 Thread Dave Airlie
Acked-by: Dave Airlie On Fri, 16 Dec 2022 at 00:20, Christian König wrote: > > Am 25.11.22 um 11:21 schrieb Christian König: > > TTM is just wrapping core DMA functionality here, remove the mid-layer. > > No functional change. > > Any objections to this guys? > > I'm basically just following a

[PATCH] drm/amd/display: fix dp_retrieve_lttpr_cap return code

2022-12-15 Thread Arnd Bergmann
From: Arnd Bergmann The dp_retrieve_lttpr_cap() return type changed from 'bool' to 'enum dc_status', so now the early 'return' uses the wrong type: drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link_dp.c: In function 'dp_retrieve_lttpr_cap':

[PATCH] drm/amd/display: fix duplicate assignments

2022-12-15 Thread Arnd Bergmann
From: Arnd Bergmann The .set_odm_combine callback pointer was added twice, causing a harmless -Wextra warning: drivers/gpu/drm/amd/amdgpu/../display/dc/dcn314/dcn314_optc.c:258:36: error: initialized field overwritten [-Werror=override-init] 258 | .set_odm_combine =

Re: [PATCH 16/16] drm/amd/display: Don't restrict bpc to 8 bpc

2022-12-15 Thread Alex Deucher
On Thu, Dec 15, 2022 at 4:07 AM Michel Dänzer wrote: > > On 12/14/22 16:46, Alex Deucher wrote: > > On Wed, Dec 14, 2022 at 4:01 AM Pekka Paalanen wrote: > >> On Tue, 13 Dec 2022 18:20:59 +0100 > >> Michel Dänzer wrote: > >>> On 12/12/22 19:21, Harry Wentland wrote: > This will let us pass

Re: [PATCH 16/16] drm/amd/display: Don't restrict bpc to 8 bpc

2022-12-15 Thread Alex Deucher
On Thu, Dec 15, 2022 at 4:17 AM Pekka Paalanen wrote: > > On Wed, 14 Dec 2022 10:46:55 -0500 > Alex Deucher wrote: > > > On Wed, Dec 14, 2022 at 4:01 AM Pekka Paalanen wrote: > > > > > > On Tue, 13 Dec 2022 18:20:59 +0100 > > > Michel Dänzer wrote: > > > > > > > On 12/12/22 19:21, Harry

Re: [PATCH 16/16] drm/amd/display: Don't restrict bpc to 8 bpc

2022-12-15 Thread Michel Dänzer
On 12/15/22 18:33, Alex Deucher wrote: > On Thu, Dec 15, 2022 at 4:17 AM Pekka Paalanen wrote: >> >> On Wed, 14 Dec 2022 10:46:55 -0500 >> Alex Deucher wrote: >> >>> On Wed, Dec 14, 2022 at 4:01 AM Pekka Paalanen wrote: On Tue, 13 Dec 2022 18:20:59 +0100 Michel Dänzer wrote:

[PATCH] drm/amd/pm: avoid large variable on kernel stack

2022-12-15 Thread Arnd Bergmann
From: Arnd Bergmann The activity_monitor_external[] array is too big to fit on the kernel stack, resulting in this warning with clang: drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu13/smu_v13_0_7_ppt.c:1438:12: error: stack frame size (1040) exceeds limit (1024) in

Re: [PATCH 16/16] drm/amd/display: Don't restrict bpc to 8 bpc

2022-12-15 Thread Pekka Paalanen
On Wed, 14 Dec 2022 10:46:55 -0500 Alex Deucher wrote: > On Wed, Dec 14, 2022 at 4:01 AM Pekka Paalanen wrote: > > > > On Tue, 13 Dec 2022 18:20:59 +0100 > > Michel Dänzer wrote: > > > > > On 12/12/22 19:21, Harry Wentland wrote: > > > > This will let us pass kms_hdr.bpc_switch. > > > > >

Re: [PATCH] drm/radeon: Fix screen corruption (v2)

2022-12-15 Thread Luben Tuikov
On 2022-12-15 04:46, Christian König wrote: > Am 15.12.22 um 10:08 schrieb Luben Tuikov: >> On 2022-12-15 03:07, Christian König wrote: >>> Am 15.12.22 um 00:08 schrieb Robin Murphy: On 2022-12-14 22:02, Alex Deucher wrote: > On Wed, Dec 14, 2022 at 4:54 PM Robin Murphy > wrote:

Re: [PATCH 16/16] drm/amd/display: Don't restrict bpc to 8 bpc

2022-12-15 Thread Michel Dänzer
On 12/14/22 16:46, Alex Deucher wrote: > On Wed, Dec 14, 2022 at 4:01 AM Pekka Paalanen wrote: >> On Tue, 13 Dec 2022 18:20:59 +0100 >> Michel Dänzer wrote: >>> On 12/12/22 19:21, Harry Wentland wrote: This will let us pass kms_hdr.bpc_switch. I don't see any good reasons why we

Re: [PATCH] drm/radeon: Fix screen corruption (v2)

2022-12-15 Thread Luben Tuikov
On 2022-12-15 03:07, Christian König wrote: > Am 15.12.22 um 00:08 schrieb Robin Murphy: >> On 2022-12-14 22:02, Alex Deucher wrote: >>> On Wed, Dec 14, 2022 at 4:54 PM Robin Murphy >>> wrote: On 2022-12-12 02:08, Luben Tuikov wrote: > Fix screen corruption on older 32-bit systems

Re: [RESEND PATCH] drm/plane-helper: Add the missing declaration of drm_atomic_state

2022-12-15 Thread Thomas Zimmermann
Hi Am 15.12.22 um 04:01 schrieb Ma Jun: Add the missing declaration of struct drm_atomic_state to fix the compile error below: error: 'struct drm_atomic_state' declared inside parameter list will not be visible outside of this definition or declaration [-Werror] Signed-off-by: Ma Jun ---

Re: [PATCH] drm/radeon: Fix screen corruption (v2)

2022-12-15 Thread Christian König
Am 15.12.22 um 10:08 schrieb Luben Tuikov: On 2022-12-15 03:07, Christian König wrote: Am 15.12.22 um 00:08 schrieb Robin Murphy: On 2022-12-14 22:02, Alex Deucher wrote: On Wed, Dec 14, 2022 at 4:54 PM Robin Murphy wrote: On 2022-12-12 02:08, Luben Tuikov wrote: Fix screen corruption on

Re: [PATCH 05/18] drm/amd/display: Use mdelay to avoid crashes

2022-12-15 Thread Michel Dänzer
On 12/15/22 09:09, Christian König wrote: > Am 15.12.22 um 00:33 schrieb Alex Hung: >> On 2022-12-14 16:06, Alex Deucher wrote: >>> On Wed, Dec 14, 2022 at 5:56 PM Alex Hung wrote: On 2022-12-14 15:35, Alex Deucher wrote: > On Wed, Dec 14, 2022 at 5:25 PM Alex Hung wrote: >> On

Re: [PATCH 05/18] drm/amd/display: Use mdelay to avoid crashes

2022-12-15 Thread Christian König
Am 15.12.22 um 00:33 schrieb Alex Hung: On 2022-12-14 16:06, Alex Deucher wrote: On Wed, Dec 14, 2022 at 5:56 PM Alex Hung wrote: On 2022-12-14 15:35, Alex Deucher wrote: On Wed, Dec 14, 2022 at 5:25 PM Alex Hung wrote: On 2022-12-14 14:54, Alex Deucher wrote: On Wed, Dec 14, 2022

Re: [PATCH] drm/radeon: Fix screen corruption (v2)

2022-12-15 Thread Christian König
Am 15.12.22 um 00:08 schrieb Robin Murphy: On 2022-12-14 22:02, Alex Deucher wrote: On Wed, Dec 14, 2022 at 4:54 PM Robin Murphy wrote: On 2022-12-12 02:08, Luben Tuikov wrote: Fix screen corruption on older 32-bit systems using AGP chips. On older systems with little memory, for instance

[linux-next:master] BUILD REGRESSION 459c73db4069c27c1d4a0e20d055b837396364b8

2022-12-15 Thread kernel test robot
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master branch HEAD: 459c73db4069c27c1d4a0e20d055b837396364b8 Add linux-next specific files for 20221215 Error/Warning reports: https://lore.kernel.org/oe-kbuild-all/202211242120.mzzvguln-...@intel.com https

Re: [PATCH] drm/radeon: Fix screen corruption (v2)

2022-12-15 Thread Luben Tuikov
On 2022-12-15 06:27, Christian König wrote: > Am 15.12.22 um 11:19 schrieb Luben Tuikov: >> On 2022-12-15 04:46, Christian König wrote: >>> Am 15.12.22 um 10:08 schrieb Luben Tuikov: On 2022-12-15 03:07, Christian König wrote: > Am 15.12.22 um 00:08 schrieb Robin Murphy: >> On

Re: [PATCH] drm/radeon: Fix screen corruption (v2)

2022-12-15 Thread Robin Murphy
On 2022-12-15 11:40, Luben Tuikov wrote: On 2022-12-15 06:27, Christian König wrote: Am 15.12.22 um 11:19 schrieb Luben Tuikov: On 2022-12-15 04:46, Christian König wrote: Am 15.12.22 um 10:08 schrieb Luben Tuikov: On 2022-12-15 03:07, Christian König wrote: Am 15.12.22 um 00:08 schrieb

Re: [PATCH] drm/radeon: Fix screen corruption (v2)

2022-12-15 Thread Christian König
Am 15.12.22 um 11:19 schrieb Luben Tuikov: On 2022-12-15 04:46, Christian König wrote: Am 15.12.22 um 10:08 schrieb Luben Tuikov: On 2022-12-15 03:07, Christian König wrote: Am 15.12.22 um 00:08 schrieb Robin Murphy: On 2022-12-14 22:02, Alex Deucher wrote: On Wed, Dec 14, 2022 at 4:54 PM

Re: [PATCH] drm/radeon: Fix screen corruption (v2)

2022-12-15 Thread Luben Tuikov
On 2022-12-15 06:53, Robin Murphy wrote: > On 2022-12-15 11:40, Luben Tuikov wrote: >> On 2022-12-15 06:27, Christian König wrote: >>> Am 15.12.22 um 11:19 schrieb Luben Tuikov: On 2022-12-15 04:46, Christian König wrote: > Am 15.12.22 um 10:08 schrieb Luben Tuikov: >> On 2022-12-15

Re: [PATCH 6/9] drm/qxl: stop using ttm_bo_wait

2022-12-15 Thread Christian König
Am 25.11.22 um 11:21 schrieb Christian König: TTM is just wrapping core DMA functionality here, remove the mid-layer. No functional change. Any objections to this guys? I'm basically just following a suggestion from Daniel here and it already triggered a discussion about the timeout for

Re: [PATCH 5/7] drm/amdgpu: for S0ix, skip SMDA 5.x+ suspend/resume

2022-12-15 Thread Bhardwaj, Rajneesh
Don't we need a similar check on resume_phase2? Other than that, looks good to me. Acked-by: Rajneesh Bhardwaj On 12/14/2022 5:16 PM, Alex Deucher wrote: SDMA 5.x is part of the GFX block so it's controlled via GFXOFF. Skip suspend as it should be handled the same as GFX. v2: drop SDMA

Re: [PATCH 05/18] drm/amd/display: Use mdelay to avoid crashes

2022-12-15 Thread Harry Wentland
On 12/15/22 05:29, Michel Dänzer wrote: > On 12/15/22 09:09, Christian König wrote: >> Am 15.12.22 um 00:33 schrieb Alex Hung: >>> On 2022-12-14 16:06, Alex Deucher wrote: On Wed, Dec 14, 2022 at 5:56 PM Alex Hung wrote: > On 2022-12-14 15:35, Alex Deucher wrote: >> On Wed, Dec

Re: [PATCH 2/2] drm/amd/pm: bump SMU13.0.0 driver_if header to version 0x34

2022-12-15 Thread Deucher, Alexander
[Public] Series is: Acked-by: Alex Deucher From: Quan, Evan Sent: Thursday, December 15, 2022 1:16 AM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Quan, Evan Subject: [PATCH 2/2] drm/amd/pm: bump SMU13.0.0 driver_if header to version 0x34 To

Re: [PATCH 5/7] drm/amdgpu: for S0ix, skip SMDA 5.x+ suspend/resume

2022-12-15 Thread Alex Deucher
On Thu, Dec 15, 2022 at 10:05 AM Bhardwaj, Rajneesh wrote: > > Don't we need a similar check on resume_phase2? The resume code looks to see if the IP was suspended in the first place before trying to resume it so no need. Alex > > Other than that, looks good to me. > > Acked-by: Rajneesh

Re: [PATCH 16/16] drm/amd/display: Don't restrict bpc to 8 bpc

2022-12-15 Thread Michel Dänzer
On 12/15/22 18:42, Michel Dänzer wrote: > On 12/15/22 18:33, Alex Deucher wrote: >> On Thu, Dec 15, 2022 at 4:17 AM Pekka Paalanen wrote: >>> >>> On Wed, 14 Dec 2022 10:46:55 -0500 >>> Alex Deucher wrote: >>> On Wed, Dec 14, 2022 at 4:01 AM Pekka Paalanen wrote: > > On Tue, 13 Dec

Re: [PATCH] drm/amd/display: fix dp_retrieve_lttpr_cap return code

2022-12-15 Thread Michel Dänzer
On 12/15/22 17:37, Arnd Bergmann wrote: > From: Arnd Bergmann > > The dp_retrieve_lttpr_cap() return type changed from 'bool' > to 'enum dc_status', so now the early 'return' uses the wrong > type: > > drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link_dp.c: In function >

Re: [PATCH] drm/amd/pm: avoid large variable on kernel stack

2022-12-15 Thread Alex Deucher
Applied. Thanks! Alex On Thu, Dec 15, 2022 at 11:37 AM Arnd Bergmann wrote: > > From: Arnd Bergmann > > The activity_monitor_external[] array is too big to fit on the > kernel stack, resulting in this warning with clang: > >

Re: [PATCH] drm/amd/display: fix duplicate assignments

2022-12-15 Thread Alex Deucher
Applied. Thanks! Alex On Thu, Dec 15, 2022 at 11:46 AM Arnd Bergmann wrote: > > From: Arnd Bergmann > > The .set_odm_combine callback pointer was added twice, causing > a harmless -Wextra warning: > > drivers/gpu/drm/amd/amdgpu/../display/dc/dcn314/dcn314_optc.c:258:36: error: > initialized

RE: [PATCH v3 0/3] Adjust ACPI video detection fallback path

2022-12-15 Thread Limonciello, Mario
[Public] > -Original Message- > From: Limonciello, Mario > Sent: Thursday, December 8, 2022 10:42 > To: Rafael J . Wysocki ; Deucher, Alexander > ; Hans de Goede > > Cc: amd-gfx@lists.freedesktop.org; linux-a...@vger.kernel.org; Daniel > Dadap ; Limonciello, Mario > > Subject: [PATCH