RE: [PATCH] drm/amdgpu: drop the long-double-128 powerpc check/hack

2023-02-01 Thread Deucher, Alexander
[Public] > -Original Message- > From: amd-gfx On Behalf Of > Daniel Kolesa > Sent: Wednesday, February 1, 2023 1:46 PM > To: linuxppc-...@lists.ozlabs.org > Cc: d...@danny.cz; sta...@vger.kernel.org; > tpear...@raptorengineering.com; amd-gfx@lists.freedesktop.org; >

[pull] amdgpu drm-fixes-6.2

2023-02-01 Thread Alex Deucher
Hi Dave, Daniel, Fixes for 6.2. The following changes since commit 6d796c50f84ca79f1722bb131799e5a5710c4700: Linux 6.2-rc6 (2023-01-29 13:59:43 -0800) are available in the Git repository at: https://gitlab.freedesktop.org/agd5f/linux.git tags/amd-drm-fixes-6.2-2023-02-01 for you to

RE: [linux-next:master] BUILD REGRESSION 66eee64b235411d512bed4d672c2d00683239daf

2023-02-01 Thread Neal Liu
> Hi Neal, > > On Thu, 2 Feb 2023, at 03:17, kernel test robot wrote: > > tree/branch: > > https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git > > master > > branch HEAD: 66eee64b235411d512bed4d672c2d00683239daf Add > linux-

Re: [linux-next:master] BUILD REGRESSION 66eee64b235411d512bed4d672c2d00683239daf

2023-02-01 Thread Andrew Jeffery
Hi Neal, On Thu, 2 Feb 2023, at 03:17, kernel test robot wrote: > tree/branch: > https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git > master > branch HEAD: 66eee64b235411d512bed4d672c2d00683239daf Add linux-next > specific files for 20230201 > > >

Re: [PATCH] drm/amd: Allow s0ix without BIOS support

2023-02-01 Thread Alex Deucher
On Wed, Jan 25, 2023 at 1:33 PM Mario Limonciello wrote: > > We guard the suspend entry code from running unless we have proper > BIOS support for either S3 mode or s0ix mode. > > If a user's system doesn't support either of these modes the kernel > still does offer s2idle in

RE: [PATCH v2] drm/amdgpu/fence: Fix oops due to non-matching drm_sched init/fini

2023-02-01 Thread Chen, Guchun
Reviewed-by: Guchun Chen Regards, Guchun -Original Message- From: Guilherme G. Piccoli Sent: Thursday, February 2, 2023 12:48 AM To: amd-gfx@lists.freedesktop.org Cc: dri-de...@lists.freedesktop.org; Deucher, Alexander ; Koenig, Christian ; Pan, Xinhui ; ker...@gpiccoli.net;

Re: [PATCH v2] drm/amdgpu/fence: Fix oops due to non-matching drm_sched init/fini

2023-02-01 Thread Luben Tuikov
Reviewed-by: Luben Tuikov Regards, Luben On 2023-02-01 11:48, Guilherme G. Piccoli wrote: > Currently amdgpu calls drm_sched_fini() from the fence driver sw fini > routine - such function is expected to be called only after the > respective init function - drm_sched_init() - was executed

[PATCH v2] drm/amdgpu/fence: Fix oops due to non-matching drm_sched init/fini

2023-02-01 Thread Guilherme G. Piccoli
Currently amdgpu calls drm_sched_fini() from the fence driver sw fini routine - such function is expected to be called only after the respective init function - drm_sched_init() - was executed successfully. Happens that we faced a driver probe failure in the Steam Deck recently, and the function

Re: [PATCH] drm/amdgpu/fence: Fix oops due to non-matching drm_sched init/fini

2023-02-01 Thread Guilherme G. Piccoli
On 01/02/2023 13:21, Luben Tuikov wrote: > Hi Guilherme, > > Since setting sched->ready to false, seems to be taking place in, directly > amdgpu_ring_fini() > and in amdgpu_fence_driver_sw_fini() indirectly as that function calls > drm_sched_fini() > which sets it to false, we seem to have two

Re: [PATCH] drm/amdgpu: add more fields into device info, caches sizes, etc.

2023-02-01 Thread Alex Deucher
Looks good to me. WIth a link the mesa MR which uses these, the patch is: Reviewed-by: Alex Deucher For TA_CNTL2, an alternative would be to add this register to the AMDGPU_INFO_READ_MMR_REG and just cache it in the KGD if you think we may need other fields from it in the future. Alex On Mon,

RE: [PATCH] Revert "drm/display/dp_mst: Move all payload info into the atomic state"

2023-02-01 Thread Limonciello, Mario
[AMD Official Use Only - General] > -Original Message- > From: Greg KH > Sent: Sunday, January 29, 2023 07:32 > To: Limonciello, Mario > Cc: Linux regressions mailing list ; dri- > de...@lists.freedesktop.org; sta...@vger.kernel.org; > stanislav.lisovs...@intel.com; Zuo, Jerry ; amd-

[linux-next:master] BUILD REGRESSION 66eee64b235411d512bed4d672c2d00683239daf

2023-02-01 Thread kernel test robot
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master branch HEAD: 66eee64b235411d512bed4d672c2d00683239daf Add linux-next specific files for 20230201 Error/Warning reports: https://lore.kernel.org/oe-kbuild-all/202301300743.bp7dpazv-...@intel.com https

[PATCH] drm/amdgpu: drop the long-double-128 powerpc check/hack

2023-02-01 Thread Daniel Kolesa
Commit c653c591789b ("drm/amdgpu: Re-enable DCN for 64-bit powerpc") introduced this check as a workaround for the driver not building with toolchains that default to 64-bit long double. The reason things worked on 128-bit-long-double toolchains and not otherwise was however largely accidental.

[PATCH] drm/amd/amdgpu: enable athub cg on gc 11.0.3

2023-02-01 Thread Kenneth Feng
enable athub cg on gc 11.0.3 Signed-off-by: Kenneth Feng --- drivers/gpu/drm/amd/amdgpu/soc21.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/soc21.c b/drivers/gpu/drm/amd/amdgpu/soc21.c index 2ea0b9142868..0615fdbf0a64 100644 ---

Re: [RFC PATCH] drm/amdgpu: add force_sg_display module parameter (v2)

2023-02-01 Thread Christian König
Am 27.01.23 um 18:51 schrieb Alex Deucher: Add a module parameter to force sg (scatter/gather) display on APUs. Normally we allow displays in both VRAM and GTT, but this option forces displays into GTT so we can explicitly test more scenarios with GTT. I'm still absolutely not keen to add

Re: [PATCH] drm/amdgpu/fence: Fix oops due to non-matching drm_sched init/fini

2023-02-01 Thread Luben Tuikov
Hi Guilherme, Since setting sched->ready to false, seems to be taking place in, directly amdgpu_ring_fini() and in amdgpu_fence_driver_sw_fini() indirectly as that function calls drm_sched_fini() which sets it to false, we seem to have two competing policies of, "set ready to false to show that

Re: [PATCH] drm/amdgpu/fence: Fix oops due to non-matching drm_sched init/fini

2023-02-01 Thread Alex Deucher
On Wed, Feb 1, 2023 at 2:18 AM Christian König wrote: > > Hi Guchun, > > no, that doesn't make any sense at all. > > The ready flag indicates that the scheduler is fully prepared for hw > submissions from userspace and is unrelated to the initialization > status. It's set to true after IB testing

Re: [PATCH] drm/amdgpu/fence: Fix oops due to non-matching drm_sched init/fini

2023-02-01 Thread Christian König
Am 01.02.23 um 15:24 schrieb Alex Deucher: On Wed, Feb 1, 2023 at 2:18 AM Christian König wrote: Hi Guchun, no, that doesn't make any sense at all. The ready flag indicates that the scheduler is fully prepared for hw submissions from userspace and is unrelated to the initialization status.