[AMD Official Use Only - General]
> -Original Message-
> From: Zhang, Hawking
> Sent: Friday, February 10, 2023 11:02 PM
> To: Zhou1, Tao ; amd-gfx@lists.freedesktop.org; Yang,
> Stanley ; Chai, Thomas ; Li,
> Candice
> Subject: RE: [PATCH] drm/amdgpu: don't increase UMC RAS UE count if
Hi,
On 2/11/23 00:30, Orlando Chamberlain wrote:
> On Fri, 10 Feb 2023 20:19:27 +0100
> Hans de Goede wrote:
>
>> Hi,
>>
>> On 2/10/23 20:09, Hans de Goede wrote:
>>> Hi,
>>>
>>> On 2/10/23 05:48, Orlando Chamberlain wrote:
Currently it manually flips the byte order, but we can instead
On Fri, 10 Feb 2023 14:47:50 -0500
Harry Wentland wrote:
> On 2/10/23 04:28, Pekka Paalanen wrote:
> > On Thu, 9 Feb 2023 13:27:02 -0100
> > Melissa Wen wrote:
> >
> >> On 01/31, Pekka Paalanen wrote:
> >>> On Mon, 9 Jan 2023 14:38:09 -0100
> >>> Melissa Wen wrote:
> >>>
> On
Freeing memory was warned during suspend.
Move the self test out of suspend.
Link: https://bugzilla.redhat.com/show_bug.cgi?id=2151825
Cc: jfale...@redhat.com
Signed-off-by: Jack Xiao
---
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 3 +++
drivers/gpu/drm/amd/amdgpu/mes_v11_0.c | 2 +-
2
On Thu, Feb 9, 2023 at 10:17 PM Leo Li wrote:
>
> Hi Mikhail, seems like your report flew past me, thanks for the ping.
>
> This might be a simple issue of not backing off when deadlock was hit.
> drm_atomic_normalize_zpos() can return an error code, and I ignored it
> (oops!)
>
> Can you give
On 2/10/2023 2:15 PM, Tao Zhou wrote:
If a UMC bad page is reserved but not freed by an application, the
application may trigger uncorrectable error repeatly by accessing the page.
There is amdgpu_ras_check_bad_page which checks if address is already
part of an existing bad page. Can't
On Mon, Feb 13, 2023 at 11:01:31AM +0200, Pekka Paalanen wrote:
> On Fri, 10 Feb 2023 14:47:50 -0500
> Harry Wentland wrote:
>
> > On 2/10/23 04:28, Pekka Paalanen wrote:
> > > On Thu, 9 Feb 2023 13:27:02 -0100
> > > Melissa Wen wrote:
> > >
> > >> On 01/31, Pekka Paalanen wrote:
> > >>>
[Public]
Hi all,
This week this patchset was tested on the following systems:
Lenovo Thinkpad T14s Gen2, with AMD Ryzen 5 5650U
Lenovo Thinkpad T13s Gen4 with AMD Ryzen 5 6600U
Reference AMD RX6800
These systems were tested on the following display types:
eDP, (1080p 60hz [5650U])
From: Leo Li
[Why]
drm_atomic_normalize_zpos() can return an error code when there's
modeset lock contention. This was being ignored.
[How]
Bail out of atomic check if normalize_zpos() returns an error.
Fixes: b261509952bc ("drm/amd/display: Fix double cursor on non-video RGB MPO")
Am 13.02.23 um 11:52 schrieb Jack Xiao:
Freeing memory was warned during suspend.
Move the self test out of suspend.
Link: https://bugzilla.redhat.com/show_bug.cgi?id=2151825
Cc: jfale...@redhat.com
Signed-off-by: Jack Xiao
Reviewed-by: Christian König
---
On 2/13/23 10:51, sunpeng...@amd.com wrote:
From: Leo Li
[Why]
drm_atomic_normalize_zpos() can return an error code when there's
modeset lock contention. This was being ignored.
[How]
Bail out of atomic check if normalize_zpos() returns an error.
Fixes: b261509952bc ("drm/amd/display: Fix
Applied. Thanks.
On Thu, Feb 9, 2023 at 7:59 PM Yang Li wrote:
>
> ./drivers/gpu/drm/amd/display/dc/link/protocols/link_dp_capability.c:1610:68-73:
> WARNING: conversion to bool not needed here
>
> Reported-by: Abaci Robot
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=4025
>
Applied. Thanks!
On Thu, Feb 9, 2023 at 8:06 PM Yang Li wrote:
>
> drivers/gpu/drm/amd/amdgpu/../display/dc/link/link_factory.c:145
> get_ddc_line() warn: inconsistent indenting
> drivers/gpu/drm/amd/amdgpu/../display/dc/link/link_factory.c:201
> dc_link_construct_phy() warn: inconsistent
Applied. Thanks!
On Thu, Feb 9, 2023 at 9:28 PM Jiapeng Chong
wrote:
>
> Variable ds_port is not effectively used, so delete it.
>
> drivers/gpu/drm/amd/amdgpu/../display/dc/link/protocols/link_dp_capability.c:280:35:
> warning: variable ‘ds_port’ set but not used.
>
> Reported-by: Abaci Robot
Applied. Thanks!
On Thu, Feb 9, 2023 at 9:44 PM Jiapeng Chong
wrote:
>
> Variable pre_connection_type is not effectively used, so delete it.
>
> Reported-by: Abaci Robot
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=4031
> Signed-off-by: Jiapeng Chong
> ---
>
tree/branch:
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
branch HEAD: 09e41676e35ab06e4bce8870ea3bf1f191c3cb90 Add linux-next specific
files for 20230213
Error/Warning reports:
https://lore.kernel.org/oe-kbuild-all/202301300743.bp7dpazv-...@intel.com
https
On 02/10, Pekka Paalanen wrote:
> On Thu, 9 Feb 2023 13:27:02 -0100
> Melissa Wen wrote:
>
> > On 01/31, Pekka Paalanen wrote:
> > > On Mon, 9 Jan 2023 14:38:09 -0100
> > > Melissa Wen wrote:
> > >
> > > > On 01/09, Melissa Wen wrote:
> > > > > Hi,
> > > > >
> > > > > After collecting
On 02/13, Ville Syrjälä wrote:
> On Mon, Feb 13, 2023 at 11:01:31AM +0200, Pekka Paalanen wrote:
> > On Fri, 10 Feb 2023 14:47:50 -0500
> > Harry Wentland wrote:
> >
> > > On 2/10/23 04:28, Pekka Paalanen wrote:
> > > > On Thu, 9 Feb 2023 13:27:02 -0100
> > > > Melissa Wen wrote:
> > > >
> >
Hi,
This series resolve some of the warnings that appear when compiling AMDGPU
with W=1.
Each patch is focused in a specific warning.
This is my First Patch for the GSoC Project Idea about increasing code
coverage of the DRM code[1].
Thanks for reviewing!
Best regards,
Arthur Grillo
[1]:
Turn global functions that are only used locally into static ones. This
reduces the number of -Wmissing-prototypes warnings.
Signed-off-by: Arthur Grillo
---
drivers/gpu/drm/amd/display/dc/clk_mgr/dcn315/dcn315_clk_mgr.c | 2 +-
drivers/gpu/drm/amd/display/dc/irq/dcn201/irq_service_dcn201.c | 2
Add function prototypes to headers to reduce the number of
-Wmissing-prototypes warnings.
Signed-off-by: Arthur Grillo
---
drivers/gpu/drm/amd/display/dc/dcn31/dcn31_hubbub.h | 2 ++
drivers/gpu/drm/amd/display/dc/dcn32/dcn32_hubbub.h | 2 ++
drivers/gpu/drm/amd/display/dc/dcn32/dcn32_hubp.h
Add function prototypes to headers to reduce the number of
-Wmissing-prototypes warnings.
Signed-off-by: Arthur Grillo
---
drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.h
Add includes that were previously missing to reduce the number of
-Wmissing-prototypes warnings.
Signed-off-by: Arthur Grillo
---
drivers/gpu/drm/amd/display/dc/dcn32/dcn32_init.c | 1 +
drivers/gpu/drm/amd/display/dc/link/accessories/link_dp_trace.c | 1 +
2 files changed, 2
Remove arguments present on kernel-doc that are not present on the
function declaration and add the new ones if present.
Signed-off-by: Arthur Grillo
---
drivers/gpu/drm/amd/amdgpu/sdma_v6_0.c| 15 +++
drivers/gpu/drm/amd/display/dc/dc_dmub_srv.c | 2 +-
Make implicit enum conversion to avoid -Wenum-conversion warning, such
as:
drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn21/display_mode_vba_21.c:4109:88:
warning: implicit conversion from ‘enum ’ to ‘enum
odm_combine_mode’ [-Wenum-conversion]
4109 |
Deal with return value of an allocation. This reduces the number of
-Wunused-but-set-variable warnings.
Signed-off-by: Arthur Grillo
---
drivers/gpu/drm/amd/amdgpu/amdgpu_mes.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_mes.c
Remove local variables that were just set but were never used. This
decrease the number of -Wunused-but-set-variable warnings.
Signed-off-by: Arthur Grillo
---
drivers/gpu/drm/amd/display/dc/dcn10/dcn10_link_encoder.c | 3 ---
drivers/gpu/drm/amd/display/dc/dcn201/dcn201_dpp.c | 7
Am 13.02.23 um 21:49 schrieb Arthur Grillo:
Deal with return value of an allocation. This reduces the number of
-Wunused-but-set-variable warnings.
Signed-off-by: Arthur Grillo
---
drivers/gpu/drm/amd/amdgpu/amdgpu_mes.c | 2 ++
1 file changed, 2 insertions(+)
diff --git
On Mon, Feb 13, 2023 at 3:50 PM Arthur Grillo wrote:
>
> Remove local variables that were just set but were never used. This
> decrease the number of -Wunused-but-set-variable warnings.
>
> Signed-off-by: Arthur Grillo
> ---
> drivers/gpu/drm/amd/display/dc/dcn10/dcn10_link_encoder.c | 3 ---
>
APUs before Raven didn't support s0ix. As we just relieved some
of the safety checks for s0ix to improve power consumption on
APUs that support it but that are missing BIOS support a new
blind spot was introduced that a user could "try" to run s0ix.
Plug this hole so that if users try to run
Reviewed-by: Feifei Xu
-Original Message-
From: amd-gfx On Behalf Of Jack Xiao
Sent: Monday, February 13, 2023 6:52 PM
To: amd-gfx@lists.freedesktop.org
Cc: Xiao, Jack ; jfale...@redhat.com
Subject: [PATCH] drm/amd/amdgpu: fix warining during suspend
Freeing memory was warned during
> -Original Message-
> From: Lazar, Lijo
> Sent: Monday, February 13, 2023 8:38 PM
> To: Zhou1, Tao ; amd-gfx@lists.freedesktop.org; Zhang,
> Hawking ; Yang, Stanley
> ; Chai, Thomas ; Li, Candice
>
> Subject: Re: [PATCH] drm/amdgpu: don't increase UMC RAS UE count if no new
> bad page
[AMD Official Use Only - General]
> -Original Message-
> From: Zhou1, Tao
> Sent: Monday, February 13, 2023 4:25 PM
> To: Zhang, Hawking ; amd-
> g...@lists.freedesktop.org; Yang, Stanley ; Chai,
> Thomas ; Li, Candice
> Subject: RE: [PATCH] drm/amdgpu: don't increase UMC RAS UE count
[AMD Official Use Only - General]
Reviewed-and-tested-by: Evan Quan
> -Original Message-
> From: amd-gfx On Behalf Of Jack
> Xiao
> Sent: Monday, February 13, 2023 6:52 PM
> To: amd-gfx@lists.freedesktop.org
> Cc: Xiao, Jack ; jfale...@redhat.com
> Subject: [PATCH] drm/amd/amdgpu: fix
On 2/14/2023 7:56 AM, Zhou1, Tao wrote:
-Original Message-
From: Lazar, Lijo
Sent: Monday, February 13, 2023 8:38 PM
To: Zhou1, Tao ; amd-gfx@lists.freedesktop.org; Zhang,
Hawking ; Yang, Stanley
; Chai, Thomas ; Li, Candice
Subject: Re: [PATCH] drm/amdgpu: don't increase UMC RAS
> -Original Message-
> From: Lazar, Lijo
> Sent: Tuesday, February 14, 2023 12:55 PM
> To: Zhou1, Tao ; amd-gfx@lists.freedesktop.org; Zhang,
> Hawking ; Yang, Stanley
> ; Chai, Thomas ; Li, Candice
>
> Subject: Re: [PATCH] drm/amdgpu: don't increase UMC RAS UE count if no new
> bad
On 2/14/2023 11:42 AM, Zhou1, Tao wrote:
-Original Message-
From: Lazar, Lijo
Sent: Tuesday, February 14, 2023 12:55 PM
To: Zhou1, Tao ; amd-gfx@lists.freedesktop.org; Zhang,
Hawking ; Yang, Stanley
; Chai, Thomas ; Li, Candice
Subject: Re: [PATCH] drm/amdgpu: don't increase UMC
When building on OpenBSD/arm64 with clang 15, unaligned access
warnings are seen when a union is embedded inside a packed struct.
drm/amd/display/dmub/inc/dmub_cmd.h:941:18: error: field
cursor_copy_src within 'struct dmub_rb_cmd_mall' is less aligned than
'union dmub_addr' and is usually due
When building on OpenBSD/arm64 with clang 15, unaligned access
warnings are seen when a union is embedded inside a packed struct.
drm/amd/pm/powerplay/hwmgr/vega20_pptable.h:136:17: error: field
smcPPTable within 'struct _ATOM_VEGA20_POWERPLAYTABLE' is less aligned
than 'PPTable_t' and is
Hi guys,
this is an extract from Amar's earlier patch set with quite some
re-ordering, bug fixes and separating changes into smaller patches.
Background is that we want to use GEM/TTM to manage all kind of
resources which most are not accounted in pages but rather bytes or even
arbitary units
Instead of resource->start use the cursor to get this.
v2 (chk): remove changes to amdgpu_bo_gpu_offset_no_check(), that
won't work with the AGP aperture otherwise.
Signed-off-by: Somalapuram Amaranath
Reviewed-by: Christian König
Signed-off-by: Christian König
---
From: Somalapuram Amaranath
Change the parameters of ttm_range_man_init_nocheck()
size from page size to byte size.
Cleanup the PAGE_SHIFT operation on the depended caller functions.
Signed-off-by: Somalapuram Amaranath
Reviewed-by: Christian König
---
drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
From: Somalapuram Amaranath
Change the ttm_range_man_alloc() allocation from pages to size in bytes.
Fix the dependent drm_mm_nodes start and size from pages to bytes.
v2 (chk): Change the drm_mm_node usage in amdgpu as well. re-order the
patch to be independent of the resource->start
added a sysfs interface for thermal throttling, then userspace can get/update
thermal limit
Jira ID: SWDEV-354511
Signed-off-by: Kun Liu
Change-Id: I9948cb8966b731d2d74d7aad87cbcdc840dd34c8
---
.../gpu/drm/amd/include/kgd_pp_interface.h| 2 +
drivers/gpu/drm/amd/pm/amdgpu_dpm.c
44 matches
Mail list logo
