[PATCH 2/2] drm/amdgpu: added a sysfs interface for thermal throttling

2023-02-14 Thread kunliu13
implement apu_thermal_cap r/w callback for vangogh Jira ID: SWDEV-354511 Signed-off-by: Kun Liu --- .../gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c | 23 +++ 1 file changed, 23 insertions(+) diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c

Re: [PATCH 2/2] drm/amdgpu: added a sysfs interface for thermal throttling

2023-02-14 Thread Christian König
Am 14.02.23 um 09:02 schrieb kunliu13: implement apu_thermal_cap r/w callback for vangogh Jira ID: SWDEV-354511 Signed-off-by: Kun Liu --- .../gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c | 23 +++ 1 file changed, 23 insertions(+) diff --git

RE: [PATCH 2/2] drm/amdgpu: added a sysfs interface for thermal throttling

2023-02-14 Thread Quan, Evan
[AMD Official Use Only - General] > -Original Message- > From: kunliu13 > Sent: Tuesday, February 14, 2023 4:03 PM > To: Limonciello, Mario ; Liang, Richard qi > ; Yuan, Perry ; amd- > g...@lists.freedesktop.org > Cc: Deucher, Alexander ; Du, Xiaojian > ; Quan, Evan ; Liu, Kun > >

RE: [PATCH 1/2] drm/amdgpu: added a sysfs interface for thermal throttling

2023-02-14 Thread Quan, Evan
[AMD Official Use Only - General] > -Original Message- > From: kunliu13 > Sent: Tuesday, February 14, 2023 3:54 PM > To: Limonciello, Mario ; Liang, Richard qi > ; Yuan, Perry ; amd- > g...@lists.freedesktop.org > Cc: Deucher, Alexander ; Du, Xiaojian > ; Quan, Evan ; Liu, Kun > >

Re: [RFC PATCH v2 00/18] Add DRM CRTC 3D LUT interface

2023-02-14 Thread Pekka Paalanen
On Mon, 13 Feb 2023 18:26:55 -0100 Melissa Wen wrote: > On 02/10, Pekka Paalanen wrote: > > On Thu, 9 Feb 2023 13:27:02 -0100 > > Melissa Wen wrote: > > > > > On 01/31, Pekka Paalanen wrote: > > > > On Mon, 9 Jan 2023 14:38:09 -0100 > > > > Melissa Wen wrote: > > > > > > > > > On

Re: [RFC PATCH v2 00/18] Add DRM CRTC 3D LUT interface

2023-02-14 Thread Pekka Paalanen
On Mon, 13 Feb 2023 18:45:40 -0100 Melissa Wen wrote: > On 02/13, Ville Syrjälä wrote: > > On Mon, Feb 13, 2023 at 11:01:31AM +0200, Pekka Paalanen wrote: > > > On Fri, 10 Feb 2023 14:47:50 -0500 > > > Harry Wentland wrote: > > > > > > > On 2/10/23 04:28, Pekka Paalanen wrote: > > > > >

RE: [PATCH] drm/amdgpu: don't increase UMC RAS UE count if no new bad page

2023-02-14 Thread Zhang, Hawking
[AMD Official Use Only - General] -EINVAL looks better than EEXIST, but it still doesn't fit the case? Alternatively, Can we compare the count before and after amdgpu_ras_add_bad_pages to decide whether reset ue_count to 0 or not. That could be straightforward than struggling for returning

Re: [PATCH] drm/amd/amdgpu: fix warining during suspend

2023-02-14 Thread Jocelyn Falempe
On 13/02/2023 11:52, Jack Xiao wrote: Freeing memory was warned during suspend. Move the self test out of suspend. Thanks a lot, this fixes the following warning during suspend/resume on v6.2-rc8 WARNING: CPU: 2 PID: 3980 at drivers/gpu/drm/amd/amdgpu/amdgpu_object.c:425

RE: [PATCH] drm/amdgpu: don't increase UMC RAS UE count if no new bad page

2023-02-14 Thread Zhou1, Tao
[AMD Official Use Only - General] OK, I'll add a new function to do the check. Tao > -Original Message- > From: Zhang, Hawking > Sent: Tuesday, February 14, 2023 6:03 PM > To: Yang, Stanley ; Zhou1, Tao > ; amd-gfx@lists.freedesktop.org; Chai, Thomas > ; Li, Candice > Subject: RE:

Re: [Intel-gfx] [PATCH 3/3] drm/ttm: Change the meaning of the fields in the drm_mm_nodes structure from pfn to bytes v2

2023-02-14 Thread Matthew Auld
On Tue, 14 Feb 2023 at 07:43, Christian König wrote: > > From: Somalapuram Amaranath > > Change the ttm_range_man_alloc() allocation from pages to size in bytes. > Fix the dependent drm_mm_nodes start and size from pages to bytes. > > v2 (chk): Change the drm_mm_node usage in amdgpu as well.

Re: [Intel-gfx] [PATCH 3/3] drm/ttm: Change the meaning of the fields in the drm_mm_nodes structure from pfn to bytes v2

2023-02-14 Thread Christian König
Am 14.02.23 um 11:31 schrieb Matthew Auld: On Tue, 14 Feb 2023 at 07:43, Christian König wrote: From: Somalapuram Amaranath Change the ttm_range_man_alloc() allocation from pages to size in bytes. Fix the dependent drm_mm_nodes start and size from pages to bytes. v2 (chk): Change the

RE: [RFC PATCH v2 00/18] Add DRM CRTC 3D LUT interface

2023-02-14 Thread Sharma, Shashank
[AMD Official Use Only - General] + Uday, for awareness. Regards Shashank -Original Message- From: Pekka Paalanen Sent: 14 February 2023 10:28 To: Melissa Wen Cc: Ville Syrjälä ; dri-de...@lists.freedesktop.org; airl...@gmail.com; laurent.pinchart+rene...@ideasonboard.com; Sharma,

Re: [PATCH 06/10] drm/amd/display: Fix implicit enum conversion

2023-02-14 Thread Michel Dänzer
On 2/13/23 21:49, Arthur Grillo wrote: > Make implicit enum conversion to avoid -Wenum-conversion warning, such > as: > > drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn21/display_mode_vba_21.c:4109:88: > warning: implicit conversion from ‘enum ’ to ‘enum > odm_combine_mode’

[PATCH 0/6] Trivial code cleanup around color resources

2023-02-14 Thread Melissa Wen
Hi, Sorry for the noise, but while I've been working on wiring 3D LUT support to AMD display driver [1] I found some annoying code style issues in the shared-code part. So I'm just sending what I've been cleaning to better examine the code. Most seem trivial, except the last one "remove unused

[PATCH 1/6] drm/amd/display: ident braces in dcn30_acquire_post_bldn_3dlut correctly

2023-02-14 Thread Melissa Wen
Signed-off-by: Melissa Wen --- drivers/gpu/drm/amd/display/dc/dcn30/dcn30_resource.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/dc/dcn30/dcn30_resource.c b/drivers/gpu/drm/amd/display/dc/dcn30/dcn30_resource.c index feb4bb491525..60bb5634b6e2

[PATCH 3/6] drm/amd/display: camel case cleanup in color_gamma file

2023-02-14 Thread Melissa Wen
Rename mapUserRamp to map_user_ramp and doClamping to do_clamping Signed-off-by: Melissa Wen --- .../amd/display/modules/color/color_gamma.c | 50 ++- 1 file changed, 26 insertions(+), 24 deletions(-) diff --git a/drivers/gpu/drm/amd/display/modules/color/color_gamma.c

[PATCH 5/6] drm/amd/display: remove unused func declaration from resource headers

2023-02-14 Thread Melissa Wen
The function resource_validate_ctx_update_pointer_after_copy() is declared in resource.h but never defined, therefore, remove its declaration from headers. Signed-off-by: Melissa Wen --- drivers/gpu/drm/amd/display/dc/inc/resource.h | 4 1 file changed, 4 deletions(-) diff --git

[PATCH 2/6] drm/amd/display: clean code-style issues in dcn30_set_mpc_shaper_3dlut

2023-02-14 Thread Melissa Wen
This function has many conditions and all code style issues (identation, missing braces, etc.) make reading it really annoying. Signed-off-by: Melissa Wen --- .../drm/amd/display/dc/dcn30/dcn30_hwseq.c| 37 ++- 1 file changed, 19 insertions(+), 18 deletions(-) diff --git

[PATCH 4/6] drm/amd/display: unset initial value for tf since it's never used

2023-02-14 Thread Melissa Wen
In mod_color_calculate_{degamma/regamma}_params(), a tf variable is initialized as TRANSFER_FUNCTION_SRGB but tf is only used after tf = input->tf, therefore, better to just remove this initial value and avoid misleading interpretations. Signed-off-by: Melissa Wen ---

[PATCH 6/6] drm/amd/display: remove unused _calculate_degamma_curve function

2023-02-14 Thread Melissa Wen
We don't use this function anywhere, therefore, remove it. Signed-off-by: Melissa Wen --- .../amd/display/modules/color/color_gamma.c | 86 --- .../amd/display/modules/color/color_gamma.h | 3 - 2 files changed, 89 deletions(-) diff --git

Re: [PATCH 0/6] Trivial code cleanup around color resources

2023-02-14 Thread Christian König
Am 14.02.23 um 13:14 schrieb Melissa Wen: Hi, Sorry for the noise, but while I've been working on wiring 3D LUT support to AMD display driver [1] I found some annoying code style issues in the shared-code part. So I'm just sending what I've been cleaning to better examine the code. Most seem

[PATCH] drm/gem: Expose the buffer object handle to userspace last

2023-02-14 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Currently drm_gem_handle_create_tail exposes the handle to userspace before the buffer object constructions is complete. This allowing of working against a partially constructed object, which may also be in the process of having its creation fail, can have a range of

Re: [PATCH] drm/gem: Expose the buffer object handle to userspace last

2023-02-14 Thread Christian König
Am 14.02.23 um 13:50 schrieb Tvrtko Ursulin: From: Tvrtko Ursulin Currently drm_gem_handle_create_tail exposes the handle to userspace before the buffer object constructions is complete. This allowing of working against a partially constructed object, which may also be in the process of having

Re: [PATCH 3/3] drm/connector: Deprecate split for BT.2020 in drm_colorspace enum

2023-02-14 Thread Sebastian Wick
On Fri, Feb 3, 2023 at 5:00 PM Ville Syrjälä wrote: > > On Fri, Feb 03, 2023 at 10:24:52AM -0500, Harry Wentland wrote: > > > > > > On 2/3/23 10:19, Ville Syrjälä wrote: > > > On Fri, Feb 03, 2023 at 09:39:42AM -0500, Harry Wentland wrote: > > >> > > >> > > >> On 2/3/23 07:59, Sebastian Wick

[PATCH v2 0/8] Re-design doorbell framework for usermode queues

2023-02-14 Thread Shashank Sharma
From: Shashank Sharma This patch series re-designs the current doorbell handling of the AMDGPU driver and prepares it for Usermode queues. The fundamental changes are: - Introduce and accommodate a new GEM domain for doorbells. - Prepare the AMDGPU ttm backend for handling doorbell memory. -

[PATCH v2 2/8] drm/amdgpu: replace aper_base_kaddr with vram_aper_base_kaddr

2023-02-14 Thread Shashank Sharma
From: Alex Deucher To differentiate it from the doorbell BAR. V2: Added Christian's A-B Acked-by: Christian Koenig Cc: Alex Deucher Cc: Christian Koenig Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 10 +- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c

[PATCH v2 6/8] drm/amdgpu: get doorbell memory

2023-02-14 Thread Shashank Sharma
From: Alex Deucher This patch adds section for doorbell memory in memory status reporting functions like vm/bo_get_memory. V2: Rebase Cc: Alex Deucher Cc: Christian Koenig Signed-off-by: Alex Deucher Signed-off-by: Shashank Sharma --- drivers/gpu/drm/amd/amdgpu/amdgpu_fdinfo.c | 4 ++--

[PATCH v2 1/8] drm/amdgpu: add UAPI for allocating doorbell memory

2023-02-14 Thread Shashank Sharma
From: Alex Deucher This patch adds flags for a new gem domain AMDGPU_GEM_DOMAIN_DOORBELL in the UAPI layer. V2: Drop 'memory' from description (Christian) Cc: Alex Deucher Cc: Christian Koenig Signed-off-by: Alex Deucher --- include/uapi/drm/amdgpu_drm.h | 7 ++- 1 file changed, 6

[PATCH v2 5/8] drm/amdgpu: accommodate DOMAIN/PL_DOORBELL

2023-02-14 Thread Shashank Sharma
From: Alex Deucher This patch adds changes: - to accommodate the new GEM domain DOORBELL - to accommodate the new TTM PL DOORBELL to manage doorbell allocations as GEM Objects. V2: Addressed reviwe comments from Christian - drop the doorbell changes for pinning/unpinning - drop the

[PATCH v2 3/8] drm/amdgpu: rename gmc.aper_base/size

2023-02-14 Thread Shashank Sharma
From: Alex Deucher This patch renames aper_base and aper_size parameters (in adev->gmc), to vram_aper_base and vram_aper_size, to differentiate it from the doorbell BAR. V2: rebase Cc: Alex Deucher Cc: Christian Koenig Signed-off-by: Alex Deucher Signed-off-by: Shashank Sharma ---

[PATCH v2 7/8] drm/amdgpu: create doorbell kernel object

2023-02-14 Thread Shashank Sharma
From: Shashank Sharma This patch does the following: - Initializes TTM range management for domain DOORBELL. - Introduces a kernel bo for doorbell management in form of mman.doorbell_kernel_bo. This bo holds the kernel doorbell space now. - Removes ioremapping of doorbell-kernel memory, as

[PATCH v2 8/8] drm/amdgpu: start using kernel doorbell bo

2023-02-14 Thread Shashank Sharma
From: Shashank Sharma This patch does the following: - Adds new variables like mman.doorbell_bo_size/gpu_addr/cpu_addr. The cpu_addr ptr will be used now for doorbell read/write from doorbell BAR. - Adjusts the existing code to use kernel doorbell BO's size and its cpu_address. Cc: Alex

[PATCH v2 4/8] drm/amdgpu: rename doorbell variables

2023-02-14 Thread Shashank Sharma
From: Alex Deucher This patch: - renames the adev->doorbell.base to adev->doorbell.doorbell_aper_base - renames the adev->doorbell.size to adev->doorbell.doorbell_aper_size - moves the adev->doorbell.ptr to adev->mman.doorbell_aper_base_kaddr rest of the changes are just to accommodate these

Re: [PATCH] drm/amdgpu: remove TOPDOWN flags when allocating VRAM in large bar system

2023-02-14 Thread Christian König
Am 15.02.23 um 06:25 schrieb Shane Xiao: Since VRAM manager is changed from drm mm to drm buddy, the TOP_DOWN flag should not be set by default in the large bar system. Removing this flag helps improve drm buddy allactor efficiency and reduce the risk of splitting higher order block into lower

[PATCH] drm/amd/pm: re-enable ac/dc on smu_v13_0_0/10

2023-02-14 Thread Kenneth Feng
re-enable ac/dc on smu_v13_0_0/10 Signed-off-by: Kenneth Feng --- drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_0_ppt.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_0_ppt.c b/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_0_ppt.c index

Re: [PATCH v2 8/8] drm/amdgpu: start using kernel doorbell bo

2023-02-14 Thread Christian König
Am 14.02.23 um 20:28 schrieb Shashank Sharma: On 14/02/2023 19:40, Christian König wrote: Am 14.02.23 um 17:15 schrieb Shashank Sharma: From: Shashank Sharma This patch does the following: - Adds new variables like mman.doorbell_bo_size/gpu_addr/cpu_addr.    The cpu_addr ptr will be used

[PATCH] drm/amdgpu: remove TOPDOWN flags when allocating VRAM in large bar system

2023-02-14 Thread Shane Xiao
Since VRAM manager is changed from drm mm to drm buddy, the TOP_DOWN flag should not be set by default in the large bar system. Removing this flag helps improve drm buddy allactor efficiency and reduce the risk of splitting higher order block into lower order. Signed-off-by: Shane Xiao ---

Re: [PATCH v2 5/8] drm/amdgpu: accommodate DOMAIN/PL_DOORBELL

2023-02-14 Thread Christian König
Am 14.02.23 um 20:24 schrieb Shashank Sharma: On 14/02/2023 19:31, Christian König wrote: Am 14.02.23 um 17:15 schrieb Shashank Sharma: From: Alex Deucher This patch adds changes: - to accommodate the new GEM domain DOORBELL - to accommodate the new TTM PL DOORBELL to manage doorbell

[PATCH] Revert "drm/amd/display: enable DPG when disabling plane for phantom pipe"

2023-02-14 Thread Qingqing Zhuo
This reverts commit b73cf50bd1d0008027cc1b41881b671d9c9054b9. regression detected by the change. Revert until fix is available. Signed-off-by: Qingqing Zhuo --- drivers/gpu/drm/amd/display/dc/core/dc.c | 47 +--- 1 file changed, 1 insertion(+), 46 deletions(-) diff --git

Re: [PATCH] drm/amd/display: Remove duplicate/repeating expressions

2023-02-14 Thread Alex Deucher
Applied. Thanks! Alex On Fri, Feb 10, 2023 at 2:37 PM Harry Wentland wrote: > > On 2/10/23 05:00, Deepak R Varma wrote: > > Remove duplicate or repeating expressions in the if condition > > evaluation. Issue identified using doubletest.cocci Coccinelle semantic > > patch. > > > >

Re: [PATCH] drm/amd/display: Remove duplicate/repeating expression

2023-02-14 Thread Alex Deucher
Applied. Thanks! On Fri, Feb 10, 2023 at 10:22 AM Harry Wentland wrote: > > On 2/10/23 05:11, Deepak R Varma wrote: > > Remove duplicate or repeating expressions in the if condition > > evaluation. Issue identified using doubletest.cocci Coccinelle semantic > > patch. > > > > Signed-off-by:

Re: [PATCH] drm/amd/pm: avoid unaligned access warnings

2023-02-14 Thread Alex Deucher
Applied. Thanks! Alex On Tue, Feb 14, 2023 at 1:58 AM Jonathan Gray wrote: > > When building on OpenBSD/arm64 with clang 15, unaligned access > warnings are seen when a union is embedded inside a packed struct. > > drm/amd/pm/powerplay/hwmgr/vega20_pptable.h:136:17: error: field > smcPPTable

Re: [PATCH 3/3] drm/connector: Deprecate split for BT.2020 in drm_colorspace enum

2023-02-14 Thread Ville Syrjälä
On Tue, Feb 14, 2023 at 10:18:49PM +0100, Sebastian Wick wrote: > On Tue, Feb 14, 2023 at 9:10 PM Ville Syrjälä > wrote: > > > > On Tue, Feb 14, 2023 at 08:45:00PM +0100, Sebastian Wick wrote: > > > On Tue, Feb 14, 2023 at 5:57 PM Harry Wentland > > > wrote: > > > > > > > > > > > > > > > > On

RE: [PATCH 1/2] drm/amdgpu: optimize VRAM allocation when using drm buddy

2023-02-14 Thread Xiao, Shane
For public review > -Original Message- > From: Koenig, Christian > Sent: Wednesday, February 15, 2023 3:02 AM > To: Xiao, Shane ; Paneer Selvam, Arunpravin > > Subject: Re: [PATCH 1/2] drm/amdgpu: optimize VRAM allocation when using > drm buddy > > Am 14.02.23 um 15:53 schrieb Xiao,

Re: [PATCH] drm/amd/display: avoid unaligned access warnings

2023-02-14 Thread Alex Deucher
Applied. Thanks! On Tue, Feb 14, 2023 at 1:56 AM Jonathan Gray wrote: > > When building on OpenBSD/arm64 with clang 15, unaligned access > warnings are seen when a union is embedded inside a packed struct. > > drm/amd/display/dmub/inc/dmub_cmd.h:941:18: error: field > cursor_copy_src within

Re: [PATCH 01/10] drm/amd/display: Turn global functions into static

2023-02-14 Thread Alex Deucher
On Mon, Feb 13, 2023 at 3:49 PM Arthur Grillo wrote: > > Turn global functions that are only used locally into static ones. This > reduces the number of -Wmissing-prototypes warnings. > > Signed-off-by: Arthur Grillo The first hunk was already fixed, but I applied the second hunk. Alex > ---

Re: [PATCH 0/6] Trivial code cleanup around color resources

2023-02-14 Thread Alex Deucher
Applied. Thanks! Alex On Tue, Feb 14, 2023 at 7:48 AM Christian König wrote: > > Am 14.02.23 um 13:14 schrieb Melissa Wen: > > Hi, > > > > Sorry for the noise, but while I've been working on wiring 3D LUT > > support to AMD display driver [1] I found some annoying code style > > issues in the

Re: [PATCH 03/10] drm/amd/amdgpu: Add function prototypes to headers

2023-02-14 Thread Alex Deucher
Applied. Thanks! On Mon, Feb 13, 2023 at 3:50 PM Arthur Grillo wrote: > > Add function prototypes to headers to reduce the number of > -Wmissing-prototypes warnings. > > Signed-off-by: Arthur Grillo > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.h | 1 + > 1 file changed, 1 insertion(+) > >

Re: [PATCH 09/10] drm/amd/display: Make variables declaration inside ifdef guard

2023-02-14 Thread Alex Deucher
Applied. Thanks! On Mon, Feb 13, 2023 at 3:50 PM Arthur Grillo wrote: > > Make variables declaration inside ifdef guard, as they are only used > inside the same ifdef guard. This remove some of the > -Wunused-but-set-variable warning. > > Signed-off-by: Arthur Grillo > --- >

Re: [PATCH v2 3/8] drm/amdgpu: rename gmc.aper_base/size

2023-02-14 Thread Christian König
Am 14.02.23 um 17:15 schrieb Shashank Sharma: From: Alex Deucher This patch renames aper_base and aper_size parameters (in adev->gmc), to vram_aper_base and vram_aper_size, to differentiate it from the doorbell BAR. V2: rebase Cc: Alex Deucher Cc: Christian Koenig Signed-off-by: Alex

Re: [PATCH v2 7/8] drm/amdgpu: create doorbell kernel object

2023-02-14 Thread Christian König
Am 14.02.23 um 17:15 schrieb Shashank Sharma: From: Shashank Sharma This patch does the following: - Initializes TTM range management for domain DOORBELL. - Introduces a kernel bo for doorbell management in form of mman.doorbell_kernel_bo. This bo holds the kernel doorbell space now. -

Re: [PATCH 3/3] drm/connector: Deprecate split for BT.2020 in drm_colorspace enum

2023-02-14 Thread Harry Wentland
On 2/14/23 10:49, Sebastian Wick wrote: > On Fri, Feb 3, 2023 at 5:00 PM Ville Syrjälä > wrote: >> >> On Fri, Feb 03, 2023 at 10:24:52AM -0500, Harry Wentland wrote: >>> >>> >>> On 2/3/23 10:19, Ville Syrjälä wrote: On Fri, Feb 03, 2023 at 09:39:42AM -0500, Harry Wentland wrote: >

Re: [PATCH 04/10] drm/amd/display: Add previously missing includes

2023-02-14 Thread Alex Deucher
Applied. Thanks! On Mon, Feb 13, 2023 at 3:50 PM Arthur Grillo wrote: > > Add includes that were previously missing to reduce the number of > -Wmissing-prototypes warnings. > > Signed-off-by: Arthur Grillo > --- > drivers/gpu/drm/amd/display/dc/dcn32/dcn32_init.c | 1 + >

Re: [PATCH v2 1/8] drm/amdgpu: add UAPI for allocating doorbell memory

2023-02-14 Thread Christian König
Am 14.02.23 um 17:15 schrieb Shashank Sharma: From: Alex Deucher This patch adds flags for a new gem domain AMDGPU_GEM_DOMAIN_DOORBELL in the UAPI layer. V2: Drop 'memory' from description (Christian) Cc: Alex Deucher Cc: Christian Koenig Signed-off-by: Alex Deucher ---

Re: [PATCH v2 2/8] drm/amdgpu: replace aper_base_kaddr with vram_aper_base_kaddr

2023-02-14 Thread Christian König
Am 14.02.23 um 17:15 schrieb Shashank Sharma: From: Alex Deucher To differentiate it from the doorbell BAR. Since we removed the manual ioremap() for the doorbell BAR today we don't really need that patch any more, don't we? On the other hand renaming the field still makes a lot of sense

Re: [PATCH v2 4/8] drm/amdgpu: rename doorbell variables

2023-02-14 Thread Christian König
Am 14.02.23 um 17:15 schrieb Shashank Sharma: From: Alex Deucher This patch: - renames the adev->doorbell.base to adev->doorbell.doorbell_aper_base - renames the adev->doorbell.size to adev->doorbell.doorbell_aper_size - moves the adev->doorbell.ptr to adev->mman.doorbell_aper_base_kaddr

Re: [PATCH v2 5/8] drm/amdgpu: accommodate DOMAIN/PL_DOORBELL

2023-02-14 Thread Christian König
Am 14.02.23 um 17:15 schrieb Shashank Sharma: From: Alex Deucher This patch adds changes: - to accommodate the new GEM domain DOORBELL - to accommodate the new TTM PL DOORBELL to manage doorbell allocations as GEM Objects. V2: Addressed reviwe comments from Christian - drop the doorbell

[linux-next:master] BUILD REGRESSION 3ebb0ac55efaf1d0fb1b106f852c114e5021f7eb

2023-02-14 Thread kernel test robot
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master branch HEAD: 3ebb0ac55efaf1d0fb1b106f852c114e5021f7eb Add linux-next specific files for 20230214 Error/Warning reports: https://lore.kernel.org/oe-kbuild-all/202301300743.bp7dpazv-...@intel.com https

Re: [PATCH 02/10] drm/amd/display: Add function prototypes to headers

2023-02-14 Thread Alex Deucher
Applied. Thanks! On Mon, Feb 13, 2023 at 3:50 PM Arthur Grillo wrote: > > Add function prototypes to headers to reduce the number of > -Wmissing-prototypes warnings. > > Signed-off-by: Arthur Grillo > --- > drivers/gpu/drm/amd/display/dc/dcn31/dcn31_hubbub.h | 2 ++ >

Re: [PATCH 05/10] drm/amd/display: Fix excess arguments on kernel-doc

2023-02-14 Thread Alex Deucher
Applied. Thanks! On Mon, Feb 13, 2023 at 3:50 PM Arthur Grillo wrote: > > Remove arguments present on kernel-doc that are not present on the > function declaration and add the new ones if present. > > Signed-off-by: Arthur Grillo > --- > drivers/gpu/drm/amd/amdgpu/sdma_v6_0.c| 15

Re: [PATCH v2 8/8] drm/amdgpu: start using kernel doorbell bo

2023-02-14 Thread Christian König
Am 14.02.23 um 17:15 schrieb Shashank Sharma: From: Shashank Sharma This patch does the following: - Adds new variables like mman.doorbell_bo_size/gpu_addr/cpu_addr. The cpu_addr ptr will be used now for doorbell read/write from doorbell BAR. - Adjusts the existing code to use kernel

Re: [PATCH v2 1/8] drm/amdgpu: add UAPI for allocating doorbell memory

2023-02-14 Thread Shashank Sharma
On 14/02/2023 19:22, Christian König wrote: Am 14.02.23 um 17:15 schrieb Shashank Sharma: From: Alex Deucher This patch adds flags for a new gem domain AMDGPU_GEM_DOMAIN_DOORBELL in the UAPI layer. V2: Drop 'memory' from description (Christian) Cc: Alex Deucher Cc: Christian Koenig

Re: [PATCH v2 2/8] drm/amdgpu: replace aper_base_kaddr with vram_aper_base_kaddr

2023-02-14 Thread Shashank Sharma
On 14/02/2023 19:24, Christian König wrote: Am 14.02.23 um 17:15 schrieb Shashank Sharma: From: Alex Deucher To differentiate it from the doorbell BAR. Since we removed the manual ioremap() for the doorbell BAR today we don't really need that patch any more, don't we? On the other hand

Re: [PATCH v2 5/8] drm/amdgpu: accommodate DOMAIN/PL_DOORBELL

2023-02-14 Thread Shashank Sharma
On 14/02/2023 19:31, Christian König wrote: Am 14.02.23 um 17:15 schrieb Shashank Sharma: From: Alex Deucher This patch adds changes: - to accommodate the new GEM domain DOORBELL - to accommodate the new TTM PL DOORBELL to manage doorbell allocations as GEM Objects. V2: Addressed reviwe

Re: [PATCH v2 8/8] drm/amdgpu: start using kernel doorbell bo

2023-02-14 Thread Shashank Sharma
On 14/02/2023 19:40, Christian König wrote: Am 14.02.23 um 17:15 schrieb Shashank Sharma: From: Shashank Sharma This patch does the following: - Adds new variables like mman.doorbell_bo_size/gpu_addr/cpu_addr.    The cpu_addr ptr will be used now for doorbell read/write from    doorbell

Re: [PATCH 3/3] drm/connector: Deprecate split for BT.2020 in drm_colorspace enum

2023-02-14 Thread Sebastian Wick
On Tue, Feb 14, 2023 at 5:57 PM Harry Wentland wrote: > > > > On 2/14/23 10:49, Sebastian Wick wrote: > > On Fri, Feb 3, 2023 at 5:00 PM Ville Syrjälä > > wrote: > >> > >> On Fri, Feb 03, 2023 at 10:24:52AM -0500, Harry Wentland wrote: > >>> > >>> > >>> On 2/3/23 10:19, Ville Syrjälä wrote: >

Re: [PATCH 3/3] drm/connector: Deprecate split for BT.2020 in drm_colorspace enum

2023-02-14 Thread Harry Wentland
On 2/14/23 14:45, Sebastian Wick wrote: On Tue, Feb 14, 2023 at 5:57 PM Harry Wentland wrote: On 2/14/23 10:49, Sebastian Wick wrote: On Fri, Feb 3, 2023 at 5:00 PM Ville Syrjälä wrote: On Fri, Feb 03, 2023 at 10:24:52AM -0500, Harry Wentland wrote: On 2/3/23 10:19, Ville Syrjälä

Re: [PATCH v2 4/8] drm/amdgpu: rename doorbell variables

2023-02-14 Thread Shashank Sharma
On 14/02/2023 19:27, Christian König wrote: Am 14.02.23 um 17:15 schrieb Shashank Sharma: From: Alex Deucher This patch: - renames the adev->doorbell.base to adev->doorbell.doorbell_aper_base - renames the adev->doorbell.size to adev->doorbell.doorbell_aper_size - moves the

Re: [PATCH v2 7/8] drm/amdgpu: create doorbell kernel object

2023-02-14 Thread Shashank Sharma
On 14/02/2023 19:35, Christian König wrote: Am 14.02.23 um 17:15 schrieb Shashank Sharma: From: Shashank Sharma This patch does the following: - Initializes TTM range management for domain DOORBELL. - Introduces a kernel bo for doorbell management in form of mman.doorbell_kernel_bo.   

Re: [PATCH 3/3] drm/connector: Deprecate split for BT.2020 in drm_colorspace enum

2023-02-14 Thread Ville Syrjälä
On Tue, Feb 14, 2023 at 08:45:00PM +0100, Sebastian Wick wrote: > On Tue, Feb 14, 2023 at 5:57 PM Harry Wentland wrote: > > > > > > > > On 2/14/23 10:49, Sebastian Wick wrote: > > > On Fri, Feb 3, 2023 at 5:00 PM Ville Syrjälä > > > wrote: > > >> > > >> On Fri, Feb 03, 2023 at 10:24:52AM -0500,

[PATCH] drm/amd/display: only warn once in dce110_edp_wait_for_hpd_ready()

2023-02-14 Thread Hamza Mahfooz
Since, hot plugging eDP displays isn't supported, it is sufficient for us to warn about the lack of a connected display once. So, use ASSERT() in dce110_edp_wait_for_hpd_ready() instead of DC_LOG_WARNING(). Signed-off-by: Hamza Mahfooz ---

Re: [PATCH 3/3] drm/connector: Deprecate split for BT.2020 in drm_colorspace enum

2023-02-14 Thread Sebastian Wick
On Tue, Feb 14, 2023 at 9:10 PM Ville Syrjälä wrote: > > On Tue, Feb 14, 2023 at 08:45:00PM +0100, Sebastian Wick wrote: > > On Tue, Feb 14, 2023 at 5:57 PM Harry Wentland > > wrote: > > > > > > > > > > > > On 2/14/23 10:49, Sebastian Wick wrote: > > > > On Fri, Feb 3, 2023 at 5:00 PM Ville