Re: [PATCH v2 0/3] Resolve warnings from AMDGPU

2023-02-20 Thread Christian König
Acked-by: Christian König for the whole series. Am 17.02.23 um 19:14 schrieb Arthur Grillo: Hi, This series resolve some of the warnings that appear when compiling AMDGPU with W=1. Each patch is focused in a specific warning. This is my First Patch for the GSoC Project Idea about increasing

Re: [PATCH] drm/gem: Expose the buffer object handle to userspace last

2023-02-20 Thread Christian König
Am 20.02.23 um 10:55 schrieb Tvrtko Ursulin: Hi, On 14/02/2023 13:59, Christian König wrote: Am 14.02.23 um 13:50 schrieb Tvrtko Ursulin: From: Tvrtko Ursulin Currently drm_gem_handle_create_tail exposes the handle to userspace before the buffer object constructions is complete. This

Re: [PATCH] drm/gem: Expose the buffer object handle to userspace last

2023-02-20 Thread Tvrtko Ursulin
Hi, On 14/02/2023 13:59, Christian König wrote: Am 14.02.23 um 13:50 schrieb Tvrtko Ursulin: From: Tvrtko Ursulin Currently drm_gem_handle_create_tail exposes the handle to userspace before the buffer object constructions is complete. This allowing of working against a partially

Re: [PATCH] drm/gem: Expose the buffer object handle to userspace last

2023-02-20 Thread Tvrtko Ursulin
On 20/02/2023 10:01, Christian König wrote: Am 20.02.23 um 10:55 schrieb Tvrtko Ursulin: Hi, On 14/02/2023 13:59, Christian König wrote: Am 14.02.23 um 13:50 schrieb Tvrtko Ursulin: From: Tvrtko Ursulin Currently drm_gem_handle_create_tail exposes the handle to userspace before the

Re: [PATCH v2] drm/amd: Don't allow s0ix on APUs older than Raven

2023-02-20 Thread Alex Deucher
On Mon, Feb 20, 2023 at 11:56 AM Limonciello, Mario wrote: > > [Public] > > > > > -Original Message- > > From: Limonciello, Mario > > Sent: Monday, February 13, 2023 15:11 > > To: amd-gfx@lists.freedesktop.org > > Cc: Limonciello, Mario ; Deucher, Alexander > > > > Subject: [PATCH v2]

[PATCH 2/3] drm/amd: Use runtime suspend in lieu regular suspend on supported dGPUs

2023-02-20 Thread Mario Limonciello
The PMFW on dGPUs that support BACO will transition them in and out of BACO when video/audio move in out of D3/D0. On the Linux side users can configure what sleep mode to use in `/sys/power/mem_sleep`, but if the host hardware doesn't cut the power rails during this state then calling suspend

[RFC 0/3] Adjust suspend flow for dGPUs

2023-02-20 Thread Mario Limonciello
Currently when a dGPU supports BOCO and is runtime suspended when running the prepare() callback, the rest of the suspend and resume will be skipped. This skipping is due to "Smart prepare", "Smart suspend" and "Smart resume" flags. dGPUs that support BACO are normally suspended via PMFW and lack

[PATCH 1/3] drm/amd: Allow dGPUs that support BACO to use smart suspend

2023-02-20 Thread Mario Limonciello
If a dGPU is already runtime suspended using BACO, there is no point to waking it up to run regular suspend callbacks. Cc: Peter Kopec Signed-off-by: Mario Limonciello --- drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git

[PATCH 3/3] drm/amd: Don't always set s3 for dGPUs in all sleep modes

2023-02-20 Thread Mario Limonciello
dGPUs that will be using BACO or BOCO shouldn't be put into S3 when the system is being put into s2idle. Cc: Peter Kopec Signed-off-by: Mario Limonciello --- drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git

[PATCH] drm/amd: Fix initialization for nbio 7.5.1

2023-02-20 Thread Mario Limonciello
A mistake has been made in the BIOS for some ASICs with NBIO 7.5.1 where some NBIO registers aren't properly setup. Ensure that they're set during initialization. Tested-by: Richard Gong Signed-off-by: Mario Limonciello --- drivers/gpu/drm/amd/amdgpu/nbio_v7_2.c | 5 + 1 file changed, 5

Re: [PATCH] drm/amd: Fix initialization for nbio 7.5.1

2023-02-20 Thread Deucher, Alexander
[AMD Official Use Only - General] Acked-by: Alex Deucher From: amd-gfx on behalf of Mario Limonciello Sent: Monday, February 20, 2023 1:10 PM To: amd-gfx@lists.freedesktop.org Cc: Gong, Richard ; Limonciello, Mario Subject: [PATCH] drm/amd: Fix

[linux-next:master] BUILD REGRESSION d2af0fa4bfa4ec29d03b449ccd43fee39501112d

2023-02-20 Thread kernel test robot
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master branch HEAD: d2af0fa4bfa4ec29d03b449ccd43fee39501112d Add linux-next specific files for 20230220 Error/Warning reports: https://lore.kernel.org/oe-kbuild-all/202302062224.byzetxh1-...@intel.com https

RE: [PATCH v2] drm/amd: Don't allow s0ix on APUs older than Raven

2023-02-20 Thread Limonciello, Mario
[Public] > -Original Message- > From: Limonciello, Mario > Sent: Monday, February 13, 2023 15:11 > To: amd-gfx@lists.freedesktop.org > Cc: Limonciello, Mario ; Deucher, Alexander > > Subject: [PATCH v2] drm/amd: Don't allow s0ix on APUs older than Raven > > APUs before Raven didn't

RE: [PATCH v2] drm/amd: Don't allow s0ix on APUs older than Raven

2023-02-20 Thread Limonciello, Mario
[AMD Official Use Only - General] > -Original Message- > From: Alex Deucher > Sent: Monday, February 20, 2023 11:10 > To: Limonciello, Mario > Cc: amd-gfx@lists.freedesktop.org; Deucher, Alexander > > Subject: Re: [PATCH v2] drm/amd: Don't allow s0ix on APUs older than Raven > > On

[PATCH] drm/amd/pm: downgrade log level upon SMU IF version mismatch

2023-02-20 Thread Guchun Chen
SMU IF version mismatch as a warning message exists widely after asic production, however, due to this log level setting, such mismatch warning will be caught by automation test like IGT and reported as a fake error after checking. As such mismatch does not break anything, to reduce confusion,

[PATCH 1/2] drm/amd/pm: correct the baco state setting for ArmD3 scenario

2023-02-20 Thread Evan Quan
The check for baco support relies on the correct baco state. Signed-off-by: Evan Quan Change-Id: I9dd15958c213eb83abdb8b7d858eff0d2d364b4e --- .../gpu/drm/amd/pm/swsmu/smu13/smu_v13_0.c| 21 +++ 1 file changed, 17 insertions(+), 4 deletions(-) diff --git

[PATCH 2/2] drm/amd/pm: no pptable resetup on runpm exiting

2023-02-20 Thread Evan Quan
It is assumed the pptable used before runpm is same as the one used afterwards. Thus, we can reuse the stored copy and do not need to resetup the pptable again. Signed-off-by: Evan Quan Change-Id: Ib6d61f8e8cb58df45d9e24725b0672239b3ff653 --- drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c | 15