[PATCH 16/20] drm/amd/display: Correct DML calculation as HW SpreadSheet

2023-02-21 Thread Qingqing Zhuo
From: Paul Hsieh [Why] In 2560x1440@240p eDP panel, some use cases will enable MPC combine with RGB MPO then underflow happened. This case is not allow from HW SpreadSheet. [How] Correct eDP, DP and DP2 output bpp calculation as HW SpreadSheet Reviewed-by: Nicholas Kazlauskas Acked-by:

[PATCH 18/20] drm/amd/display: enable DPG when disabling plane for phantom pipe

2023-02-21 Thread Qingqing Zhuo
From: Samson Tam [Why] In disable_dangling_plane, for phantom pipes, we enable OTG so disable programming gets the double buffer update. But this causes an underflow to occur. [How] Enable DPG prior to enabling OTG. Reviewed-by: Alvin Lee Acked-by: Qingqing Zhuo Signed-off-by: Samson Tam

[PATCH 17/20] drm/amd/display: remove empty dc_link.c

2023-02-21 Thread Qingqing Zhuo
From: Wenjing Liu [why] We kept an empty dc_link.c file due to external build dependency. Now the last build dependency has been removed. We can safely delete this file. Reviewed-by: Rodrigo Siqueira Acked-by: Qingqing Zhuo Signed-off-by: Wenjing Liu ---

[PATCH 19/20] drm/amd/display: Only wait for blank completion if OTG active

2023-02-21 Thread Qingqing Zhuo
From: Aric Cyr [why] If OTG is not active, waiting for blank completion will always fail and timeout resulting in unnecessary driver delays. [how] Check that OTG is enabled before waiting for blank. Reviewed-by: Alvin Lee Acked-by: Qingqing Zhuo Signed-off-by: Aric Cyr ---

[PATCH 20/20] drm/amd/display: Promote DAL to 3.2.224

2023-02-21 Thread Qingqing Zhuo
From: Aric Cyr This version brings along the following: - Correct DML calculation - Extend Freesync over Pcon support - Fixes in pstate hang and more - Code cleanup for dc_link.h and dc_link.c Acked-by: Qingqing Zhuo Signed-off-by: Aric Cyr --- drivers/gpu/drm/amd/display/dc/dc.h | 2 +- 1

RE: [PATCH 2/2] drm/amdgpu: Add ecc info query interface for umc v8_10

2023-02-21 Thread Yang, Stanley
[AMD Official Use Only - General] The series is Reviewed-by: Stanley.Yang Regards, Stanley > -Original Message- > From: amd-gfx On Behalf Of > Candice Li > Sent: Wednesday, February 22, 2023 12:35 PM > To: amd-gfx@lists.freedesktop.org > Cc: Li, Candice > Subject: [PATCH 2/2]

RE: [PATCH 2/2] drm/amdgpu: add bad_page_threshold check in ras_eeprom_check_err

2023-02-21 Thread Yang, Stanley
[AMD Official Use Only - General] > -Original Message- > From: Zhou1, Tao > Sent: Tuesday, February 21, 2023 4:29 PM > To: amd-gfx@lists.freedesktop.org; Zhang, Hawking > ; Yang, Stanley ; Chai, > Thomas ; Li, Candice > Cc: Zhou1, Tao > Subject: [PATCH 2/2] drm/amdgpu: add

Re: [PATCH] drm/amd/pm: downgrade log level upon SMU IF version mismatch

2023-02-21 Thread Deucher, Alexander
[AMD Official Use Only - General] Reviewed-by: Alex Deucher From: amd-gfx on behalf of Guchun Chen Sent: Monday, February 20, 2023 11:42 PM To: amd-gfx@lists.freedesktop.org ; Deucher, Alexander ; Zhang, Hawking ; Lazar, Lijo ; Quan, Evan ; Feng, Kenneth

[PATCH] drm/amdkfd: Fix an illegal memory access

2023-02-21 Thread qu . huang
From: Qu Huang In the kfd_wait_on_events() function, the kfd_event_waiter structure is allocated by alloc_event_waiters(), but the event field of the waiter structure is not initialized; When copy_from_user() fails in the kfd_wait_on_events() function, it will enter exception handling to release

Re: [PATCH] drm/amdkfd: Fix an illegal memory access

2023-02-21 Thread Felix Kuehling
On 2023-02-21 06:35, qu.hu...@linux.dev wrote: From: Qu Huang In the kfd_wait_on_events() function, the kfd_event_waiter structure is allocated by alloc_event_waiters(), but the event field of the waiter structure is not initialized; When copy_from_user() fails in the kfd_wait_on_events()

Re: [Intel-gfx] [PATCH 7/7] drm/ttm: cleanup ttm_range_mgr_node

2023-02-21 Thread Matthew Auld
On Fri, 17 Feb 2023 at 12:23, Christian König wrote: > > We don't need multiple drm_mm nodes any more. Clean that up and remove > the extra complexity. > > Signed-off-by: Christian König Reviewed-by: Matthew Auld

Re: [PATCH 5/7] drm/gem: Remove BUG_ON in drm_gem_private_object_init

2023-02-21 Thread Matthew Auld
On Fri, 17 Feb 2023 at 12:23, Christian König wrote: > > From: Somalapuram Amaranath > > ttm_resource can allocate size in bytes to support less than page size. > > Signed-off-by: Somalapuram Amaranath > Reviewed-by: Christian König > Signed-off-by: Christian König > Link: >

[linux-next:master] BUILD REGRESSION 465461cf48465b8a0a54025db5ae2b3df7a04577

2023-02-21 Thread kernel test robot
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master branch HEAD: 465461cf48465b8a0a54025db5ae2b3df7a04577 Add linux-next specific files for 20230221 Error/Warning reports: https://lore.kernel.org/oe-kbuild-all/202302062224.byzetxh1-...@intel.com https

RE: [PATCH 2/2] drm/amdgpu: add bad_page_threshold check in ras_eeprom_check_err

2023-02-21 Thread Zhou1, Tao
[AMD Official Use Only - General] > -Original Message- > From: Yang, Stanley > Sent: Tuesday, February 21, 2023 5:34 PM > To: Zhou1, Tao ; amd-gfx@lists.freedesktop.org; Zhang, > Hawking ; Chai, Thomas ; > Li, Candice > Subject: RE: [PATCH 2/2] drm/amdgpu: add bad_page_threshold check

Re: [PATCH] drm/fb-helper: Remove drm_fb_helper_unprepare() from drm_fb_helper_fini()

2023-02-21 Thread Javier Martinez Canillas
Thomas Zimmermann writes: > Move drm_fb_helper_unprepare() from drm_fb_helper_fini() into the > calling fbdev implementation. Avoids a possible stale mutex with > generic fbdev code. > > As indicated by its name, drm_fb_helper_prepare() prepares struct > drm_fb_helper before setting up the fbdev

RE: [PATCH 2/3] drm/amd: Use runtime suspend in lieu regular suspend on supported dGPUs

2023-02-21 Thread Limonciello, Mario
[Public] > -Original Message- > From: Lazar, Lijo > Sent: Tuesday, February 21, 2023 07:20 > To: Limonciello, Mario ; amd- > g...@lists.freedesktop.org > Cc: Peter Kopec > Subject: Re: [PATCH 2/3] drm/amd: Use runtime suspend in lieu regular suspend > on supported dGPUs > > > > On

RE: [PATCH 3/3] drm/amd: Don't always set s3 for dGPUs in all sleep modes

2023-02-21 Thread Quan, Evan
[AMD Official Use Only - General] > -Original Message- > From: amd-gfx On Behalf Of > Mario Limonciello > Sent: Tuesday, February 21, 2023 4:16 AM > To: amd-gfx@lists.freedesktop.org > Cc: Peter Kopec ; Limonciello, Mario > > Subject: [PATCH 3/3] drm/amd: Don't always set s3 for dGPUs

RE: [PATCH 1/3] drm/amd: Allow dGPUs that support BACO to use smart suspend

2023-02-21 Thread Quan, Evan
[AMD Official Use Only - General] > -Original Message- > From: amd-gfx On Behalf Of > Mario Limonciello > Sent: Tuesday, February 21, 2023 4:16 AM > To: amd-gfx@lists.freedesktop.org > Cc: Peter Kopec ; Limonciello, Mario > > Subject: [PATCH 1/3] drm/amd: Allow dGPUs that support BACO

RE: [PATCH 2/2] drm/amdgpu: exclude duplicate pages from UMC RAS UE count

2023-02-21 Thread Zhou1, Tao
Ping... > -Original Message- > From: Zhou1, Tao > Sent: Monday, February 20, 2023 11:17 AM > To: amd-gfx@lists.freedesktop.org; Zhang, Hawking > ; Yang, Stanley ; Chai, > Thomas ; Li, Candice ; Lazar, > Lijo > Cc: Zhou1, Tao > Subject: [PATCH 2/2] drm/amdgpu: exclude duplicate pages

RE: [PATCH 2/2] drm/amdgpu: add bad_page_threshold check in ras_eeprom_check_err

2023-02-21 Thread Yang, Stanley
[AMD Official Use Only - General] The series is Reviewed-by: Stanley.Yang Regards, Stanley > -Original Message- > From: Zhou1, Tao > Sent: Wednesday, February 22, 2023 10:52 AM > To: amd-gfx@lists.freedesktop.org; Zhang, Hawking > ; Yang, Stanley ; Chai, > Thomas ; Li, Candice ; Lazar,

Re: [PATCH v2] drm/amdkfd: Fix an illegal memory access

2023-02-21 Thread Felix Kuehling
Am 2023-02-21 um 22:05 schrieb qu.hu...@linux.dev: In the kfd_wait_on_events() function, the kfd_event_waiter structure is allocated by alloc_event_waiters(), but the event field of the waiter structure is not initialized; When copy_from_user() fails in the kfd_wait_on_events() function, it

[PATCH 1/2] drm/amdgpu: change default behavior of bad_page_threshold parameter

2023-02-21 Thread Tao Zhou
Ignore ras umc bad page threshold by default, GPU initialization won't be stopped in this mode. v2: refine the description of bad_page_threshold. Signed-off-by: Tao Zhou --- drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c| 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c| 7 ---

[PATCH 2/2] drm/amdgpu: add bad_page_threshold check in ras_eeprom_check_err

2023-02-21 Thread Tao Zhou
bad_page_threshold controls page retirement behavior and it should be also checked. v2: simplify the condition of bad page handling path. Signed-off-by: Tao Zhou --- .../gpu/drm/amd/amdgpu/amdgpu_ras_eeprom.c| 19 ++- 1 file changed, 14 insertions(+), 5 deletions(-) diff

[PATCH 1/2] drm/amdgpu: Add convert_error_address function for umc v8_10

2023-02-21 Thread Candice Li
Add convert_error_address for umc v8_10. Signed-off-by: Candice Li Reviewed-by: Tao Zhou --- drivers/gpu/drm/amd/amdgpu/umc_v8_10.c | 73 +++--- 1 file changed, 42 insertions(+), 31 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/umc_v8_10.c

[PATCH 2/2] drm/amdgpu: Add ecc info query interface for umc v8_10

2023-02-21 Thread Candice Li
Support ecc info query for umc v8_10. v2: Simplied by convert_error_address. v3: Remove unused variable and invalid checking. Signed-off-by: Candice Li Reviewed-by: Tao Zhou Reviewed-by: Stanley.Yang --- drivers/gpu/drm/amd/amdgpu/umc_v8_10.c | 134 + 1 file changed,

[PATCH 03/20] drm/amd/display: Reduce CPU busy-waiting for long delays

2023-02-21 Thread Qingqing Zhuo
From: Aric Cyr [WHY] udelay should not be used for long waits since it keeps CPU active, wasting power. [HOW] Use fsleep where acceptable to allow CPU cores to be parked by the scheduler. Reviewed-by: Wenjing Liu Acked-by: Qingqing Zhuo Signed-off-by: Aric Cyr ---

RE: [PATCH 2/2] drm/amdgpu: exclude duplicate pages from UMC RAS UE count

2023-02-21 Thread Yang, Stanley
[AMD Official Use Only - General] Reviewed-by: Stanley.Yang Regards, Stanley > -Original Message- > From: Zhou1, Tao > Sent: Wednesday, February 22, 2023 10:53 AM > To: amd-gfx@lists.freedesktop.org; Zhang, Hawking > ; Yang, Stanley ; Chai, > Thomas ; Li, Candice ; Lazar, > Lijo >

[PATCH 04/20] drm/amd/display: Updating Video Format Fall Back Policy.

2023-02-21 Thread Qingqing Zhuo
From: Jasdeep Dhillon [WHY] Adding 1920x1080 as fail safe mode for Video Format Fall Back Policy. Reviewed-by: Jerry Zuo Acked-by: Qingqing Zhuo Signed-off-by: Jasdeep Dhillon --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 5 +

[PATCH 00/20] DC Patches Feb 27th, 2023

2023-02-21 Thread Qingqing Zhuo
This DC patchset brings improvements in multiple areas. In summary, we highlight: - Correct DML calculation - Extend Freesync over Pcon support - Fixes in pstate hang and more - Code cleanup for dc_link.h and dc_link.c Cc: Daniel Wheeler Alex Hung (1): drm/amd/display: fix

[PATCH 06/20] drm/amd/display: Allocation at stream Enable

2023-02-21 Thread Qingqing Zhuo
From: Mustapha Ghaddar [WHY & HOW] After we allocate BW at plug, we will de-alloc and allocate only what stream needs at stream_enable() [HOW] Introduce bw allocation check at link_enable() for DPIA links Reviewed-by: Wenjing Liu Acked-by: Qingqing Zhuo Signed-off-by: Mustapha Ghaddar ---

[PATCH 01/20] drm/amd/display: Ext displays with dock can't recognized after resume

2023-02-21 Thread Qingqing Zhuo
From: Ryan Lin [Why] Needs to set the default value of the LTTPR timeout after resume. [How] Set the default (3.2ms) timeout at resuming if the sink supports LTTPR Reviewed-by: Jerry Zuo Acked-by: Qingqing Zhuo Signed-off-by: Ryan Lin --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c

[PATCH 02/20] drm/amd/display: fix shift-out-of-bounds in CalculateVMAndRowBytes

2023-02-21 Thread Qingqing Zhuo
From: Alex Hung [WHY] When PTEBufferSizeInRequests is zero, UBSAN reports the following warning because dml_log2 returns an unexpected negative value: shift exponent 4294966273 is too large for 32-bit type 'int' [HOW] In the case PTEBufferSizeInRequests is zero, skip the dml_log2() and

[PATCH 05/20] Revert "drm/amd/display: Do not set DRR on pipe commit"

2023-02-21 Thread Qingqing Zhuo
From: Aric Cyr This reverts commit 723a86ab744043dadf9ff40b34be81efa78895e5. [Why & How] Original change causes a regression. Revert until fix is available. Reviewed-by: Aric Cyr Acked-by: Qingqing Zhuo Signed-off-by: Aric Cyr --- drivers/gpu/drm/amd/display/dc/dcn30/dcn30_hwseq.c | 3 +++

[PATCH 12/20] Revert "drm/amd/display: Fix FreeSync active bit issue"

2023-02-21 Thread Qingqing Zhuo
From: Aric Cyr This reverts commit 768ba5d529ae198c3a7cbcb1cbacb8c99dc77f07. [Why & How] Original change causes black screen. Revert until fix is available. Reviewed-by: Aric Cyr Acked-by: Qingqing Zhuo Signed-off-by: Aric Cyr --- .../gpu/drm/amd/display/modules/freesync/freesync.c | 12

[PATCH 15/20] drm/amd/display: merge dc_link.h into dc.h and dc_types.h

2023-02-21 Thread Qingqing Zhuo
From: Wenjing Liu [why] Remove the need to include dc_link.h separately. dc.h should contain everything needed on DM side. [How] Merge dc_link.h into dc.h and dc_types.h so DM only needs to include dc.h to use all link public functions. Reviewed-by: Jun Lei Acked-by: Qingqing Zhuo

[PATCH 07/20] drm/amd/display: dcn32/321 dsc_pg_control not executed properly

2023-02-21 Thread Qingqing Zhuo
From: Hersen Wu [why] during boot up or resume from s3, hw default value of domain_power_forceon is 1. when program domain_power_gate to 1 to power down hw block, hw will not change to power off due to domain_power_forceon = 1. [how] enable_power_gating_plane(true) should be executed to set

[PATCH 11/20] drm/amd/display: DAL to program DISPCLK WDIVIDER if PMFW doesn't

2023-02-21 Thread Qingqing Zhuo
From: Alvin Lee [Why & How] - If for any reason PMFW fails to set the expected (or valid) DISPCLK WDIVIDER, then DAL will program DENTIST DISPCLK WDIVIDER to correct for this issue Reviewed-by: Samson Tam Acked-by: Qingqing Zhuo Signed-off-by: Alvin Lee ---

[PATCH 14/20] drm/amd/display: Update BW ALLOCATION Function declaration

2023-02-21 Thread Qingqing Zhuo
From: Mustapha Ghaddar [WHY & HOW] Update the declaration to give a better idea of what the function does. Reviewed-by: Wenjing Liu Acked-by: Qingqing Zhuo Signed-off-by: Mustapha Ghaddar --- drivers/gpu/drm/amd/display/dc/dc_link.h| 6 +++---

[PATCH 13/20] drm/amd/display: Do not update DRR while BW optimizations pending

2023-02-21 Thread Qingqing Zhuo
From: Aric Cyr [why] While bandwidth optimizations are pending, it's possible a pstate change will occur. During this time, VSYNC handler should not also try to update DRR parameters causing pstate hang [how] Do not adjust DRR if optimize bandwidth is set. Reviewed-by: Aric Cyr Acked-by:

[PATCH 09/20] drm/amd/display: update pixel format in DP hw sequence

2023-02-21 Thread Qingqing Zhuo
From: Yihan Zhu [WHY] DP 420 formats do not light up because the pixel processing mode of the DP_FORMAT is misprogrammed [HOW] Added appropriate programming for DP pixel format Reviewed-by: Charlene Liu Reviewed-by: Nicholas Kazlauskas Acked-by: Qingqing Zhuo Signed-off-by: Yihan Zhu ---

[PATCH 10/20] drm/amd/display: Extend Freesync over PCon support for more devices

2023-02-21 Thread Qingqing Zhuo
From: Sung Joon Kim [why] More branch devices are able to support Freesync over PCon so include them in the list of supporting devices. [how] Add more compatible PCon devices in the whitelist for Freesync over Pcon. Reviewed-by: Harry Wentland Acked-by: Qingqing Zhuo Signed-off-by: Sung Joon

[PATCH 08/20] drm/amd/display: populate subvp cmd info only for the top pipe

2023-02-21 Thread Qingqing Zhuo
From: Ayush Gupta [Why] System restart observed while changing the display resolution to 8k with extended mode. Sytem restart was caused by a page fault. [How] When the driver populates subvp info it did it for both the pipes using vblank which caused an outof bounds array access causing the

Re: [PATCH 3/3] drm/amd: Don't always set s3 for dGPUs in all sleep modes

2023-02-21 Thread Lazar, Lijo
On 2/21/2023 1:46 AM, Mario Limonciello wrote: dGPUs that will be using BACO or BOCO shouldn't be put into S3 when the system is being put into s2idle. Cc: Peter Kopec Signed-off-by: Mario Limonciello --- drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c | 9 +++-- 1 file changed, 7

Re: [PATCH 3/3] drm/amd: Don't always set s3 for dGPUs in all sleep modes

2023-02-21 Thread Mario Limonciello
On 2/21/23 07:25, Lazar, Lijo wrote: On 2/21/2023 1:46 AM, Mario Limonciello wrote: dGPUs that will be using BACO or BOCO shouldn't be put into S3 when the system is being put into s2idle. Cc: Peter Kopec Signed-off-by: Mario Limonciello ---   drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c | 9

Re: [PATCH] drm/fb-helper: Remove drm_fb_helper_unprepare() from drm_fb_helper_fini()

2023-02-21 Thread Thomas Zimmermann
Hi Am 21.02.23 um 11:27 schrieb Javier Martinez Canillas: Thomas Zimmermann writes: Move drm_fb_helper_unprepare() from drm_fb_helper_fini() into the calling fbdev implementation. Avoids a possible stale mutex with generic fbdev code. As indicated by its name, drm_fb_helper_prepare()

Re: [PATCH] drm/fb-helper: Remove drm_fb_helper_unprepare() from drm_fb_helper_fini()

2023-02-21 Thread Javier Martinez Canillas
Thomas Zimmermann writes: > Hi > > Am 21.02.23 um 11:27 schrieb Javier Martinez Canillas: >> Thomas Zimmermann writes: >> >>> Move drm_fb_helper_unprepare() from drm_fb_helper_fini() into the >>> calling fbdev implementation. Avoids a possible stale mutex with >>> generic fbdev code. >>> >>>

Re: [PATCH 2/3] drm/amd: Use runtime suspend in lieu regular suspend on supported dGPUs

2023-02-21 Thread Lazar, Lijo
On 2/21/2023 1:46 AM, Mario Limonciello wrote: The PMFW on dGPUs that support BACO will transition them in and out of BACO when video/audio move in out of D3/D0. On the Linux side users can configure what sleep mode to use in `/sys/power/mem_sleep`, but if the host hardware doesn't cut the

Re: [PATCH 3/3] drm/amd: Don't always set s3 for dGPUs in all sleep modes

2023-02-21 Thread Lazar, Lijo
On 2/21/2023 6:57 PM, Mario Limonciello wrote: On 2/21/23 07:25, Lazar, Lijo wrote: On 2/21/2023 1:46 AM, Mario Limonciello wrote: dGPUs that will be using BACO or BOCO shouldn't be put into S3 when the system is being put into s2idle. Cc: Peter Kopec Signed-off-by: Mario Limonciello

RE: [PATCH 2/2] drm/amd/pm: no pptable resetup on runpm exiting

2023-02-21 Thread Xu, Feifei
Series is Reviewed-by: Feifei Xu -Original Message- From: amd-gfx On Behalf Of Evan Quan Sent: Tuesday, February 21, 2023 3:51 PM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Quan, Evan Subject: [PATCH 2/2] drm/amd/pm: no pptable resetup on runpm exiting It is

[PATCH 2/2] drm/amdgpu: add bad_page_threshold check in ras_eeprom_check_err

2023-02-21 Thread Tao Zhou
bad_page_threshold controls page retirement behavior and it should be also checked. Signed-off-by: Tao Zhou --- .../gpu/drm/amd/amdgpu/amdgpu_ras_eeprom.c| 20 ++- 1 file changed, 15 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ras_eeprom.c

[PATCH 1/2] drm/amdgpu: change default behavior of bad_page_threshold parameter

2023-02-21 Thread Tao Zhou
Ignore ras umc bad page threshold by default, GPU initialization won't be stopped in this mode. Signed-off-by: Tao Zhou --- drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c| 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c| 7 --- drivers/gpu/drm/amd/amdgpu/amdgpu_ras_eeprom.c | 4 ++--

Re: [PATCH 3/3] drm/amd: Don't always set s3 for dGPUs in all sleep modes

2023-02-21 Thread Limonciello, Mario
On 2/21/2023 07:34, Lazar, Lijo wrote: On 2/21/2023 6:57 PM, Mario Limonciello wrote: On 2/21/23 07:25, Lazar, Lijo wrote: On 2/21/2023 1:46 AM, Mario Limonciello wrote: dGPUs that will be using BACO or BOCO shouldn't be put into S3 when the system is being put into s2idle. Cc: Peter