[PATCH] drm/amd/display: Set MPC_SPLIT_DYNAMIC for DCN301

2023-03-09 Thread Rodrigo Siqueira
Since DC version 3.2.226, DC started to use a new internal commit sequence that better deals with hardware limitations. Usually, DC adopts split pipe dynamics to improve the display bandwidth and, in some cases, to save power. This commit sets MPC_SPLIT_DYNAMIC for DCN301, improving the bandwidth

RE: [PATCH v3 2/2] drm/probe_helper: warning on poll_enabled for issue catching

2023-03-09 Thread Quan, Evan
[AMD Official Use Only - General] Series is acked-by: Evan Quan > -Original Message- > From: amd-gfx On Behalf Of > Guchun Chen > Sent: Friday, March 10, 2023 9:02 AM > To: amd-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org; > Deucher, Alexander ; Zhang, Hawking > ;

[pull] amdgpu, amdkfd drm-fixes-6.3

2023-03-09 Thread Alex Deucher
Hi Dave, Daniel, Fixes for 6.3. Same pull as yesterday, but drop the KFD patch that caused a regression. The following changes since commit 66305069eb6d17d9190cbcd196f3f7487df47ae8: Merge tag 'drm-misc-fixes-2023-02-23' of git://anongit.freedesktop.org/drm/drm-misc into drm-fixes

Re: [PATCH] amd/display/debugfs: add sysfs entry to read PSR residency from firmware

2023-03-09 Thread S, Shirish
On 3/8/2023 11:52 PM, Hamza Mahfooz wrote: On 3/8/23 02:10, Shirish S wrote: [Why] Currently there aren't any methods to determine PSR state residency. [How] create a sysfs entry for reading residency and internally hook it up to existing functionality of reading PSR residency from

[PATCH] amd/display/debugfs: add sysfs entry to read PSR residency from firmware

2023-03-09 Thread Shirish S
[Why] Currently there aren't any methods to determine PSR state residency. [How] create a sysfs entry for reading residency and internally hook it up to existing functionality of reading PSR residency from firmware. Signed-off-by: Shirish S --- .../amd/display/amdgpu_dm/amdgpu_dm_debugfs.c |

Re: [PATCH] amd/display/debugfs: add sysfs entry to read PSR residency from firmware

2023-03-09 Thread S, Shirish
On 3/10/2023 12:00 PM, S, Shirish wrote: On 3/8/2023 11:52 PM, Hamza Mahfooz wrote: On 3/8/23 02:10, Shirish S wrote: [Why] Currently there aren't any methods to determine PSR state residency. [How] create a sysfs entry for reading residency and internally hook it up to existing

Re: [PATCH 2/2] drm/amdgpu: use drm_device pointer directly rather than convert again

2023-03-09 Thread Christian König
Am 10.03.23 um 06:04 schrieb Guchun Chen: The convert from adev is redundant. Signed-off-by: Guchun Chen Reviewed-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

RE: [PATCH] drm/amdgpu/nv: fix codec array for SR_IOV

2023-03-09 Thread Chen, Guchun
Acked-by: Guchun Chen > -Original Message- > From: amd-gfx On Behalf Of Alex > Deucher > Sent: Friday, March 10, 2023 11:14 AM > To: Deucher, Alexander > Cc: Jiapeng Chong ; Abaci Robot > ; amd-gfx@lists.freedesktop.org > Subject: Re: [PATCH] drm/amdgpu/nv: fix codec array for SR_IOV >

[PATCH 2/2] drm/amdgpu: use drm_device pointer directly rather than convert again

2023-03-09 Thread Guchun Chen
The convert from adev is redundant. Signed-off-by: Guchun Chen --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c index

[PATCH] amd/display/debugfs: add sysfs entry to read PSR residency from firmware

2023-03-09 Thread Shirish S
[Why] Currently there aren't any methods to determine PSR state residency. [How] create a sysfs entry for reading residency and internally hook it up to existing functionality of reading PSR residency from firmware. Signed-off-by: Shirish S --- .../amd/display/amdgpu_dm/amdgpu_dm_debugfs.c |

Re: [PATCH 2/2] drm/amd/pm: Fix navi10 incorrect OD volage after resume

2023-03-09 Thread Alex Deucher
On Thu, Mar 9, 2023 at 6:54 AM Lazar, Lijo wrote: > > > > On 3/9/2023 8:11 AM, Quan, Evan wrote: > > [AMD Official Use Only - General] > > > > > > > >> -Original Message- > >> From: Deucher, Alexander > >> Sent: Wednesday, March 8, 2023 11:20 PM > >> To: amd-gfx@lists.freedesktop.org >

Re: [PATCH] drm/amdgpu/nv: fix codec array for SR_IOV

2023-03-09 Thread Alex Deucher
Ping? On Wed, Mar 8, 2023 at 10:51 PM Alex Deucher wrote: > > Copy paste error. > > Fixes: 384334120b66 ("drm/amdgpu/nv: don't expose AV1 if VCN0 is harvested") > Reported-by: Abaci Robot > Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=4454 > Cc: Jiapeng Chong > Signed-off-by: Alex

[PATCH 1/2] drm/amdgpu: drop pm_sysfs_en flag from amdgpu_device structure

2023-03-09 Thread Guchun Chen
pm_sysfs_en is overlapped with pm.sysfs_initialized, so drop it for simplifying code(no functional change). Signed-off-by: Guchun Chen --- drivers/gpu/drm/amd/amdgpu/amdgpu.h| 1 - drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 9 +++-- 2 files changed, 3 insertions(+), 7 deletions(-)

Re: [PATCH 1/2] drm/amdgpu: drop pm_sysfs_en flag from amdgpu_device structure

2023-03-09 Thread Christian König
Am 10.03.23 um 06:03 schrieb Guchun Chen: pm_sysfs_en is overlapped with pm.sysfs_initialized, so drop it for simplifying code(no functional change). Signed-off-by: Guchun Chen Acked-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu.h| 1 -

[PATCH v3 1/2] drm/amdgpu: move poll enabled/disable into non DC path

2023-03-09 Thread Guchun Chen
Some amd asics having reliable hotplug support don't call drm_kms_helper_poll_init in driver init sequence. However, due to the unified suspend/resume path for all asics, because the output_poll_work->func is not set for these asics, a warning arrives when suspending. [ 90.656049] [

Re: [pull] amdgpu, amdkfd drm-fixes-6.3

2023-03-09 Thread Alex Deucher
On Thu, Mar 9, 2023 at 12:16 PM Felix Kuehling wrote: > > > Am 2023-03-08 um 23:38 schrieb Alex Deucher: > > Hi Dave, Daniel, > > > > Fixes for 6.3. > > > > The following changes since commit 66305069eb6d17d9190cbcd196f3f7487df47ae8: > > > >Merge tag 'drm-misc-fixes-2023-02-23' of > >

Re: [pull] amdgpu, amdkfd drm-fixes-6.3

2023-03-09 Thread Chen, Xiaogang
On 3/9/2023 11:32 AM, Alex Deucher wrote: Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding. On Thu, Mar 9, 2023 at 12:16 PM Felix Kuehling wrote: Am 2023-03-08 um 23:38 schrieb Alex Deucher: Hi Dave,

Re: [PATCH v3 02/17] drm/connector: Add enum documentation to drm_colorspace

2023-03-09 Thread Sebastian Wick
On Thu, Mar 9, 2023 at 11:03 AM Pekka Paalanen wrote: > > On Thu, 9 Mar 2023 01:56:11 +0100 > Sebastian Wick wrote: > > > On Wed, Mar 8, 2023 at 9:59 AM Pekka Paalanen wrote: > > > > > > On Tue, 7 Mar 2023 10:10:52 -0500 > > > Harry Wentland wrote: > > > > > > > From: Joshua Ashton > > > > >

[PATCH] drm/amd/display: use a more accurate check in dm_helpers_dp_read_dpcd()

2023-03-09 Thread Hamza Mahfooz
We should be checking if drm_dp_dpcd_read() returns the size that we are asking it to read instead of just checking if it is greater than zero. Also, we should WARN_ON() here since this condition is only ever met, if there is an issue worth investigating. So, compare the return value of

Re: [PATCH] drm/amdkfd: fix potential kgd_mem UAFs

2023-03-09 Thread Felix Kuehling
Am 2023-03-08 um 16:37 schrieb Chia-I Wu: kgd_mem should be accessed with p->mutex locked, or it could have been freed by kfd_ioctl_free_memory_of_gpu. Thank you for the patch. It's not just about accessing kgd_mem with p->mutex held. It's also about holding the mutex continuously. I'd

[PATCH v3 2/2] drm/probe_helper: warning on poll_enabled for issue catching

2023-03-09 Thread Guchun Chen
In order to catch issues in other drivers to ensure proper call sequence of polling function. v2: drop Fixes tag in commit message Bug: https://gitlab.freedesktop.org/drm/amd/-/issues/2411 Reported-by: Bert Karwatzki Suggested-by: Dmitry Baryshkov Signed-off-by: Guchun Chen ---

Re: [PATCH 9/9] drm: move ttm_execbuf_util into vmwgfx

2023-03-09 Thread Intel
Hi, On 3/9/23 06:14, Zack Rusin wrote: On Wed, 2023-03-08 at 10:10 +0100, Christian König wrote: Am 08.03.23 um 06:14 schrieb Zack Rusin: On Tue, 2023-02-28 at 09:34 +0100, Christian König wrote: VMWGFX is the only remaining user of this and should probably moved over to drm_exec when it

[PATCH] drm/amd/pm: Remove unavailable temperature params

2023-03-09 Thread Lijo Lazar
Temperature limits are not available for SMU v13.0.6. Also, edge temperature is not tracked. Remove logic associated with those. Signed-off-by: Lijo Lazar Reviewed-by: Hawking Zhang --- .../drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c | 43 --- 1 file changed, 43 deletions(-)

RE: [PATCH] [RFC] drm/drm_buddy fails to initialize on 32-bit architectures

2023-03-09 Thread Paneer Selvam, Arunpravin
[AMD Official Use Only - General] Hi Luis, Sorry, I missed this one. Give me some time. I will check on it. Regards, Arun -Original Message- From: Luís Mendes Sent: Thursday, March 9, 2023 3:43 PM To: Koenig, Christian Cc: a...@linux-foundation.org; amd-gfx list ; Linux Kernel

Re: [PATCH 2/2] drm/probe_helper: warning on poll_enabled for issue catching

2023-03-09 Thread Dmitry Baryshkov
On 09/03/2023 07:48, Guchun Chen wrote: In order to catch issues in other drivers to ensure proper call sequence of polling function. Bug: https://gitlab.freedesktop.org/drm/amd/-/issues/2411 Fixes: a4e771729a51("drm/probe_helper: sort out poll_running vs poll_enabled") Previously it was

Re: [RFC v2 0/6] drm/amd/display: Pass proper parent for DM backlight device v2

2023-03-09 Thread Hans de Goede
Hi all, On 3/8/23 23:10, Hans de Goede wrote: > Hi, > > On 3/8/23 22:58, Hans de Goede wrote: >> Hi All, >> >> Here is version 2 of my patch series to pass the proper parent device >> to backlight_device_register(). >> >> New in version 2 is delaying the registering of the backlight_dev till >>

Re: [PATCH v3 02/17] drm/connector: Add enum documentation to drm_colorspace

2023-03-09 Thread Pekka Paalanen
On Thu, 9 Mar 2023 01:56:11 +0100 Sebastian Wick wrote: > On Wed, Mar 8, 2023 at 9:59 AM Pekka Paalanen wrote: > > > > On Tue, 7 Mar 2023 10:10:52 -0500 > > Harry Wentland wrote: > > > > > From: Joshua Ashton > > > > > > To match the other enums, and add more information about these values.

Re: [PATCH 9/9] drm: move ttm_execbuf_util into vmwgfx

2023-03-09 Thread Intel
On 3/8/23 10:10, Christian König wrote: Am 08.03.23 um 06:14 schrieb Zack Rusin: On Tue, 2023-02-28 at 09:34 +0100, Christian König wrote: VMWGFX is the only remaining user of this and should probably moved over to drm_exec when it starts using GEM as well. Is this because vmwgfx piggybacks

Re: [PATCH] [RFC] drm/drm_buddy fails to initialize on 32-bit architectures

2023-03-09 Thread Luís Mendes
Hi, Ping? This is actually a regression. If there is no one available to work this, maybe I can have a look in my spare time, in accordance with your suggestion. Regards, Luís On Tue, Jan 3, 2023 at 8:44 AM Christian König wrote: > > Am 25.12.22 um 20:39 schrieb Luís Mendes: > > Re-sending

[linux-next:master] BUILD REGRESSION 2c6433e9294b6d0f4d8f08c3c70a3eac434d3ec8

2023-03-09 Thread kernel test robot
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master branch HEAD: 2c6433e9294b6d0f4d8f08c3c70a3eac434d3ec8 Add linux-next specific files for 20230309 Error/Warning reports: https://lore.kernel.org/oe-kbuild-all/202302111601.jty4lkra-...@intel.com https

Re: [PATCH] drm/amd/display: Use swap() instead of open coding it

2023-03-09 Thread Hamza Mahfooz
On 3/8/23 21:52, Jiapeng Chong wrote: Swap is a function interface that provides exchange function. To avoid code duplication, we can use swap function. ./drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c:359:57-58: WARNING opportunity for swap(). Reported-by: Abaci Robot Link:

[PATCH] drm/amd/amdgpu: Add missing INT_STAT_DEBUG registers to GC 10.1 and 10.3 headers

2023-03-09 Thread Tom St Denis
Checked against database, copied from GC 9.4.2 header. Signed-off-by: Tom St Denis --- .../include/asic_reg/gc/gc_10_1_0_offset.h| 4 ++ .../include/asic_reg/gc/gc_10_1_0_sh_mask.h | 54 +++ .../include/asic_reg/gc/gc_10_3_0_offset.h| 4 ++

Re: [PATCH] drm/amdkfd: Get prange->offset after svm_range_vram_node_new

2023-03-09 Thread Felix Kuehling
Am 2023-03-08 um 13:39 schrieb Chen, Xiaogang: On 3/8/2023 11:11 AM, Felix Kuehling wrote: On 2023-03-08 02:45, Xiaogang.Chen wrote: From: Xiaogang Chen During miration to vram prange->offset is valid after vram buffer is located, either use old one or allocate a new one. Move

Re: [PATCH] drm/amd/amdgpu: Add missing INT_STAT_DEBUG registers to GC 10.1 and 10.3 headers

2023-03-09 Thread Alex Deucher
On Thu, Mar 9, 2023 at 10:24 AM Tom St Denis wrote: > > Checked against database, copied from GC 9.4.2 header. > > Signed-off-by: Tom St Denis Acked-by: Alex Deucher > --- > .../include/asic_reg/gc/gc_10_1_0_offset.h| 4 ++ > .../include/asic_reg/gc/gc_10_1_0_sh_mask.h | 54

Re: [PATCH 2/2] drm/amd/pm: Fix navi10 incorrect OD volage after resume

2023-03-09 Thread Lazar, Lijo
On 3/9/2023 8:11 AM, Quan, Evan wrote: [AMD Official Use Only - General] -Original Message- From: Deucher, Alexander Sent: Wednesday, March 8, 2023 11:20 PM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Błażej Szczygieł ; Quan, Evan Subject: [PATCH 2/2] drm/amd/pm:

Re: [PATCH] drm/amd/pm: Remove unavailable temperature params

2023-03-09 Thread Wang, Yang(Kevin)
[AMD Official Use Only - General] we'd better to add other patches to avoid create HWMON node file "temp_inputX" when smu doesn't support sensor type of AMDGPU_PP_SENSOR_EDGE_TEMP. Reviewed-by: Yang Wang Best Regards, Kevin From: amd-gfx on behalf of Lijo

Re: [PATCH 1/2] drm/amdgpu: move poll enabled/disable into non DC path

2023-03-09 Thread Alex Deucher
On Thu, Mar 9, 2023 at 12:48 AM Guchun Chen wrote: > > Some amd asics having reliable hotplug support don't call > drm_kms_helper_poll_init in driver init sequence. However, > due to the unified suspend/resume path for all asics, because > the output_poll_work->func is not set for these asics, a

RE: [PATCH 2/2] drm/probe_helper: warning on poll_enabled for issue catching

2023-03-09 Thread Chen, Guchun
> -Original Message- > From: Dmitry Baryshkov > Sent: Thursday, March 9, 2023 4:49 PM > To: Chen, Guchun ; amd- > g...@lists.freedesktop.org; dri-de...@lists.freedesktop.org; Deucher, > Alexander ; Zhang, Hawking > ; spassw...@web.de; m...@fireburn.co.uk > Subject: Re: [PATCH 2/2]

Re: [PATCH] drm/amdgpu: expose more memory stats in fdinfo

2023-03-09 Thread Marek Olšák
Ping On Thu, Feb 23, 2023 at 1:46 PM Marek Olšák wrote: > Updated patch attached. > > Marek > > On Mon, Feb 6, 2023 at 4:05 AM Christian König < > ckoenig.leichtzumer...@gmail.com> wrote: > >> Just two nit picks: >> >> +seq_printf(m, "drm-evicted-visible-vram:\t%llu KiB\n", >> +

Re: [PATCH] drm/amdgpu: expose more memory stats in fdinfo

2023-03-09 Thread Christian König
Feel free to add my rb on this and push it to amd-staging-drm-next. Christian. Am 09.03.23 um 17:02 schrieb Marek Olšák: Ping On Thu, Feb 23, 2023 at 1:46 PM Marek Olšák wrote: Updated patch attached. Marek On Mon, Feb 6, 2023 at 4:05 AM Christian König wrote:

Re: [pull] amdgpu, amdkfd drm-fixes-6.3

2023-03-09 Thread Felix Kuehling
Am 2023-03-08 um 23:38 schrieb Alex Deucher: Hi Dave, Daniel, Fixes for 6.3. The following changes since commit 66305069eb6d17d9190cbcd196f3f7487df47ae8: Merge tag 'drm-misc-fixes-2023-02-23' of git://anongit.freedesktop.org/drm/drm-misc into drm-fixes (2023-03-07 05:42:34 +1000) are