[AMD Official Use Only - General]
> -Original Message-
> From: Quan, Evan
> Sent: Thursday, March 23, 2023 3:17 PM
> To: Yang, WenYou ; Deucher, Alexander
> ; Koenig, Christian
> ; Pan, Xinhui
> Cc: Yuan, Perry ; Li, Ying ; amd-
> g...@lists.freedesktop.org; Yang, WenYou ; Liu,
> Kun
[AMD Official Use Only - General]
> -Original Message-
> From: Yuan, Perry
> Sent: Thursday, March 23, 2023 10:21 AM
> To: Yang, WenYou ; Deucher, Alexander
> ; Koenig, Christian
> ; Pan, Xinhui
> Cc: Liang, Richard qi ; Li, Ying
> ; Liu, Kun ; amd-
> g...@lists.freedesktop.org; Yang,
On 3/23/2023 3:04 PM, Yang, WenYou wrote:
[AMD Official Use Only - General]
-Original Message-
From: Lazar, Lijo
Sent: Thursday, March 23, 2023 4:29 PM
To: Yang, WenYou ; Deucher, Alexander
; Koenig, Christian
; Pan, Xinhui
Cc: Yuan, Perry ; Li, Ying ; amd-
Signed-off-by: Stanley.Yang
---
drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.c
b/drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.c
index 6d2879ac585b..f76b1cb8baf8 100644
---
[AMD Official Use Only - General]
> -Original Message-
> From: amd-gfx On Behalf Of
> Wenyou Yang
> Sent: Wednesday, March 22, 2023 5:16 PM
> To: Deucher, Alexander ; Koenig, Christian
> ; Pan, Xinhui
> Cc: Yuan, Perry ; Li, Ying ; amd-
> g...@lists.freedesktop.org; Yang, WenYou ;
[AMD Official Use Only - General]
Thanks Evan.
> > -Original Message-
> > From: amd-gfx On Behalf Of
> > Wenyou Yang
> > Sent: Wednesday, March 22, 2023 5:16 PM
> > To: Deucher, Alexander ; Koenig,
> Christian
> > ; Pan, Xinhui
> > Cc: Yuan, Perry ; Li, Ying ;
> amd-
> >
Added AMD_IP_BLOCK_TYPE_MES to the list of engine
under amdgpu_device_ip_reinit_late_sriov, so that MES engine can be
correctly reset in SRIOV environment
Signed-off-by: Bill Liu
---
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git
[AMD Official Use Only - General]
Reviewed-by: Candice Li
Thanks,
Candice
-Original Message-
From: amd-gfx On Behalf Of Stanley.Yang
Sent: Thursday, March 23, 2023 4:35 PM
To: amd-gfx@lists.freedesktop.org
Cc: Yang, Stanley
Subject: [PATCH Review 1/1] drm/amdgpu: print ras drv fw
On 3/22/2023 2:46 PM, Wenyou Yang wrote:
When the CPU SMT status change in the fly, sent the SMT-enable
message to pmfw to notify it that the SMT status changed.
Signed-off-by: Wenyou Yang
---
drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c | 41 +++
[AMD Official Use Only - General]
> -Original Message-
> From: Lazar, Lijo
> Sent: Thursday, March 23, 2023 4:29 PM
> To: Yang, WenYou ; Deucher, Alexander
> ; Koenig, Christian
> ; Pan, Xinhui
> Cc: Yuan, Perry ; Li, Ying ; amd-
> g...@lists.freedesktop.org; Liu, Kun ; Liang, Richard
As soon as control->i2c_address is set, return; remove the "break;" from the
switch--it is unnecessary. This mimics what happens when for some cases in the
switch, we call helper functions with "return ".
Remove final function "return true;" to indicate that the switch is final and
terminal, and
Remove second switch since it already has its own function and case in the
first switch. This also avoids requalifying the EEPROM I2C address for VEGA20,
SIENNA CICHLID, and ALDEBARAN, as those have been set by the first switch and
shouldn't match SMU v13.0.x.
Cc: Candice Li
Cc: Kent Russell
[AMD Official Use Only - General]
> -Original Message-
> From: amd-gfx On Behalf Of
> Wenyou Yang
> Sent: Wednesday, March 22, 2023 5:16 PM
> To: Deucher, Alexander ; Koenig, Christian
> ; Pan, Xinhui
> Cc: Yuan, Perry ; Li, Ying ; amd-
> g...@lists.freedesktop.org; Yang, WenYou ;
We are seeking nominations for candidates for election to the X.org
Foundation Board of Directors. However, as we presently do not have
enough nominations to start the election - the decision has been made to
extend the timeline by 2 weeks. Note this is a fairly regular part of
the elections
[AMD Official Use Only - General]
Good catch. This is a typo
The change is
Reviewed-by: Hawking Zhang
Regards,
Hawking
-Original Message-
From: Koenig, Christian
Sent: Thursday, March 23, 2023 21:29
To: SHANMUGAM, SRINIVASAN ; Deucher, Alexander
; Limonciello, Mario ;
Zhang,
On 2023-03-23 09:29, Christian König wrote:
> Am 23.03.23 um 13:04 schrieb Srinivasan Shanmugam:
>> CC drivers/gpu/drm/amd/amdgpu/amdgpu_ras.o
>> drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c:2567:28: error: bitwise or with
>> non-zero value always evaluates to true
>>
Am 2023-03-23 um 09:50 schrieb Kim, Jonathan:
[Public]
-Original Message-
From: Kuehling, Felix
Sent: Monday, March 20, 2023 5:50 PM
To: Kim, Jonathan ; amd-
g...@lists.freedesktop.org; dri-de...@lists.freedesktop.org
Subject: Re: [PATCH 15/32] drm/amdkfd: prepare trap workaround
[Public]
> -Original Message-
> From: SHANMUGAM, SRINIVASAN
>
> Sent: Thursday, March 23, 2023 07:32
> To: Koenig, Christian ; Deucher, Alexander
> ; Limonciello, Mario
> ; Li, Candice ; Zhang,
> Hawking
> Cc: amd-gfx@lists.freedesktop.org; SHANMUGAM, SRINIVASAN
>
> Subject: [PATCH]
CC drivers/gpu/drm/amd/amdgpu/amdgpu_ras.o
drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c:2567:28: error: bitwise or with
non-zero value always evaluates to true [-Werror,-Wtautological-bitwise-compare]
if (adev->ras_hw_enabled | AMDGPU_RAS_BLOCK__DF)
Series is:
Reviewed-by: Alex Deucher
On Thu, Mar 23, 2023 at 2:06 AM Luben Tuikov wrote:
>
> As soon as control->i2c_address is set, return; remove the "break;" from the
> switch--it is unnecessary. This mimics what happens when for some cases in the
> switch, we call helper functions with
[AMD Official Use Only - General]
Thanks a lot Christian!, much appreciate for your help!
Best Regards,
Srini
-Original Message-
From: Koenig, Christian
Sent: Thursday, March 23, 2023 6:59 PM
To: SHANMUGAM, SRINIVASAN ; Deucher, Alexander
; Limonciello, Mario ;
Zhang, Hawking ;
[AMD Official Use Only - General]
Thanks a lot Luben!, much appreciate for your help!
-Original Message-
From: Tuikov, Luben
Sent: Thursday, March 23, 2023 7:24 PM
To: Koenig, Christian ; SHANMUGAM, SRINIVASAN
; Deucher, Alexander ;
Limonciello, Mario ; Zhang, Hawking
Cc:
[Public]
> -Original Message-
> From: SHANMUGAM, SRINIVASAN
>
> Sent: Thursday, March 23, 2023 07:37
> To: Limonciello, Mario ; Koenig, Christian
> ; Deucher, Alexander
> ; Li, Candice ;
> Zhang, Hawking
> Cc: amd-gfx@lists.freedesktop.org
> Subject: RE: [PATCH] drm/amd/amdgpu: Fix
Am 23.03.23 um 13:04 schrieb Srinivasan Shanmugam:
CC drivers/gpu/drm/amd/amdgpu/amdgpu_ras.o
drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c:2567:28: error: bitwise or with
non-zero value always evaluates to true [-Werror,-Wtautological-bitwise-compare]
if (adev->ras_hw_enabled |
[Public]
> -Original Message-
> From: Kuehling, Felix
> Sent: Monday, March 20, 2023 5:50 PM
> To: Kim, Jonathan ; amd-
> g...@lists.freedesktop.org; dri-de...@lists.freedesktop.org
> Subject: Re: [PATCH 15/32] drm/amdkfd: prepare trap workaround for gfx11
>
>
> On 2023-01-25 14:53,
[AMD Official Use Only - General]
Thanks a lot Hawking!, much appreciate for your help in reviewing!
Best Regards,
Srini
-Original Message-
From: Zhang, Hawking
Sent: Thursday, March 23, 2023 7:15 PM
To: Koenig, Christian ; SHANMUGAM, SRINIVASAN
; Deucher, Alexander ;
Limonciello,
[Public]
Thanks a lot Mario!, much appreciate for your help in reviewing!
Best Regards,
Srini
-Original Message-
From: Limonciello, Mario
Sent: Thursday, March 23, 2023 6:09 PM
To: SHANMUGAM, SRINIVASAN ; Koenig, Christian
; Deucher, Alexander ; Li,
Candice ; Zhang, Hawking
Cc:
Hi Dave, Daniel,
Fixes for 6.3.
The following changes since commit e8d018dd0257f744ca50a729e3d042cf2ec9da65:
Linux 6.3-rc3 (2023-03-19 13:27:55 -0700)
are available in the Git repository at:
https://gitlab.freedesktop.org/agd5f/linux.git
tags/amd-drm-fixes-6.3-2023-03-23
for you to
CC drivers/gpu/drm/amd/amdgpu/amdgpu_ras.o
drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c:2567:28: error: bitwise or with
non-zero value always evaluates to true [-Werror,-Wtautological-bitwise-compare]
if (adev->ras_hw_enabled | AMDGPU_RAS_BLOCK__DF)
[Public]
Hi Mario,
Thanks for your comments, it was on " origin/amd-staging-drm-next"
Best Regards,
Srini
-Original Message-
From: Limonciello, Mario
Sent: Thursday, March 23, 2023 6:03 PM
To: SHANMUGAM, SRINIVASAN ; Koenig, Christian
; Deucher, Alexander ; Li,
Candice ; Zhang,
On 3/22/2023 00:48, Wenyou Yang wrote:
When the CPU SMT status change in the fly, sent the SMT-enable
message to pmfw to notify it that the SMT status changed.
Signed-off-by: Wenyou Yang
---
drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c | 41 +++
[AMD Official Use Only - General]
> -Original Message-
> From: Kuehling, Felix
> Sent: Monday, March 20, 2023 8:31 PM
> To: Kim, Jonathan ; amd-
> g...@lists.freedesktop.org; dri-de...@lists.freedesktop.org
> Subject: Re: [PATCH 19/32] drm/amdkfd: add runtime enable operation
>
>
> On
On Tue, Mar 21, 2023 at 11:47 PM Christian König
wrote:
>
> Hi Mikhail,
>
> That looks like a reference counting issue to me.
>
> I'm going to take a look, but we have already fixed one of those recently.
>
> Probably best that you try this on drm-fixes, just to double check that
> this isn't the
[AMD Official Use Only - General]
Hello Rodrigo and Harry,
I would like to propose some changes to keep this patch consistent with the
naming scheme and general organization of the drm_dp.h file.
#define DP_EDP_OLED_VESA_BRIGHTNESS_ON 0x80
It would be better to use the (1<<7)
On 3/22/2023 00:48, Wenyou Yang wrote:
Add the support to PPSMC_MSG_SetCClkSMTEnable(0x58) message to pmfw
for vangogh.
Signed-off-by: Wenyou Yang
---
.../pm/swsmu/inc/pmfw_if/smu_v11_5_ppsmc.h| 3 ++-
drivers/gpu/drm/amd/pm/swsmu/inc/smu_types.h | 3 ++-
[Public]
> -Original Message-
> From: Kuehling, Felix
> Sent: Thursday, February 16, 2023 6:44 PM
> To: Kim, Jonathan ; amd-
> g...@lists.freedesktop.org; dri-de...@lists.freedesktop.org
> Subject: Re: [PATCH 03/32] drm/amdkfd: prepare per-process debug enable
> and disable
>
>
> On
Sorry, I think that was just a stray comment that I messed up while
editing my response. You can ignore it.
Regards,
Felix
Am 2023-03-23 um 15:12 schrieb Kim, Jonathan:
index c06ada0844ba..a2ac98d06e71 100644
--- a/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c
+++
tree/branch:
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
branch HEAD: 7c4a254d78f89546d0e74a40617ef24c6151c8d1 Add linux-next specific
files for 20230323
Error/Warning reports:
https://lore.kernel.org/oe-kbuild-all/202303161521.jbgbafjj-...@intel.com
https
On 3/23/2023 12:41, Limonciello, Mario wrote:
On 3/22/2023 00:48, Wenyou Yang wrote:
When the CPU SMT status change in the fly, sent the SMT-enable
message to pmfw to notify it that the SMT status changed.
Signed-off-by: Wenyou Yang
---
drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c | 41
Hi Wenyou Yang, first of all thanks for the improvement!
I'd like to ask you (and all CCed) if it would be possible to explain a
bit the goal / functionality behind these patches.
By reading the commit descriptions and code, I can understand code-wise
what's going on and how this will message
On Fri, Mar 24, 2023 at 05:34:18AM +0800, kernel test robot wrote:
> tree/branch:
> https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
> branch HEAD: 7c4a254d78f89546d0e74a40617ef24c6151c8d1 Add linux-next
> specific files for 20230323
>
> Err
[AMD Official Use Only - General]
> -Original Message-
> From: Limonciello, Mario
> Sent: Friday, March 24, 2023 1:42 AM
> To: Yang, WenYou ; Deucher, Alexander
> ; Koenig, Christian
> ; Pan, Xinhui
> Cc: Li, Ying ; Liu, Kun ; amd-
> g...@lists.freedesktop.org; Liang, Richard qi
>
[AMD Official Use Only - General]
> -Original Message-
> From: Limonciello, Mario
> Sent: Friday, March 24, 2023 1:15 AM
> To: Yang, WenYou ; Deucher, Alexander
> ; Koenig, Christian
> ; Pan, Xinhui
> Cc: Li, Ying ; Liu, Kun ; amd-
> g...@lists.freedesktop.org; Liang, Richard qi
>
This patch set allows for FW assisted shadowing on supported
platforms. A new enough CP FW is required. This feature is
required for mid command buffer preemption and proper SR-IOV
support. This also simplifies the UMDs by allowing persistent
hardware state when the command submission executes.
From: Christian König
Add ring callback for gfx to update the CP firmware
with the new shadow information before we process the
IB.
v2: add implementation for new packet (Alex)
v3: add current FW version checks (Alex)
v4: only initialize shadow on first use
Only set IB_VMID when a valid
Use this to determine if we support the new SET_Q_PREEMPTION_MODE
packet.
Signed-off-by: Alex Deucher
---
drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.h | 2 ++
drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c | 13 +
2 files changed, 15 insertions(+)
diff --git
From: Christian König
Add support for submitting the shadow update packet
when submitting an IB. Needed for MCBP on GFX11.
v2: update API for CSA (Alex)
v3: fix ordering; SET_Q_PREEMPTION_MODE most come before COND_EXEC
Add missing check for AMDGPU_CHUNK_ID_CP_GFX_SHADOW in
Use the new callback to fetch the data. Return an error if
not supported. UMDs should use this query to check whether
shadow buffers are supported and if so what size they
should be.
v2: return an error rather than a zerod structure.
v3: drop GDS, move into dev_info structure. Data will be
It varies by generation and we need to know the size
to expose this via debugfs.
Reviewed-by: Christian König
Signed-off-by: Alex Deucher
---
drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c | 2 ++
drivers/gpu/drm/amd/amdgpu/amdgpu_ring.h | 1 +
2 files changed, 3 insertions(+)
diff --git
So UMDs can determine whether the kernel supports this.
Mesa MR: https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21986
Signed-off-by: Alex Deucher
---
drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git
For GFX11, the UMD needs to allocate some shadow buffers
to be used for preemption. The UMD allocates the buffers
and passes the GPU virtual address to the kernel since the
kernel will program the packet that specified these
addresses as part of its IB submission frame.
v2: UMD passes shadow
Add UAPI to query the GFX shadow buffer requirements
for preemption on GFX11. UMDs need to specify the shadow
areas for preemption.
v2: move into existing asic info query
drop GDS as its use is determined by the UMD (Marek)
Signed-off-by: Alex Deucher
---
include/uapi/drm/amdgpu_drm.h | 8
We need to reset the shadow state every time we submit an
IB and there needs to be a COND_EXEC packet after the
SET_Q_PREEMPTION_MODE packet for it to work properly, so
we should emit both of these packets regardless of whether
there is a job present or not.
Reviewed-by: Christian König
Used to get the size and alignment requirements for
the gfx shadow buffer for preemption.
v2: use FW version check to determine whether to
return a valid size here
return an error if not supported (Alex)
v3: drop GDS (Alex)
Signed-off-by: Alex Deucher
---
Only set the supported flag if we have new enough CP FW.
XXX: don't commit this until the CP FW versions are finalized!
Acked-by: Christian König
Signed-off-by: Alex Deucher
---
drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c | 9 +
1 file changed, 9 insertions(+)
diff --git
To provide IP specific shadow sizes. UMDs will use
this to query the kernel driver for the size of the
shadow buffers.
v2: make callback return an int (Alex)
v3: drop GDS (Alex)
Signed-off-by: Alex Deucher
---
drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.h | 10 ++
1 file changed, 10
Provide a debugfs interface to access the MQD. Useful for
debugging issues with the CP and MES hardware scheduler.
Reviewed-by: Christian König
Signed-off-by: Alex Deucher
---
drivers/gpu/drm/amd/amdgpu/amdgpu_ring.c | 60 +++-
1 file changed, 59 insertions(+), 1
On 3/23/2023 11:36 PM, Limonciello, Mario wrote:
On 3/23/2023 12:41, Limonciello, Mario wrote:
On 3/22/2023 00:48, Wenyou Yang wrote:
When the CPU SMT status change in the fly, sent the SMT-enable
message to pmfw to notify it that the SMT status changed.
Signed-off-by: Wenyou Yang
---
58 matches
Mail list logo
