Re: [PATCH] Add freesync ioctl interface

I thought I'd add some notes as a someone who also plays games on Windows with Freesync... I have a 4K monitor with Freesync, the range is 45 to 60 Hz. It might sounds narrow but it allows you to have a smooth experience even at very high resolutions and settings. If the game can't hit 60 fps

Re: [PATCH] amdgpu: Fix failing boot after support for third vce ring

-gfx <amd-gfx-boun...@lists.freedesktop.org> on behalf of > Ernst Sjöstrand <ern...@gmail.com> > *Sent:* Friday, October 14, 2016 08:49 > *To:* amd-gfx@lists.freedesktop.org > *Cc:* Ernst Sjöstrand > *Subject:* [PATCH] amdgpu: Fix failing boot aft

Re: [PATCH] amdgpu: Fix failing boot after support for third vce ring

/amdgpu/vce_v3_0.c:855:16: note: (near initialization for ‘vce_v3_0_ring_phys_funcs.get_wptr’) drivers/gpu/drm/amd/amdgpu/vce_v3_0.c:856:2: error: unknown field ‘nop’ specified in initializer .nop = VCE_CMD_NO_OP, ^ 2016-10-14 15:15 GMT+02:00 Ernst Sjöstrand <ern...@gmail.com>: > I'

[PATCH] amdgpu: Fix failing boot after support for third vce ring

My Fiji class Fury fails to boot after commit 6f0359ff73076483902de0c17f9649bf55651e2a "drm/amdgpu/vce3: add support for third vce ring" This commits reverts the number of vce rings back to 2, but leaves the other changes intact. Signed-off-by: Ernst Sjöstrand <ern...@gmail.com>

Re: [PATCH] amdgpu: Fix failing boot after support for third vce ring

If you are still getting failures with drm-next-4.9(-wip) or > amd-staging-4.7, please file a bug and attach your dmesg output. > > > > Alex > > > > *From:* Ernst Sjöstrand [mailto:ern...@gmail.com] > *Sent:* Friday, October 14, 2016 10:23 AM > *To:* Deucher,

Re: [PATCH] amdgpu: Fix failing boot after support for third vce ring

https://cgit.freedesktop.org/~agd5f/linux/commit/?h=drm-next-4.7-wip=9d24b304abbe5380da1bc782b4460596e7cb1109 2016-10-14 16:12 GMT+02:00 Deucher, Alexander <alexander.deuc...@amd.com>: > What patch are you referring to? > > > > Alex > > > > *From:* Ernst S

Re: [PATCH] amdgpu: Fix failing boot after support for third vce ring

1109 as well? > > > I've booted the tip of our staging-4.7 branch with a FIJI device (FURY) > and was able to play videos (vdpau) and normal GL apps. > > > Tom > > > -- > *From:* Ernst Sjöstrand <ern...@gmail.com> > *Sent:* Friday, Octob

Testing dc-drm-next-atomic-wip

Hi, this is more feedback about how the code works and runs rather than what you're really looking for, so I thought I'd start a new thread. :-) I get the following error when compiling and (obviously) forgetting to enable the new DC option. I see the option will be removed, so maybe that

Re: [PATCH v2] drm/amd/display: Disable pre-Vega ASICs by default

Add Fiji to the help text? Regards //Ernst 2017-09-12 22:46 GMT+02:00 Harry Wentland : > v2: Clarify help text for pre-vega config > > Signed-off-by: Harry Wentland > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 ++ >

[PATCH 2/5] drm/amd/powerplay: Fix missing newlines at end of file

Signed-off-by: Ernst Sjöstrand <ern...@gmail.com> --- drivers/gpu/drm/amd/include/kgd_pp_interface.h | 2 +- drivers/gpu/drm/amd/powerplay/hwmgr/pp_overdriver.h | 2 +- drivers/gpu/drm/amd/powerplay/hwmgr/ppatomfwctrl.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff

[PATCH 5/5] drm/amd/powerplay: Followup fixes to mc_reg_address

any known problems, perhaps avoided by luck. Signed-off-by: Ernst Sjöstrand <ern...@gmail.com> --- drivers/gpu/drm/amd/amdgpu/si_dpm.c | 10 +++--- drivers/gpu/drm/amd/powerplay/smumgr/ci_smumgr.c | 12 drivers/gpu/drm/amd/powerplay/smumgr/iceland_sm

[PATCH 4/5] drm/amd/powerplay: Fix buffer overflows with mc_reg_address

enting. It's fine if j reaches max after we're done. This allows the last entry of the array to be filled without an error message for example. Changed some whitespace to clarify grouping. Signed-off-by: Ernst Sjöstrand <ern...@gmail.com> --- drivers/gpu/drm/amd/amdgpu/ci_dpm.c

[PATCH 1/5] drm/amd/powerplay: Minor fixes in processpptables.c

Reported by smatch: init_overdrive_limits() error: uninitialized symbol 'result'. get_clock_voltage_dependency_table() warn: inconsistent indenting Signed-off-by: Ernst Sjöstrand <ern...@gmail.com> --- drivers/gpu/drm/amd/powerplay/hwmgr/processpptables.c | 6 +++--- 1 file changed, 3 inse

[PATCH 3/5] drm/amd/amdgpu: Fix missing null check in atombios_i2c.c

Reported by smatch: amdgpu_atombios_i2c_process_i2c_ch() error: we previously assumed 'buf' could be null Signed-off-by: Ernst Sjöstrand <ern...@gmail.com> --- drivers/gpu/drm/amd/amdgpu/atombios_i2c.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/drive

[PATCH 2/3] amdgpu/dc: Fix potential null dereference in amdgpu_dm.c

Signed-off-by: Ernst Sjöstrand <ern...@gmail.com> --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c index e6bfa9

[PATCH 1/3] amdgpu/dc: fix more indentation warnings

More "warn: inconsistent indenting" fixes from smatch. Signed-off-by: Ernst Sjöstrand <ern...@gmail.com> --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 10 +- .../gpu/drm/amd/display/dc/i2caux/dce110/aux_engine_dce110.c | 2 +- 2 files changed, 6

[PATCH 3/3] amdgpu/dc: Fix missing null checks in amdgpu_dm.c

From smatch: error: we previously assumed X could be null Signed-off-by: Ernst Sjöstrand <ern...@gmail.com> --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 15 +++ 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgp

More smatch fixes

I saw the previous smatch fixes and thought I would try to fix a few. Since the other patches were applied to agd5f/amd-staging-drm-next I continued there. ___ amd-gfx mailing list amd-gfx@lists.freedesktop.org

[PATCH v2 2/3] amdgpu/dc: Fix potential null dereferences in amdgpu_dm.c

Signed-off-by: Ernst Sjöstrand <ern...@gmail.com> --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c index e6bfa9

[PATCH v2 3/3] amdgpu/dc: Fix missing null checks in amdgpu_dm.c

From smatch: error: we previously assumed X could be null Signed-off-by: Ernst Sjöstrand <ern...@gmail.com> --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 17 - 1 file changed, 12 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/amd/display/amd

[PATCH v2 1/3] amdgpu/dc: fix more indentation warnings

More "warn: inconsistent indenting" fixes from smatch. Signed-off-by: Ernst Sjöstrand <ern...@gmail.com> --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 10 +- .../gpu/drm/amd/display/dc/i2caux/dce110/aux_engine_dce110.c | 2 +- 2 files changed, 6

[PATCH] amdgpu/dc: Fix double unlock in amdgpu_dm_commit_planes

Reported by smartch: amdgpu_dm_commit_planes() error: double unlock 'spin_lock:>dev->event_lock' amdgpu_dm_commit_planes() error: double unlock 'irqsave:flags' The error path doesn't return so we only need a single unlock. Signed-off-by: Ernst Sjöstrand <ern...@gmail.com> --- dri

Re: [PATCH 1/2] drm/amdgpu: potential uninitialized variable in amdgpu_vce_ring_parse_cs()

Can't find these anywhere yet, errors still there. https://patchwork.freedesktop.org/series/31220/ Regards //Ernst 2017-09-30 10:25 GMT+02:00 Christian König : > Am 30.09.2017 um 10:13 schrieb Dan Carpenter: >> >> We shifted some code around in commit 9cca0b8e5df0

Re: [PATCH 3/3] amdgpu/dc: Fix missing null checks in amdgpu_dm.c

2017-11-07 15:18 GMT+01:00 Deucher, Alexander <alexander.deuc...@amd.com>: >> -Original Message- >> From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf >> Of Ernst Sjöstrand >> Sent: Monday, November 06, 2017 6:55 PM >> To: amd-gf

Re: RFC for a render API to support adaptive sync and VRR

It would be really nice to have support for the automatic extension-less fullscreen game scenario. Maybe you don't have to solve everything in the first implementation... So a friendly ping here! Regards //Ernst Den tis 24 apr. 2018 kl 23:58 skrev Daniel Vetter : > > On Tue, Apr 24, 2018 at 4:28

Re: Making use of more Gitlab features for xf86-video-amdgpu

Couldn't you add a "service account" for the mailing list and enable notifications for it? Den fre 21 sep. 2018 kl 11:50 skrev Michel Dänzer : > > On 2018-09-21 9:57 a.m., Christian König wrote: > > Am 21.09.2018 um 09:42 schrieb Michel Dänzer: > >> On 2018-09-21 9:22 a.m., Zhou, David(ChunMing)

Re: [PATCH] drm/amdgpu: Add delay after enable RLC ucode

Does this solve a problem? If so, you could write that in the commit message. Regards //Ernst Den tors 22 nov. 2018 kl 19:22 skrev Liu, Shaoyun : > > Driver shouldn't try to access any GFX registers until RLC is idle. > During the test, it took 12 seconds for RLC to clear the BUSY bit > in

Re: [PATCH 1/2] drm/amd/powerplay: correct power reading on fiji

Wasn't there a long discussion about this timing some months ago... ? Regards //Ernst Den tors 28 feb. 2019 kl 11:47 skrev Xu, Feifei : > > Reviewed-by: Feifei Xu > > -Original Message- > From: amd-gfx On Behalf Of Evan Quan > Sent: Thursday, February 28, 2019 6:32 PM > To:

Re: Slow memory access when using OpenCL without X11

Does echo high > /sys/class/drm/card0/device/power_dpm_force_performance_level or setting cpu scaling governor to performance affect it at all? Regards //Ernst Den tors 14 mars 2019 kl 14:31 skrev Lauri Ehrenpreis : > > I tried also with those 2 boards now: >

Re: [PATCH v2] dri2: reply to client for WaitMSC request in any case

This looks like a v2 with silightly different semantics? Den mån 3 juni 2019 kl 09:26 skrev Cui, Flora : > > ping... > > commit 47613e8e8f4a5e3b25830e3c015a4a217fcbe469 > Author: Flora Cui > Date: Wed May 29 14:18:50 2019 +0800 > > dri2: reply to client for WaitMSC request in any case > >

[PATCH v2] drm/amd/amdgpu: Tabs instead of spaces in gfx_v10_0.c

Done automatically with unexpand, plus some extra 7-space lines. Signed-off-by: Ernst Sjöstrand --- drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c | 168 - 1 file changed, 84 insertions(+), 84 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c b/drivers/gpu/drm

[PATCH 1/2] drm/amd/amdgpu: Tabs instead of spaces in gfx_v10_0.c

Done automatically with unexpand. Signed-off-by: Ernst Sjöstrand --- drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c | 158 - 1 file changed, 79 insertions(+), 79 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c b/drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c index

[PATCH 2/2] drm/amd/amdgpu: Indent AMD_IS_APU properly

Reported by smatch: drivers/gpu/drm/amd/amdgpu/soc15.c:715 soc15_get_pcie_usage() warn: inconsistent indenting And a similar one in si.c. Signed-off-by: Ernst Sjöstrand --- drivers/gpu/drm/amd/amdgpu/si.c| 4 ++-- drivers/gpu/drm/amd/amdgpu/soc15.c | 4 ++-- 2 files changed, 4 insertions

[PATCH 5/6] drm/amd/amdgpu: Fix style issues in dcn20_resource.c

Inconsistent indentation and mixed use of brackets. Signed-off-by: Ernst Sjöstrand --- drivers/gpu/drm/amd/display/dc/dcn20/dcn20_resource.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/dcn20/dcn20_resource.c b/drivers/gpu/drm

[PATCH 2/6] drm/amd/amdgpu: Fix amdgpu_set_pp_od_clk_voltage error check

Reported by smatch: drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c:693 amdgpu_set_pp_od_clk_voltage() error: uninitialized symbol 'ret'. Signed-off-by: Ernst Sjöstrand --- drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm

[PATCH 1/6] drm/amd/amdgpu: Indent AMD_IS_APU properly

Reported by smatch: drivers/gpu/drm/amd/amdgpu/soc15.c:715 soc15_get_pcie_usage() warn: inconsistent indenting And a similar one in si.c. Signed-off-by: Ernst Sjöstrand --- drivers/gpu/drm/amd/amdgpu/si.c| 4 ++-- drivers/gpu/drm/amd/amdgpu/soc15.c | 4 ++-- 2 files changed, 4 insertions

[PATCH 4/6] drm/amd/amdgpu: Check stream in amdgpu_dm_commit_planes

Reported by smatch: amdgpu_dm.c:5637 amdgpu_dm_commit_planes() error: we previously assumed 'acrtc_state->stream' could be null This seems to be checked for null pretty consistently elsewhere. Signed-off-by: Ernst Sjöstrand --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 3 ++- 1 f

[PATCH 3/6] drm/amd/amdgpu: amdgpu_hwmon_show_temp: initialize temp

Reported by smatch: drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c:1496 amdgpu_hwmon_show_temp() error: uninitialized symbol 'temp'. Signed-off-by: Ernst Sjöstrand --- drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu

[PATCH 6/6] drm/amd/amdgpu: sdma_v4_0_start: initialize r

Reported by smatch: drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c:1167 sdma_v4_0_start() error: uninitialized symbol 'r'. Signed-off-by: Ernst Sjöstrand --- drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/sdma_v4_0

Re: [PATCH] drm/amdgpu: Handle job is NULL use case in amdgpu_device_gpu_recover

Den tis 27 aug. 2019 kl 20:17 skrev Andrey Grodzovsky : > > This should be checked at all places job is accessed. > > Signed-off-by: Andrey Grodzovsky > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git

Re: [PATCH 1/2] drm/amd/display: Embed DCN2 SOC bounding box

Isn't NV10 a family of chips in Nouveau? Regards //Ernst Den tis 30 juli 2019 kl 15:57 skrev Nicholas Kazlauskas : > > [Why] > In order to support uclk switching on NV10 the SOC bounding box > needs to be updated. > > [How] > We currently read the constants from the gpu info FW, but supporting >

Re: [PATCH] drm/amd/display: re-enable wait in pipelock, but add timeout

The same bug is listed twice. Did you mean a third bug? Den tors 21 nov. 2019 kl 00:25 skrev Alex Deucher : > > Ping? > > On Fri, Nov 15, 2019 at 11:01 AM Alex Deucher wrote: > > > > Removing this causes hangs in some games, so re-add it, but add > > a timeout so we don't hang while switching

Re: Radeon rx 590 Fatboy on Linux still don't work

Could it be something platform related? "Socket 2011 for 2nd Generation Core™ i7 Processors " is probably not very well tested these days. It should work of course. Den fre 17 jan. 2020 kl 18:48 skrev Martin Bångens : > > I still have problems with my video card. I don't think this is about >

Re: [PATCH v2 00/11] amd/display: Add GFX9+ modifier support.

Den fre 4 sep. 2020 kl 18:07 skrev Bas Nieuwenhuizen < b...@basnieuwenhuizen.nl>: > This adds modifier support to radeonsi. > Wouldn't it be more correct to say that this adds modifier support to amdgpu (and enables it to work with radeonsi OpenGL) or something like that? //E > It has been

kernel NULL pointer dereference with dce_aux_transfer_raw

Hi, first I had some enabling link 2 failed: 15 after DPMS, but then I got a NULL pointer dereference later. I'm running 5.8.8 + "Require primary plane to be enabled whenever the CRTC is" 2x 4K DisplayPort monitors. Gnome Wayland desktop, Ubuntu 20.10. sep 14 00:22:01 mammut kernel:

Re: [PATCH] gpu/drm/radeon: fix spellint typo in comments

There is a typo in your patch subject. ;-) Regards //Ernst Den tis 22 sep. 2020 kl 15:11 skrev Wang Qing : > Modify the comment typo: "definately" -> "definitely". > > Signed-off-by: Wang Qing > --- > drivers/gpu/drm/radeon/radeon_vm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >

Re: [PATCH] drm/amdgpu: use function pointer for gfxhub functions

Can some of them be null and others not? Perhaps write that in the comments somewhere. Like v1 doesn't have get_fb_location for example. Regards //Ernst Den fre 18 sep. 2020 kl 01:16 skrev Oak Zeng : > gfxhub functions are now called from function pointers, > instead of from asic-specific

Re: [PATCH] drm/amd/pm: Activate a more aggressive DPM policy while there's heavy load.

Is this really a patch for kernel.org? Seems like a hack for Stadia or something. (And the patch description is not very good...) This should really be made into a generic solution. Regards //Ernst Den tis 27 okt. 2020 kl 07:38 skrev Li, Xin (Justin) : > [AMD Official Use Only - Internal

Re: The inherent defect of the AMDGPU driver about hotplug

Have you tried a much later kernel btw? I saw you mentioned 4.19. Den tis 16 juni 2020 kl 02:50 skrev Aaron Chou : > Yes, I agree. > > On Tue, Jun 16, 2020 at 3:08 AM Alex Deucher > wrote: > > > > On Mon, Jun 15, 2020 at 5:30 AM Aaron Chou > wrote: > > > > > > About one month ago, I have asked

Re: [bug] Radeon 3900XT not switch to graphic mode on kernel 5.10

-2 means no such file or directory. Perhaps you need to rebuild your ramdisk manually for some reason. Regards //Ernst Den sön 27 dec. 2020 kl 17:58 skrev Mikhail Gavrilov < mikhail.v.gavri...@gmail.com>: > On Sun, 27 Dec 2020 at 21:39, Mikhail Gavrilov > wrote: > > I suppose the root of cause

Re: [PATCH] drm/amd/display: Add DC feature flag to disable audio

rieb Harry Wentland: > > On 2021-01-26 9:51 a.m., Ernst Sjöstrand wrote: > >> No problems with amdgpu, but when my headphone port is glitching I > >> often end up with some HDMI audio output selected instead. > >> > > > > Wouldn't this be better fixed in the au

[PATCH] drm/amd/display: Add DC feature flag to disable audio

With the pre-DC path you could set audio=0 to disable audio. This adds a similar feature for the DC path with amdgpu.dcfeaturemask=0x10. Signed-off-by: Ernst Sjöstrand --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 3 +++ drivers/gpu/drm/amd/display/dc/core/dc_resource.c | 7

Re: [PATCH] drm/amd/display: Add DC feature flag to disable audio

No problems with amdgpu, but when my headphone port is glitching I often end up with some HDMI audio output selected instead. It also cleans up the clutter in the audio selection list. //E Den tis 26 jan. 2021 kl 15:34 skrev Alex Deucher : > On Tue, Jan 26, 2021 at 9:32 AM Ernst Sjöstr

Re: [PATCH] drm/amdgpu/vcn: drop gfxoff control for VCN2+

Hi, doesn't this patch apply the change to VCN1.0 also, which has that bug you mentioned? Regards //Ernst Den mån 7 juni 2021 kl 22:29 skrev Alex Deucher : > Drop disabling of gfxoff during VCN use. This allows gfxoff > to kick in and potentially save power if the user is not using > gfx for

Re: [PATCH] drm/amd/pm: enable ASPM by default

You could even write why it was disabled before and why you can enable it now again in the commit message. Regards //Ernst Den tis 11 maj 2021 kl 09:25 skrev Chen, Jiansong (Simon) < jiansong.c...@amd.com>: > [AMD Official Use Only - Internal Distribution Only] > > Better to make the commit msg

Re: 6900XT HDMI 2.1 -> Missing 4K120Hz

Which kernel version are you running? Den sön 28 feb. 2021 kl 23:48 skrev Adolfo Rodrigues < adolfotreg...@gmail.com>: > Hi. > I cannot find a way to enable 4K @ 120Hz over hdmi 2.1. It seams limited > to HDMI 2.0b.. is it ? > > Under Windows 10 it works fine but not under linux. Why ? > > >

[PATCH] drm/amd/amdgpu: Increase HWIP_MAX_INSTANCE to 10

-off-by: Ernst Sjöstrand --- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu.h b/drivers/gpu/drm/amd/amdgpu/amdgpu.h index dc3c6b3a00e5..d356e329e6f8 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu.h +++ b

Gmail throws all mailing list mails from amd.com in spam

Hi, I noticed that this has been going on for some time. I guess this is because of DKIM? Not sure what can be done about it. Gmail is quite persistent about it. Regards //Ernst ___ amd-gfx mailing list amd-gfx@lists.freedesktop.org

Re: Gmail throws all mailing list mails from amd.com in spam

esn't seem to be affected though! :-D On Fri, Jul 30, 2021 at 11:11 AM Michel Dänzer wrote: > On 2021-07-30 10:48 a.m., Ernst Sjöstrand wrote: > > Hi, > > > > I noticed that this has been going on for some time. I guess this is > because of DKIM? > > Not sure w

[PATCH] drm/amd/amdgpu: Validate ip discovery blob

We use the number_instance index that we get from the fw discovery blob to index into an array for example. Signed-off-by: Ernst Sjöstrand --- drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu

VCN_INFO_TABLE_MAX_NUM_INSTANCES vs AMDGPU_MAX_VCN_INSTANCES

smatch found this problem on amd-staging-drm-next: drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c:1443 amdgpu_discovery_get_vcn_info() error: buffer overflow 'adev->vcn.vcn_codec_disable_mask' 2 <= 3 This is caused by: #define AMDGPU_MAX_VCN_INSTANCES 2 #define VCN_INFO_TABLE_MAX_NUM_INSTANCES 4

Re: [PATCH] drm/amdgpu: enable tmz by default for skyrim

Skyrim is maybe not the best code name ever for a GPU, perhaps not include it upstream if it's not official? Regards //Ernst Den mån 30 maj 2022 kl 20:03 skrev Sunil Khatri : > Enable tmz feature by default for skyrim > i.e IP GC 10.3.7 > > Signed-off-by: Sunil Khatri > --- >

Re: [kbuild] drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c:1433 amdgpu_discovery_get_vcn_info() error: buffer overflow 'adev->vcn.vcn_codec_disable_mask' 2 <= 3

Dan: I also ran Smatch which resulted in the following discussion: https://lists.freedesktop.org/archives/amd-gfx/2022-May/079228.html Regards Den ons 1 juni 2022 kl 20:44 skrev Alex Deucher : > On Fri, May 27, 2022 at 3:46 AM Dan Carpenter > wrote: > > > > [ kbuild bot sent this warning on

Re: VCN_INFO_TABLE_MAX_NUM_INSTANCES vs AMDGPU_MAX_VCN_INSTANCES

Looks good to me! Den mån 16 maj 2022 kl 20:15 skrev Alex Deucher : > On Mon, May 16, 2022 at 2:10 PM Christian König > wrote: > > > > Am 16.05.22 um 19:49 schrieb Ernst Sjöstrand: > > > > Den mån 16 maj 2022 kl 17:13 skrev Alex Deucher : > >> >

Re: VCN_INFO_TABLE_MAX_NUM_INSTANCES vs AMDGPU_MAX_VCN_INSTANCES

Den mån 16 maj 2022 kl 17:13 skrev Alex Deucher : > On Sun, May 15, 2022 at 11:46 AM Ernst Sjöstrand wrote: > > > > smatch found this problem on amd-staging-drm-next: > > > > drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c:1443 > amdgpu_discovery_get_vcn_info()

Re: [PATCH] drm/radeon: Add build directory to include path

Den sön 19 juni 2022 kl 00:20 skrev Masahiro Yamada : > On Wed, Jun 15, 2022 at 5:35 PM Michel Dänzer > wrote: > > > > On 2022-04-14 18:57, Michel Dänzer wrote: > > > On 2022-04-14 17:04, Masahiro Yamada wrote: > > >> On Thu, Apr 14, 2022 at 10:50 PM Michel Dänzer > > >> wrote: > > >>> On

Re: [PATCH] drm/amdgpu: Revert "drm/amdgpu: getting fan speed pwm for vega10 properly"

This stuff I assume: https://github.com/RadeonOpenCompute/rocm_smi_lib/tree/master/tests/rocm_smi_test https://docs.amd.com/bundle/ROCm-System-Management-Interface-Guide/page/ROCm-System-Managment.html#building-tests Regards Den ons 26 okt. 2022 kl 17:43 skrev Yury Zhuravlev : > > > On Wed,

Re: [PATCH 2/2] drm/amd: Re-create firmware framebuffer on failure to probe

What about a system with multiple GPUs? Hybrid graphics? Headless systems? Regards //Ernst Den tors 22 dec. 2022 kl 19:30 skrev Mario Limonciello < mario.limoncie...@amd.com>: > If the probe sequence fails then the user is stuck with a frozen > screen and can only really recover via SSH or by

Re: Minimal kernel version for 7900XT

method for new cards. //Ernst Den mån 23 jan. 2023 kl 12:47 skrev Goran Mekić : > On 1/23/23 12:28, Ernst Sjöstrand wrote:> 6.0 should be enough: > > https://www.phoronix.com/review/rx7900xt-rx7900xtx-linux > > <https://www.phoronix.com/review/rx7900xt-rx7900xtx-linux> &g

Re: Minimal kernel version for 7900XT

6.0 should be enough: https://www.phoronix.com/review/rx7900xt-rx7900xtx-linux The firmware files is maybe the most complicated part right now... //Ernst Den mån 23 jan. 2023 kl 11:11 skrev Goran Mekić : > Hello, > > I'm trying to figure out what's the minimal kernel version that supports >

Re: [PATCH v3 1/2] drm/amdgpu: Add a max ibs per submission limit.

Sorry if I read this completely wrong, but the other patch says "radv currently has a limit of 192 which seems to work for most gfx submissions, but is way too high for e.g. compute or sdma.", while you return 192 for AMDGPU_RING_TYPE_COMPUTE here still? Regards //Ernst Den ons 12 apr. 2023 kl