Re: [linux-next:master] BUILD REGRESSION a54df7622717a40ddec95fd98086aff8ba7839a6

2023-01-24 Thread Mike Kravetz
> > > This could be because if CONFIG_CGROUP_HUGETLB is not set, the function in > alloc_hugetlb_folio() which initializes h_cg just returns 0 > > static inline int hugetlb_cgroup_charge_cgroup_rsvd(int idx, > unsigned long nr_pages, > struct hugetlb_cgroup **ptr) > { > return 0; > } Yes! > > where ptr is h_cg. I can add a "= NULL" in the v2 of my hugetlb page fault > conversion series. Thanks -- Mike Kravetz

Re: [linux-next:master] BUILD REGRESSION a54df7622717a40ddec95fd98086aff8ba7839a6

2023-01-24 Thread Mike Kravetz
t sure how the compiler would know this as hugetlb_cgroup_charge_cgroup is in another file. IMO, this was not introduced by Sid's changes. However, I can not explain why it is showing up now. Neither can I reproduce with my compiler, otherwise I would have sent a patch yesterday. I will send a patch to initialize to NULL to keep compiler quiet. -- Mike Kravetz