[PATCH 2/4] drm/amd/amdgpu: Add GFX and UVD PG for Carrizo

2016-07-27 Thread Tom St Denis
Enables GFX PG and UVD static PG on Carrizo class asics. Signed-off-by: Tom St Denis <tom.stde...@amd.com> --- drivers/gpu/drm/amd/amdgpu/vi.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/vi.c b/drivers/gpu/drm/amd/amdgpu/vi.c index 9ba649

[PATCH 4/4] drm/amd/powerplay: Fix PG/CG for UVD

2016-07-27 Thread Tom St Denis
enabled. Signed-off-by: Tom St Denis <tom.stde...@amd.com> --- drivers/gpu/drm/amd/amdgpu/amdgpu.h| 5 + drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c| 5 - drivers/gpu/drm/amd/amdgpu/uvd_v6_0.c | 4 ++-- drivers/gpu/drm/amd/amdgp

GFX/UVD PG (v2)

2016-07-27 Thread Tom St Denis
This stream changes a comment in patch #2 and re-works the init sequence for powerplay in patch #4 by removing the enable_clock_power_gatings_tasks task from the initialize task list. In theory that should be better as now other blocks won't be powered off before init.

[PATCH 02/14] drm/amd/amdgpu: add pm lock to debugfs mmio entry

2016-07-28 Thread Tom St Denis
Adds support for PM locks around access to registers that might have race conditions on PG transistions. Signed-off-by: Tom St Denis <tom.stde...@amd.com> --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/d

[PATCH 1/2] Revert "drm/amdgpu: disable GFX PG on CZ/BR/ST"

2016-07-24 Thread Tom St Denis
This partially reverts commit bd0ced160a2a7f1b23058bdca008f7770fd863c3. But keeps the SMU SCLK slowdown and CP PG disabled since that is what is causing the system hangs on Carrizo(AM4) systems. PG is still disabled for ST systems as that hasn't been fully tested yet. Signed-off-by: Tom St

[PATCH 4/4] drm/amd/powerplay: Prevent UVD powerdown before init

2016-07-26 Thread Tom St Denis
comparable clock/power behaviour to powerplay=0 with DPM is observed. Signed-off-by: Tom St Denis <tom.stde...@amd.com> --- drivers/gpu/drm/amd/amdgpu/amdgpu.h| 6 ++ drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c| 5 - drivers/gpu/drm/amd/amdgpu/uvd_v6_0.c

[PATCH 1/4] drm/amd/amdgpu: Cleanup register access in VCE v3

2016-08-11 Thread Tom St Denis
Signed-off-by: Tom St Denis <tom.stde...@amd.com> --- drivers/gpu/drm/amd/amdgpu/vce_v3_0.c | 145 ++ 1 file changed, 43 insertions(+), 102 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/vce_v3_0.c b/drivers/gpu/drm/amd/amdgpu/vce_v3_0.c index 7e6bb4

[PATCH 4/4] drm/amd/amdgpu: UVD v6 register cleanup

2016-08-11 Thread Tom St Denis
Signed-off-by: Tom St Denis <tom.stde...@amd.com> --- drivers/gpu/drm/amd/amdgpu/uvd_v6_0.c | 27 +++ 1 file changed, 11 insertions(+), 16 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/uvd_v6_0.c b/drivers/gpu/drm/amd/amdgpu/uvd_v6_0.c index c11b97

Various tidy-ups for VCE/UVD

2016-08-11 Thread Tom St Denis
Various cleanups using WREG32_FIELD as well as a bug fix in the soft_reset check for VCEv3 which didn't hold the GRBM lock around accessing GRBM_GFX_IDX. ___ amd-gfx mailing list amd-gfx@lists.freedesktop.org

[PATCH 2/4] drm/amd/amdgpu: add mutex in check_soft for VCE v3

2016-08-11 Thread Tom St Denis
Signed-off-by: Tom St Denis <tom.stde...@amd.com> --- drivers/gpu/drm/amd/amdgpu/vce_v3_0.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/vce_v3_0.c b/drivers/gpu/drm/amd/amdgpu/vce_v3_0.c index 073cf9ed0674..615b8b16ad04 100644 --- a/drivers/gpu/drm/amd/

[PATCH 2/6] drm/amd/amdgpu: Fix VCE CG order and resume defaults

2016-08-03 Thread Tom St Denis
CG was being enabled in reverse sense from dpm/powerplay. Also fix the default CLK_EN signal to enable all of the blocks. Signed-off-by: Tom St Denis <tom.stde...@amd.com> --- drivers/gpu/drm/amd/amdgpu/vce_v3_0.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/d

[PATCH 4/6] drm/amd/amdgpu: Move VCE bypass after MGCG test

2016-08-03 Thread Tom St Denis
Only issue bypass if MGCG enabled Signed-off-by: Tom St Denis <tom.stde...@amd.com> --- drivers/gpu/drm/amd/amdgpu/vce_v3_0.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/vce_v3_0.c b/drivers/gpu/drm/amd/amdgpu/vce_v3_0.c

[PATCH 6/6] drm/amd/amdgpu: Enable VCE MGCG for Stoney

2016-08-03 Thread Tom St Denis
Signed-off-by: Tom St Denis <tom.stde...@amd.com> --- drivers/gpu/drm/amd/amdgpu/vi.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/vi.c b/drivers/gpu/drm/amd/amdgpu/vi.c index 5449a3c8c9eb..07ea150f85f4 100644 --- a/drivers/gpu/drm/amd/

[PATCH 5/6] drm/amd/amdgpu: Enable VCE MGCG for Carrizo

2016-08-03 Thread Tom St Denis
Signed-off-by: Tom St Denis <tom.stde...@amd.com> --- drivers/gpu/drm/amd/amdgpu/vi.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/vi.c b/drivers/gpu/drm/amd/amdgpu/vi.c index 33bad99176fe..5449a3c8c9eb 100644 --- a/drivers/gpu/drm/amd/

[PATCH 3/6] drm/amd/amdgpu: Don't set VCE CG in startup

2016-08-03 Thread Tom St Denis
It's handled by DPM/PP properly. Signed-off-by: Tom St Denis <tom.stde...@amd.com> --- drivers/gpu/drm/amd/amdgpu/vce_v3_0.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/vce_v3_0.c b/drivers/gpu/drm/amd/amdgpu/vce_v3_0.c index 93604bb78257..9d1924

[PATCH] drm/amd/amdgpu: Partially revert change to UVD v3 CG

2016-08-03 Thread Tom St Denis
Partially undo changes made by commit: drm/amd/amdgpu: don't track state in UVD clockgating To keep bypass even if CG flags are not set. Signed-off-by: Tom St Denis <tom.stde...@amd.com> --- drivers/gpu/drm/amd/amdgpu/uvd_v6_0.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)

[PATCH] drm/amd/amdgpu: Add more config data for debugfs

2016-08-12 Thread Tom St Denis
Adds rev_id as well as cg/pg flags to help debug runtime. Signed-off-by: Tom St Denis <tom.stde...@amd.com> --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/d

[PATCH 3/3] drm/amd/amdgpu: Simplify bitfield operations in gfx v8

2016-08-09 Thread Tom St Denis
Foo, FIELD, new_value); Unlike WREG32_P() it understands offsets/masks and doesn't require the caller to shift the value (or mask properly). It's applied where suitable in the gfx_v8_0.c driver to start with. Signed-off-by: Tom St Denis <tom.stde...@amd.com> --- drivers/gpu/drm/amd/amdgpu/

Various cleanups for gfx_v8_0.c

2016-08-09 Thread Tom St Denis
These patches perform various cleanups in the GFX v8 driver. Patch #1, performs various whitespace/error message cleanups. Patch #2, performs various simplifications to routines to make them easier to read (and reduce LOC). Patch #3, introduces a WREG32_FIELD() macro which is then used to

[PATCH] drm/amd/amdgpu: Add more debugfs config data

2016-08-17 Thread Tom St Denis
Adds family and external_rev_id to config data Signed-off-by: Tom St Denis <tom.stde...@amd.com> --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/

[PATCH] drm/amd/powerplay: Tidy up cz_hwmgr.c

2016-08-18 Thread Tom St Denis
Clean up whitespace and formatting. Signed-off-by: Tom St Denis <tom.stde...@amd.com> --- drivers/gpu/drm/amd/powerplay/hwmgr/cz_hwmgr.c | 53 +++--- 1 file changed, 13 insertions(+), 40 deletions(-) diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/cz_hwmgr.c b/drive

Re: [PATCH] Autodetect libdrm path (v2)

2017-02-07 Thread Tom St Denis
On 07/02/17 06:02 AM, Emil Velikov wrote: On 6 February 2017 at 22:39, StDenis, Tom wrote: Apparently I missed the bottom of your reply (all of the clients I have outlook/gmail do top post only ...) Both Outlook and Gmail can do inline replies and plain text. There

[PATCH] Allow reading all of ring buffer and decode partial ranges

2017-02-06 Thread Tom St Denis
Fixes bug where say "-R gfx" would not actually dump the full ring contents. Adds feature where if you specify start and stop, e.g., "-R gfx[0:16]" will enable the decoder. Signed-off-by: Tom St Denis <tom.stde...@amd.com> --- src/app/ring_read.c | 11 ++- 1

[PATCH] Autodetect libdrm path (v2)

2017-02-05 Thread Tom St Denis
(v2): Use findLibDRM script instead of directly finding path Signed-off-by: Tom St Denis <tom.stde...@amd.com> --- CMakeLists.txt | 3 +++ cmake_modules/FindLibDRM.cmake | 35 +++ src/lib/query_drm.c| 4 ++-- 3 files chang

Add autodetect for libdrm to umr

2017-02-05 Thread Tom St Denis
While the cmake commits haven't been pushed yet I'd like to get feedback on this patch which helps find the libdrm headers. ___ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx

[PATCH] autodetect path to libdrm

2017-02-05 Thread Tom St Denis
Signed-off-by: Tom St Denis <tom.stde...@amd.com> --- CMakeLists.txt | 4 +++- src/lib/query_drm.c | 4 ++-- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index bef94fdba788..d2f393f0fa9b 100644 --- a/CMakeLists.txt +++ b/CMakeLis

[PATCH umr] Add SENSOR for SI/CIK/KV systems.

2017-02-17 Thread Tom St Denis
Signed-off-by: Tom St Denis <tom.stde...@amd.com> --- src/app/top.c | 30 ++ 1 file changed, 30 insertions(+) diff --git a/src/app/top.c b/src/app/top.c index 92ab8ab854af..c97a0c9d93ab 100644 --- a/src/app/top.c +++ b/src/app/top.c @@ -231,6 +231,27 @@ static

[PATCH umr] Allow * for ipname in --read/--write/--write-bit

2017-02-23 Thread Tom St Denis
To simplify scripting you can now use * for ipnames as well. Signed-off-by: Tom St Denis <tom.stde...@amd.com> --- doc/umr.1 | 6 ++- src/app/main.c| 5 ++- src/app/scan.c| 21 ++ src/app/set_bit.c | 117 +++--- s

Re: [PATCH umr] Allow * for ipname in --read/--write/--write-bit

2017-02-23 Thread Tom St Denis
On 23/02/17 01:41 PM, Andres Rodriguez wrote: On 2017-02-23 09:46 AM, Tom St Denis wrote: To simplify scripting you can now use * for ipnames as well. Thanks for the patch, this change is very welcome. Signed-off-by: Tom St Denis <tom.stde...@amd.com> --- doc/umr.1

[PATCH umr] Allow * for ipname in --read/--write/--write-bit (v2)

2017-02-23 Thread Tom St Denis
To simplify scripting you can now use * for ipnames as well. (v2) Continue matching other IP blocks after first register hit. Signed-off-by: Tom St Denis <tom.stde...@amd.com> --- doc/umr.1 | 6 ++- src/app/main.c| 5 ++- src/app/scan.c| 32 --- s

[PATCH umr] Simplify --scan and --list-regs syntax

2017-02-22 Thread Tom St Denis
Now it supports the same syntax as --read/--write, you can specify any of: *.ipname asicname.ipname ipname When using --scan and --list-regs now. e.g., umr --scan carrizo.uvd6 or umr --scan uvd6 Signed-off-by: Tom St Denis <tom.stde...@amd.com> --- src/app/main.

Re: [PATCH v2] drm/amdgpu: expose amdgpu_sensors on pre-powerplay chips

2017-02-14 Thread Tom St Denis
On 14/02/17 12:52 PM, Tom St Denis wrote: On 14/02/17 12:16 PM, Tom St Denis wrote: On 14/02/17 12:01 PM, Samuel Pitoiset wrote: No worries. I thought that check was enough. Anyway, writing code without the hardware should be avoided. :) Can you try the thing suggested by Alex? Because I

Re: [PATCH v2] drm/amdgpu: expose amdgpu_sensors on pre-powerplay chips

2017-02-14 Thread Tom St Denis
On 14/02/17 12:52 PM, Tom St Denis wrote: On 14/02/17 12:16 PM, Tom St Denis wrote: On 14/02/17 12:01 PM, Samuel Pitoiset wrote: No worries. I thought that check was enough. Anyway, writing code without the hardware should be avoided. :) Can you try the thing suggested by Alex? Because I

Re: [PATCH v2] drm/amdgpu: expose amdgpu_sensors on pre-powerplay chips

2017-02-14 Thread Tom St Denis
On 14/02/17 12:16 PM, Tom St Denis wrote: On 14/02/17 12:01 PM, Samuel Pitoiset wrote: No worries. I thought that check was enough. Anyway, writing code without the hardware should be avoided. :) Can you try the thing suggested by Alex? Because I will need to fix up the DRM ioctl codepath

[PATCH] drm/amd/amdgpu: Update read_sensor calls to have size parameter

2017-02-09 Thread Tom St Denis
-off-by: Tom St Denis <tom.stde...@amd.com> --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c| 26 +++-- drivers/gpu/drm/amd/amdgpu/amdgpu_dpm.h | 4 ++-- drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c| 28 +-- drivers/gpu/drm/amd/pow

Re: [UMR] Add GPU_POWER (v3) + refactored cleanup

2017-02-11 Thread Tom St Denis
On 02/11/2017 01:57 PM, Kai Wasserbäch wrote: Hey Tom, Tom St Denis wrote on 11.02.2017 18:52: I split out the deletion of the unused bits in --top. thank you so much for bearing with me (and Edward, though I can't speak for him, obviously)! You can still have my R-b. ;-) Cheers, Kai

Re: [PATCH 1/2] drm/amdgpu: implement read_sensor() for pre-powerplay chips

2017-02-13 Thread Tom St Denis
On 02/13/2017 05:13 PM, Deucher, Alexander wrote: -Original Message- From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf Of Samuel Pitoiset Sent: Monday, February 13, 2017 5:02 PM To: amd-gfx@lists.freedesktop.org Cc: Samuel Pitoiset Subject: [PATCH 1/2] drm/amdgpu:

Re: [PATCH 1/2] drm/amdgpu: implement read_sensor() for pre-powerplay chips

2017-02-13 Thread Tom St Denis
Hi Samuel, It would be helpful to modify amdgpu_debugfs_sensor_read() to support dpm based sensors as well. This will let me add it to umr. If you can swing that in here that would be helpful if not I can submit my own patch when this lands. Cheers, Tom On 02/13/2017 05:01 PM, Samuel

Re: [PATCH 1/2] drm/amdgpu: implement read_sensor() for pre-powerplay chips

2017-02-13 Thread Tom St Denis
On 02/13/2017 06:40 PM, Samuel Pitoiset wrote: On 02/14/2017 12:17 AM, Tom St Denis wrote: Hi Samuel, Hi Tom, It would be helpful to modify amdgpu_debugfs_sensor_read() to support dpm based sensors as well. This will let me add it to umr. You mean removing the sanity check

Re: [PATCH] drm/amdgpu: expose amdgpu_sensors on pre-powerplay chips

2017-02-14 Thread Tom St Denis
On 13/02/17 07:23 PM, Samuel Pitoiset wrote: Totally untested but as long as read_sensor() has been recently implemented for dpm based boards, amdgpu_sensors can now be exposed. Cc: Tom St Denis <tom.stde...@amd.com> Signed-off-by: Samuel Pitoiset <samuel.pitoi...@gmail.com> ---

[PATCH] Add GPU_POWER sensors

2017-02-10 Thread Tom St Denis
Add the ability to sample GPU_POWER sensors. Because the sensors have a high latency we read them from a background thread which means we've added the requirement for pthreads. Signed-off-by: Tom St Denis <tom.stde...@amd.com> --- CMakeLists.txt | 5 ++- README

[UMR] Add GPU_POWER Sensors

2017-02-10 Thread Tom St Denis
This patch adds the ability to read GPU_POWER sensors on smu7 hardware. Because there is an incredibly high latency on reading them I've added a pthread to handle that. Hence the project now requires pthreads to build. ___ amd-gfx mailing list

Re: [PATCH] Add GPU_POWER sensors

2017-02-10 Thread Tom St Denis
On 02/10/2017 07:25 PM, Edward O'Callaghan wrote: Hey Tom, On 02/11/2017 05:10 AM, Tom St Denis wrote: Add the ability to sample GPU_POWER sensors. Because the sensors have a high latency we read them from a background thread which means we've added the requirement for pthreads. Signed-off

[PATCH] Add GPU_POWER sensors (v2)

2017-02-11 Thread Tom St Denis
Add the ability to sample GPU_POWER sensors. Because the sensors have a high latency we read them from a background thread which means we've added the requirement for pthreads. Signed-off-by: Tom St Denis <tom.stde...@amd.com> (v2) Cleaned up CMake around pthreads --- CMakeLis

Re: [PATCH] Add GPU_POWER sensors

2017-02-11 Thread Tom St Denis
On 11/02/17 05:56 AM, Kai Wasserbäch wrote: Hey Tom, Tom St Denis wrote on 11.02.2017 02:02: On 02/10/2017 07:25 PM, Edward O'Callaghan wrote: Hey Tom, On 02/11/2017 05:10 AM, Tom St Denis wrote: Add the ability to sample GPU_POWER sensors. Because the sensors have a high latency we read

Re: [PATCH v2] drm/amdgpu: expose amdgpu_sensors on pre-powerplay chips

2017-02-14 Thread Tom St Denis
On 14/02/17 10:08 AM, Samuel Pitoiset wrote: Totally untested but as long as read_sensor() has been recently implemented for dpm based boards, amdgpu_sensors can now be exposed. v2: - make sure read_sensor is not NULL on dpm chips - keep sanity check for powerplay chips Cc: Tom St Denis

Re: [PATCH] Add missing CIK devices

2017-02-13 Thread Tom St Denis
On 13/02/17 08:12 AM, Christian König wrote: Am 13.02.2017 um 13:46 schrieb Tom St Denis: Adds mullins, kabini, and hawaii ASICs to the library. Signed-off-by: Tom St Denis <tom.stde...@amd.com> Acked-by: Christian König <christian.koe...@amd.com>. Thanks. If there are no obj

[PATCH] Add new gmc/smu registers

2017-02-13 Thread Tom St Denis
Signed-off-by: Tom St Denis <tom.stde...@amd.com> --- src/lib/ip/gmc60_bits.i | 2 ++ src/lib/ip/smu701_bits.i | 4 src/lib/ip/smu701_regs.i | 1 + src/lib/ip/smu711_bits.i | 4 src/lib/ip/smu711_regs.i | 1 + src/lib/ip/smu712_bits.i | 4 src/lib/ip/smu712_regs.i | 1 + s

Re: Initial Public Release of AMDGPU debugger

2017-02-12 Thread Tom St Denis
On 02/12/2017 09:39 PM, Dave Airlie wrote: We're pleased to announce the initial public release of the AMDGPU User Mode Register debugger (umr). This tool allows privileged users to read and write GPU registers in order to diagnose, debug, and aid in development of AMDGPU features. The tool

[PATCH] Fix SMC read/write

2017-02-13 Thread Tom St Denis
The registers in umr are stored as byte addresses (mm registers are word addresses). Signed-off-by: Tom St Denis <tom.stde...@amd.com> --- src/app/scan.c| 2 +- src/app/set_bit.c | 2 +- src/app/set_reg.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/app/sc

Re: [PATCH] Add missing CIK devices

2017-02-13 Thread Tom St Denis
On 13/02/17 10:32 AM, Deucher, Alexander wrote: -Original Message- From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf Of Tom St Denis Sent: Monday, February 13, 2017 7:46 AM To: amd-gfx@lists.freedesktop.org Cc: StDenis, Tom Subject: [PATCH] Add missing CIK devices

Re: [PATCH] Add new gmc/smu registers

2017-02-13 Thread Tom St Denis
On 13/02/17 11:35 AM, Nicolai Hähnle wrote: Hi Tom, it's probably a good idea to use subject prefixes for umr patches. git config format.subjectPrefix "PATCH umr" or edit .git/config accordingly, e.g. for libdrm I have this in .git/config: [format] subjectPrefix = PATCH libdrm Then

[PATCH 2/2] Add GPU_POWER sensors (v3)

2017-02-11 Thread Tom St Denis
Add the ability to sample GPU_POWER sensors. Because the sensors have a high latency we read them from a background thread which means we've added the requirement for pthreads. Signed-off-by: Tom St Denis <tom.stde...@amd.com> (v2) Cleaned up CMake around pthreads (v3) Update readme, fact

[PATCH 1/2] Remove unused bits from --top

2017-02-11 Thread Tom St Denis
Signed-off-by: Tom St Denis <tom.stde...@amd.com> --- src/app/top.c | 5 - 1 file changed, 5 deletions(-) diff --git a/src/app/top.c b/src/app/top.c index b081515a5b40..d9a474d78cf7 100644 --- a/src/app/top.c +++ b/src/app/top.c @@ -171,19 +171,14 @@ static struct umr_bi

[UMR] Add GPU_POWER (v3) + refactored cleanup

2017-02-11 Thread Tom St Denis
I split out the deletion of the unused bits in --top. ___ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Re: [PATCH] Add GPU_POWER sensors (v2)

2017-02-11 Thread Tom St Denis
On 02/11/2017 08:29 AM, Kai Wasserbäch wrote: Hey Tom, Tom St Denis wrote on 11.02.2017 12:26: Add the ability to sample GPU_POWER sensors. Because the sensors have a high latency we read them from a background thread which means we've added the requirement for pthreads. Signed-off-by: Tom St

Re: Initial Public Release of AMDGPU debugger

2017-02-13 Thread Tom St Denis
On 13/02/17 05:00 AM, Nils Holland wrote: On Sat, Feb 04, 2017 at 06:44:12PM +, StDenis, Tom wrote: Hello all, We're pleased to announce the initial public release of the AMDGPU User Mode Register debugger (umr). This tool allows privileged users to read and write GPU registers in order

[PATCH] drm/amd/amdgpu: Fix flow control in uvd_v4_2_stop()

2017-02-13 Thread Tom St Denis
Break out of outer loop properly. Signed-off-by: Tom St Denis <tom.stde...@amd.com> Reported-by: Dan Carpenter <dan.carpen...@oracle.com> --- drivers/gpu/drm/amd/amdgpu/uvd_v4_2.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgp

[no subject]

2017-02-10 Thread Tom St Denis
Fix bug where GPU_POWER wasn't accessible because we wrote to *size early... ___ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx

[PATCH] drm/amd/amdgpu: Update read_sensor calls to have size parameter (v2)

2017-02-10 Thread Tom St Denis
): Don't set size to 4 before reading GPU_POWER Signed-off-by: Tom St Denis <tom.stde...@amd.com> --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c| 26 +++-- drivers/gpu/drm/amd/amdgpu/amdgpu_dpm.h | 4 ++-- drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c

Re: [PATCH v3] drm/amdgpu: expose amdgpu_sensors on pre-powerplay chips

2017-02-15 Thread Tom St Denis
St Denis <tom.stde...@amd.com> Signed-off-by: Samuel Pitoiset <samuel.pitoi...@gmail.com> Cool, you can throw my R-b on this and the first patch (which adds the sensors). Christian/Alex/etc can RB the DRM part. Reviewed-by: Tom St Denis <tom.stde...@amd.com> Thanks, Tom

Re: [PATCH] drm/amdgpu: expose amdgpu_sensors on pre-powerplay chips

2017-02-15 Thread Tom St Denis
On 14/02/17 09:56 PM, Deucher, Alexander wrote: -Original Message- From: Michel Dänzer [mailto:mic...@daenzer.net] Sent: Tuesday, February 14, 2017 9:52 PM To: Deucher, Alexander; 'Samuel Pitoiset'; StDenis, Tom Cc: amd-gfx@lists.freedesktop.org Subject: Re: [PATCH] drm/amdgpu: expose

[PATCH] Add missing CIK devices

2017-02-13 Thread Tom St Denis
Adds mullins, kabini, and hawaii ASICs to the library. Signed-off-by: Tom St Denis <tom.stde...@amd.com> --- src/lib/asic/CMakeLists.txt | 3 +++ src/lib/asic/hawaii.c | 40 src/lib/asic/kabini.c

[PATCH] drm/amd/amdgpu: Add PCI info to gca_config debugfs

2017-01-18 Thread Tom St Denis
So we can determine which device the entry is before connecting a display. Signed-off-by: Tom St Denis <tom.stde...@amd.com> --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_devic

[PATCH 4/6] drm/amd/amdgpu: Merge get_wptr functions in gfx6

2016-09-02 Thread Tom St Denis
Signed-off-by: Tom St Denis <tom.stde...@amd.com> --- drivers/gpu/drm/amd/amdgpu/gfx_v6_0.c | 31 +++ 1 file changed, 11 insertions(+), 20 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v6_0.c b/drivers/gpu/drm/amd/amdgpu/gfx_v6_0.c index 8cc502

Merge get_rptr and get_wptr functions

2016-09-02 Thread Tom St Denis
These patches merge the ring get_rptr and get_wptr functions from each of the GFX drivers between gfx and compute rings. ___ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx

[PATCH 6/6] drm/amd/amdgpu: Merge get_wptr functions in gfx8

2016-09-02 Thread Tom St Denis
Signed-off-by: Tom St Denis <tom.stde...@amd.com> --- drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c | 15 +-- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c b/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c index 02056762ea06..d8b17745bc19

[PATCH 5/6] drm/amd/amdgpu: Merge get_wptr functions in gfx7

2016-09-02 Thread Tom St Denis
Signed-off-by: Tom St Denis <tom.stde...@amd.com> --- drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c | 17 +++-- 1 file changed, 7 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c b/drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c index 84ad13ec3771..926fd570f0ed

[PATCH 1/6] drm/amd/amdgpu: Merge get_rptr functions in gfx6

2016-09-02 Thread Tom St Denis
Signed-off-by: Tom St Denis <tom.stde...@amd.com> --- drivers/gpu/drm/amd/amdgpu/gfx_v6_0.c | 11 +++ 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v6_0.c b/drivers/gpu/drm/amd/amdgpu/gfx_v6_0.c index 63ca77937714..8cc5025d8a4d

[PATCH 5/7] drm/amd/amdgpu: Tidy up SI IH code

2016-09-06 Thread Tom St Denis
Signed-off-by: Tom St Denis <tom.stde...@amd.com> --- drivers/gpu/drm/amd/amdgpu/si_ih.c | 30 -- 1 file changed, 8 insertions(+), 22 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/si_ih.c b/drivers/gpu/drm/amd/amdgpu/si_ih.c index 994ff02db013..8fae3d

[PATCH 7/7] drm/amd/amdgpu: Comment out currently unused SI DPM struct

2016-09-06 Thread Tom St Denis
The tahiti_le structure is not currently used. Comment it out to avoid warnings. Signed-off-by: Tom St Denis <tom.stde...@amd.com> --- drivers/gpu/drm/amd/amdgpu/si_dpm.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/si_dpm.c b/drivers/gpu/drm/amd/

[PATCH 3/7] drm/amd/amdgpu: Clean up SI DPM table assignments

2016-09-06 Thread Tom St Denis
Hoist common assignments out of cases. Signed-off-by: Tom St Denis <tom.stde...@amd.com> --- drivers/gpu/drm/amd/amdgpu/si_dpm.c | 42 + 1 file changed, 10 insertions(+), 32 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/si_dpm.c b/drivers/gpu/d

[PATCH 1/7] drm/amd/amdgpu: Tidy up SI DMA code

2016-09-06 Thread Tom St Denis
Signed-off-by: Tom St Denis <tom.stde...@amd.com> --- drivers/gpu/drm/amd/amdgpu/si_dma.c | 35 +-- 1 file changed, 5 insertions(+), 30 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/si_dma.c b/drivers/gpu/drm/amd/amdgpu/si_dma.c index 377f4a

[PATCH 4/7] drm/amd/amdgpu: Correct whitespace in SI DPM code

2016-09-06 Thread Tom St Denis
Replace 8 spaces with tabs, correct {} braces, etc. Signed-off-by: Tom St Denis <tom.stde...@amd.com> --- drivers/gpu/drm/amd/amdgpu/si_dpm.c | 441 +--- 1 file changed, 209 insertions(+), 232 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/si_dp

[PATCH 6/7] drm/amd/amdgpu: Tidy up SI SMC code

2016-09-06 Thread Tom St Denis
As well as merge SMC clock functions into one to reduce LOC. Signed-off-by: Tom St Denis <tom.stde...@amd.com> --- drivers/gpu/drm/amd/amdgpu/si_dpm.c | 6 +++--- drivers/gpu/drm/amd/amdgpu/si_smc.c | 25 - drivers/gpu/drm/amd/amdgpu/sislands_smc.

Various tidy'ups with SI DMA/DPM/SMC/IH code

2016-09-06 Thread Tom St Denis
Various cleanups including simplifications, LOC reductions and whitespace corrections. ___ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx

[PATCH 2/7] drm/amd/amdgpu: Allow calling si_dpm_fini at any point

2016-09-06 Thread Tom St Denis
Allow calling fini even if ps array is not allocated. Signed-off-by: Tom St Denis <tom.stde...@amd.com> --- drivers/gpu/drm/amd/amdgpu/si_dpm.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/si_dpm.c b/drivers/gpu/drm/amd/amdgpu/si

[PATCH 2/3] drm/amd/amdgpu: Simplify mask creation in gfx6

2016-09-01 Thread Tom St Denis
Signed-off-by: Tom St Denis <tom.stde...@amd.com> --- drivers/gpu/drm/amd/amdgpu/gfx_v6_0.c | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v6_0.c b/drivers/gpu/drm/amd/amdgpu/gfx_v6_0.c index 099539f0fa53..5f508c96496f

Various fixes for gfx6

2016-09-01 Thread Tom St Denis
Patch #1 adds missing mutex locking around se/sh/instance writes. Patches #2/3 perform various cleanups. ___ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx

[PATCH 1/3] drm/amd/amdgpu: Add GRBM lock to various SI functions

2016-09-01 Thread Tom St Denis
Add missing lock around SE/SH/INSTANCE selections. Signed-off-by: Tom St Denis <tom.stde...@amd.com> --- drivers/gpu/drm/amd/amdgpu/gfx_v6_0.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v6_0.c b/drivers/gpu/drm/amd/amdgpu/gfx_v6_0.c

[PATCH 3/3] drm/amd/amdgpu: Various tidy ups for gfx6

2016-09-01 Thread Tom St Denis
Various whitespace and logical simplifications for gfx6. Signed-off-by: Tom St Denis <tom.stde...@amd.com> --- drivers/gpu/drm/amd/amdgpu/gfx_v6_0.c | 40 +-- 1 file changed, 5 insertions(+), 35 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v6_

[PATCH] drm/amd/amdgpu: Fix return values in SI DPM code

2016-09-07 Thread Tom St Denis
Fix a couple of spots where errors were not returned as well as add some error messages to si_patch_dependency_based_on_leakage() which were not being read. Signed-off-by: Tom St Denis <tom.stde...@amd.com> --- drivers/gpu/drm/amd/amdgpu/si_dpm.c | 10 -- 1 file changed, 8 inse

[PATCH] drm/amd/amdgpu: Remove double lock from gfx v6

2016-09-07 Thread Tom St Denis
The function gfx_v6_0_get_cu_info() was taking the grbm_idx_mutex which was then taken by a dependent function gfx_v6_0_get_cu_active_bitmap(). This patch removes the select from the parent function to avoid the double lock. Signed-off-by: Tom St Denis <tom.stde...@amd.com> --- drivers/g

[PATCH] drm/amd/amdgpu: Convert messages in gmc v6 to dev_*()

2016-09-07 Thread Tom St Denis
Make the kernel log messaging more consistent and use the dev_*() functions instead of a mix of DRM_*() and printk(). Signed-off-by: Tom St Denis <tom.stde...@amd.com> --- drivers/gpu/drm/amd/amdgpu/gmc_v6_0.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff

[PATCH] drm/amdgpu: Avoid use-after-free

2016-09-12 Thread Tom St Denis
Switch to _SAFE variant of list macro to avoid use-after-free bug. Signed-off-by: Tom St Denis <tom.stde...@amd.com> --- amdgpu/amdgpu_cs.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/amdgpu/amdgpu_cs.c b/amdgpu/amdgpu_cs.c index fb5b3a8c4bc4..cd92a0957293

[PATCH 2/2] drm/amd/amdgpu: Hook up read_sensor() to debugfs

2016-09-15 Thread Tom St Denis
Signed-off-by: Tom St Denis <tom.stde...@amd.com> --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 31 ++ 1 file changed, 31 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c index 9103e7

Add sensors support to debugfs for Powerplay

2016-09-15 Thread Tom St Denis
This patch adds the ability to read various sensors from userspace. It's extensible so we can always add more later on. Currently CZ/ST supported (CZ tested with a WIP copy of the debug tool). ___ amd-gfx mailing list amd-gfx@lists.freedesktop.org

[PATCH] drm/amd/amdgpu: Add sensors debugfs support

2016-09-15 Thread Tom St Denis
so they shouldn't cause any sort of oops. Signed-off-by: Tom St Denis <tom.stde...@amd.com> --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 31 +++ drivers/gpu/drm/amd/powerplay/amd_powerplay.c | 20 + drivers/gpu/drm/amd/powerplay/hwmgr/cz_hwmgr.c

[PATCH 1/2] drm/amd/powerplay: Add read_sensor() callback to hwmgr

2016-09-15 Thread Tom St Denis
Provides standardized interface to read various sensors. The API is extensible (by adding to the end of the amd_pp_sensors enumeration list. Signed-off-by: Tom St Denis <tom.stde...@amd.com> --- drivers/gpu/drm/amd/powerplay/amd_powerplay.c | 20 + drivers/gpu/drm/amd/powerplay

[PATCH] drm/amd/powerplay: Add read_sensor support to tonga/fiji/polaris/iceland

2016-09-15 Thread Tom St Denis
Signed-off-by: Tom St Denis <tom.stde...@amd.com> --- drivers/gpu/drm/amd/powerplay/hwmgr/fiji_hwmgr.c | 35 +- .../gpu/drm/amd/powerplay/hwmgr/iceland_hwmgr.c| 35 +- .../gpu/drm/amd/powerplay/hwmgr/polaris10_hwmgr.c

Re: [PATCH] drm/amdgpu: remove duplicate evict_vram in suspend path

2016-10-05 Thread Tom St Denis
I proposed to remove that when running into SDMA job out-of-order issues and Christian K very strongly NAK'ed that (a couple of times). So I suspect he'll do it again. Tom On Wed, Oct 5, 2016 at 8:10 PM Dave Airlie wrote: > On 6 October 2016 at 05:42, Alex Deucher

Re: [PATCH] drm/amdgpu: remove duplicate evict_vram in suspend path

2016-10-09 Thread Tom St Denis
Yup that's what I said in another part of the thread :-) i'm a trailblazer of bad ideas at times :-) hehehehe Tom On Sun, Oct 9, 2016 at 11:13 AM Christian König wrote: > Am 05.10.2016 um 21:42 schrieb Alex Deucher: > > Looks like fallout from a rebase or merge. > > >

[PATCH] drm/amd/amdgpu: Make debugfs write compliment read

2016-10-10 Thread Tom St Denis
Add PG lock support as well as bank selection to the MMIO write function. Signed-off-by: Tom St Denis <tom.stde...@amd.com> --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 43 ++ 1 file changed, 43 insertions(+) diff --git a/drivers/gpu/drm/amd/

[PATCH] drm/amd/amdgpu: Allow broadcast on debugfs read

2016-10-09 Thread Tom St Denis
Allow any of the se/sh/instance fields to be specified as a broadcast by submitting 0x3FF. Signed-off-by: Tom St Denis <tom.stde...@amd.com> --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_devic

[PATCH] drm/amd/amdgpu: Allow broadcast on debugfs read (v2)

2016-10-09 Thread Tom St Denis
Allow any of the se/sh/instance fields to be specified as a broadcast by submitting 0x3FF. (v2) Fix broadcast range checking Signed-off-by: Tom St Denis <tom.stde...@amd.com> --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-)

[PATCH 1/2] drm/amd/powerplay: Add read_sensor() callback to hwmgr (v3)

2016-09-19 Thread Tom St Denis
Provides standardized interface to read various sensors. The API is extensible (by adding to the end of the amd_pp_sensors enumeration list. Support has been added to Carrizo/smu7 (v2) Squashed the two sensor patches into one. (v3) Updated to apply to smu7_hwmgr instead Signed-off-by: Tom St

[PATCH 2/2] drm/amd/amdgpu: Hook up read_sensor() to debugfs (v2)

2016-09-19 Thread Tom St Denis
(v2) Tidy'ed up read function. Signed-off-by: Tom St Denis <tom.stde...@amd.com> Reviewed-by: Edward O'Callaghan <funfunc...@folklore1984.net> --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 31 ++ 1 file changed, 31 insertions(+) diff --git a/drivers

[PATCH] drm/amd/powerplay: Replace per-asic print_performance with generic

2016-09-19 Thread Tom St Denis
Replace per-asic print_current_performance() functions with generic that calls read_sensor. Tested on Tonga and Carrizo for aesthetics and accuracy. Signed-off-by: Tom St Denis <tom.stde...@amd.com> --- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 10 +-- drivers/gpu/drm/amd/

[PATCH 1/2] drm/amd/powerplay: Add read_sensor() callback to hwmgr (v2)

2016-09-16 Thread Tom St Denis
Provides standardized interface to read various sensors. The API is extensible (by adding to the end of the amd_pp_sensors enumeration list. Support has been added to Carrizo/Tonga/Fiji/Polaris/Iceland (v2) Squashed the two sensor patches into one. Signed-off-by: Tom St Denis <tom.s

Powerplay sensors (v2.5)

2016-09-16 Thread Tom St Denis
I've rebased the backend to squash the carrizo + rest patches together and then touched up the debugfs entry per Edwards suggestions. Tested on Tonga, Carrizo, and Stoney. ___ amd-gfx mailing list amd-gfx@lists.freedesktop.org

  1   2   3   4   5   6   7   8   >