[PATCH 0/7] Add "activ bpc" and "active color format" drm property

2021-06-08 Thread Werner Sembach
I started work on my proposal for better color handling in Linux display drivers: https://lkml.org/lkml/2021/5/12/764 In this 2nd revision the first two read-only properties are now implemented for amdgpu and i915. I post it here to collect collect some additional feedback, if someone sees an

[PATCH v2 3/7] drm/amd/display: Add handling for new "active bpc" property

2021-06-08 Thread Werner Sembach
This commit implements the "active bpc" drm property for the AMD GPU driver. Signed-off-by: Werner Sembach --- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 18 +- .../display/amdgpu_dm/amdgpu_dm_mst_types.c| 4 +++- 2 files changed, 20 insertions(+), 2

[PATCH v2 1/7] drm/amd/display: Add missing cases convert_dc_color_depth_into_bpc

2021-06-08 Thread Werner Sembach
convert_dc_color_depth_into_bpc() that converts the enum dc_color_depth to an integer had the casses for COLOR_DEPTH_999 and COLOR_DEPTH_11 missing. Signed-off-by: Werner Sembach --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 4 1 file changed, 4 insertions(+) diff --git

[PATCH v2 2/7] drm/uAPI: Add "active bpc" as feedback channel for "max bpc" drm property

2021-06-08 Thread Werner Sembach
ailable. Signed-off-by: Werner Sembach --- drivers/gpu/drm/drm_atomic_uapi.c | 2 ++ drivers/gpu/drm/drm_connector.c | 41 +++ include/drm/drm_connector.h | 15 +++ 3 files changed, 58 insertions(+) diff --git a/drivers/gpu/drm/drm_atomic_uapi.

[PATCH v2 4/7] drm/i915/display: Add handling for new "active bpc" property

2021-06-08 Thread Werner Sembach
This commits implements the "active bpc" drm property for the Intel GPU driver. Signed-off-by: Werner Sembach --- drivers/gpu/drm/i915/display/intel_display.c | 14 ++ drivers/gpu/drm/i915/display/intel_dp.c | 8 ++-- drivers/gpu/drm/i915/display/intel_dp_m

[PATCH v2 6/7] drm/amd/display: Add handling for new "active color format" property

2021-06-08 Thread Werner Sembach
This commit implements the "active color format" drm property for the AMD GPU driver. Signed-off-by: Werner Sembach --- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 27 +-- .../display/amdgpu_dm/amdgpu_dm_mst_types.c | 1 + 2 files changed, 26 insertions(+), 2

[PATCH v2 5/7] drm/uAPI: Add "active color format" drm property as feedback for userspace

2021-06-08 Thread Werner Sembach
lso depend on this information being available. Signed-off-by: Werner Sembach --- drivers/gpu/drm/drm_atomic_uapi.c | 2 ++ drivers/gpu/drm/drm_connector.c | 46 +++ include/drm/drm_connector.h | 13 + 3 files changed, 61 insertions(+) diff --git a/drive

[PATCH v2 7/7] drm/i915/display: Add handling for new "active color format" property

2021-06-08 Thread Werner Sembach
This commit implements the "active color format" drm property for the Intel GPU driver. Signed-off-by: Werner Sembach --- drivers/gpu/drm/i915/display/intel_display.c | 20 +++- drivers/gpu/drm/i915/display/intel_dp.c | 2 ++ drivers/gpu/drm/i915/display/inte

Re: [PATCH 4/4] drm/i915/display: Add handling for new "active bpc" property

2021-06-08 Thread Werner Sembach
Am 07.06.21 um 22:33 schrieb Werner Sembach: Am 07.06.21 um 08:47 schrieb Werner Sembach: Am 04.06.21 um 19:30 schrieb Ville Syrjälä: On Fri, Jun 04, 2021 at 07:17:23PM +0200, Werner Sembach wrote: This commits implements the "active bpc" drm property for the Intel GPU driver.

Re: [PATCH 4/4] drm/i915/display: Add handling for new "active bpc" property

2021-06-07 Thread Werner Sembach
Am 07.06.21 um 08:47 schrieb Werner Sembach: Am 04.06.21 um 19:30 schrieb Ville Syrjälä: On Fri, Jun 04, 2021 at 07:17:23PM +0200, Werner Sembach wrote: This commits implements the "active bpc" drm property for the Intel GPU driver. Signed-off-by: Werner Sembach ---   drivers/gp

[PATCH v4 01/17] drm/amd/display: Remove unnecessary SIGNAL_TYPE_HDMI_TYPE_A check

2021-06-18 Thread Werner Sembach
reports drm_mode_is_420_only() even on a non HDMI connection. This patch also moves both checks in the same if-case. This eliminates an extra else-if-case. Signed-off-by: Werner Sembach --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(

[PATCH v4 03/17] drm/uAPI: Add "active bpc" as feedback channel for "max bpc" drm property

2021-06-18 Thread Werner Sembach
ailable. Signed-off-by: Werner Sembach --- drivers/gpu/drm/drm_connector.c | 51 + include/drm/drm_connector.h | 8 ++ 2 files changed, 59 insertions(+) diff --git a/drivers/gpu/drm/drm_connector.c b/drivers/gpu/drm/drm_connector.c index da39e7ff6965.

[PATCH v4 04/17] drm/amd/display: Add handling for new "active bpc" property

2021-06-18 Thread Werner Sembach
This commit implements the "active bpc" drm property for the AMD GPU driver. Signed-off-by: Werner Sembach --- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 19 ++- .../display/amdgpu_dm/amdgpu_dm_mst_types.c | 4 2 files changed, 22 insertions(+), 1 deletio

[PATCH v4 02/17] drm/amd/display: Add missing cases convert_dc_color_depth_into_bpc

2021-06-18 Thread Werner Sembach
convert_dc_color_depth_into_bpc() that converts the enum dc_color_depth to an integer had the casses for COLOR_DEPTH_999 and COLOR_DEPTH_11 missing. Signed-off-by: Werner Sembach --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 4 1 file changed, 4 insertions(+) diff --git

[PATCH v4 00/17] New uAPI drm properties for color management

2021-06-18 Thread Werner Sembach
Implementation of https://lkml.org/lkml/2021/5/12/764 now feature complete albeit not fully tested. I have not yet corrected the DSC behavior and double checked the dithering behavior. I release the feature complete patch series now anyways so that work on the userspace implementation can start.

[PATCH v4 12/17] drm/uAPI: Add "preferred color format" drm property as setting for userspace

2021-06-18 Thread Werner Sembach
bandwidth heavy ycbcr422 and ycbcr420 formats for a signal that is less deceptible to interference. In the future, automatic color calibration for screens might also depend on this option being available. Signed-off-by: Werner Sembach --- drivers/gpu/drm/drm_atomic_helper.c | 4 +++ drive

[PATCH v4 11/17] drm/i915/display: Add handling for new "active color range" property

2021-06-18 Thread Werner Sembach
This commit implements the "active color range" drm property for the Intel GPU driver. Signed-off-by: Werner Sembach --- drivers/gpu/drm/i915/display/intel_display.c | 6 ++ drivers/gpu/drm/i915/display/intel_dp.c | 2 ++ drivers/gpu/drm/i915/display/intel_dp_mst.c | 5

[PATCH v4 13/17] drm/amd/display: Add handling for new "preferred color format" property

2021-06-18 Thread Werner Sembach
This commit implements the "preferred color format" drm property for the AMD GPU driver. Signed-off-by: Werner Sembach --- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 30 +++ .../display/amdgpu_dm/amdgpu_dm_mst_types.c | 4 +++ 2 files changed, 28 insert

[PATCH v4 17/17] drm/amd/display: Add handling for new "Broadcast RGB" property

2021-06-18 Thread Werner Sembach
This commit implements the "Broadcast RGB" drm property for the AMD GPU driver. Signed-off-by: Werner Sembach --- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 22 ++- .../display/amdgpu_dm/amdgpu_dm_mst_types.c | 4 2 files changed, 21 insertions(+), 5

[PATCH v4 15/17] drm/uAPI: Move "Broadcast RGB" property from driver specific to general context

2021-06-18 Thread Werner Sembach
e a manual overwrite is required to not have washed out colors or lose details in very dark or bright scenes. Signed-off-by: Werner Sembach --- drivers/gpu/drm/drm_atomic_helper.c | 4 +++ drivers/gpu/drm/drm_atomic_uapi.c | 4 +++ drivers/gpu/drm/drm_connector.c | 43

[PATCH v4 16/17] drm/i915/display: Use the general "Broadcast RGB" implementation

2021-06-18 Thread Werner Sembach
Change from the i915 specific "Broadcast RGB" drm property implementation to the general one. This commit delete all traces of the former "Broadcast RGB" implementation and add a new one using the new driver agnoistic functions an variables. Signed-off-by: Werner Sembach

[PATCH v4 06/17] drm/uAPI: Add "active color format" drm property as feedback for userspace

2021-06-18 Thread Werner Sembach
lso depend on this information being available. Signed-off-by: Werner Sembach --- drivers/gpu/drm/drm_connector.c | 61 + include/drm/drm_connector.h | 9 + 2 files changed, 70 insertions(+) diff --git a/drivers/gpu/drm/drm_connector.c b/drivers/gpu/drm/drm_connect

[PATCH v4 05/17] drm/i915/display: Add handling for new "active bpc" property

2021-06-18 Thread Werner Sembach
This commit implements the "active bpc" drm property for the Intel GPU driver. Signed-off-by: Werner Sembach --- drivers/gpu/drm/i915/display/intel_display.c | 17 + drivers/gpu/drm/i915/display/intel_dp.c | 7 +-- drivers/gpu/drm/i915/display/intel_dp_m

[PATCH v4 08/17] drm/i915/display: Add handling for new "active color format" property

2021-06-18 Thread Werner Sembach
This commit implements the "active color format" drm property for the Intel GPU driver. Signed-off-by: Werner Sembach --- drivers/gpu/drm/i915/display/intel_display.c | 22 +++- drivers/gpu/drm/i915/display/intel_dp.c | 2 ++ drivers/gpu/drm/i915/display/inte

[PATCH v4 07/17] drm/amd/display: Add handling for new "active color format" property

2021-06-18 Thread Werner Sembach
This commit implements the "active color format" drm property for the AMD GPU driver. Signed-off-by: Werner Sembach --- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 29 +-- .../display/amdgpu_dm/amdgpu_dm_mst_types.c | 4 +++ 2 files changed, 31 insertions(+), 2

[PATCH v4 09/17] drm/uAPI: Add "active color range" drm property as feedback for userspace

2021-06-18 Thread Werner Sembach
he monitor and what the default behaviour of the used driver is. This property helps eliminating the guessing at this point. In the future, automatic color calibration for screens might also depend on this information being available. Signed-off-by: Werner Sembach --- drivers/gpu/drm/drm_connec

[PATCH v4 10/17] drm/amd/display: Add handling for new "active color range" property

2021-06-18 Thread Werner Sembach
This commit implements the "active color range" drm property for the AMD GPU driver. Signed-off-by: Werner Sembach --- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 33 +++ .../display/amdgpu_dm/amdgpu_dm_mst_types.c | 4 +++ 2 files changed, 37 insertions(+)

[PATCH v4 14/17] drm/i915/display: Add handling for new "preferred color format" property

2021-06-18 Thread Werner Sembach
This commit implements the "preferred color format" drm property for the Intel GPU driver. Signed-off-by: Werner Sembach --- drivers/gpu/drm/i915/display/intel_dp.c | 7 ++- drivers/gpu/drm/i915/display/intel_dp_mst.c | 5 + drivers/gpu/drm/i915/display/intel_hdmi.c | 6

Re: New uAPI for color management proposal and feedback request

2021-06-22 Thread Werner Sembach
Am 19.05.21 um 11:34 schrieb Pekka Paalanen: > On Wed, 12 May 2021 16:04:16 +0300 > Ville Syrjälä wrote: > >> On Wed, May 12, 2021 at 02:06:56PM +0200, Werner Sembach wrote: >>> Hello, >>> >>> In addition to the existing "max bpc", and "

Re: [PATCH v4 15/17] drm/uAPI: Move "Broadcast RGB" property from driver specific to general context

2021-06-23 Thread Werner Sembach
Am 23.06.21 um 09:48 schrieb Pekka Paalanen: > On Tue, 22 Jun 2021 11:57:53 +0200 > Werner Sembach wrote: > >> Am 22.06.21 um 09:25 schrieb Pekka Paalanen: >>> On Fri, 18 Jun 2021 11:11:14 +0200 >>> Werner Sembach wrote: >>> >>>> Add "

Re: [PATCH v4 09/17] drm/uAPI: Add "active color range" drm property as feedback for userspace

2021-06-23 Thread Werner Sembach
Am 23.06.21 um 09:32 schrieb Pekka Paalanen: > On Tue, 22 Jun 2021 11:48:52 + > Simon Ser wrote: > >> On Tuesday, June 22nd, 2021 at 11:50, Werner Sembach >> wrote: >> >>> Unknown is when no monitor is connected or is when the >>> connecto

Re: [PATCH v4 17/17] drm/amd/display: Add handling for new "Broadcast RGB" property

2021-06-23 Thread Werner Sembach
Am 23.06.21 um 10:01 schrieb Pekka Paalanen: > On Tue, 22 Jun 2021 11:28:57 +0200 > Werner Sembach wrote: > >> Am 22.06.21 um 09:29 schrieb Pekka Paalanen: >>> On Fri, 18 Jun 2021 11:11:16 +0200 >>> Werner Sembach wrote: >>> >>>> T

Re: [PATCH v4 09/17] drm/uAPI: Add "active color range" drm property as feedback for userspace

2021-06-23 Thread Werner Sembach
Am 23.06.21 um 13:14 schrieb Pekka Paalanen: > On Wed, 23 Jun 2021 12:17:40 +0200 > Werner Sembach wrote: > >> Am 23.06.21 um 09:32 schrieb Pekka Paalanen: >>> On Tue, 22 Jun 2021 11:48:52 + >>> Simon Ser wrote: >>> >>>> On Tuesday,

Re: [PATCH v4 09/17] drm/uAPI: Add "active color range" drm property as feedback for userspace

2021-06-22 Thread Werner Sembach
Am 22.06.21 um 09:00 schrieb Pekka Paalanen: > On Fri, 18 Jun 2021 11:11:08 +0200 > Werner Sembach wrote: > >> Add a new general drm property "active color range" which can be used by >> graphic drivers to report the used color range back to userspace. >&g

Re: [PATCH v4 15/17] drm/uAPI: Move "Broadcast RGB" property from driver specific to general context

2021-06-22 Thread Werner Sembach
Am 22.06.21 um 09:25 schrieb Pekka Paalanen: > On Fri, 18 Jun 2021 11:11:14 +0200 > Werner Sembach wrote: > >> Add "Broadcast RGB" to general drm context so that more drivers besides >> i915 and gma500 can implement it without duplicating code. >> >&

Re: [PATCH v4 17/17] drm/amd/display: Add handling for new "Broadcast RGB" property

2021-06-22 Thread Werner Sembach
Am 22.06.21 um 09:29 schrieb Pekka Paalanen: > On Fri, 18 Jun 2021 11:11:16 +0200 > Werner Sembach wrote: > >> This commit implements the "Broadcast RGB" drm property for the AMD GPU >> driver. >> >> Signed-off-by: Werner Sembach >> --- >&

Re: [PATCH v4 15/17] drm/uAPI: Move "Broadcast RGB" property from driver specific to general context

2021-06-25 Thread Werner Sembach
Am 23.06.21 um 13:26 schrieb Pekka Paalanen: > On Wed, 23 Jun 2021 12:10:14 +0200 > Werner Sembach wrote: > >> Am 23.06.21 um 09:48 schrieb Pekka Paalanen: >>> On Tue, 22 Jun 2021 11:57:53 +0200 >>> Werner Sembach wrote: >>> >>>> Am 22

[PATCH v3 00/14] New uAPI drm properties for color management

2021-06-15 Thread Werner Sembach
I started work on my proposal for better color handling in Linux display drivers: https://lkml.org/lkml/2021/5/12/764 In this 3rd revision everything except the generalised Broadcast RGB implementation is included. I did however not yet include everything suggested in the feedback for v1 and v2.

[PATCH v3 13/14] drm/amd/display: Add handling for new "preferred color format" property

2021-06-15 Thread Werner Sembach
This commit implements the "preferred color format" drm property for the AMD GPU driver. Signed-off-by: Werner Sembach --- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 24 ++- .../display/amdgpu_dm/amdgpu_dm_mst_types.c | 4 2 files changed, 22 insert

[PATCH v3 09/14] drm/uAPI: Add "active color range" drm property as feedback for userspace

2021-06-15 Thread Werner Sembach
he monitor and what the default behaviour of the used driver is. This property helps eliminating the guessing at this point. In the future, automatic color calibration for screens might also depend on this information being available. Signed-off-by: Werner Sembach --- drivers/gpu/drm/drm_connec

[PATCH v3 12/14] drm/uAPI: Add "preferred color format" drm property as setting for userspace

2021-06-15 Thread Werner Sembach
bandwidth heavy ycbcr422 and ycbcr420 formats for a signal that is less deceptible to interference. In the future, automatic color calibration for screens might also depend on this option being available. Signed-off-by: Werner Sembach --- drivers/gpu/drm/drm_atomic_helper.c | 4 +++ drive

[PATCH v3 08/14] drm/i915/display: Add handling for new "active color format" property

2021-06-15 Thread Werner Sembach
This commit implements the "active color format" drm property for the Intel GPU driver. Signed-off-by: Werner Sembach --- drivers/gpu/drm/i915/display/intel_display.c | 21 +++- drivers/gpu/drm/i915/display/intel_dp.c | 2 ++ drivers/gpu/drm/i915/display/inte

[PATCH v3 07/14] drm/amd/display: Add handling for new "active color format" property

2021-06-15 Thread Werner Sembach
This commit implements the "active color format" drm property for the AMD GPU driver. Signed-off-by: Werner Sembach --- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 28 +-- .../display/amdgpu_dm/amdgpu_dm_mst_types.c | 4 +++ 2 files changed, 30 insertions(+), 2

[PATCH v3 11/14] drm/i915/display: Add handling for new "active color range" property

2021-06-15 Thread Werner Sembach
This commit implements the "active color range" drm property for the Intel GPU driver. Signed-off-by: Werner Sembach --- drivers/gpu/drm/i915/display/intel_display.c | 4 drivers/gpu/drm/i915/display/intel_dp.c | 2 ++ drivers/gpu/drm/i915/display/intel_dp_mst.c | 5

[PATCH v3 14/14] drm/i915/display: Add handling for new "preferred color format" property

2021-06-15 Thread Werner Sembach
This commit implements the "preferred color format" drm property for the Intel GPU driver. Signed-off-by: Werner Sembach --- drivers/gpu/drm/i915/display/intel_dp.c | 7 ++- drivers/gpu/drm/i915/display/intel_dp_mst.c | 5 + drivers/gpu/drm/i915/display/intel_hdmi.c |

[PATCH v3 01/14] drm/amd/display: Remove unnecessary SIGNAL_TYPE_HDMI_TYPE_A check

2021-06-15 Thread Werner Sembach
reports drm_mode_is_420_only() even on a non HDMI connection. This patch also moves both checks in the same if-case. This eliminates an extra else-if-case. Signed-off-by: Werner Sembach --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(

[PATCH v3 06/14] drm/uAPI: Add "active color format" drm property as feedback for userspace

2021-06-15 Thread Werner Sembach
lso depend on this information being available. Signed-off-by: Werner Sembach --- drivers/gpu/drm/drm_connector.c | 56 + include/drm/drm_connector.h | 8 + 2 files changed, 64 insertions(+) diff --git a/drivers/gpu/drm/drm_connector.c b/drivers/gpu/drm/drm_connect

[PATCH v3 04/14] drm/amd/display: Add handling for new "active bpc" property

2021-06-15 Thread Werner Sembach
This commit implements the "active bpc" drm property for the AMD GPU driver. Signed-off-by: Werner Sembach --- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 19 ++- .../display/amdgpu_dm/amdgpu_dm_mst_types.c | 4 2 files changed, 22 insertions(+), 1 deletio

[PATCH v3 03/14] drm/uAPI: Add "active bpc" as feedback channel for "max bpc" drm property

2021-06-15 Thread Werner Sembach
ailable. Signed-off-by: Werner Sembach --- drivers/gpu/drm/drm_connector.c | 50 + include/drm/drm_connector.h | 8 ++ 2 files changed, 58 insertions(+) diff --git a/drivers/gpu/drm/drm_connector.c b/drivers/gpu/drm/drm_connector.c index da39e7ff6965.

[PATCH v3 05/14] drm/i915/display: Add handling for new "active bpc" property

2021-06-15 Thread Werner Sembach
This commit implements the "active bpc" drm property for the Intel GPU driver. Signed-off-by: Werner Sembach --- drivers/gpu/drm/i915/display/intel_display.c | 14 ++ drivers/gpu/drm/i915/display/intel_dp.c | 8 ++-- drivers/gpu/drm/i915/display/intel_dp_m

[PATCH v3 02/14] drm/amd/display: Add missing cases convert_dc_color_depth_into_bpc

2021-06-15 Thread Werner Sembach
convert_dc_color_depth_into_bpc() that converts the enum dc_color_depth to an integer had the casses for COLOR_DEPTH_999 and COLOR_DEPTH_11 missing. Signed-off-by: Werner Sembach --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 4 1 file changed, 4 insertions(+) diff --git

[PATCH v3 10/14] drm/amd/display: Add handling for new "active color range" property

2021-06-15 Thread Werner Sembach
This commit implements the "active color range" drm property for the AMD GPU driver. Signed-off-by: Werner Sembach --- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 32 +++ .../display/amdgpu_dm/amdgpu_dm_mst_types.c | 4 +++ 2 files changed, 36 insertions(+)

Re: [PATCH v3 03/14] drm/uAPI: Add "active bpc" as feedback channel for "max bpc" drm property

2021-06-15 Thread Werner Sembach
Am 15.06.21 um 16:14 schrieb Werner Sembach: Add a new general drm property "active bpc" which can be used by graphic drivers to report the applied bit depth per pixel back to userspace. While "max bpc" can be used to change the color depth, there was no way to check which o

[PATCH] drm/amd/display: Remove unnecessary SIGNAL_TYPE_HDMI_TYPE_A check

2021-06-11 Thread Werner Sembach
reports drm_mode_is_420_only() even on a non HDMI connection. This patch also moves both checks in the same if-case. This eliminates an extra else-if-case. Signed-off-by: Werner Sembach --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(

Re: [PATCH] drm/amd/display: Expose active display color configurations to userspace

2021-05-11 Thread Werner Sembach
Am 11.05.21 um 10:07 schrieb Pekka Paalanen: > On Mon, 10 May 2021 17:47:01 -0400 > Alex Deucher wrote: > >> On Fri, May 7, 2021 at 3:27 PM Werner Sembach >> wrote: >>> xrandr --prop and other userspace info tools have currently no way of >>> telling wh

New uAPI for color management proposal and feedback request

2021-05-12 Thread Werner Sembach
e feedback channels first, because they can be very useful for debugging the setting properties afterwards. I will split each of it up it in 3 or 5 patch sets: 1 for the vendor agnostic part, 1 for Intel (or 2 split up between HDMI and DP), and 1 for AMD (or 2 split up between HDMI and DP) Kind regards, Werner Sembach ___ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx

[PATCH] drm/amd/display: Expose active display color configurations to userspace

2021-05-07 Thread Werner Sembach
these configuration information readily available is a useful tool in debuging washed out colors, color artefacts on small fonts and missing refreshrate options. Signed-off-by: Werner Sembach --- drivers/gpu/drm/amd/amdgpu/amdgpu_display.c | 58 +++ drivers/gpu/drm/amd/amdgpu

Re: New uAPI for color management proposal and feedback request

2021-05-17 Thread Werner Sembach
Am 12.05.21 um 14:06 schrieb Werner Sembach: > Hello, > > In addition to the existing "max bpc", and "Broadcast RGB/output_csc" drm > properties I propose 4 new properties: > "preferred pixel encoding", "active color depth", "active col

Re: New uAPI for color management proposal and feedback request

2021-05-12 Thread Werner Sembach
Am 12.05.21 um 14:06 schrieb Werner Sembach: > Hello, > > In addition to the existing "max bpc", and "Broadcast RGB/output_csc" drm > properties I propose 4 new properties: > "preferred pixel encoding", "active color depth", "active c

Re: New uAPI for color management proposal and feedback request

2021-05-31 Thread Werner Sembach
Am 12.05.21 um 19:59 schrieb Alex Deucher: > On Wed, May 12, 2021 at 9:04 AM Ville Syrjälä > wrote: >> On Wed, May 12, 2021 at 02:06:56PM +0200, Werner Sembach wrote: >>> Hello, >>> >>> In addition to the existing "max bpc", and "Broadca

Re: New uAPI for color management proposal and feedback request

2021-05-31 Thread Werner Sembach
Am 19.05.21 um 15:49 schrieb Ville Syrjälä: > On Wed, May 19, 2021 at 12:34:05PM +0300, Pekka Paalanen wrote: >> On Wed, 12 May 2021 16:04:16 +0300 >> Ville Syrjälä wrote: >> >>> On Wed, May 12, 2021 at 02:06:56PM +0200, Werner Sembach wrote: >>>> Hello,

Re: [PATCH 4/4] drm/i915/display: Add handling for new "active bpc" property

2021-06-07 Thread Werner Sembach
Am 04.06.21 um 19:30 schrieb Ville Syrjälä: On Fri, Jun 04, 2021 at 07:17:23PM +0200, Werner Sembach wrote: This commits implements the "active bpc" drm property for the Intel GPU driver. Signed-off-by: Werner Sembach --- drivers/gpu/drm/i915/display/intel_disp

Re: [PATCH 2/4] drm/uAPI: Add "active bpc" as feedback channel for "max bpc" drm property

2021-06-07 Thread Werner Sembach
Am 04.06.21 um 19:26 schrieb Ville Syrjälä: On Fri, Jun 04, 2021 at 07:17:21PM +0200, Werner Sembach wrote: Add a new general drm property "active bpc" which can be used by graphic drivers to report the applied bit depth per pixel back to userspace. While "max bpc" c

Re: [PATCH 2/4] drm/uAPI: Add "active bpc" as feedback channel for "max bpc" drm property

2021-06-07 Thread Werner Sembach
Am 07.06.21 um 09:40 schrieb Maxime Ripard: Hi, On Fri, Jun 04, 2021 at 07:17:21PM +0200, Werner Sembach wrote: Add a new general drm property "active bpc" which can be used by graphic drivers to report the applied bit depth per pixel back to userspace. Just a heads up, we'll ne

Re: [PATCH 2/4] drm/uAPI: Add "active bpc" as feedback channel for "max bpc" drm property

2021-06-07 Thread Werner Sembach
Am 07.06.21 um 09:52 schrieb Pekka Paalanen: On Fri, 4 Jun 2021 19:17:21 +0200 Werner Sembach wrote: Add a new general drm property "active bpc" which can be used by graphic drivers to report the applied bit depth per pixel back to userspace. While "max bpc" can be used

[PATCH] drm/amd/display: Add missing cases convert_dc_color_depth_into_bpc

2021-06-04 Thread Werner Sembach
convert_dc_color_depth_into_bpc() that converts the enum dc_color_depth to an integer had the casses for COLOR_DEPTH_999 and COLOR_DEPTH_11 missing. Signed-off-by: Werner Sembach --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 4 1 file changed, 4 insertions(+) diff --git

[PATCH 0/1] drm/amd/display: Add missing cases

2021-06-04 Thread Werner Sembach
Rev 2: Fix small typo in commit message. ___ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx

[PATCH 1/1] drm/amd/display: Add missing cases convert_dc_color_depth_into_bpc

2021-06-04 Thread Werner Sembach
convert_dc_color_depth_into_bpc() that converts the enum dc_color_depth to an integer had the cases for COLOR_DEPTH_999 and COLOR_DEPTH_11 missing. Signed-off-by: Werner Sembach --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 4 1 file changed, 4 insertions(+) diff --git

[PATCH 2/4] drm/uAPI: Add "active bpc" as feedback channel for "max bpc" drm property

2021-06-04 Thread Werner Sembach
ailable. Signed-off-by: Werner Sembach --- drivers/gpu/drm/drm_atomic_uapi.c | 2 ++ drivers/gpu/drm/drm_connector.c | 40 +++ include/drm/drm_connector.h | 15 3 files changed, 57 insertions(+) diff --git a/drivers/gpu/drm/drm_atomic_uapi.

[PATCH 0/4] Add "activ bpc" drm property and use it in AMD and Intel driver

2021-06-04 Thread Werner Sembach
I started work on my proposal for better color handling in Linux display drivers: https://lkml.org/lkml/2021/5/12/764 Since the first read-only property is now implemented for amdgpu and i915 I wanted to collect some feedback, since the other two read-only properties will be quite similar, I

[PATCH 3/4] drm/amd/display: Add handling for new "active bpc" property

2021-06-04 Thread Werner Sembach
This commits implements the "active bpc" drm property for the AMD GPU driver. Signed-off-by: Werner Sembach --- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 18 +- .../display/amdgpu_dm/amdgpu_dm_mst_types.c| 4 +++- 2 files changed, 20 insertions(+), 2

[PATCH 1/4] drm/amd/display: Add missing cases convert_dc_color_depth_into_bpc

2021-06-04 Thread Werner Sembach
convert_dc_color_depth_into_bpc() that converts the enum dc_color_depth to an integer had the casses for COLOR_DEPTH_999 and COLOR_DEPTH_11 missing. Signed-off-by: Werner Sembach --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 4 1 file changed, 4 insertions(+) diff --git

[PATCH 4/4] drm/i915/display: Add handling for new "active bpc" property

2021-06-04 Thread Werner Sembach
This commits implements the "active bpc" drm property for the Intel GPU driver. Signed-off-by: Werner Sembach --- drivers/gpu/drm/i915/display/intel_display.c | 13 + drivers/gpu/drm/i915/display/intel_dp.c | 8 ++-- drivers/gpu/drm/i915/display/intel_dp_m

Re: [PATCH v4 03/17] drm/uAPI: Add "active bpc" as feedback channel for "max bpc" drm property

2021-06-30 Thread Werner Sembach
Am 30.06.21 um 10:21 schrieb Pekka Paalanen: On Tue, 29 Jun 2021 13:02:05 +0200 Werner Sembach wrote: Am 28.06.21 um 19:03 schrieb Werner Sembach: Am 18.06.21 um 11:11 schrieb Werner Sembach: Add a new general drm property "active bpc" which can be used by graphic drivers

Re: [PATCH v4 12/17] drm/uAPI: Add "preferred color format" drm property as setting for userspace

2021-06-30 Thread Werner Sembach
Am 30.06.21 um 10:41 schrieb Pekka Paalanen: On Tue, 29 Jun 2021 13:39:18 +0200 Werner Sembach wrote: Am 29.06.21 um 13:17 schrieb Pekka Paalanen: On Tue, 29 Jun 2021 08:12:54 + Simon Ser wrote: On Tuesday, June 22nd, 2021 at 09:15, Pekka Paalanen wrote: yes, I think

Re: [PATCH v4 12/17] drm/uAPI: Add "preferred color format" drm property as setting for userspace

2021-07-01 Thread Werner Sembach
Am 01.07.21 um 10:07 schrieb Pekka Paalanen: > On Wed, 30 Jun 2021 11:20:18 +0200 > Werner Sembach wrote: > >> Am 30.06.21 um 10:41 schrieb Pekka Paalanen: >> >>> On Tue, 29 Jun 2021 13:39:18 +0200 >>> Werner Sembach wrote: >>> >>>>

Re: [PATCH v4 03/17] drm/uAPI: Add "active bpc" as feedback channel for "max bpc" drm property

2021-07-01 Thread Werner Sembach
Am 01.07.21 um 09:42 schrieb Pekka Paalanen: > On Wed, 30 Jun 2021 11:42:10 +0200 > Werner Sembach wrote: > >> Am 30.06.21 um 10:21 schrieb Pekka Paalanen: >>> On Tue, 29 Jun 2021 13:02:05 +0200 >>> Werner Sembach wrote: >>> >>>> A

[PATCH v5 09/17] drm/uAPI: Add "active color range" drm property as feedback for userspace

2021-06-30 Thread Werner Sembach
he monitor and what the default behaviour of the used driver is. This property helps eliminating the guessing at this point. In the future, automatic color calibration for screens might also depend on this information being available. Signed-off-by: Werner Sembach --- drivers/gpu/drm/drm_connec

[PATCH v5 06/17] drm/uAPI: Add "active color format" drm property as feedback for userspace

2021-06-30 Thread Werner Sembach
lso depend on this information being available. Signed-off-by: Werner Sembach --- drivers/gpu/drm/drm_connector.c | 63 + include/drm/drm_connector.h | 9 + 2 files changed, 72 insertions(+) diff --git a/drivers/gpu/drm/drm_connector.c b/drivers/gpu/drm/drm_connect

[PATCH v5 11/17] drm/i915/display: Add handling for new "active color range" property

2021-06-30 Thread Werner Sembach
This commit implements the "active color range" drm property for the Intel GPU driver. Signed-off-by: Werner Sembach --- drivers/gpu/drm/i915/display/intel_display.c | 7 +++ drivers/gpu/drm/i915/display/intel_dp.c | 1 + drivers/gpu/drm/i915/display/intel_dp_mst.c | 5

[PATCH v5 13/17] drm/amd/display: Add handling for new "preferred color format" property

2021-06-30 Thread Werner Sembach
This commit implements the "preferred color format" drm property for the AMD GPU driver. Signed-off-by: Werner Sembach --- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 30 +++ .../display/amdgpu_dm/amdgpu_dm_mst_types.c | 4 +++ 2 files changed, 28 insert

[PATCH v5 07/17] drm/amd/display: Add handling for new "active color format" property

2021-06-30 Thread Werner Sembach
This commit implements the "active color format" drm property for the AMD GPU driver. Signed-off-by: Werner Sembach --- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 29 +-- .../display/amdgpu_dm/amdgpu_dm_mst_types.c | 4 +++ 2 files changed, 31 insertions(+), 2

[PATCH v5 10/17] drm/amd/display: Add handling for new "active color range" property

2021-06-30 Thread Werner Sembach
This commit implements the "active color range" drm property for the AMD GPU driver. Signed-off-by: Werner Sembach --- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 33 +++ .../display/amdgpu_dm/amdgpu_dm_mst_types.c | 4 +++ 2 files changed, 37 insertions(+)

[PATCH v5 17/17] drm/amd/display: Add handling for new "Broadcast RGB" property

2021-06-30 Thread Werner Sembach
This commit implements the "Broadcast RGB" drm property for the AMD GPU driver. Signed-off-by: Werner Sembach --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 14 +++--- .../amd/display/amdgpu_dm/amdgpu_dm_mst_types.c| 4 2 files changed, 15 insertions(+), 3

[PATCH v5 16/17] drm/i915/display: Use the general "Broadcast RGB" implementation

2021-06-30 Thread Werner Sembach
Change from the i915 specific "Broadcast RGB" drm property implementation to the general one. This commit delete all traces of the former "Broadcast RGB" implementation and add a new one using the new driver agnoistic functions an variables. Signed-off-by: Werner Sembach

[PATCH v5 15/17] drm/uAPI: Move "Broadcast RGB" property from driver specific to general context

2021-06-30 Thread Werner Sembach
e a manual overwrite is required to not have washed out colors or lose details in very dark or bright scenes. Signed-off-by: Werner Sembach --- drivers/gpu/drm/drm_atomic_helper.c | 4 +++ drivers/gpu/drm/drm_atomic_uapi.c | 4 +++ drivers/gpu/drm/drm_connector.c | 46

[PATCH v5 12/17] drm/uAPI: Add "preferred color format" drm property as setting for userspace

2021-06-30 Thread Werner Sembach
bandwidth heavy ycbcr422 and ycbcr420 formats for a signal that is less deceptible to interference. In the future, automatic color calibration for screens might also depend on this option being available. Signed-off-by: Werner Sembach --- drivers/gpu/drm/drm_atomic_helper.c | 4 +++ drive

[PATCH v5 14/17] drm/i915/display: Add handling for new "preferred color format" property

2021-06-30 Thread Werner Sembach
This commit implements the "preferred color format" drm property for the Intel GPU driver. Signed-off-by: Werner Sembach --- drivers/gpu/drm/i915/display/intel_dp.c | 7 ++- drivers/gpu/drm/i915/display/intel_dp_mst.c | 5 + drivers/gpu/drm/i915/display/intel_hdmi.c | 6

[PATCH v5 02/17] drm/amd/display: Add missing cases convert_dc_color_depth_into_bpc

2021-06-30 Thread Werner Sembach
convert_dc_color_depth_into_bpc() that converts the enum dc_color_depth to an integer had the casses for COLOR_DEPTH_999 and COLOR_DEPTH_11 missing. Signed-off-by: Werner Sembach --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 4 1 file changed, 4 insertions(+) diff --git

[PATCH v5 08/17] drm/i915/display: Add handling for new "active color format" property

2021-06-30 Thread Werner Sembach
This commit implements the "active color format" drm property for the Intel GPU driver. Signed-off-by: Werner Sembach --- drivers/gpu/drm/i915/display/intel_display.c | 22 +++- drivers/gpu/drm/i915/display/intel_dp.c | 2 ++ drivers/gpu/drm/i915/display/inte

[PATCH v5 05/17] drm/i915/display: Add handling for new "active bpc" property

2021-06-30 Thread Werner Sembach
This commit implements the "active bpc" drm property for the Intel GPU driver. Signed-off-by: Werner Sembach --- drivers/gpu/drm/i915/display/intel_display.c | 19 +++ drivers/gpu/drm/i915/display/intel_dp.c | 7 +-- drivers/gpu/drm/i915/display/intel_dp_m

[PATCH v5 03/17] drm/uAPI: Add "active bpc" as feedback channel for "max bpc" drm property

2021-06-30 Thread Werner Sembach
tion being available. Signed-off-by: Werner Sembach --- drivers/gpu/drm/drm_connector.c | 53 + include/drm/drm_connector.h | 8 + 2 files changed, 61 insertions(+) diff --git a/drivers/gpu/drm/drm_connector.c b/drivers/gpu/drm/drm_connector.c index da39e7ff6965.

[PATCH v5 01/17] drm/amd/display: Remove unnecessary SIGNAL_TYPE_HDMI_TYPE_A check

2021-06-30 Thread Werner Sembach
reports drm_mode_is_420_only() even on a non HDMI connection. This patch also moves both checks in the same if-case. This eliminates an extra else-if-case. Signed-off-by: Werner Sembach --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(

[PATCH v5 04/17] drm/amd/display: Add handling for new "active bpc" property

2021-06-30 Thread Werner Sembach
This commit implements the "active bpc" drm property for the AMD GPU driver. Signed-off-by: Werner Sembach --- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 24 ++- .../display/amdgpu_dm/amdgpu_dm_mst_types.c | 4 2 files changed, 27 insertions(+), 1 deletio

[PATCH v5 00/17] New uAPI drm properties for color management

2021-06-30 Thread Werner Sembach
Implementation of https://lkml.org/lkml/2021/5/12/764 now feature complete albeit not fully tested. I have now corrected the DSC behavior, but still no wait to test it. Exact dithering behavior remains a mistery so in case dithering is active it's not 100% clear what "active bpc" means, or where

Re: [PATCH v4 03/17] drm/uAPI: Add "active bpc" as feedback channel for "max bpc" drm property

2021-06-28 Thread Werner Sembach
Am 18.06.21 um 11:11 schrieb Werner Sembach: > Add a new general drm property "active bpc" which can be used by graphic > drivers to report the applied bit depth per pixel back to userspace. > > While "max bpc" can be used to change the color depth, there was no w

Re: [PATCH v4 12/17] drm/uAPI: Add "preferred color format" drm property as setting for userspace

2021-07-05 Thread Werner Sembach
Am 01.07.21 um 15:24 schrieb Pekka Paalanen: > On Thu, 1 Jul 2021 14:50:13 +0200 > Werner Sembach wrote: > >> Am 01.07.21 um 10:07 schrieb Pekka Paalanen: >> >>> On Wed, 30 Jun 2021 11:20:18 +0200 >>> Werner Sembach wrote: >>>

Re: [PATCH v4 12/17] drm/uAPI: Add "preferred color format" drm property as setting for userspace

2021-06-29 Thread Werner Sembach
Am 29.06.21 um 13:17 schrieb Pekka Paalanen: > On Tue, 29 Jun 2021 08:12:54 + > Simon Ser wrote: > >> On Tuesday, June 22nd, 2021 at 09:15, Pekka Paalanen >> wrote: >> >>> yes, I think this makes sense, even if it is a property that one can't >>> tell for sure what it does before hand.

Re: [PATCH v4 03/17] drm/uAPI: Add "active bpc" as feedback channel for "max bpc" drm property

2021-06-29 Thread Werner Sembach
Am 28.06.21 um 19:03 schrieb Werner Sembach: > Am 18.06.21 um 11:11 schrieb Werner Sembach: >> Add a new general drm property "active bpc" which can be used by graphic >> drivers to report the applied bit depth per pixel back to userspace. >> >> While &quo

Re: [PATCH v4 12/17] drm/uAPI: Add "preferred color format" drm property as setting for userspace

2021-06-29 Thread Werner Sembach
Am 29.06.21 um 13:17 schrieb Pekka Paalanen: > On Tue, 29 Jun 2021 08:12:54 + > Simon Ser wrote: > >> On Tuesday, June 22nd, 2021 at 09:15, Pekka Paalanen >> wrote: >> >>> yes, I think this makes sense, even if it is a property that one can't >>> tell for sure what it does before hand. >>>

  1   2   >