Re: [PATCH v2 5/5] drm/amdgpu:add VCN booting with firmware loaded by PSP

-gfx on behalf of Felix Kuehling Sent: Friday, August 17, 2018 7:25:53 PM To: James Zhu; amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander; Gao, Likun; Zhu, James; Huang, Ray Subject: Re: [PATCH v2 5/5] drm/amdgpu:add VCN booting with firmware loaded by PSP ROCm CQE is seeing what looks like hangs du

[PATCH] drm/amdgpu/vcn:Fix uninitialized symbol error

ret_code should be initialized with 0. The check of read/write ptr should be activate when UVD_POWER_STATUS_TILES is off. Signed-off-by: James Zhu --- drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

Re: [PATCH v2] drm/amdgpu:No action when VCN PG state is unchanged

Ping Alex and Christian, Could you give a review on this updated patch? Thanks & Best Regards! James Zhu From: James Zhu Sent: Thursday, September 13, 2018 4:55 PM To: amd-gfx@lists.freedesktop.org Cc: Zhu, James Subject: [PATCH v2] drm/amdgpu:No ac

[PATCH 6/6] drm/amdgpu/vcn:Reset decode r/w point after unset jpeg/non_jpeg pause mode

Reset decode r/w point after unset jpeg/non_jpeg pause mode to address a hardware bug. Signed-off-by: James Zhu --- drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c

[PATCH 2/6] drm/amdgpu/vcn:Update ring point to JPEG before init JPEG wptr

It is a bug fix. Signed-off-by: James Zhu --- drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c b/drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c index 7752043..5df6ea9 100644 ---

[PATCH 1/6] drm/amdgpu/vcn:Always gate vcn block during hw finishing

Under Dynamic Power Gate mode, UVD_STATUS needn't be checked. Signed-off-by: James Zhu --- drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c b/drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c index

[PATCH 4/6] drm/amdgpu/vcn:Scan enc/jpeg fences to init dpg pause new state

Scan enc/jpeg fences to init dpg pause new state in begin use. It will help set dpg mode to desire state actively. Signed-off-by: James Zhu --- drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c | 18 ++ 1 file changed, 14 insertions(+), 4 deletions(-) diff --git

[PATCH 5/6] drm/amdgpu/vcn:Wait for all vcn rings finish before switching dpg mode

For robustness, it is safe to wait for all vcn rings finish before switching dpg mode. Signed-off-by: James Zhu --- drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c | 17 + 1 file changed, 17 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c

[PATCH 3/6] drm/amdgpu/vcn:Always check all vcn ring status during dpg mode stop

Always check all vcn ring status during dpg mode stop, it will help identify which vcn ring may cause the issue. Signed-off-by: James Zhu --- drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c | 24 1 file changed, 16 insertions(+), 8 deletions(-) diff --git

[PATCH] drm/amdgpu/uvd:Change uvd ring name convention

Since umr tool can't handle bracket, change uvd ring name convention. Signed-off-by: James Zhu --- drivers/gpu/drm/amd/amdgpu/uvd_v7_0.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/uvd_v7_0.c b/drivers/gpu/drm/amd/amdgpu/uvd_v7_0.c index

[PATCH] drm/amdgpu:Improves robustness of SOC15_WAIT_ON_RREG

If monitor register value is updating, reset timeout counter. It improves robustness of SOC15_WAIT_ON_RREG. Signed-off-by: James Zhu --- drivers/gpu/drm/amd/amdgpu/soc15_common.h | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/soc15_common.h

[PATCH v2] drm/amdgpu:Improves robustness of SOC15_WAIT_ON_RREG

If register value is updating, reset timeout counter. It improves robustness of SOC15_WAIT_ON_RREG. Signed-off-by: James Zhu --- drivers/gpu/drm/amd/amdgpu/soc15_common.h | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/soc15_common.h

[PATCH v2 6/6] drm/amdgpu/vcn:Remove bit 31 for scratch2 to indicate the WA is active

Remove bit 31 for scratch2 to indicate the Hardware bug work around is active. Signed-off-by: James Zhu --- drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c

[PATCH] drm/amdgpu/vcn:Fixed S3 hung issue

Replace vcn_v1_0_stop with vcn_v1_0_set_powergating_state during suspend, to keep adev->vcn.cur_state update. It will fix VCN S3 hung issue. Signed-off-by: James Zhu --- drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

[PATCH] drm/amdgpu: Fixed missing to clear some EDC count

EDC counts are related to instance and se. They are not the same for different type of EDC. EDC clearing are changed to base on individual EDC's instance and SE number. Signed-off-by: James Zhu --- drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 85 +--

[PATCH] drm/amdgpu: Add GDS clearing workaround in later init for gfx9

Since Hardware bug, GDS exist ECC error after cold boot up, adding GDS clearing workaround in later init for gfx9. Signed-off-by: James Zhu --- drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 48 +++ 1 file changed, 48 insertions(+) diff --git

[PATCH v2] drm/amdgpu: explicitly set mmGDS_VMID0_BASE to 0

Explicitly set mmGDS_VMID0_BASE to 0. Also update GDS_VMID0_BASE/_SIZE with direct register writes. Signed-off-by: James Zhu --- drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 35 +-- 1 file changed, 17 insertions(+), 18 deletions(-) diff --git

[PATCH v3] drm/amdgpu: explicitly set mmGDS_VMID0_BASE to 0

Explicitly set mmGDS_VMID0_BASE to 0. Also update GDS_VMID0_BASE/_SIZE with direct register writes. Signed-off-by: James Zhu --- drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 35 +-- 1 file changed, 17 insertions(+), 18 deletions(-) diff --git

[PATCH] drm/amdgpu: explicitly set mmGDS_VMID0_BASE to 0

Explicitly set mmGDS_VMID0_BASE to 0. Also update GDS_VMID0_BASE/_SIZE with direct register writes. Signed-off-by: James Zhu --- drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 33 +++-- 1 file changed, 15 insertions(+), 18 deletions(-) diff --git

[PATCH] drm/amdgpu: Fix S3 test issue

During S3 test, when system wake up and resume, ras interface is already allocated. Move workaround before ras jumps to resume step in gfx_v9_0_ecc_late_init, and make sure workaround applied during resume. Also remove unused mmGB_EDC_MODE clearing. Signed-off-by: James Zhu ---

[PATCH 1/2] drm/amdgpu: add EDC counter register

Add EDC counter register to support gfx9 gpr EDC workaround to clear all EDC counters. Signed-off-by: James Zhu Reviewed-by: Alex Deucher --- .../drm/amd/include/asic_reg/gc/gc_9_0_offset.h| 31 ++ 1 file changed, 31 insertions(+) diff --git

[PATCH 2/2] drm/amdgpu: add gfx9 gpr EDC workaround when RAS is enabled

When RAS is enabled, initializes the VGPRs/LDS/SGPRs and resets EDC error counts. This is done in late_init, before RAS TA GFX enable. Signed-off-by: James Zhu Reviewed-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 245 ++

[PATCH 0/3] Fixed amdgpu resume failure from suspend

UVD session info size can be upto 128K, we need to allocate a large enough buffer for the session info, otherwise the IB test can overwrite other's memory. Bug: https://bugzilla.kernel.org/show_bug.cgi?id=204241 James Zhu (3): drm/amdgpu/uvd:Add uvd enc session bo drm/amdgpu/uvd:Allocate enc

[PATCH 1/3] drm/amdgpu/uvd:Add uvd enc session bo

Add uvd enc session bo for uvd encode IB test. Signed-off-by: James Zhu --- drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.h | 4 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.h b/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.h index 5eb6328..1e39c8a 100644 ---

[PATCH 2/3] drm/amdgpu/uvd:Allocate enc session bo for uvd6.0 ring IB test

Allocate 256K enc session bo for uvd6.0 ring IB test to fix S3 resume corruption issue. Signed-off-by: James Zhu --- drivers/gpu/drm/amd/amdgpu/uvd_v6_0.c | 16 ++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/uvd_v6_0.c

[PATCH 3/3] drm/amdgpu/uvd:Allocate enc session bo for uvd7.0 ring IB test

Allocate 256K enc session bo for uvd6.0 ring IB test to fix S3 resume corruption issue. Signed-off-by: James Zhu --- drivers/gpu/drm/amd/amdgpu/uvd_v7_0.c | 16 ++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/uvd_v7_0.c

[PATCH] drm/amdgpu/vcn: Enable VCN2.5 encoding

After VCN2.5 firmware (Version ENC: 1.1 Revision: 11), VCN2.5 encoding can work properly. Signed-off-by: James Zhu --- drivers/gpu/drm/amd/amdgpu/vcn_v2_5.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/vcn_v2_5.c b/drivers/gpu/drm/amd/amdgpu/vcn_v2_5.c

Re: [PATCH 1/2] drm/amdgpu/vcn: fix race condition issue for vcn start

[AMD Official Use Only - Internal Distribution Only] ping From: Zhu, James Sent: Monday, February 10, 2020 1:06 PM To: amd-gfx@lists.freedesktop.org Cc: Zhu, James Subject: [PATCH 1/2] drm/amdgpu/vcn: fix race condition issue for vcn start Fix race condition

Re: [PATCH 1/2] drm/amdgpu/vcn: fix race condition issue for vcn start

Sent: Wednesday, February 12, 2020 10:11 AM To: Zhu, James ; amd-gfx@lists.freedesktop.org Subject: RE: [PATCH 1/2] drm/amdgpu/vcn: fix race condition issue for vcn start With your patches, still seeing the hung with multiple processes of decode, encode, and transcode. I think we need find the root c

Re: [PATCH] drm/amdgpu/vcn2.5: fix warning

[AMD Official Use Only - Internal Distribution Only] ping From: Zhu, James Sent: Friday, February 7, 2020 8:17 AM To: amd-gfx@lists.freedesktop.org Cc: Zhu, James Subject: [PATCH] drm/amdgpu/vcn2.5: fix warning Fix warning during switching to dpg pause mode

Re: [PATCH v3 1/4] drm/amdgpu/vcn: fix race condition issue for vcn start

[AMD Official Use Only - Internal Distribution Only] ping From: Zhu, James Sent: Monday, March 9, 2020 12:57 PM To: amd-gfx@lists.freedesktop.org Cc: Zhu, James ; Koenig, Christian Subject: [PATCH v3 1/4] drm/amdgpu/vcn: fix race condition issue for vcn start

Re: [PATCH] drm/amdgpu: vcn_v2_5_mc_resume_dpg_mode() can be static

[AMD Public Use] sure Thanks & Best Regards! James Zhu From: Deucher, Alexander Sent: Wednesday, June 17, 2020 4:53 PM To: Zhu, James ; amd-gfx@lists.freedesktop.org Cc: kernel test robot Subject: Re: [PATCH] drm/amdgpu: vcn_v2_5_mc_resume_dpg_mode()

Re: [PATCH v2] drm/amdgpu: disable gfxoff if VCN is busy

[AMD Official Use Only - Internal Distribution Only] This patch is Reviewed-by: James Zhu From: Jiansong Chen Sent: Friday, October 30, 2020 11:05 AM To: amd-gfx@lists.freedesktop.org Cc: Zhang, Hawking ; Zhu, James ; Liu, Leo ; Zhou1, Tao ; Chen, Jiansong

Re: [PATCH] drm/amdgpu: enable VCN PG and CG for yellow carp

yuan ; Zhu, James ; Liu, Leo ; Liu, Aaron Subject: [PATCH] drm/amdgpu: enable VCN PG and CG for yellow carp Enable VCN 3.0 PG and CG for Yellow Carp by setting up flags. Signed-off-by: Aaron Liu --- drivers/gpu/drm/amd/amdgpu/nv.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-)

Re: [PATCH] drm/amdgpu/vcn3: drop extraneous Beige Goby hunk

[AMD Official Use Only] This patch is Reviewed-by: James Zhu Thanks & Best Regards! James Zhu From: amd-gfx on behalf of Alex Deucher Sent: Tuesday, June 15, 2021 5:32 PM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander Subject: [PATCH]

Re: [PATCH] drm/amdgpu/vcn: drop gfxoff control for VCN2+

[AMD Official Use Only] Reviewed-by: James Zhu Thanks & Best Regards! James Zhu From: amd-gfx on behalf of Christian König Sent: Tuesday, June 8, 2021 3:23 AM To: Zhang, Boyuan ; Deucher, Alexander ; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH]

Re: [PATCH v2 1/2] drm/amdgpu: enhance amdgpu_vcn_suspend

[AMD Official Use Only - Internal Distribution Only] save_bo needn't ungate vcn, it just keeps data in memory. Thanks & Best Regards! James Zhu From: Liu, Leo Sent: Monday, May 17, 2021 2:07 PM To: Zhu, James ; Zhu, James ; amd-gfx@lists.freedesktop

Re: [PATCH] drm/amdgpu: add missing cleanups for Polaris12 UVD/VCE on suspend

[AMD Official Use Only] Why not move changes into hw_fini? Best Regards! James Zhu From: amd-gfx on behalf of Evan Quan Sent: Wednesday, August 18, 2021 11:08 PM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Chen, Guchun ; Lazar, Lijo ;

Re: [PATCH 1/2] amdgpu/nv.c - Added video codec support for Yellow Carp

[AMD Official Use Only] Reviewed-by: James Zhu for the series James Zhu From: Gopalakrishnan, Veerabadhran (Veera) Sent: Tuesday, July 13, 2021 2:48 PM To: amd-gfx@lists.freedesktop.org Cc: Liu, Leo ; Zhu, James ; Zhang, Boyuan ; Rao, Srinath

Re: [PATCH 2/2] drm/amdgpu: Use mod_delayed_work in JPEG/UVD/VCE/VCN ring_end_use hooks

call at least. Thanks & Best Regards! James Zhu From: Koenig, Christian Sent: Wednesday, August 11, 2021 5:34 PM To: Michel Dänzer ; Deucher, Alexander Cc: Liu, Leo ; Zhu, James ; amd-gfx@lists.freedesktop.org ; dri-de...@lists.freedesktop.org Subject

Re: [PATCH 2/2] drm/amdgpu: Use mod_delayed_work in JPEG/UVD/VCE/VCN ring_end_use hooks

[AMD Official Use Only] I shouldn't say reduce one delay work call , For this case, Michael's proposal is closer to idle work design's purpose. Thanks & Best Regards! James Zhu From: amd-gfx on behalf of Zhu, James Sent: Wednesday, August 11, 2021

Re: [PATCH 2/2] drm/amdgpu: Use mod_delayed_work in JPEG/UVD/VCE/VCN ring_end_use hooks

[AMD Official Use Only] This patch is Reviewed-by: James Zhu Thanks & Best Regards! James Zhu From: Alex Deucher Sent: Wednesday, August 11, 2021 4:34 PM To: Michel Dänzer Cc: Deucher, Alexander ; Koenig, Christian ; Liu, Leo ; Zhu, James ; amd-gfx

Re: [PATCH 1/2] drm/amdkfd: fix boot failure when iommu is disabled in Picasso.

[AMD Official Use Only] From: Zhang, Yifan Sent: Monday, October 11, 2021 8:57 AM To: amd-gfx@lists.freedesktop.org Cc: Kuehling, Felix ; Zhu, James ; youling...@gmail.com ; Zhang, Yifan Subject: [PATCH 1/2] drm/amdkfd: fix boot failure when iommu

Re: [PATCH 1/2] drm/amdgpu/nbio7.4: don't use GPU_HDP_FLUSH bit 12

[AMD Official Use Only] Reviewed-by: James Zhu for the series. James Zhu From: amd-gfx on behalf of Alex Deucher Sent: Friday, October 8, 2021 12:10 PM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander Subject: [PATCH 1/2] drm/amdgpu/nbio7.4:

Re: [PATCH 1/2] drm/amdkfd: remove redundant iommu cleanup code

[AMD Official Use Only] Reviewed-by: James Zhu for the series James Zhu From: amd-gfx on behalf of Yifan Zhang Sent: Tuesday, September 28, 2021 4:28 AM To: amd-gfx@lists.freedesktop.org Cc: Kuehling, Felix ; Zhang, Yifan Subject: [PATCH 1/2]

Re: [PATCH 2/2] drm/amdgpu: init iommu after amdkfd device init

& Best Regards! James Zhu From: Kuehling, Felix Sent: Monday, October 4, 2021 11:00 AM To: Zhang, Yifan ; Zhu, James ; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH 2/2] drm/amdgpu: init iommu after amdkfd device init I'm trying to understand what the

Re: [PATCH 2/2] drm/amdgpu: init iommu after amdkfd device init

mber 28, 2021 11:41 AM To: Zhang, Yifan ; amd-gfx@lists.freedesktop.org ; Zhu, James Subject: Re: [PATCH 2/2] drm/amdgpu: init iommu after amdkfd device init [+James] This basically undoes James's change "drm/amdgpu: move iommu_resume before ip init/resume". I assume James made his chang

Re: [PATCH 1/2] Revert "drm/amdkfd: fix boot failure when iommu is disabled in Picasso."

[AMD Official Use Only] Hi Alex Sure, Let me check it can be merged into one patch. Thanks & Best Regards! James Zhu From: Alex Deucher Sent: Tuesday, November 2, 2021 4:34 PM To: Zhu, James Cc: amd-gfx list ; Deucher, Alexander ; Zhang, Yifan ;

Re: [PATCH] drm/amdgpu/vcn: improve vcn dpg stop procedure

[AMD Official Use Only] This patch is Reviewed-by: James Zhu From: Tianci Yin Sent: Wednesday, March 23, 2022 12:01 PM To: amd-gfx@lists.freedesktop.org Cc: Chen, Guchun ; Zhu, James ; Wang, Yu (Charlie) ; Yin, Tianci (Rico) Subject: [PATCH] drm/amdgpu/vcn

Re: [PATCH] drm/amd/vcn: fix an error msg on vcn 3.0

[AMD Official Use Only] This patch is Reviewed-by: James Zhu From: Tianci Yin Sent: Sunday, March 27, 2022 7:18 AM To: amd-gfx@lists.freedesktop.org Cc: Chen, Guchun ; Zhu, James ; Wang, Yu (Charlie) ; Yin, Tianci (Rico) Subject: [PATCH] drm/amd/vcn: fix

Re: [PATCH] drm/amdgpu: fix VCN 3.1.2 firmware name

[AMD Official Use Only] This patch is Reviewed-by: James Zhu From: amd-gfx on behalf of Alex Deucher Sent: Wednesday, April 6, 2022 2:41 PM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander Subject: [PATCH] drm/amdgpu: fix VCN 3.1.2 firmware name

Re: [PATCH] drm/amdxcp: fix amdxcp unloads incompletely

[AMD Official Use Only - General] ping ... Thanks & Best Regards! James Zhu From: Zhu, James Sent: Thursday, September 7, 2023 10:41 AM To: amd-gfx@lists.freedesktop.org Cc: Kamal, Asad ; Lin, Amber ; Zhu, James Subject: [PATCH] drm/amdxcp: fix am

Re: [PATCH v2] drm/amdgpu: limiting AV1 to first instance on VCN4 decode

[AMD Official Use Only - General] This patch is Reviewed-by: James Zhu From: amd-gfx on behalf of Sonny Jiang Sent: Wednesday, July 13, 2022 11:59 AM To: amd-gfx@lists.freedesktop.org Cc: Jiang, Sonny Subject: [PATCH v2] drm/amdgpu: limiting AV1 to first

Re: [PATCH 06/24] drm/amdkfd: add trace_id return

[AMD Official Use Only - General] On 2023-11-22 17:21, Felix Kuehling wrote: On 2023-11-03 09:11, James Zhu wrote: Add trace_id return for new pc sampling creation per device, Use IDR to quickly locate pc_sampling_entry for reference. Signed-off-by: James Zhu ---