Re: [PATCH 07/14] drm/amd/powerplay: remove enable_clock_power_gatings_tasks from initialize and resume events

For the series: Reviewed-by: Rex Zhu <rex@amd.com> Best Regards Rex From: amd-gfx <amd-gfx-boun...@lists.freedesktop.org> on behalf of Tom St Denis <tstdeni...@gmail.com> Sent: Thursday, July 28, 2016 10:19:05 PM To: amd-gfx@lists.

RE: [PATCH 2/2] drm/amd/powerplay: refine code to avoid potential bug that the memory not cleared.

+ clocks->count = mclk_table->count Missing semicolon. Will fix in V2. Best Regards Rex -Original Message- From: Rex Zhu [mailto:rex@amd.com] Sent: Monday, February 06, 2017 1:09 PM To: amd-gfx@lists.freedesktop.org Cc: Zhu, Rex Subject: [PATCH 2/2] drm/amd/pow

RE: [PATCH 4/4] drm/amdgpu: extend profiling mode.

Regards Rex -Original Message- From: Andy Furniss [mailto:adf.li...@gmail.com] Sent: Wednesday, February 01, 2017 11:37 PM To: Alex Deucher Cc: Zhu, Rex; amd-gfx list Subject: Re: [PATCH 4/4] drm/amdgpu: extend profiling mode. Alex Deucher wrote: > On Tue, Jan 31, 2017 at 6:19 PM, A

RE: [PATCH 04/21] drm/amdgpu:fix powerplay logic

Hi Monk, In static int pp_suspend(void *handle) { ret = pp_check(pp_handle); if (ret != 0) return ret; in suspend function, when dpm disabled/srv, also neet to return 0. Best Regards Rex -Original Message- From: amd-gfx

RE: [PATCH 4/4] drm/amdgpu: extend profiling mode.

Please see in line. Best Regards Rex -Original Message- From: Andy Furniss [mailto:adf.li...@gmail.com] Sent: Monday, February 06, 2017 8:32 PM To: Zhu, Rex; Alex Deucher Cc: amd-gfx list Subject: Re: [PATCH 4/4] drm/amdgpu: extend profiling mode. Zhu, Rex wrote: > Sorry for the l

Re: [PATCH 1/2] drm/amd/display: fix array lenth error.

10:54:24 PM To: Zhu, Rex; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH 1/2] drm/amd/display: fix array lenth error. On 2017-02-06 12:08 AM, Rex Zhu wrote: > Change-Id: I09011c5e6d5493db7e3d9a7ff7ab8c871a8db862 > Signed-off-by: Rex Zhu <rex@amd.com> > --- > drivers/g

Re: [PATCH 00/12] mise patch related uvd/vce cg and pg.

oun...@lists.freedesktop.org> on behalf of Christian König <deathsim...@vodafone.de> Sent: Friday, January 27, 2017 4:34 PM To: Zhu, Rex; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH 00/12] mise patch related uvd/vce cg and pg. I only skimmed over it, but what I saw looked mostl

RE: Bug (and probably, fix): UVD initialization / clock gating issue on kabini

we fixed this issue on Kv as uvd pg was enabled on APU. We need to change the uvd cg mode. When idle, use hw cg. And encode, use sw cg. So WREG32(mmUVD_CGC_GATE, 0); // ture off cg. Then uvd_v4_2_set_dcm(adev, true); // set sw cg. The first patch can fix this issue. The second dpm patch can

Re: [PATCH] drm/amd/powerplay: header should be defining _SMU7_CLOCK_POWER_GATING_H_

Thanks. Reviewed-by: Rex Zhu <rex@amd.com> Best Regards Rex From: Colin King <colin.k...@canonical.com> Sent: Wednesday, January 25, 2017 8:07 PM To: Deucher, Alexander; Koenig, Christian; David Airlie; Wang, Ken; Daenzer, Michel; Zhu,

Re: [PATCH 0/9] misc patches related to powerplay

___ From: Christian König <deathsim...@vodafone.de> Sent: Friday, September 9, 2016 10:23:26 PM To: Zhu, Rex; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH 0/9] misc patches related to powerplay Patch #1-#7 and #9 are Acked-by: Christian König <christian.koe...@amd.com>. Pa

Re: [PATCH 0/9] misc patches related to powerplay

Hi Christian, you are right, I missed mult-gpu case. i will refine related patches. Thanks. Best Regards Rex From: Christian König <deathsim...@vodafone.de> Sent: Saturday, September 10, 2016 1:51:30 AM To: Zhu, Rex; amd-gfx@lists.freedesktop.org S

RE: [PATCH v2 00/16] powerplay code refactoring.

Hi Christian, Thanks. I will refine those patches. Best Regards Rex -Original Message- From: Christian König [mailto:deathsim...@vodafone.de] Sent: Monday, September 12, 2016 6:52 PM To: Zhu, Rex; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH v2 00/16] powerplay code refactoring

Re: [PATCH] drm/amd/amdgpu: S3 resumed failed after 4-5 times loop

do we need to check those status(lmi status,firmware loaded, vce status and etc) when vce suspend? it is weird that we didn't implement vce suspend function as hw spec suggested. Best Regards Rex From: amd-gfx on

RE: [PATCH] drm/amdgpu: set bypass mode when uvd is idle.

: Friday, November 04, 2016 9:43 PM To: Zhu, Rex; amd-gfx@lists.freedesktop.org Subject: RE: [PATCH] drm/amdgpu: set bypass mode when uvd is idle. > -Original Message- > From: Zhu, Rex > Sent: Thursday, November 03, 2016 11:18 PM > To: Deucher, Alexander; amd-gfx@lists.freedesktop.o

RE: [PATCH] drm/amd/powerplay: don't give up if DPM is already running

not be initialized, so kernel panic when we visited those tables in set power state. I will send the fix patch for review tomorrow. Thanks. Best Regards Rex -Original Message- From: Grazvydas Ignotas [mailto:nota...@gmail.com] Sent: Sunday, October 16, 2016 2:55 AM To: Zhu, Rex Cc

RE: [PATCH] drm/amd/powerplay: don't give up if DPM is already running

Hi Gražvydas, In GPU passthrough case, I can't find better solution than yours from driver. So will apply your patch and just update reproduce step. Thanks. Best Regards Rex -Original Message- From: Zhu, Rex Sent: Wednesday, October 19, 2016 10:00 PM To: 'Grazvydas Ignotas' Cc: Alex

RE: [PATCH 1/8] drm/amdgpu: move dpm related definitions to amdgpu_dpm.h

Patch3-8 are Reviewed-by: Rex Zhu <rex@amd.com> Best Regards Rex -Original Message- From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf Of Christian König Sent: Thursday, October 13, 2016 3:15 PM To: Alex Deucher; amd-gfx@lists.freedesktop.org Cc: D

RE: [PATCH] drm/amd/powerplay: don't give up if DPM is already running

Hi Alex, Your new attached patch is Tested-by and Reviewed-by: Rex Zhu <rex@amd.com> Just one question, Do we need to set clock_gate for smu? Best Regards Rex -Original Message- From: Alex Deucher [mailto:alexdeuc...@gmail.com] Sent: Thursday, October 13, 2016 11:29 PM T

Re: [PATCH 1/7] drm/amdgpu: check min clock set by DAL before set ps.

Ok. i will add CI support in powerplay next week. Best Regards Rex From: Deucher, Alexander Sent: Friday, October 14, 2016 9:42:42 PM To: Zhu, Rex; amd-gfx@lists.freedesktop.org Cc: Zhu, Rex Subject: RE: [PATCH 1/7] drm/amdgpu: check min clock set by DAL before

RE: [PATCH] drm/amd/powerplay: fix issue dpm can't work on iceland.

Please review. Best Regards Rex -Original Message- From: Deucher, Alexander Sent: Friday, November 11, 2016 10:55 PM To: Zhu, Rex; amd-gfx@lists.freedesktop.org Cc: Zhu, Rex Subject: RE: [PATCH] drm/amd/powerplay: fix issue dpm can't work on iceland. > -Original Message- >

[PATCH 5/6] [V2]drm/amdgpu: disable dpm before turn off clock when vce idle.

Signed-off-by: Rex Zhu <rex@amd.com> --- drivers/gpu/drm/amd/amdgpu/ci_dpm.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/ci_dpm.c b/drivers/gpu/drm/amd/amdgpu/ci_dpm.c index 54a7019..8f6e7a0 100644 --- a/drivers/gpu/drm/amd/

RE: [PATCH 1/7] drm/amdgpu/powerplay: pp module only enable smu when dpm disabled.

rom: Grazvydas Ignotas [mailto:nota...@gmail.com] Sent: Wednesday, November 02, 2016 9:17 PM To: Zhu, Rex Cc: amd-gfx@lists.freedesktop.org Subject: Re: [PATCH 1/7] drm/amdgpu/powerplay: pp module only enable smu when dpm disabled. On Wed, Nov 2, 2016 at 12:27 PM, Rex Zhu <rex@amd.com> wrote:

RE: [PATCH 5/6] drm/amdgpu/powerplay: add an implementation for get_vce_clock_table

D by add a member in struct drm_amdgpu_info_vce_clock_table. Best Regards Rex -Original Message- From: Alex Deucher [mailto:alexdeuc...@gmail.com] Sent: Wednesday, October 12, 2016 4:07 AM To: amd-gfx list; Fang, Peter; Zhang, Boyuan; Zhu, Rex Cc: Deucher, Alexander Subject: Re: [PATCH 5/6

RE: [PATCH 5/6] drm/amdgpu/powerplay: add an implementation for get_vce_clock_table

return copy_to_user(out, _clk_table, + min((size_t)size, sizeof(vce_clk_table))) ? -EFAULT : 0; + } Best Regards Rex From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf Of Christian König Sent: Wednesday, October 12, 2016 4:53 PM

RE: [PATCH] drm/amd/powerplay: don't give up if DPM is already running

Hi Grazvydas and Alex, We needed to disable dpm when rmmod amdgpu for this issue. I am checking the function of disable dpm task. Best Regards Rex -Original Message- From: Alex Deucher [mailto:alexdeuc...@gmail.com] Sent: Wednesday, October 12, 2016 4:01 AM To: Grazvydas Ignotas; Zhu

RE: [PATCH] drm/amd/powerplay: don't give up if DPM is already running

Hi all, The attached patches were also for this issue. Disable dpm when rmmod amdgpu. Please help to review. Best Regards Rex -Original Message- From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf Of Zhu, Rex Sent: Wednesday, October 12, 2016 9:45 PM To: Alex

RE: [PATCH] drm/amdgpu: refine pg code for gfx_v8.

. Patch 0006 -0007: refine set clockgating code for tonga/polars. Best Regards Rex -Original Message- From: Deucher, Alexander Sent: Tuesday, December 06, 2016 5:07 AM To: Zhu, Rex; Alex Deucher; StDenis, Tom Cc: amd-gfx list Subject: RE: [PATCH] drm/amdgpu: refine pg code for gfx_v8

RE: [PATCH 6/6] drm/amd/powerplay: Fix potential NULL pointer issue

This patch is Reviewed-by: Rex Zhu <rex@amd.com> Best Regards Rex -Original Message- From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf Of Xiangliang Yu Sent: Wednesday, November 30, 2016 3:03 PM To: amd-gfx@lists.freedesktop.org Cc: Yu, Xiangliang S

RE: [PATCH] drm/amdgpu: show gfx clock gating status to user

/pg state. Best Regards Rex -Original Message- From: Huang Rui [mailto:ray.hu...@amd.com] Sent: Wednesday, January 04, 2017 10:22 AM To: Deucher, Alexander Cc: amd-gfx@lists.freedesktop.org; Zhu, Rex; Mao, David; Fu, Ping Subject: Re: [PATCH] drm/amdgpu: show gfx clock gating status

RE: [PATCH 4/4] drm/amd/powerplay: add profiling mode in dpm level

to:adf.li...@gmail.com] Sent: Monday, January 09, 2017 6:29 PM To: Zhu, Rex; Alex Deucher Cc: amd-gfx list Subject: Re: [PATCH 4/4] drm/amd/powerplay: add profiling mode in dpm level Hi, that change does fix it for me. The patch doesn't apply directly to drm-next-4.10-wip, here's what I tested - diff --git

RE: [PATCH 4/4] drm/amd/powerplay: add profiling mode in dpm level

Thanks Andy, The attached patch can fix this bug. Please review. Best Regards Rex -Original Message- From: Andy Furniss [mailto:adf.li...@gmail.com] Sent: Monday, January 09, 2017 4:18 AM To: Alex Deucher; Zhu, Rex Cc: amd-gfx list Subject: Re: [PATCH 4/4] drm/amd/powerplay: add

RE: [PATCH 1/4] drm/amd/powerplay: Configuring DIDT blocks only SQ enabled on Polaris11.

Hi Alex, >>> This will set the caps on Polaris10 as well? Intended? Rex: Yes, Currently, New didt messages were only supported on Polaris11. Best Regards Rex -Original Message- From: Deucher, Alexander Sent: Monday, January 09, 2017 10:12 PM To: Zhu, Rex

RE: [PATCH 3/3] drm/amdgpu: do not block gpu resume when cp ring test failed.

: Thursday, March 30, 2017 2:14 PM To: Zhu, Rex Cc: amd-gfx@lists.freedesktop.org Subject: Re: [PATCH 3/3] drm/amdgpu: do not block gpu resume when cp ring test failed. On 30/03/17 02:42 PM, Rex Zhu wrote: > As kiq enabled, ring test may randomly failed because of timing. > it was not c

Re: [PATCH] drm/amdgpu/gfx8: move MEC doorbell range setting

Patch was Tested-by and Reviewed-by: Rex Zhu <rex@amd.com> Best Regards Rex From: amd-gfx <amd-gfx-boun...@lists.freedesktop.org> on behalf of Alex Deucher <alexdeuc...@gmail.com> Sent: Tuesday, April 11, 2017 1:02:02 AM To: amd-gfx@lis

Re: [PATCH] drm/amdgpu/gfx8: set doorbell range for polaris as well

Patch was Tested-by and Reviewed-by: Rex Zhu <rex@amd.com> Best Regards Rex From: amd-gfx <amd-gfx-boun...@lists.freedesktop.org> on behalf of Alex Deucher <alexdeuc...@gmail.com> Sent: Tuesday, April 11, 2017 12:51

Re: [PATCH 12/12] drm/amdgpu/gfx9: Switch baremetal to use KIQ for compute ring management. (v3)

+static int gfx_v9_0_kiq_kcq_disable(struct amdgpu_device *adev) ... + DRM_ERROR("KCQ enable failed (scratch(0x%04X)=0x%08X)\n", should be disable here. Best Regards Rex From: amd-gfx on

Re: [PATCH] drm/amdgpu: Fix module unload hang by KIQ on Vega10

I think no need to check function type. Best Regards Rex From: amd-gfx on behalf of Deucher, Alexander Sent: Tuesday, April 18, 2017 9:33:58 PM To: Huang, Trigger; amd-gfx@lists.freedesktop.org

RE: [PATCH] drm/amd/powerplay: fixed wrong data type declaration for ppfeaturemask

Reviewed-by: Rex Zhu <rex@amd.com> Best Regards Rex -Original Message- From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf Of Evan Quan Sent: Thursday, July 06, 2017 10:02 AM To: amd-gfx@lists.freedesktop.org Cc: Quan, Evan Subject: [PATCH] drm/amd/pow

Re: [PATCH] drm/amd/powerplay: fix copy error in powerplay.

gt; Sent: Thursday, June 8, 2017 8:47:58 PM To: amd-gfx@lists.freedesktop.org Subject: Re: [PATCH] drm/amd/powerplay: fix copy error in powerplay. On 06/08/2017 02:50 AM, Rex Zhu wrote: > should disable led dpm feature when stop dpm. > > Change-Id: I9d78459ff2467d2eba0b26d9696138f7eba484a

Re: [PATCH] drm/amd/powerplay: fix a signedness bugs

Patches has been applied. Thanks. Best Regards Rex From: Huang, JinHuiEric Sent: Friday, May 19, 2017 12:28:09 AM To: Dan Carpenter; Deucher, Alexander; Zhu, Rex Cc: Koenig, Christian; David Airlie; Wang, Ken; Huang, Ray; amd-gfx@lists.freedesktop.org; dri

RE: [PATCH 4/4] drm/amd/powerplay/smu7: disable mclk switching for high refresh rates

We met similar issue on CI(SWDEV-103046). In high refresh rate, Dal need to notify powerpaly the min_mclk. Best Regards Rex -Original Message- From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf Of Alex Deucher Sent: Wednesday, May 24, 2017 5:27 AM To:

RE: [PATCH 3/4] drm/amd/powerplay/smu7: add vblank check for mclk switching (v2)

+ if (vblank_time_us < switch_limit_us) + return true; + else + return false; How about change the code to return vblank_time_us < switch_limit_us ? true : false; anyway, patch is reviewed-by: Rex Zhu <rex@amd.com> Best

Fw: [PATCH 5/5] drm/amd/powerplay: refine pwm1_enable callback functions on CI.

Change-Id: Ieb05cfa95e4072357e18f631ab71780de0688008 Signed-off-by: Rex Zhu <rex@amd.com> --- drivers/gpu/drm/amd/amdgpu/ci_dpm.c | 27 +++ 1 file changed, 15 insertions(+), 12 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/ci_dpm.c b/drivers/gpu/d

Fw: [PATCH 1/5] drm/amdgpu: add amd fan ctrl mode define.

Change-Id: Ida8f8168d9600503146b5140ea47c913733888cf Signed-off-by: Rex Zhu <rex@amd.com> --- drivers/gpu/drm/amd/include/amd_shared.h | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/gpu/drm/amd/include/amd_shared.h b/drivers/gpu/drm/amd/include/amd_shared.h index 2

Fw: [PATCH 4/5] drm/amd/powerplay: refine pwm1_enable callback functions on vi.

Signed-off-by: Rex Zhu <rex@amd.com> Change-Id: I72d61851630e5d4ff5b3236ca33abac6f5b200c6 --- drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c | 35 -- drivers/gpu/drm/amd/powerplay/hwmgr/smu7_thermal.c | 9 +++--- drivers/gpu/drm/amd/powerplay/hwmgr/smu7_the

Fw: [PATCH 3/5] drm/amd/powerplay: refine pwm1_enable callback functions on vega10.

Change-Id: Ib8681558cabab99da804d1d10987aca63435b1e5 Signed-off-by: Rex Zhu <rex@amd.com> --- drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c | 43 -- .../gpu/drm/amd/powerplay/hwmgr/vega10_thermal.h | 1 + 2 files changed, 25 insertions(+), 19 deletions(-)

Re: Regression: Crash/freeze when resuming from suspend or locked screen

Hi Martin, Can you try to reproduce this issue with amdgpu.dc=0 when modprobe amdgpu Best Regards Rex From: amd-gfx on behalf of Deucher, Alexander Sent: Tuesday, October 10, 2017 10:41:29 PM

Re: tonga mclk regression

Thanks Tom. The attached patch can fix this bug. Best Regards Rex From: StDenis, Tom Sent: Thursday, October 5, 2017 9:42 PM To: amd-gfx mailing list Cc: Zhu, Rex; Deucher, Alexander Subject: tonga mclk regression I've bisected it to this commit [root

RE: [PATCH 2/2] drm/amdgpu: allow GTT overcommit during bind

Patch is Tested-by: Rex Zhu <rex@amd.com> Best Regards Rex -Original Message- From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf Of Christian König Sent: Tuesday, October 17, 2017 4:28 PM To: Zhou, David(ChunMing); amd-gfx@lists.freedesktop.org Subje

RE: unclear code in vega10 pp

Yes. Best Regards Rex -Original Message- From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf Of Tom St Denis Sent: Wednesday, September 06, 2017 12:23 AM To: amd-gfx@lists.freedesktop.org Subject: Re: unclear code in vega10 pp After seeing this style a few other

RE: [PATCH] drm/amd/powerplay: Fix psm_set_user_performance_state()

Thanks Tom. Patch is Reviewed-By: Rex Zhu <rex@amd.com> Best Regards Rex -Original Message- From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf Of Tom St Denis Sent: Tuesday, September 05, 2017 8:03 PM To: amd-gfx@lists.freedesktop.org Cc: StDenis, Tom S

RE: powerplay change breaks driver

25/09/17 01:55 PM, Tom St Denis wrote: > This change > > commit f96306921d5e346ebc82c7c51ae6e0b736e5b425 > Author: Rex Zhu <rex@amd.com> > Date:   Wed Sep 20 14:44:55 2017 +0800 > >     drm/amd/powerplay: refine powerplay code. > >     delete struct

RE: [PATCH] drm/amd/powerplay: fix a warning in pp_hw_init

Hi Alex, Thanks for pointing out the logic error in pp_hw_init. Please review the attached patch. Best Regards Rex -Original Message- From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf Of Alex Deucher Sent: Saturday, September 30, 2017 12:38 AM To:

RE: [amd-staging-drm-next] regression - no fan info (sensors) on RX580

September 29, 2017 10:11 PM To: Dieter Nützel; Zhu, Rex Cc: amd-devel; DRI Devel; Wentland, Harry; Michel Dänzer Subject: Re: [amd-staging-drm-next] regression - no fan info (sensors) on RX580 Rex, probably related to the recent cleanups in powerplay. On Fri, Sep 29, 2017 at 10:09 AM, Dieter N

RE: some more powerplay/pwr virus size reduction patches

Hi Alex, We can use Polaris's PwrVirusTable on Fiji. So can remove fiji_pwrvirus.h Best Regards Rex -Original Message- From: Deucher, Alexander Sent: Friday, September 29, 2017 11:13 AM To: 'Dave Airlie'; amd-gfx mailing list; Alex Deucher; Zhu, Rex Subject: RE: some more powerplay

Recall: [PATCH] drm/amdgpu: correct reference clock value on vega10

Zhu, Rex would like to recall the message, "[PATCH] drm/amdgpu: correct reference clock value on vega10". ___ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx

RE: [PATCH] drm/amdgpu: correct reference clock value on vega10

Reviewed-by: Rex Zhu <rex@amd.com> Best Regards Rex -Original Message- From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf Of ken.w...@amd.com Sent: Friday, September 29, 2017 4:35 PM To: amd-gfx@lists.freedesktop.org Cc: Wang, Ken Subject: [PATCH] drm/

Re: [PATCH 4/4] drm/amd/powerplay: set uvd/vce/nb/mclk level as UMD P-state required

Hi Alex, 》BTW, can you review my stable p-state fix for CZ? 》https://patchwork.freedesktop.org/patch/174102 Patch is Reviewed-by: Rex Zhu <rex@amd.com> Best Regards Rex From: Deucher, Alexander Sent: Friday, September 1, 2017 11:03:10 PM To: Zhu, Re

Re: [PATCH] drm/amd/powerplay/hwmgr: Remove null check before kfree

Reviewed-by: Rex Zhu <rex@amd.com<mailto:rex@amd.com>> Best Regards Rex From: Wentland, Harry Sent: Tuesday, August 29, 2017 9:34:01 PM To: Himanshu Jha; airl...@linux.ie Cc: linux-ker...@vger.kernel.org; dri-de...@lists.freedesktop.o

RE: [PATCH] drm/amdgpu: fix rmmod KCQ disable failed error

Reviewed-by: Rex Zhu <rex@amd.com> Best Regards Rex -Original Message- From: Wang Hongcheng [mailto:annie.w...@amd.com] Sent: Friday, November 17, 2017 2:24 PM To: amd-gfx@lists.freedesktop.org Cc: Zhu, Rex; Wang, Annie Subject: [PATCH] drm/amdgpu: fix rmmod KCQ disable failed

RE: [PATCH] drm/amd/powerplay: fix memory leak of hardcoded pptable

Reviewed-by: Rex Zhu <rex@amd.com> Best Regards Rex -Original Message- From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf Of Eric Huang Sent: Wednesday, November 01, 2017 5:40 AM To: amd-gfx@lists.freedesktop.org Cc: Huang, JinHuiEric Subject: [PATCH] d

Re: [PATCH] drm/amd/pp: Fix uninitialized variable

Applied. Thanks. Best Regards Rex From: rajan.v...@gmail.com Sent: Monday, June 18, 2018 3:31 PM To: Deucher, Alexander; Koenig, Christian; Zhou, David(ChunMing); Zhu, Rex; StDenis, Tom Cc: amd-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org

Re: [PATCH] drm/amdgpu: Partially revert commit 2dc80b006

_ From: jv...@scarletmail.rutgers.edu on behalf of Jan Vesely Sent: Wednesday, June 13, 2018 9:30 PM To: Koenig, Christian Cc: Zhu, Rex; amd-gfx list Subject: Re: [PATCH] drm/amdgpu: Partially revert commit 2dc80b006 Hi, can you please improve the commit message? seeing "Revert $HAS

Re: [PATCH 4/7] drm/amd/pp: Add gfx pg support in smu through set_powergating_by_smu

C, 0); Move this change to patch3. From: amd-gfx on behalf of Rex Zhu Sent: Wednesday, June 13, 2018 7:18 PM To: amd-gfx@lists.freedesktop.org Cc: Zhu, Rex Subject: [PATCH 4/7] drm/amd/pp: Add gfx pg support in smu through set_powergating_by_smu gfx ip bl

Re: [PATCH] drm/amd/powerplay: Set higher SCLK frequency than dpm7 in OD

Acked-by: Rex Zhu Best Regards Rex From: amd-gfx on behalf of Kenneth Feng Sent: Tuesday, June 12, 2018 10:54 PM To: amd-gfx@lists.freedesktop.org Cc: Feng, Kenneth Subject: [PATCH] drm/amd/powerplay: Set higher SCLK frequency than dpm7 in OD Fix the issue

Re: [PATCH 10/13] drm/amd/powerplay: apply clocks adjust rules on power state change

Hi Evan, did we need to check the following flags on vega12?will driver set those flags when user select the umd_pstate? PHM_PlatformCaps_UMDPState/PHM_PlatformCaps_PState. Best Regards Rex ?? Outlook for Android From: amd-gfx on

Re: [PATCH] drm/amdgpu/display: check if ppfuncs exists before using it

Reviewed-by: Rex Zhu Best Regards Rex From: amd-gfx on behalf of Alex Deucher Sent: Wednesday, May 30, 2018 10:37 PM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander Subject: [PATCH] drm/amdgpu/display: check if ppfuncs exists before using it Fixes

Re: [PATCH] drm/amdgpu/pp: switch the default dpm implementation for CI

Reviewed-by: Rex Zhu Best Regards Rex From: amd-gfx on behalf of Alex Deucher Sent: Friday, June 1, 2018 1:48 AM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander Subject: [PATCH] drm/amdgpu/pp: switch the default dpm implementation for CI Switch

Re: [PATCH 2/2] drm/amdgpu: Make gfx_off control by GFX ip

ock first. Currently, it is not a big deal, because SMU don't support CG/PG on all legacy asics. Best Regards Rex From: Huang Rui Sent: Wednesday, June 6, 2018 10:33 AM To: Zhu, Rex Cc: amd-gfx@lists.freedesktop.org Subject: Re: [PATCH 2/2] drm/amdgpu: Make gfx

Re: [PATCH] drm/amd/powerplay: fix wrong clock adjust sequence

Reviewed-by: Rex Zhu Best Regards Rex From: amd-gfx on behalf of Evan Quan Sent: Wednesday, June 6, 2018 1:54 PM To: amd-gfx@lists.freedesktop.org Cc: Quan, Evan; Zhu, Rex Subject: [PATCH] drm/amd/powerplay: fix wrong clock adjust sequence The clocks

Re: [PATCH 1/2] drm/amdgpu: Add module parameter stutter_mode

i36> From: amd-gfx on behalf of Michel Dänzer Sent: Tuesday, June 26, 2018 6:38:14 PM To: Zhu, Rex Cc: Zhu, Rex; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH 1/2] drm/amdgpu: Add module parameter stutter_mode On 2018-06-26 12:23 PM, rex zhu wrote: >

Re: [PATCH 2/2] drm/amd/pp: Add stable Pstate clk display support in debugfs

Ok. Thanks. I will query twice.one for pstate sclk and one for mclk. Best Regards Rex From: Deucher, Alexander Sent: Friday, January 5, 2018 11:44:00 PM To: Zhu, Rex; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH 2/2] drm/amd/pp: Add stable Pstate clk display

RE: [PATCH v2] drm/amd/pp: Implement get_max_high_clocks for CI/VI

l Message- From: Alex Deucher [mailto:alexdeuc...@gmail.com] Sent: Thursday, January 04, 2018 2:58 PM To: Zhu, Rex Cc: amd-gfx list Subject: Re: [PATCH v2] drm/amd/pp: Implement get_max_high_clocks for CI/VI On Thu, Jan 4, 2018 at 1:01 AM, Rex Zhu <rex@amd.com> wrote: > v2: add

Re: [PATCH 1/2] drm/amdgpu: add custom power policy support in sysfs

Yes, this new interface is more common, I just save the input and send to hw backend. Smu7 and Vega can share this interface. Best Regards Rex From: Alex Deucher <alexdeuc...@gmail.com> Sent: Thursday, January 11, 2018 4:18:11 AM To: Zhu, Rex Cc: amd-gf

RE: [amd-staging-drm-next]: amdgpu: [powerplay] pp_get_power_profile_mode was not implemented.

Yes, I just implemented this callback function on Vega10. Best Regards Rex -Original Message- From: Dieter Nützel [mailto:die...@nuetzel-hh.de] Sent: Friday, January 19, 2018 4:23 PM To: Zhu, Rex Cc: amd-devel Subject: [amd-staging-drm-next]: amdgpu: [powerplay

RE: [PATCH] drm/amdgpu/powerplay/vega10: fix compute profile name

Thanks, Alex. Reviewed-by: Rex Zhu <rex@amd.com> Best Regards Rex -Original Message- From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf Of Alex Deucher Sent: Saturday, January 20, 2018 1:14 AM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander S

Re: [PATCH 4/4] drm/amd/pp: Implement set_power_profile_mode on smu7

> "5 * * * * * * * *" mean "CUSTOM enable_sclk SCLK_UP_HYST > SCLK_DOWN_HYST SCLK_ACTIVE_LEVEL enable_mclk MCLK_UP_HYST > MCLK_DOWN_HYST MCLK_ACTIVE_LEVEL" > > Change-Id: Ic6d6f37363bc81ab17051285f6ace847edf725de > Signed-off-by: Rex Zhu <rex@amd.com> > --

Re: [PATCH 4/4] drm/amd/pp: Implement set_power_profile_mode on smu7

Yes. Best Regards Rex From: Huang, JinHuiEric Sent: Thursday, January 25, 2018 4:47:23 AM To: Zhu, Rex; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH 4/4] drm/amd/pp: Implement set_power_profile_mode on smu7 Hi Rex, So you intend to separate previous one

Re: [PATCH 4/4] drm/amd/pp: Implement set_power_profile_mode on smu7

. Best Regards Rex From: Kuehling, Felix Sent: Thursday, January 25, 2018 5:41:43 AM To: Zhu, Rex; Huang, JinHuiEric; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH 4/4] drm/amd/pp: Implement set_power_profile_mode on smu7 Hi Rex, As I understand it (the way

Re: [PATCH 1/2] drm/amd/pp: Remove manual mode for power_dpm_force_performance_level

t: Friday, January 26, 2018 8:26 AM To: Zhu, Rex; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH 1/2] drm/amd/pp: Remove manual mode for power_dpm_force_performance_level On 2018-01-25 07:07 PM, Zhu, Rex wrote: > I also think about this problem. > just think user should unforced clk level

Re: [PATCH 1/2] drm/amd/pp: Remove manual mode for power_dpm_force_performance_level

driver still can set min sclk/mclk. Best Regards Rex From: Kuehling, Felix Sent: Saturday, January 27, 2018 12:49 AM To: Zhu, Rex; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH 1/2] drm/amd/pp: Remove manual mode for power_dpm_force_performance_level Hi Rex

RE: [PATCH 1/8] drm/amd/pp: Add a new pp feature mask bit for OD feature

-Original Message- From: Grazvydas Ignotas [mailto:nota...@gmail.com] Sent: Wednesday, January 17, 2018 1:53 AM To: Zhu, Rex Cc: amd-gfx@lists.freedesktop.org Subject: Re: [PATCH 1/8] drm/amd/pp: Add a new pp feature mask bit for OD feature On Tue, Jan 16, 2018 at 2:02 PM, Rex Zhu <

RE: [PATCH 2/3] drm/amd/pp: Add stable Pstate clk display when print_clock_levels

Ok, I will drop this patch. and please review the new attached patch expose stable pstate clock by ioctl. Best Regards Rex -Original Message- From: Alex Deucher [mailto:alexdeuc...@gmail.com] Sent: Wednesday, January 17, 2018 12:03 AM To: Zhu, Rex Cc: amd-gfx list Subject: Re: [PATCH 2

RE: [PATCH 1/8] drm/amd/pp: Add a new pp feature mask bit for OD feature

2 AM To: Zhu, Rex Cc: amd-gfx list Subject: Re: [PATCH 1/8] drm/amd/pp: Add a new pp feature mask bit for OD feature On Tue, Jan 16, 2018 at 7:02 AM, Rex Zhu <rex@amd.com> wrote: > when this bit was set on module load, > driver will allow the user over/under gpu clock and

RE: [PATCH 1/2] drm/amdgpu: add custom power policy support in sysfs

Sure. We should add the PP_SMC_POWER_PROFILE_AUTO in PP_SMC_POWER_PROFILE. And will be implemented as auto wattman feature. Best Regards Rex -Original Message- From: Alex Deucher [mailto:alexdeuc...@gmail.com] Sent: Tuesday, January 16, 2018 11:59 PM To: Zhu, Rex Cc: amd-gfx list Subject

RE: [PATCH] drm/amd/powerplay: Fix smu_table_entry.handle type

Reviewed-by: Rex Zhu <rex@amd.com> Best Regards Rex From: Deucher, Alexander Sent: Thursday, January 18, 2018 7:11 AM To: Grodzovsky, Andrey; amd-gfx@lists.freedesktop.org Cc: Lipski, Mikita; Zhu, Rex Subject: Re: [PATCH] drm/amd/powerplay: Fix smu_table_entry.handle type Reviewed-by

Re: [PATCH 6/6] drm/amdgpu/pm: rework the hwmon visibility settings

Series is Reviewed-by: Rex Zhu <rex@amd.com> Best Regards Rex From: amd-gfx <amd-gfx-boun...@lists.freedesktop.org> on behalf of Alex Deucher <alexdeuc...@gmail.com> Sent: Thursday, January 25, 2018 7:55 AM To: amd-gfx@lists.freedeskt

Re: [PATCH 4/4] drm/amd/pp: Implement set_power_profile_mode on smu7

tools. Best Regards Rex From: amd-gfx <amd-gfx-boun...@lists.freedesktop.org> on behalf of Felix Kuehling <felix.kuehl...@amd.com> Sent: Thursday, January 25, 2018 7:12 AM To: Zhu, Rex; Huang, JinHuiEric; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH 4/4] drm/amd/pp: Impl

Re: [PATCH 1/4] drm/amd/pp: Add new smu callback function

m settings > > Change-Id: Idc0362c219d84564693ca90adf9299e56cfeb6a4 > Signed-off-by: Rex Zhu <rex@amd.com> > --- > drivers/gpu/drm/amd/powerplay/inc/hwmgr.h | 1 + > drivers/gpu/drm/amd/powerplay/inc/smumgr.h| 1 + > drivers/gpu/drm/amd/powerplay/smumgr/smumgr.c | 8 &

Re: [PATCH 1/2] drm/amd/pp: Remove manual mode for power_dpm_force_performance_level

From: Kuehling, Felix Sent: Friday, January 26, 2018 12:55:19 AM To: amd-gfx@lists.freedesktop.org; Zhu, Rex Subject: Re: [PATCH 1/2] drm/amd/pp: Remove manual mode for power_dpm_force_performance_level This patch breaks unforcing of clocks, which is currently done

RE: [PATCH 4/4] drm/amd/pp: Implement set_power_profile_mode on smu7

oblem maybe we should not name new sysfs as "power_profile_mode ". It is easy to add min sclk/mclk in the new sysfs, I just think it repeated with other sysfs. Best Regards Rex -Original Message- From: Alex Deucher [mailto:alexdeuc...@gmail.com] Sent: Thursd

RE: [PATCH 4/4] drm/amd/pp: Implement set_power_profile_mode on smu7

. Thanks. Best Regards Rex -Original Message- From: Kuehling, Felix Sent: Thursday, January 25, 2018 12:16 PM To: Zhu, Rex; Huang, JinHuiEric; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH 4/4] drm/amd/pp: Implement set_power_profile_mode on smu7 On 2018-01-24 09:28 PM, Zhu, Rex wro

Re: [PATCH 1/2] drm/amd/pp: Remove manual mode for power_dpm_force_performance_level

ing, Felix Sent: Saturday, January 27, 2018 3:32 AM To: Zhu, Rex; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH 1/2] drm/amd/pp: Remove manual mode for power_dpm_force_performance_level On 2018-01-26 02:20 PM, Zhu, Rex wrote: > > >1. You're breaking the semantics of the existi

Re: [PATCH 1/2] drm/amd/pp: Remove manual mode for power_dpm_force_performance_level

Hi Alex, It's Ok, I got it. Thanks. Best Regards Rex From: Alex Deucher <alexdeuc...@gmail.com> Sent: Tuesday, January 30, 2018 6:26 AM To: Zhu, Rex Cc: Kuehling, Felix; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH 1/2] drm/amd/pp: Remove manua

Re: [PATCH 1/2] drm/amd/pp: Remove manual mode for power_dpm_force_performance_level

we just unfore the clock range in the auto state. Anyway, I will drop this patch. Best Regards Rex From: Alex Deucher <alexdeuc...@gmail.com> Sent: Tuesday, January 30, 2018 2:02 AM To: Zhu, Rex Cc: Kuehling, Felix; amd-gfx@lists.freedesktop.org Subjec

Re: [PATCH 2/2] drm/amdgpu/pm: get/set dgpu power cap via hwmon API

>Isn't the power limit only multiplied by 256 on smu7? Yes，I will fix it and convert the output to mw. Best Regards Rex From: Alex Deucher <alexdeuc...@gmail.com> Sent: Tuesday, January 30, 2018 4:00 AM To: Zhu, Rex Cc: amd-gfx list Subject: Re: [PATCH

RE: [PATCH 1/2] drm/amd/pp: Remove manual mode for power_dpm_force_performance_level

ve one less command need to input if they want to use pp_dpm_sclk/mclk/pcie. Best Regards Rex -Original Message- From: Alex Deucher [mailto:alexdeuc...@gmail.com] Sent: Saturday, January 27, 2018 7:51 AM To: Zhu, Rex Cc: Kuehling, Felix; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH 1/

RE: MCLK defaults high on second card

Hi Tom, The attached patch should be able to fix this issue. Best Regards Rex -Original Message- From: StDenis, Tom Sent: Friday, February 02, 2018 2:58 AM To: Deucher, Alexander; amd-gfx mailing list Cc: Zhu, Rex; Lazare, Jordan; Wentland, Harry Subject: Re: MCLK defaults high

Re: [PATCH 10/10] drm/amd/pp: Enable auto automan feature on Polaris

From: Alex Deucher <alexdeuc...@gmail.com> Sent: Thursday, February 8, 2018 11:28 PM To: Zhu, Rex Cc: amd-gfx list Subject: Re: [PATCH 10/10] drm/amd/pp: Enable auto automan feature on Polaris On Thu, Feb 8, 2018 at 10:14 AM, Zhu, Rex <rex@amd.com> wro

Re: [PATCH 10/10] drm/amd/pp: Enable auto automan feature on Polaris

Best Regards Rex From: amd-gfx <amd-gfx-boun...@lists.freedesktop.org> on behalf of Eric Huang <jinhuieric.hu...@amd.com> Sent: Friday, February 9, 2018 12:47 AM To: amd-gfx@lists.freedesktop.org Subject: Re: [PATCH 10/10] drm/amd/pp: Enable auto automan feature on Polaris On 2018-

  1   2   3   >