Re: [PATCH] drm/amdgpu: potential shift wrapping bug

Am 10.08.2017 15:02, schrieb Christian König: > Am 10.08.2017 um 14:53 schrieb Dan Carpenter: >> On Thu, Aug 10, 2017 at 02:30:15PM +0200, Christian König wrote: >>> Am 10.08.2017 um 14:16 schrieb Dan Carpenter: "frag_align" is a u64, so presumably we want to use the high bits as well

Re: [PATCH] drm/amd/powerplay: ensure loop does not wraparound on decrement

Am 17.05.2017 20:13, schrieb Colin King: > From: Colin Ian King > > The current for loop decrements i when it is zero and this causes > a wrap-around back to ~0 because i is unsigned. In the unlikely event > that mask is 0, the loop will run forever. Fix this so we

Re: [PATCH] drm/amd/display: indent an if statement

Am 04.11.2017 07:12, schrieb Dan Carpenter: > The if statement wasn't indented so it makes static analysis tools and > probably very recent GCC versions complain. > > Signed-off-by: Dan Carpenter > --- > I went over 80 characters because other lines do already and it

Re: [PATCH][next] drm/amdgpu/psp: fix incorrect logic when checking asic_type

Am 04.07.2019 16:23, schrieb Colin King: > From: Colin Ian King > > Currently the check of the asic_type is always returning true because > of the use of ||. Fix this by using && instead. Also break overly > wide line. > > Addresses-Coverity: ("Constant expression result") > Fixes:

Re: [PATCH][drm-next] drm/amd/powerplay: fix a few spelling mistakes

Am 01.08.2019 10:39, schrieb Colin King: > From: Colin Ian King > > There are a few spelling mistakes "unknow" -> "unknown" and > "enabeld" -> "enabled". Fix these. > > Signed-off-by: Colin Ian King > --- > drivers/gpu/drm/amd/powerplay/amdgpu_smu.c | 6 +++--- > 1 file changed, 3

Re: [PATCH][next] drm/amd/display: fix for-loop with incorrectly sized loop counter

Am 17.01.2020 14:33, schrieb Colin King: > From: Colin Ian King > > A for-loop is iterating from 0 up to 1000 however the loop variable count > is a u8 and hence not large enough. Fix this by making count an int. > Also remove the redundant initialization of count since this is never used >

AW: [PATCH] drm/amdgpu/display: Fix an error handling path in 'dm_update_crtc_state()'

Von: kernel-janitors-ow...@vger.kernel.org im Auftrag von Christophe JAILLET Gesendet: Sonntag, 8. März 2020 10:26 An: harry.wentl...@amd.com; sunpeng...@amd.com; alexander.deuc...@amd.com; christian.koe...@amd.com; david1.z...@amd.com;

AW: [PATCH] drm/amdgpu: fix potential integer overflow on shift of a int

i am curious: what is the win to have a unsigned 64 bit integer in the first place ? re, wh Von: Christian König Gesendet: Montag, 8. Februar 2021 10:17:42 An: Colin King; Alex Deucher; David Airlie; Daniel Vetter; Huang Rui; Junwei Zhang;

AW: [PATCH] drm/amdgpu: fix potential integer overflow on shift of a int

thx for info Von: Christian König Gesendet: Montag, 8. Februar 2021 13:14:49 An: Walter Harms; Colin King; Alex Deucher; David Airlie; Daniel Vetter; Huang Rui; Junwei Zhang; amd-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org Cc: kernel-janit