On 2019/12/11 上午6:08, Alex Deucher wrote:
Add a safety check to runtime suspend to make sure all outstanding
fences have signaled before we suspend. Doesn't fix any known issue.
We already do this via the fence driver suspend function, but we
just force completion rather than bailing. This ba
On 2018年09月17日 16:37, Christian König wrote:
Am 14.09.2018 um 12:37 schrieb Chunming Zhou:
This patch is for VK_KHR_timeline_semaphore extension, semaphore is
called syncobj in kernel side:
This extension introduces a new type of syncobj that has an integer
payload
identifying a point in a t
On 2018年09月18日 16:32, Christian König wrote:
+ for (i = 0; i < args->count_handles; i++) {
+ if (syncobjs[i]->type == DRM_SYNCOBJ_TYPE_TIMELINE) {
+ DRM_ERROR("timeline syncobj cannot reset!\n");
Why not? I mean that should still work or do I miss anything?
timeline semap
On 2018年09月19日 15:18, Christian König wrote:
Am 19.09.2018 um 06:26 schrieb Chunming Zhou:
[snip]
*fence = NULL;
drm_syncobj_add_callback_locked(syncobj, cb, func);
@@ -164,6 +177,153 @@ void drm_syncobj_remove_callback(struct
drm_syncobj *syncobj,
spin_unlock(&syn
On 2018年09月19日 15:18, Christian König wrote:
Am 19.09.2018 um 06:26 schrieb Chunming Zhou:
[snip]
*fence = NULL;
drm_syncobj_add_callback_locked(syncobj, cb, func);
@@ -164,6 +177,153 @@ void drm_syncobj_remove_callback(struct
drm_syncobj *syncobj,
spin_unlock(&syn
...@lists.freedesktop.org
Cc: Dave Airlie ; Rakos, Daniel
; Daniel Vetter ; amd-
g...@lists.freedesktop.org
Subject: Re: [PATCH 1/4] [RFC]drm: add syncobj timeline support v6
Am 19.09.2018 um 09:32 schrieb zhoucm1:
On 2018年09月19日 15:18, Christian König wrote:
Am 19.09.2018 um 06:26 schrieb Chunming Zhou:
[snip
On 2018年10月16日 20:54, Christian König wrote:
I've added my rb to patch #1 and pushed it to drm-misc-next.
I would really like to get an rb from other people on patch #2 before
proceeding.
Daniel, Dave and all the other usual suspects on the list what is your
opinion on this implementation?
On 2018年10月17日 16:09, Daniel Vetter wrote:
On Mon, Oct 15, 2018 at 04:55:48PM +0800, Chunming Zhou wrote:
This patch is for VK_KHR_timeline_semaphore extension, semaphore is called
syncobj in kernel side:
This extension introduces a new type of syncobj that has an integer payload
identifying
+Jason as well.
On 2018年10月17日 18:22, Daniel Vetter wrote:
On Wed, Oct 17, 2018 at 11:17 AM zhoucm1 wrote:
On 2018年10月17日 16:09, Daniel Vetter wrote:
On Mon, Oct 15, 2018 at 04:55:48PM +0800, Chunming Zhou wrote:
This patch is for VK_KHR_timeline_semaphore extension, semaphore is called
On 2018年10月17日 18:24, Daniel Vetter wrote:
On Wed, Oct 17, 2018 at 11:29 AM Koenig, Christian
wrote:
Am 17.10.18 um 11:17 schrieb zhoucm1:
[SNIP]
+struct drm_syncobj_signal_pt {
+struct dma_fence_array *base;
Out of curiosity, why the pointer and not embedding? base is kinda
On 2018年10月18日 20:31, Christian König wrote:
We should not remove mappings in rbtree_postorder_for_each_entry_safe
because that rebalances the tree.
Signed-off-by: Christian König
---
drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/drm/
On 2018年10月18日 19:50, Christian König wrote:
Am 18.10.18 um 05:11 schrieb zhoucm1:
On 2018年10月17日 18:24, Daniel Vetter wrote:
On Wed, Oct 17, 2018 at 11:29 AM Koenig, Christian
wrote:
Am 17.10.18 um 11:17 schrieb zhoucm1:
[SNIP]
+struct drm_syncobj_signal_pt {
+ struct
On 2018年10月19日 16:55, Daniel Vetter wrote:
On Fri, Oct 19, 2018 at 10:29:55AM +0800, zhoucm1 wrote:
On 2018年10月18日 19:50, Christian König wrote:
Am 18.10.18 um 05:11 schrieb zhoucm1:
On 2018年10月17日 18:24, Daniel Vetter wrote:
On Wed, Oct 17, 2018 at 11:29 AM Koenig, Christian
wrote:
Am
On 2018年10月19日 17:20, zhoucm1 wrote:
On 2018年10月19日 16:55, Daniel Vetter wrote:
On Fri, Oct 19, 2018 at 10:29:55AM +0800, zhoucm1 wrote:
On 2018年10月18日 19:50, Christian König wrote:
Am 18.10.18 um 05:11 schrieb zhoucm1:
On 2018年10月17日 18:24, Daniel Vetter wrote:
On Wed, Oct 17, 2018
[snip]
Went boom:
https://bugs.freedesktop.org/show_bug.cgi?id=108490
Can we revert pls?
Sorry for bug, please.
In fact, the bug is already caught and fixed, just the fix part isn't
in patch#1, but in patch#2:
Have you reverted? If not, I can send that fix in one minute.
Regards,
David Z
On 2018年10月26日 16:32, Daniel Vetter wrote:
On Fri, Oct 26, 2018 at 5:50 AM Zhou, David(ChunMing)
wrote:
Make igt for cross-driver, I think you should rename it first, not an intel
specific. NO company wants their employee working on other company stuff.
You can rename it to DGT(drm graphics
On 2018年11月22日 14:56, Sharma, Deepak wrote:
when returned fence is not valid mostly due to userspace ignored
previous error causes NULL pointer dereference.
Signed-off-by: Deepak Sharma
Reviewed-by: Chunming Zhou
---
drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 2 ++
1 file changed, 2 inse
Yeah, you need another drm patch as well when you apply my patch. Attached.
-David
On 2018年11月27日 08:40, Sharma, Deepak wrote:
On 11/26/18 1:57 AM, Zhou, David(ChunMing) wrote:
-Original Message-
From: Christian König
Sent: Monday, November 26, 2018 5:23 PM
To: Sharma, Deepak ; Zh
On 2018年11月28日 22:50, Christian König wrote:
For a lot of use cases we need 64bit sequence numbers. Currently drivers
overload the dma_fence structure to store the additional bits.
Stop doing that and make the sequence number in the dma_fence always
64bit.
For compatibility with hardware whic
On 2018年11月28日 22:50, Christian König wrote:
From: Chunming Zhou
v2: drop export/import
Signed-off-by: Chunming Zhou
---
xf86drm.c | 44
xf86drm.h | 8
2 files changed, 52 insertions(+)
diff --git a/xf86drm.c b/xf86drm.c
index 71ad
Looks very very good, and I applied them in my local, and tested by
./amdgpu_test -s 9 and synobj_basic/wait of IGT today.
+Daniel, Chris, Eric, Could you also have a look as well?
-David
On 2018年11月28日 22:50, Christian König wrote:
Tested this patch set more extensively in the last two we
On 2018年11月28日 22:50, Christian König wrote:
From: Chunming Zhou
v2: symbos are stored in lexical order.
v3: drop export/import and extra query indirection
Signed-off-by: Chunming Zhou
Signed-off-by: Christian König
---
amdgpu/amdgpu-symbol-check | 2 ++
amdgpu/amdgpu.h| 39
Could you move this one to dma-fence as you said? Which will be used in
other place as well.
-David
On 2018年11月28日 22:50, Christian König wrote:
Extract of useful code from the timeline work. Let's use just a single
stub fence instance instead of allocating a new one all the time.
Signed-off
On 2018年11月28日 22:50, Christian König wrote:
Lockless container implementation similar to a dma_fence_array, but with
only two elements per node and automatic garbage collection.
v2: properly document dma_fence_chain_for_each, add dma_fence_chain_find_seqno,
drop prev reference during gar
On 2018年12月04日 14:39, Wei Yongjun wrote:
Fix the return value check which testing the wrong variable
in amdgpu_allocate_static_csa().
Fixes: 7946340fa389 ("drm/amdgpu: Move csa related code to separate file")
Signed-off-by: Wei Yongjun
---
drivers/gpu/drm/amd/amdgpu/amdgpu_csa.c | 2 +-
1
need dummy page for that?
-David
On 2019年01月03日 17:01, Christian König wrote:
NAK, the problem is not the interrupt.
E.g. causing faults by accessing unmapped pages with the SDMA can
still crash the MC.
The key point is that SDMA can't work with PRT tiles on pre-gmc9 and
we need to forbi
On 2019年01月11日 21:15, Christian König wrote:
Move the BO on the LRU only when it is actually moved by a DMA
operation.
Signed-off-by: Christian König
Tested-And-Reviewed-by: Chunming Zhou
I just sent lru_notify v2 patches, please review them. With yours and
mine, the OOM issue is fixed w
On 2019年02月17日 03:22, Christian König wrote:
Am 15.02.19 um 20:31 schrieb Lionel Landwerlin via amd-gfx:
On 07/12/2018 09:55, Chunming Zhou wrote:
user mode can query timeline payload.
v2: check return value of copy_to_user
v3: handle querying entry by entry
v4: rebase on new chain container,
Hi Lionel,
I checked your igt test case,
uint64_t points[5] = { 1, 5, 3, 7, 6 };
which is illegal signal order.
I must admit we should handle it gracefully if signal isn't in-order,
and we shouldn't lead to deadlock.
Hi Christian,
Can we just ignore when signal point X <= timeline Y? Or ju
Hi Lionel,
the attached should fix your problem and also messed signal order.
Hi Christian,
Could you have a look if it's reasonable?
btw: I pushed to change to
https://github.com/amingriyue/timeline-syncobj-kernel, which is already
rebased to latest drm-misc(kernel 5.0). You can directly u
bmitted work to the hardware. And just dropping the fence
like you do in the patch is a clearly no-go as well.
Then do you have any idea to skip the messed order signal point?
-David
Regards,
Christian.
Am 19.02.19 um 11:46 schrieb zhoucm1:
Hi Lionel,
the attached should fix your problem
On 2019年02月20日 15:59, Koenig, Christian wrote:
Am 20.02.19 um 05:53 schrieb zhoucm1:
On 2019年02月19日 19:32, Koenig, Christian wrote:
Hi David,
Could you have a look if it's reasonable?
Patch #1 is also something I already fixed on my local branch.
But patch #2 won't work
On 2019年03月07日 17:55, Michel Dänzer wrote:
On 2019-03-07 10:15 a.m., Chunming Zhou wrote:
Signed-off-by: Chunming Zhou
Please provide corresponding UMD patches showing how this is to be used.
spec is here:
https://www.khronos.org/registry/vulkan/specs/1.1-extensions/html/vkspec.html,
pleas
On 2019年03月19日 19:54, Lionel Landwerlin wrote:
On 15/03/2019 12:09, Chunming Zhou wrote:
v2: individually allocate chain array, since chain node is free
independently.
v3: all existing points must be already signaled before cpu perform
signal operation,
so add check condition for that.
patch#2 and patch#4 are Ached-by: Chunming Zhou
patch#1, #3, #5~#8 are Reviewed-by: Chunming Zhou
On 2019年03月19日 20:44, Christian König wrote:
And remove the existing code when it is unused.
Signed-off-by: Christian König
---
drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 89 +
Hi Lionel and Christian,
Below is robot report for chain->prev, which was added __rcu as you
suggested.
How to fix this line "tmp = cmpxchg(&chain->prev, prev, replacement); "?
I checked kernel header file, seems it has no cmpxchg for rcu.
Any suggestion to fix this robot report?
Thanks,
-Da
quot;
Hi David,
For the cmpxchg() case I of hand don't know either. Looks like so far
nobody has used cmpxchg() with rcu protected structures.
The other cases should be replaced by RCU_INIT_POINTER() or
rcu_dereference_protected(.., true);
Regards,
Christian.
Am 21.03.19 um 07:34 schrieb
On 2019年04月01日 16:19, Lionel Landwerlin wrote:
On 01/04/2019 06:54, Zhou, David(ChunMing) wrote:
-Original Message-
From: Lionel Landwerlin
Sent: Saturday, March 30, 2019 10:09 PM
To: Koenig, Christian ; Zhou, David(ChunMing)
; dri-de...@lists.freedesktop.org; amd-
g...@lists.freede
On 2019年05月07日 18:53, Koenig, Christian wrote:
Am 07.05.19 um 11:36 schrieb Chunming Zhou:
heavy gpu job could occupy memory long time, which lead other user fail to get
memory.
basically pick up Christian idea:
1. Reserve the BO in DC using a ww_mutex ticket (trivial).
2. If we then run in
On 2019年05月07日 19:13, Koenig, Christian wrote:
Am 07.05.19 um 13:08 schrieb zhoucm1:
On 2019年05月07日 18:53, Koenig, Christian wrote:
Am 07.05.19 um 11:36 schrieb Chunming Zhou:
heavy gpu job could occupy memory long time, which lead other user
fail to get memory.
basically pick up
ping... for patch set.
On 2019年05月13日 17:52, Chunming Zhou wrote:
[CAUTION: External Email]
Signed-off-by: Chunming Zhou
---
include/drm/amdgpu_drm.h | 9 +
1 file changed, 9 insertions(+)
diff --git a/include/drm/amdgpu_drm.h b/include/drm/amdgpu_drm.h
index d0701ffc..3d0318e6 10
Thank you, Lionel.
-David
On 2019年05月14日 17:49, Lionel Landwerlin wrote:
[CAUTION: External Email]
With the small nits, patches 2 & 4 are : Reviewed-by: Lionel Landwerlin
The other patches are a bit amdgpu specific so maybe you might want
someone more familiar with amdgpu to review them.
Sti
On 2019年05月22日 20:59, Christian König wrote:
[CAUTION: External Email]
We are already doing this for DMA-buf imports and also for
amdgpu VM BOs for quite a while now.
If this doesn't run into any problems we are probably going
to stop removing BOs from the LRU altogether.
Signed-off-by: Chri
On 2019年05月22日 20:59, Christian König wrote:
[CAUTION: External Email]
BOs on the LRU might be blocked during command submission
and cause OOM situations.
Avoid this by blocking for the first busy BO not locked by
the same ticket as the BO we are searching space for.
v10: completely start ov
On 2018年07月17日 15:26, Christian König wrote:
Am 17.07.2018 um 09:16 schrieb Zhou, David(ChunMing):
Acked-by: Chunming Zhou , but I think it isn't a
nice evaluation although there is comment in code.
Yeah, I didn't thought about the possibility that we need to free the
job before it is submi
Reviewed-by: Chunming Zhou for series.
Thanks,
David Zhou
On 2018年08月01日 19:31, Christian König wrote:
Instead of the fixed round robin use let the scheduler balance the load
of page table updates.
Signed-off-by: Christian König
---
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 +-
d
On 2018年08月02日 14:01, Nayan Deshmukh wrote:
Hi David,
On Thu, Aug 2, 2018 at 8:22 AM Zhou, David(ChunMing)
mailto:david1.z...@amd.com>> wrote:
Another big question:
I agree the general idea is good to balance scheduler load for
same ring family.
But, when same entity job r
On 2018年08月07日 15:26, Junwei Zhang wrote:
When create bo from user memory, add it to handle table
for future query.
Signed-off-by: Junwei Zhang
---
amdgpu/amdgpu_bo.c | 11 ++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a/amdgpu/amdgpu_bo.c b/amdgpu/amdgpu_bo.c
ind
On 2018年08月07日 15:26, Junwei Zhang wrote:
Userspace needs to know if the user memory is from BO or malloc.
Signed-off-by: Junwei Zhang
---
amdgpu/amdgpu.h| 23 +++
amdgpu/amdgpu_bo.c | 34 ++
2 files changed, 57 insertions(+)
diff -
On 2018年08月07日 17:30, Christian König wrote:
Am 07.08.2018 um 09:55 schrieb zhoucm1:
On 2018年08月07日 15:26, Junwei Zhang wrote:
Userspace needs to know if the user memory is from BO or malloc.
Signed-off-by: Junwei Zhang
---
amdgpu/amdgpu.h | 23 +++
amdgpu
On 2018年08月08日 12:08, Junwei Zhang wrote:
Userspace needs to know if the user memory is from BO or malloc.
v2: update mutex range and rebase
Signed-off-by: Junwei Zhang
---
amdgpu/amdgpu.h| 23 +++
amdgpu/amdgpu_bo.c | 34 ++
2 file
On 2018年08月08日 14:48, Christian König wrote:
Am 08.08.2018 um 06:23 schrieb zhoucm1:
On 2018年08月08日 12:08, Junwei Zhang wrote:
Userspace needs to know if the user memory is from BO or malloc.
v2: update mutex range and rebase
Signed-off-by: Junwei Zhang
---
amdgpu/amdgpu.h | 23
On 2018年08月13日 18:16, Christian König wrote:
Am 13.08.2018 um 11:58 schrieb Huang Rui:
From: Christian König
Add bulk move pos to store the pointer of first and last buffer object.
The list in between will be bulk moved on lru list.
Signed-off-by: Christian König
Signed-off-by: Huang Rui
On 2018年08月15日 18:59, Christian König wrote:
Move the code into a separate function.
Signed-off-by: Christian König
Reviewed-by: Chunming Zhou
---
drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c | 204 +---
1 file changed, 110 insertions(+), 94 deletions(-)
diff --
On 2018年08月15日 18:59, Christian König wrote:
Use a fixed number of entities for each hardware IP.
The number of compute entities is reduced to four, SDMA keeps it two
entities and all other engines just expose one entity.
Signed-off-by: Christian König
---
drivers/gpu/drm/amd/amdgpu/amdgpu
On 2018年08月15日 20:05, Christian König wrote:
Raven doesn't have an VCE block and so also no buggy VCE firmware.
Signed-off-by: Christian König
Acked-by: Chunming Zhou
---
drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drive
On 2018年08月16日 16:11, Christian König wrote:
Am 16.08.2018 um 04:07 schrieb zhoucm1:
On 2018年08月15日 18:59, Christian König wrote:
Use a fixed number of entities for each hardware IP.
The number of compute entities is reduced to four, SDMA keeps it two
entities and all other engines just
On 2018年08月22日 16:52, Christian König wrote:
Am 22.08.2018 um 10:38 schrieb Chunming Zhou:
stub fence will be used by timeline syncobj as well.
Change-Id: Ia4252f03c07a8105491d2791dc7c8c6976682285
Signed-off-by: Chunming Zhou
Cc: Jason Ekstrand
---
drivers/gpu/drm/drm_syncobj.c | 28 ++---
On 2018年08月22日 17:05, Christian König wrote:
Am 22.08.2018 um 11:02 schrieb zhoucm1:
On 2018年08月22日 16:52, Christian König wrote:
Am 22.08.2018 um 10:38 schrieb Chunming Zhou:
stub fence will be used by timeline syncobj as well.
Change-Id: Ia4252f03c07a8105491d2791dc7c8c6976682285
Signed
On 2018年08月22日 17:24, Daniel Vetter wrote:
On Wed, Aug 22, 2018 at 04:49:28PM +0800, Chunming Zhou wrote:
VK_KHR_timeline_semaphore:
This extension introduces a new type of semaphore that has an integer payload
identifying a point in a timeline. Such timeline semaphores support the
following o
On 2018年08月22日 17:34, Daniel Vetter wrote:
On Wed, Aug 22, 2018 at 04:38:56PM +0800, Chunming Zhou wrote:
stub fence will be used by timeline syncobj as well.
Change-Id: Ia4252f03c07a8105491d2791dc7c8c6976682285
Signed-off-by: Chunming Zhou
Cc: Jason Ekstrand
Please don't expose stuff only
On 2018年08月22日 17:31, Daniel Vetter wrote:
On Wed, Aug 22, 2018 at 05:28:17PM +0800, zhoucm1 wrote:
On 2018年08月22日 17:24, Daniel Vetter wrote:
On Wed, Aug 22, 2018 at 04:49:28PM +0800, Chunming Zhou wrote:
VK_KHR_timeline_semaphore:
This extension introduces a new type of semaphore that
On 2018年08月23日 17:08, Daniel Vetter wrote:
On Thu, Aug 23, 2018 at 04:25:42PM +0800, Chunming Zhou wrote:
VK_KHR_timeline_semaphore:
This extension introduces a new type of semaphore that has an integer payload
identifying a point in a timeline. Such timeline semaphores support the
following o
On 2018年08月23日 17:15, Christian König wrote:
Am 23.08.2018 um 10:25 schrieb Chunming Zhou:
VK_KHR_timeline_semaphore:
This extension introduces a new type of semaphore that has an integer
payload
identifying a point in a timeline. Such timeline semaphores support the
following operations:
On 2018年08月28日 03:03, Felix Kuehling wrote:
The point of this series seems to be to allow access to small system
memory BOs (one page) without a GART mapping. I'm guessing that reduces
pressure on the GART and removes the need for HDP and TLB flushes.
I think if adding these explain/reason to c
On 2018年08月28日 20:47, Christian König wrote:
Am 28.08.2018 um 14:40 schrieb Emily Deng:
Fix the VMC page fault when the running sequence is as below:
1.amdgpu_gem_create_ioctl
2.ttm_bo_swapout->amdgpu_vm_bo_invalidate, as not called
amdgpu_vm_bo_base_init, so won't called
list_add_tail(&base->
On 2018年08月29日 19:42, Christian König wrote:
Am 29.08.2018 um 12:44 schrieb Chunming Zhou:
VK_KHR_timeline_semaphore:
This extension introduces a new type of semaphore that has an integer
payload
identifying a point in a timeline. Such timeline semaphores support the
following operations:
On 2018年08月30日 15:25, Christian König wrote:
Am 30.08.2018 um 05:50 schrieb zhoucm1:
On 2018年08月29日 19:42, Christian König wrote:
Am 29.08.2018 um 12:44 schrieb Chunming Zhou:
VK_KHR_timeline_semaphore:
This extension introduces a new type of semaphore that has an
integer payload
On 2018年09月03日 19:19, Christian König wrote:
Am 03.09.2018 um 12:07 schrieb Chunming Zhou:
在 2018/9/3 16:50, Christian König 写道:
Am 03.09.2018 um 06:13 schrieb Chunming Zhou:
在 2018/8/30 19:32, Christian König 写道:
[SNIP]
+
+struct drm_syncobj_wait_pt {
+ struct drm_syncobj_stub_fe
On 2018年09月04日 15:00, Christian König wrote:
Am 04.09.2018 um 06:04 schrieb zhoucm1:
On 2018年09月03日 19:19, Christian König wrote:
Am 03.09.2018 um 12:07 schrieb Chunming Zhou:
在 2018/9/3 16:50, Christian König 写道:
Am 03.09.2018 um 06:13 schrieb Chunming Zhou:
在 2018/8/30 19:32
On 2018年09月04日 16:05, Christian König wrote:
Am 04.09.2018 um 09:53 schrieb zhoucm1:
[SNIP]
How about this idea:
1. Each signaling point is a fence implementation with an rb node.
2. Each node keeps a reference to the last previously inserted node.
3. Each node is referenced by the sync
On 2018年09月04日 16:42, Christian König wrote:
Am 04.09.2018 um 10:27 schrieb zhoucm1:
On 2018年09月04日 16:05, Christian König wrote:
Am 04.09.2018 um 09:53 schrieb zhoucm1:
[SNIP]
How about this idea:
1. Each signaling point is a fence implementation with an rb node.
2. Each node keeps a
On 2018年09月04日 17:20, Christian König wrote:
Am 04.09.2018 um 11:00 schrieb zhoucm1:
On 2018年09月04日 16:42, Christian König wrote:
Am 04.09.2018 um 10:27 schrieb zhoucm1:
On 2018年09月04日 16:05, Christian König wrote:
Am 04.09.2018 um 09:53 schrieb zhoucm1:
[SNIP]
How about this idea
On 2018年09月06日 08:28, Felix Kuehling wrote:
The intent of two commits was lost in the last rebase:
810955b drm/amdgpu: Fix acquiring VM on large-BAR systems
b5d21aa drm/amdgpu: Don't use shadow BO for compute context
This commit restores the original behaviour:
* Don't set AMDGPU_GEM_CREATE_N
On 2018年09月11日 10:51, Emily Deng wrote:
It will ramdomly have the dead lock issue when test TDR:
1. amdgpu_device_handle_vram_lost gets the lock shadow_list_lock
2. amdgpu_bo_create locked the bo's resv lock
3. amdgpu_bo_create_shadow is waiting for the shadow_list_lock
4. amdgpu_device_recover
On 2018年09月11日 11:23, Deng, Emily wrote:
-Original Message-
From: Zhou, David(ChunMing)
Sent: Tuesday, September 11, 2018 11:03 AM
To: Deng, Emily ; amd-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/amdgpu: Fix the dead lock issue.
On 2018年09月11日 10:51, Emily Deng wrote:
It wil
On 2018年09月11日 11:32, Deng, Emily wrote:
-Original Message-
From: amd-gfx On Behalf Of
zhoucm1
Sent: Tuesday, September 11, 2018 11:28 AM
To: Deng, Emily ; Zhou, David(ChunMing)
; amd-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/amdgpu: Fix the dead lock issue.
On 2018年09月11日
On 2018年09月11日 11:37, zhoucm1 wrote:
On 2018年09月11日 11:32, Deng, Emily wrote:
-Original Message-
From: amd-gfx On Behalf Of
zhoucm1
Sent: Tuesday, September 11, 2018 11:28 AM
To: Deng, Emily ; Zhou, David(ChunMing)
; amd-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/amdgpu
On 2018年09月12日 15:22, Christian König wrote:
Ping? Have you seen my comments here?
Sorry, I didn't see this reply. inline...
Looks like you haven't addressed any of them in your last mail.
Christian.
Am 06.09.2018 um 09:25 schrieb Christian König:
Am 06.09.2018 um 08:25 schrieb Chunming
Reviewed-by: Chunming Zhou
On 2018年09月12日 16:55, Christian König wrote:
We can get that just by casting tv.bo.
Signed-off-by: Christian König
---
drivers/gpu/drm/amd/amdgpu/amdgpu_bo_list.c | 42 -
drivers/gpu/drm/amd/amdgpu/amdgpu_bo_list.h | 1 -
drivers/gpu/drm/am
Reviewed-by: Chunming Zhou
On 2018年09月12日 16:55, Christian König wrote:
Instead of the double linked list. Gets the size of amdgpu_vm_pt down to
64 bytes again.
We could even reduce it down to 32 bytes, but that would require some
rather extreme hacks.
Signed-off-by: Christian König
---
d
On 2018年09月12日 19:05, Christian König wrote:
Am 12.09.2018 um 12:20 schrieb zhoucm1:
[SNIP]
Drop the term semaphore here, better use syncobj.
This is from VK_KHR_timeline_semaphore extension describe, not my
invention, I just quote it. In kernel side, we call syncobj, in UMD,
they still
On 2018年09月14日 11:14, zhoucm1 wrote:
On 2018年09月13日 18:22, Christian König wrote:
Am 13.09.2018 um 11:35 schrieb Zhou, David(ChunMing):
-Original Message-
From: Koenig, Christian
Sent: Thursday, September 13, 2018 5:20 PM
To: Zhou, David(ChunMing) ; dri-
de
PM
To: Zhou, David(ChunMing) ; Zhou,
David(ChunMing) ; dri-
de...@lists.freedesktop.org
Cc: Dave Airlie ; Rakos, Daniel
; amd-gfx@lists.freedesktop.org
Subject: Re: [PATCH 1/3] [RFC]drm: add syncobj timeline support v4
Am 13.09.2018 um 04:15 schrieb zhoucm1:
On 2018年09月12日 19:05, Christian König
On 2019/7/23 上午3:08, Christian König wrote:
Am 22.07.19 um 17:34 schrieb Greathouse, Joseph:
Units in the GDS block default to allowing all VMIDs access to all
entries. Disable shader access to the GDS, GWS, and OA blocks from all
compute and gfx VMIDs by default. For compute, HWS firmware will
are of closed source stack.
But AMDVLK is indeed an open source stack, many fans are using it, we
need keep its compatibility, don't we?
-David
Marek
On Wed, Aug 28, 2019 at 2:44 AM zhoucm1 <mailto:zhou...@amd.com>> wrote:
On 2019/7/23 上午3:08, Christian König wrote:
On 2019/8/29 下午3:22, Christian König wrote:
Am 29.08.19 um 07:55 schrieb zhoucm1:
On 2019/8/29 上午1:08, Marek Olšák wrote:
It can't break an older driver, because there is no older driver
that requires the static allocation.
Note that closed source drivers don't count, because
any reason for not care .emit_ib_size in this one?
-David
On 2019年06月27日 06:35, Marek Olšák wrote:
From: Marek Olšák
Signed-off-by: Marek Olšák
---
drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c | 17 +
1 file changed, 17 insertions(+)
diff --git a/drivers/gpu/drm/amd/amdgpu/gfx
On 2019年07月30日 17:04, Koenig, Christian wrote:
Am 30.07.19 um 10:47 schrieb 亿一:
Hi alll,
While analyzing the source code, I notice that function
amdgpu_cs_process_fence_dep() may exist NULL pointer dereference and
memory leak in the following code fragments:
fence = amdgpu_ctx_ge
Looks very clean, Reviewed-by: Chunming Zhou
On 2019年07月30日 17:18, Christian König wrote:
We always need to drop the ctx reference and should check
for errors first and then dereference the fence pointer.
Signed-off-by: Christian König
---
drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 26 ++
On 2016年12月28日 10:27, Yu, Xiangliang wrote:
+
>+ amdgpu_bo_kunmap(kiq->eop_obj);
>+
I see it is in many places, which is don't need I think,
amdgpu_bo_free_kernel will handle it if I'm correct.
Regards,
David zhou
___
amd-gfx mailing list
amd-gfx
some small nitpick...
On 2017年01月20日 06:53, Alex Xie wrote:
Verify the vender ID and driver name.
Open all AMDGPU devices.
Provide an option to open render node.
Tested as root: PASS
Tested as non-privileged user:
All tests failed as expected
Signed-off-by: Alex Xie
---
tests/amdgpu/amdgpu_
Hi Pixel,
I got your mean just now, since your VF must use KIQ to read/write
registers, which use fence_wait to wait reading register completed.
The alternative way is implementing a new kiq reading/writing register
way by using udelay instead of fence wait when reading/writing register
in inte
On 2017年02月10日 06:28, Samuel Pitoiset wrote:
Move amdgpu_bo_unreserve() outside of the switch. While we are
at it, add a missing break in the default case.
Signed-off-by: Samuel Pitoiset
---
drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c | 7 ++-
1 file changed, 2 insertions(+), 5 deletions(-
On 2017年02月10日 06:28, Samuel Pitoiset wrote:
This removes code duplication.
Signed-off-by: Samuel Pitoiset
Reviewed-by: Chunming Zhou
Thanks,
David Zhou
---
drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c | 8 +---
1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/drivers/gpu/dr
On 2017年02月14日 03:03, Nicolai Hähnle wrote:
On 13.02.2017 19:58, Nicolai Hähnle wrote:
On 13.02.2017 19:38, Samuel Pitoiset wrote:
On 02/13/2017 07:09 PM, Nicolai Hähnle wrote:
On 13.02.2017 19:04, Nicolai Hähnle wrote:
On 13.02.2017 18:49, Samuel Pitoiset wrote:
On 02/13/2017 05:25 PM
On 2017年02月14日 18:37, Nicolai Hähnle wrote:
From: Nicolai Hähnle
Allow callers to opt out of calling ttm_bo_validate immediately. This
allows more flexibility in how locking of the reservation object is
done, which is needed to fix a locking bug (destroy locked mutex)
in amdgpu.
Signed-off-b
On 2017年02月15日 18:43, Nicolai Hähnle wrote:
On 15.02.2017 04:16, zhoucm1 wrote:
On 2017年02月14日 18:37, Nicolai Hähnle wrote:
From: Nicolai Hähnle
Allow callers to opt out of calling ttm_bo_validate immediately. This
allows more flexibility in how locking of the reservation object is
done
On 2017年02月16日 20:08, Christian König wrote:
Am 16.02.2017 um 12:39 schrieb Nicolai Hähnle:
From: Nicolai Hähnle
By using ttm_bo_init_reserved instead of the manual initialization of
the reservation object, the reservation lock will be properly unlocked
and destroyed when the TTM BO initiali
Hi Dave,
The attached is our semaphore implementation, amdgpu_cs.c is drm file,
the others are kernel file.
Any suggestion?
Regards,
David Zhou
On 2017年02月28日 03:36, Dave Airlie wrote:
Hi,
Any further news on these?
Dave.
On 6 January 2017 at 03:48, Andres Rodriguez wrote:
Cool, thanks
1 - 100 of 424 matches
Mail list logo
