Re: [PATCH] drm/amd/powerplay: add error message to remind user updating firmware

2017-04-20 Thread Alex Deucher 
On Thu, Apr 20, 2017 at 3:33 AM, Huang Rui  wrote:
> Signed-off-by: Huang Rui 

Reviewed-by: Alex Deucher 

> ---
>  drivers/gpu/drm/amd/powerplay/smumgr/vega10_smumgr.c | 7 +--
>  1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/powerplay/smumgr/vega10_smumgr.c 
> b/drivers/gpu/drm/amd/powerplay/smumgr/vega10_smumgr.c
> index 2685f02..b3f3af2 100644
> --- a/drivers/gpu/drm/amd/powerplay/smumgr/vega10_smumgr.c
> +++ b/drivers/gpu/drm/amd/powerplay/smumgr/vega10_smumgr.c
> @@ -378,8 +378,11 @@ static int vega10_verify_smc_interface(struct pp_smumgr 
> *smumgr)
> "Attempt to read SMC IF Version Number Failed!",
> return -1);
>
> -   if (smc_driver_if_version != SMU9_DRIVER_IF_VERSION)
> -   return -1;
> +   if (smc_driver_if_version != SMU9_DRIVER_IF_VERSION) {
> +   pr_err("Your firmware(0x%x) doesn't match 
> SMU9_DRIVER_IF_VERSION(0x%x). Please update your firmware!\n",
> +  smc_driver_if_version, SMU9_DRIVER_IF_VERSION);
> +   return -EINVAL;
> +   }
>
> return 0;
>  }
> --
> 2.7.4
>
> ___
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

RE: [PATCH] drm/amd/powerplay: add error message to remind user updating firmware

2017-04-20 Thread Quan, Evan 
Reviewed-by: Evan Quan 

>-Original Message-
>From: Huang Rui [mailto:ray.hu...@amd.com]
>Sent: Thursday, April 20, 2017 3:34 PM
>To: amd-gfx@lists.freedesktop.org
>Cc: Deucher, Alexander ; Quan, Evan
>; Huang, Ray 
>Subject: [PATCH] drm/amd/powerplay: add error message to remind user
>updating firmware
>
>Signed-off-by: Huang Rui 
>---
> drivers/gpu/drm/amd/powerplay/smumgr/vega10_smumgr.c | 7 +--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
>diff --git a/drivers/gpu/drm/amd/powerplay/smumgr/vega10_smumgr.c
>b/drivers/gpu/drm/amd/powerplay/smumgr/vega10_smumgr.c
>index 2685f02..b3f3af2 100644
>--- a/drivers/gpu/drm/amd/powerplay/smumgr/vega10_smumgr.c
>+++ b/drivers/gpu/drm/amd/powerplay/smumgr/vega10_smumgr.c
>@@ -378,8 +378,11 @@ static int vega10_verify_smc_interface(struct
>pp_smumgr *smumgr)
>   "Attempt to read SMC IF Version Number Failed!",
>   return -1);
>
>-  if (smc_driver_if_version != SMU9_DRIVER_IF_VERSION)
>-  return -1;
>+  if (smc_driver_if_version != SMU9_DRIVER_IF_VERSION) {
>+  pr_err("Your firmware(0x%x) doesn't match
>SMU9_DRIVER_IF_VERSION(0x%x). Please update your firmware!\n",
>+ smc_driver_if_version, SMU9_DRIVER_IF_VERSION);
>+  return -EINVAL;
>+  }
>
>   return 0;
> }
>--
>2.7.4

___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Re: [PATCH] drm/amd/powerplay: add error message to remind user updating firmware

2017-04-20 Thread Edward O'Callaghan 
Reviewed-by: Edward O'Callaghan 

On 04/20/2017 05:33 PM, Huang Rui wrote:
> Signed-off-by: Huang Rui 
> ---
>  drivers/gpu/drm/amd/powerplay/smumgr/vega10_smumgr.c | 7 +--
>  1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/powerplay/smumgr/vega10_smumgr.c 
> b/drivers/gpu/drm/amd/powerplay/smumgr/vega10_smumgr.c
> index 2685f02..b3f3af2 100644
> --- a/drivers/gpu/drm/amd/powerplay/smumgr/vega10_smumgr.c
> +++ b/drivers/gpu/drm/amd/powerplay/smumgr/vega10_smumgr.c
> @@ -378,8 +378,11 @@ static int vega10_verify_smc_interface(struct pp_smumgr 
> *smumgr)
>   "Attempt to read SMC IF Version Number Failed!",
>   return -1);
>  
> - if (smc_driver_if_version != SMU9_DRIVER_IF_VERSION)
> - return -1;
> + if (smc_driver_if_version != SMU9_DRIVER_IF_VERSION) {
> + pr_err("Your firmware(0x%x) doesn't match 
> SMU9_DRIVER_IF_VERSION(0x%x). Please update your firmware!\n",
> +smc_driver_if_version, SMU9_DRIVER_IF_VERSION);
> + return -EINVAL;
> + }
>  
>   return 0;
>  }
> 



signature.asc
Description: OpenPGP digital signature
___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

[PATCH] drm/amd/powerplay: add error message to remind user updating firmware

2017-04-20 Thread Huang Rui 
Signed-off-by: Huang Rui 
---
 drivers/gpu/drm/amd/powerplay/smumgr/vega10_smumgr.c | 7 +--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/amd/powerplay/smumgr/vega10_smumgr.c 
b/drivers/gpu/drm/amd/powerplay/smumgr/vega10_smumgr.c
index 2685f02..b3f3af2 100644
--- a/drivers/gpu/drm/amd/powerplay/smumgr/vega10_smumgr.c
+++ b/drivers/gpu/drm/amd/powerplay/smumgr/vega10_smumgr.c
@@ -378,8 +378,11 @@ static int vega10_verify_smc_interface(struct pp_smumgr 
*smumgr)
"Attempt to read SMC IF Version Number Failed!",
return -1);
 
-   if (smc_driver_if_version != SMU9_DRIVER_IF_VERSION)
-   return -1;
+   if (smc_driver_if_version != SMU9_DRIVER_IF_VERSION) {
+   pr_err("Your firmware(0x%x) doesn't match 
SMU9_DRIVER_IF_VERSION(0x%x). Please update your firmware!\n",
+  smc_driver_if_version, SMU9_DRIVER_IF_VERSION);
+   return -EINVAL;
+   }
 
return 0;
 }
-- 
2.7.4

___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx