RE: [PATCH 2/2] drm/amdgpu:cleanup deprecated gpu reset logic

2017-11-01 Thread Liu, Monk
om>; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH 2/2] drm/amdgpu:cleanup deprecated gpu reset logic Am 01.11.2017 um 04:29 schrieb Liu, Monk: > The thing is triggering gpu_recover() in irq routine give you NULL for the > @bad/job parameter, so gpu_recover() actually did nothing meaningful, it just

Re: [PATCH 2/2] drm/amdgpu:cleanup deprecated gpu reset logic

2017-11-01 Thread Christian König
10月31日 23:01 To: Liu, Monk <monk@amd.com>; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH 2/2] drm/amdgpu:cleanup deprecated gpu reset logic Am 31.10.2017 um 12:55 schrieb Monk Liu: trigger gpu reset/recovery from illegle instruction IRQ is deprecated long time ago, we already sw

RE: [PATCH 2/2] drm/amdgpu:cleanup deprecated gpu reset logic

2017-10-31 Thread Liu, Monk
t this error and do recover() gracefully. -Original Message- From: Christian König [mailto:ckoenig.leichtzumer...@gmail.com] Sent: 2017年10月31日 23:01 To: Liu, Monk <monk@amd.com>; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH 2/2] drm/amdgpu:cleanup deprecated gpu reset log

Re: [PATCH 2/2] drm/amdgpu:cleanup deprecated gpu reset logic

2017-10-31 Thread Christian König
Am 31.10.2017 um 12:55 schrieb Monk Liu: trigger gpu reset/recovery from illegle instruction IRQ is deprecated long time ago, we already switch to recover gpu by TDR triggering. now please set lockup_timeout to non-zero value in driver loading to enable TDR. The patch is ok, but NAK to the

[PATCH 2/2] drm/amdgpu:cleanup deprecated gpu reset logic

2017-10-31 Thread Monk Liu
trigger gpu reset/recovery from illegle instruction IRQ is deprecated long time ago, we already switch to recover gpu by TDR triggering. now please set lockup_timeout to non-zero value in driver loading to enable TDR. Change-Id: I45a576a97fd9859e1098e785ce857c2cf5adfba5 Signed-off-by: Monk Liu

RE: [PATCH 2/2] drm/amdgpu:cleanup

2017-02-08 Thread Deucher, Alexander
> -Original Message- > From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf > Of Monk Liu > Sent: Wednesday, February 08, 2017 10:50 PM > To: amd-gfx@lists.freedesktop.org > Cc: Liu, Monk > Subject: [PATCH 2/2] drm/amdgpu:cleanup > > 1)remove

[PATCH 2/2] drm/amdgpu:cleanup

2017-02-08 Thread Monk Liu
1)remove braces not needed 2)don't return failure on debugfs_firmware_init failed Change-Id: I90ec3197184d0fdda54575bfbad7b705aa178698 Signed-off-by: Monk Liu --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 10 +++--- 1 file changed, 3 insertions(+), 7 deletions(-) diff