Re: [PATCH 2/3] drm/amd/pp: Refine get_gpu_power for VI

2018-04-11 Thread Eric Huang
This patch change the power registers reading from average to maximum. If SMU team verifies it, I am OK with it. Regards, Eric On 2018-04-11 01:21 PM, Alex Deucher wrote: On Wed, Apr 11, 2018 at 2:31 AM, Rex Zhu wrote: pkgpwr is the average gpu power of 100ms. it is

Re: [PATCH 2/3] drm/amd/pp: Refine get_gpu_power for VI

2018-04-11 Thread Alex Deucher
On Wed, Apr 11, 2018 at 2:31 AM, Rex Zhu wrote: > pkgpwr is the average gpu power of 100ms. it is calculated by > firmware in real time. > > 1. we can send smu message PPSMC_MSG_GetCurrPkgPwr to read currentpkgpwr > directly. > > 2. On Fiji/tonga/bonaire/hawwii, without

[PATCH 2/3] drm/amd/pp: Refine get_gpu_power for VI

2018-04-11 Thread Rex Zhu
pkgpwr is the average gpu power of 100ms. it is calculated by firmware in real time. 1. we can send smu message PPSMC_MSG_GetCurrPkgPwr to read currentpkgpwr directly. 2. On Fiji/tonga/bonaire/hawwii, without PPSMC_MSG_GetCurrPkgPwr support. Send PPSMC_MSG_PmStatusLogStart/Sample to let smu

Re: [PATCH 2/3] drm/amd/pp: Refine get_gpu_power for VI

2018-04-04 Thread Zhu, Rex
with this patch, there should be no difference between AGT and sysfs. Best Regards Rex From: Huang, JinHuiEric Sent: Thursday, April 5, 2018 12:00 AM To: Zhu, Rex; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH 2/3] drm/amd/pp: Refine get_gpu_power for VI

Re: [PATCH 2/3] drm/amd/pp: Refine get_gpu_power for VI

2018-04-04 Thread Eric Huang
018 11:36 PM *To:* amd-gfx@lists.freedesktop.org *Subject:* Re: [PATCH 2/3] drm/amd/pp: Refine get_gpu_power for VI Sampling period is too short. The power reading value will be not aligned with AGT's. It will confuse user that why AMD provides two different power results. Regards, Eric On 2018-04-04 0

Re: [PATCH 2/3] drm/amd/pp: Refine get_gpu_power for VI

2018-04-04 Thread Zhu, Rex
org> on behalf of Eric Huang <jinhuieric.hu...@amd.com> Sent: Wednesday, April 4, 2018 11:36 PM To: amd-gfx@lists.freedesktop.org Subject: Re: [PATCH 2/3] drm/amd/pp: Refine get_gpu_power for VI Sampling period is too short. The power reading value will be not aligned with AGT's. It will

Re: [PATCH 2/3] drm/amd/pp: Refine get_gpu_power for VI

2018-04-04 Thread Eric Huang
Sampling period is too short. The power reading value will be not aligned with AGT's. It will confuse user that why AMD provides two different power results. Regards, Eric On 2018-04-04 04:25 AM, Rex Zhu wrote: 1. On polaris10/11/12, Sending smu message PPSMC_MSG_GetCurrPkgPwr to read

[PATCH 2/3] drm/amd/pp: Refine get_gpu_power for VI

2018-04-04 Thread Rex Zhu
1. On polaris10/11/12, Sending smu message PPSMC_MSG_GetCurrPkgPwr to read currentpkgpwr directly. 2. On Fiji/tonga/bonaire/hawwii, no PPSMC_MSG_GetCurrPkgPwr support. Send PPSMC_MSG_PmStatusLogStart to let smu write currentpkgpwr to ixSMU_PM_STATUS_94. this is asynchronous. need to delay