Re: [PATCH v2 0/2] AMDGPU scheduler move, take 2
For the series: Tested-by: Dieter Nützelon RX580 8GB with UH, UV, Blender 2.79, smoketest (Vulkan), glmark2 (parallel with OpenCL (/opt/opencl-example>./run_tests.sh)) Dieter Am 06.12.2017 17:49, schrieb Lucas Stach: Hi all, second try to move the AMDGPU scheduler into a common location, this time rebased onto drm-next-4.16-wip. I've tested my etnaviv series on top of this and things seem to work fine. I checked that AMDGPU still builds, but I don't have any means to actually runtime test this currently, so I would be very happy to receive some tested-bys from the AMD side. Alex, if this looks good please pull this in so it gets your usual testing. Thanks, Lucas Lucas Stach (2): drm: move amd_gpu_scheduler into common location drm/sched: move fence slab handling to module init/exit drivers/gpu/drm/Kconfig| 5 + drivers/gpu/drm/Makefile | 1 + drivers/gpu/drm/amd/amdgpu/Makefile| 5 +- drivers/gpu/drm/amd/amdgpu/amdgpu.h| 16 +- drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 6 +- drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.c| 38 +-- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 4 +- drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c| 8 - drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c | 4 +- drivers/gpu/drm/amd/amdgpu/amdgpu_job.c| 20 +- drivers/gpu/drm/amd/amdgpu/amdgpu_ring.c | 14 +- drivers/gpu/drm/amd/amdgpu/amdgpu_ring.h | 12 +- drivers/gpu/drm/amd/amdgpu/amdgpu_sched.c | 20 +- drivers/gpu/drm/amd/amdgpu/amdgpu_sched.h | 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_sync.c | 6 +- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c| 8 +- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.h| 4 +- drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c| 8 +- drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.h| 4 +- drivers/gpu/drm/amd/amdgpu/amdgpu_vce.c| 8 +- drivers/gpu/drm/amd/amdgpu/amdgpu_vce.h| 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c| 14 +- drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.h| 4 +- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 10 +- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.h | 7 +- drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c | 4 +- drivers/gpu/drm/amd/amdgpu/uvd_v6_0.c | 8 +- drivers/gpu/drm/amd/amdgpu/uvd_v7_0.c | 8 +- drivers/gpu/drm/amd/scheduler/gpu_scheduler.h | 186 - drivers/gpu/drm/scheduler/Makefile | 4 + .../gpu/drm/{amd => }/scheduler/gpu_scheduler.c| 296 ++--- drivers/gpu/drm/{amd => }/scheduler/sched_fence.c | 122 + include/drm/gpu_scheduler.h| 173 .../drm/gpu_scheduler_trace.h | 14 +- .../drm/amd/scheduler => include/drm}/spsc_queue.h | 7 +- 35 files changed, 529 insertions(+), 523 deletions(-) delete mode 100644 drivers/gpu/drm/amd/scheduler/gpu_scheduler.h create mode 100644 drivers/gpu/drm/scheduler/Makefile rename drivers/gpu/drm/{amd => }/scheduler/gpu_scheduler.c (65%) rename drivers/gpu/drm/{amd => }/scheduler/sched_fence.c (58%) create mode 100644 include/drm/gpu_scheduler.h rename drivers/gpu/drm/amd/scheduler/gpu_sched_trace.h => include/drm/gpu_scheduler_trace.h (82%) rename {drivers/gpu/drm/amd/scheduler => include/drm}/spsc_queue.h (95%) ___ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx
Re: [PATCH v2 0/2] AMDGPU scheduler move, take 2
Looks ok to me, Reviewed-by: Chunming ZhouOn 2017年12月07日 00:49, Lucas Stach wrote: Hi all, second try to move the AMDGPU scheduler into a common location, this time rebased onto drm-next-4.16-wip. I've tested my etnaviv series on top of this and things seem to work fine. I checked that AMDGPU still builds, but I don't have any means to actually runtime test this currently, so I would be very happy to receive some tested-bys from the AMD side. Alex, if this looks good please pull this in so it gets your usual testing. Thanks, Lucas Lucas Stach (2): drm: move amd_gpu_scheduler into common location drm/sched: move fence slab handling to module init/exit drivers/gpu/drm/Kconfig| 5 + drivers/gpu/drm/Makefile | 1 + drivers/gpu/drm/amd/amdgpu/Makefile| 5 +- drivers/gpu/drm/amd/amdgpu/amdgpu.h| 16 +- drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 6 +- drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.c| 38 +-- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 4 +- drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c| 8 - drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c | 4 +- drivers/gpu/drm/amd/amdgpu/amdgpu_job.c| 20 +- drivers/gpu/drm/amd/amdgpu/amdgpu_ring.c | 14 +- drivers/gpu/drm/amd/amdgpu/amdgpu_ring.h | 12 +- drivers/gpu/drm/amd/amdgpu/amdgpu_sched.c | 20 +- drivers/gpu/drm/amd/amdgpu/amdgpu_sched.h | 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_sync.c | 6 +- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c| 8 +- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.h| 4 +- drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c| 8 +- drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.h| 4 +- drivers/gpu/drm/amd/amdgpu/amdgpu_vce.c| 8 +- drivers/gpu/drm/amd/amdgpu/amdgpu_vce.h| 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c| 14 +- drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.h| 4 +- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 10 +- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.h | 7 +- drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c | 4 +- drivers/gpu/drm/amd/amdgpu/uvd_v6_0.c | 8 +- drivers/gpu/drm/amd/amdgpu/uvd_v7_0.c | 8 +- drivers/gpu/drm/amd/scheduler/gpu_scheduler.h | 186 - drivers/gpu/drm/scheduler/Makefile | 4 + .../gpu/drm/{amd => }/scheduler/gpu_scheduler.c| 296 ++--- drivers/gpu/drm/{amd => }/scheduler/sched_fence.c | 122 + include/drm/gpu_scheduler.h| 173 .../drm/gpu_scheduler_trace.h | 14 +- .../drm/amd/scheduler => include/drm}/spsc_queue.h | 7 +- 35 files changed, 529 insertions(+), 523 deletions(-) delete mode 100644 drivers/gpu/drm/amd/scheduler/gpu_scheduler.h create mode 100644 drivers/gpu/drm/scheduler/Makefile rename drivers/gpu/drm/{amd => }/scheduler/gpu_scheduler.c (65%) rename drivers/gpu/drm/{amd => }/scheduler/sched_fence.c (58%) create mode 100644 include/drm/gpu_scheduler.h rename drivers/gpu/drm/amd/scheduler/gpu_sched_trace.h => include/drm/gpu_scheduler_trace.h (82%) rename {drivers/gpu/drm/amd/scheduler => include/drm}/spsc_queue.h (95%) ___ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx
Re: [PATCH v2 0/2] AMDGPU scheduler move, take 2
Tested with amdgpu libdrm tests and desktop login with glxgears. Thanks, Andrey On 12/06/2017 02:51 PM, Alex Deucher wrote: On Wed, Dec 6, 2017 at 11:49 AM, Lucas Stachwrote: Hi all, second try to move the AMDGPU scheduler into a common location, this time rebased onto drm-next-4.16-wip. I've tested my etnaviv series on top of this and things seem to work fine. I checked that AMDGPU still builds, but I don't have any means to actually runtime test this currently, so I would be very happy to receive some tested-bys from the AMD side. Alex, if this looks good please pull this in so it gets your usual testing. Series is: Acked-by: Alex Deucher Thanks, Lucas Lucas Stach (2): drm: move amd_gpu_scheduler into common location drm/sched: move fence slab handling to module init/exit drivers/gpu/drm/Kconfig| 5 + drivers/gpu/drm/Makefile | 1 + drivers/gpu/drm/amd/amdgpu/Makefile| 5 +- drivers/gpu/drm/amd/amdgpu/amdgpu.h| 16 +- drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 6 +- drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.c| 38 +-- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 4 +- drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c| 8 - drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c | 4 +- drivers/gpu/drm/amd/amdgpu/amdgpu_job.c| 20 +- drivers/gpu/drm/amd/amdgpu/amdgpu_ring.c | 14 +- drivers/gpu/drm/amd/amdgpu/amdgpu_ring.h | 12 +- drivers/gpu/drm/amd/amdgpu/amdgpu_sched.c | 20 +- drivers/gpu/drm/amd/amdgpu/amdgpu_sched.h | 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_sync.c | 6 +- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c| 8 +- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.h| 4 +- drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c| 8 +- drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.h| 4 +- drivers/gpu/drm/amd/amdgpu/amdgpu_vce.c| 8 +- drivers/gpu/drm/amd/amdgpu/amdgpu_vce.h| 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c| 14 +- drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.h| 4 +- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 10 +- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.h | 7 +- drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c | 4 +- drivers/gpu/drm/amd/amdgpu/uvd_v6_0.c | 8 +- drivers/gpu/drm/amd/amdgpu/uvd_v7_0.c | 8 +- drivers/gpu/drm/amd/scheduler/gpu_scheduler.h | 186 - drivers/gpu/drm/scheduler/Makefile | 4 + .../gpu/drm/{amd => }/scheduler/gpu_scheduler.c| 296 ++--- drivers/gpu/drm/{amd => }/scheduler/sched_fence.c | 122 + include/drm/gpu_scheduler.h| 173 .../drm/gpu_scheduler_trace.h | 14 +- .../drm/amd/scheduler => include/drm}/spsc_queue.h | 7 +- 35 files changed, 529 insertions(+), 523 deletions(-) delete mode 100644 drivers/gpu/drm/amd/scheduler/gpu_scheduler.h create mode 100644 drivers/gpu/drm/scheduler/Makefile rename drivers/gpu/drm/{amd => }/scheduler/gpu_scheduler.c (65%) rename drivers/gpu/drm/{amd => }/scheduler/sched_fence.c (58%) create mode 100644 include/drm/gpu_scheduler.h rename drivers/gpu/drm/amd/scheduler/gpu_sched_trace.h => include/drm/gpu_scheduler_trace.h (82%) rename {drivers/gpu/drm/amd/scheduler => include/drm}/spsc_queue.h (95%) -- 2.11.0 ___ dri-devel mailing list dri-de...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ___ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx
Re: [PATCH v2 0/2] AMDGPU scheduler move, take 2
On Wed, Dec 6, 2017 at 11:49 AM, Lucas Stachwrote: > Hi all, > > second try to move the AMDGPU scheduler into a common location, this > time rebased onto drm-next-4.16-wip. > > I've tested my etnaviv series on top of this and things seem to work > fine. I checked that AMDGPU still builds, but I don't have any means > to actually runtime test this currently, so I would be very happy to > receive some tested-bys from the AMD side. > > Alex, if this looks good please pull this in so it gets your usual > testing. Series is: Acked-by: Alex Deucher > > Thanks, > Lucas > > Lucas Stach (2): > drm: move amd_gpu_scheduler into common location > drm/sched: move fence slab handling to module init/exit > > drivers/gpu/drm/Kconfig| 5 + > drivers/gpu/drm/Makefile | 1 + > drivers/gpu/drm/amd/amdgpu/Makefile| 5 +- > drivers/gpu/drm/amd/amdgpu/amdgpu.h| 16 +- > drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 6 +- > drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.c| 38 +-- > drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 4 +- > drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c| 8 - > drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c | 4 +- > drivers/gpu/drm/amd/amdgpu/amdgpu_job.c| 20 +- > drivers/gpu/drm/amd/amdgpu/amdgpu_ring.c | 14 +- > drivers/gpu/drm/amd/amdgpu/amdgpu_ring.h | 12 +- > drivers/gpu/drm/amd/amdgpu/amdgpu_sched.c | 20 +- > drivers/gpu/drm/amd/amdgpu/amdgpu_sched.h | 2 +- > drivers/gpu/drm/amd/amdgpu/amdgpu_sync.c | 6 +- > drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c| 8 +- > drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.h| 4 +- > drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c| 8 +- > drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.h| 4 +- > drivers/gpu/drm/amd/amdgpu/amdgpu_vce.c| 8 +- > drivers/gpu/drm/amd/amdgpu/amdgpu_vce.h| 2 +- > drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c| 14 +- > drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.h| 4 +- > drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 10 +- > drivers/gpu/drm/amd/amdgpu/amdgpu_vm.h | 7 +- > drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c | 4 +- > drivers/gpu/drm/amd/amdgpu/uvd_v6_0.c | 8 +- > drivers/gpu/drm/amd/amdgpu/uvd_v7_0.c | 8 +- > drivers/gpu/drm/amd/scheduler/gpu_scheduler.h | 186 - > drivers/gpu/drm/scheduler/Makefile | 4 + > .../gpu/drm/{amd => }/scheduler/gpu_scheduler.c| 296 > ++--- > drivers/gpu/drm/{amd => }/scheduler/sched_fence.c | 122 + > include/drm/gpu_scheduler.h| 173 > .../drm/gpu_scheduler_trace.h | 14 +- > .../drm/amd/scheduler => include/drm}/spsc_queue.h | 7 +- > 35 files changed, 529 insertions(+), 523 deletions(-) > delete mode 100644 drivers/gpu/drm/amd/scheduler/gpu_scheduler.h > create mode 100644 drivers/gpu/drm/scheduler/Makefile > rename drivers/gpu/drm/{amd => }/scheduler/gpu_scheduler.c (65%) > rename drivers/gpu/drm/{amd => }/scheduler/sched_fence.c (58%) > create mode 100644 include/drm/gpu_scheduler.h > rename drivers/gpu/drm/amd/scheduler/gpu_sched_trace.h => > include/drm/gpu_scheduler_trace.h (82%) > rename {drivers/gpu/drm/amd/scheduler => include/drm}/spsc_queue.h (95%) > > -- > 2.11.0 > > ___ > dri-devel mailing list > dri-de...@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel ___ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx
[PATCH v2 0/2] AMDGPU scheduler move, take 2
Hi all, second try to move the AMDGPU scheduler into a common location, this time rebased onto drm-next-4.16-wip. I've tested my etnaviv series on top of this and things seem to work fine. I checked that AMDGPU still builds, but I don't have any means to actually runtime test this currently, so I would be very happy to receive some tested-bys from the AMD side. Alex, if this looks good please pull this in so it gets your usual testing. Thanks, Lucas Lucas Stach (2): drm: move amd_gpu_scheduler into common location drm/sched: move fence slab handling to module init/exit drivers/gpu/drm/Kconfig| 5 + drivers/gpu/drm/Makefile | 1 + drivers/gpu/drm/amd/amdgpu/Makefile| 5 +- drivers/gpu/drm/amd/amdgpu/amdgpu.h| 16 +- drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 6 +- drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.c| 38 +-- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 4 +- drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c| 8 - drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c | 4 +- drivers/gpu/drm/amd/amdgpu/amdgpu_job.c| 20 +- drivers/gpu/drm/amd/amdgpu/amdgpu_ring.c | 14 +- drivers/gpu/drm/amd/amdgpu/amdgpu_ring.h | 12 +- drivers/gpu/drm/amd/amdgpu/amdgpu_sched.c | 20 +- drivers/gpu/drm/amd/amdgpu/amdgpu_sched.h | 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_sync.c | 6 +- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c| 8 +- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.h| 4 +- drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c| 8 +- drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.h| 4 +- drivers/gpu/drm/amd/amdgpu/amdgpu_vce.c| 8 +- drivers/gpu/drm/amd/amdgpu/amdgpu_vce.h| 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c| 14 +- drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.h| 4 +- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 10 +- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.h | 7 +- drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c | 4 +- drivers/gpu/drm/amd/amdgpu/uvd_v6_0.c | 8 +- drivers/gpu/drm/amd/amdgpu/uvd_v7_0.c | 8 +- drivers/gpu/drm/amd/scheduler/gpu_scheduler.h | 186 - drivers/gpu/drm/scheduler/Makefile | 4 + .../gpu/drm/{amd => }/scheduler/gpu_scheduler.c| 296 ++--- drivers/gpu/drm/{amd => }/scheduler/sched_fence.c | 122 + include/drm/gpu_scheduler.h| 173 .../drm/gpu_scheduler_trace.h | 14 +- .../drm/amd/scheduler => include/drm}/spsc_queue.h | 7 +- 35 files changed, 529 insertions(+), 523 deletions(-) delete mode 100644 drivers/gpu/drm/amd/scheduler/gpu_scheduler.h create mode 100644 drivers/gpu/drm/scheduler/Makefile rename drivers/gpu/drm/{amd => }/scheduler/gpu_scheduler.c (65%) rename drivers/gpu/drm/{amd => }/scheduler/sched_fence.c (58%) create mode 100644 include/drm/gpu_scheduler.h rename drivers/gpu/drm/amd/scheduler/gpu_sched_trace.h => include/drm/gpu_scheduler_trace.h (82%) rename {drivers/gpu/drm/amd/scheduler => include/drm}/spsc_queue.h (95%) -- 2.11.0 ___ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx